[GitHub] [airflow] vandonr-amz commented on a diff in pull request #33423: Add a mechanism to warn if executors override existing CLI commands

vandonr-amz commented on code in PR #33423: URL: https://github.com/apache/airflow/pull/33423#discussion_r1297486491 ## airflow/cli/cli_parser.py: ## @@ -59,13 +61,23 @@ "a 3.3.0+ version of the Celery provider. If using a Kubernetes executor, install a "

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #33423: Add a mechanism to warn if executors override existing CLI commands

vandonr-amz commented on code in PR #33423: URL: https://github.com/apache/airflow/pull/33423#discussion_r1297482474 ## airflow/cli/cli_parser.py: ## @@ -59,13 +61,23 @@ "a 3.3.0+ version of the Celery provider. If using a Kubernetes executor, install a "

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #33423: Add a mechanism to warn if executors override existing CLI commands

vandonr-amz commented on code in PR #33423: URL: https://github.com/apache/airflow/pull/33423#discussion_r1296464825 ## tests/cli/conftest.py: ## @@ -34,17 +36,14 @@ custom_executor_module.CustomCeleryKubernetesExecutor = type( # type: ignore

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #33423: Add a mechanism to warn if executors override existing CLI commands

vandonr-amz commented on code in PR #33423: URL: https://github.com/apache/airflow/pull/33423#discussion_r1296319339 ## airflow/cli/cli_parser.py: ## @@ -65,6 +65,22 @@ ALL_COMMANDS_DICT: dict[str, CLICommand] = {sp.name: sp for sp in airflow_commands} +# Check if

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #33423: Add a mechanism to warn if executors override existing CLI commands

vandonr-amz commented on code in PR #33423: URL: https://github.com/apache/airflow/pull/33423#discussion_r1295362936 ## airflow/cli/cli_parser.py: ## @@ -65,6 +65,22 @@ ALL_COMMANDS_DICT: dict[str, CLICommand] = {sp.name: sp for sp in airflow_commands} +# Check if

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #33423: Add a mechanism to warn if executors override existing CLI commands

vandonr-amz commented on code in PR #33423: URL: https://github.com/apache/airflow/pull/33423#discussion_r1295252828 ## airflow/cli/cli_parser.py: ## Review Comment: > Yeah, that's what I meant, raise an exception. ok :p So, yeah, that'd be good if an executor

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #33423: Add a mechanism to warn if executors override existing CLI commands

vandonr-amz commented on code in PR #33423: URL: https://github.com/apache/airflow/pull/33423#discussion_r1295251837 ## airflow/cli/cli_parser.py: ## Review Comment: there is `log.fatal` which is marked deprecated in favor of `log.critical`, the highest level of logging.

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #33423: Add a mechanism to warn if executors override existing CLI commands

vandonr-amz commented on code in PR #33423: URL: https://github.com/apache/airflow/pull/33423#discussion_r1295240828 ## airflow/cli/cli_parser.py: ## Review Comment: I think Jed is not talking about an exception but more about the level of logging to use (i.e. use

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #33423: Add a mechanism to warn if executors override existing CLI commands

vandonr-amz commented on code in PR #33423: URL: https://github.com/apache/airflow/pull/33423#discussion_r1295222030 ## airflow/cli/cli_parser.py: ## Review Comment: Yeah, I wasn't sure... It's not preventing airflow from working, but it could be something needing