[GitHub] Fokko commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?

2019-01-11 Thread GitBox
Fokko commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)? URL: https://github.com/apache/airflow/pull/4421#issuecomment-453526901 Thanks @feng-tao for the clarification. I've removed the `known_event` and `known_event_type` from the migrations and the CI is happy now! 👍 ---

[GitHub] Fokko commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?

2019-01-08 Thread GitBox
Fokko commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)? URL: https://github.com/apache/airflow/pull/4421#issuecomment-452217314 @feng-tao There are no migrations with KnownEvent(Type): ``` MacBook-Pro-van-Fokko:incubator-airflow fokkodriesprong$ grep -R -i knownevent

[GitHub] Fokko commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?

2019-01-07 Thread GitBox
Fokko commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)? URL: https://github.com/apache/airflow/pull/4421#issuecomment-452095834 Rebased. @feng-tao I've looked into the Alembic script, but it becomes quite nasty in my opinion. The upgrade will be a `DROP TABLE IF EXISTS`, an