kyungjunleeme commented on PR #46891:
URL: https://github.com/apache/airflow/pull/46891#issuecomment-3089505645
Cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
jscheffl commented on PR #46891:
URL: https://github.com/apache/airflow/pull/46891#issuecomment-3085217568
Wohoo! Party!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eladkal commented on PR #46891:
URL: https://github.com/apache/airflow/pull/46891#issuecomment-3084991422
🎉 🎉🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
shahar1 commented on PR #46891:
URL: https://github.com/apache/airflow/pull/46891#issuecomment-3084834765
#protm for sure, great job Jarek! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
aritra24 commented on PR #46891:
URL: https://github.com/apache/airflow/pull/46891#issuecomment-3084411958
Long effort!! Great job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
potiuk commented on PR #46891:
URL: https://github.com/apache/airflow/pull/46891#issuecomment-3084386748
Aaand merged :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
potiuk merged PR #46891:
URL: https://github.com/apache/airflow/pull/46891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2213153842
##
airflow-core/tests/unit/cli/commands/test_api_server_command.py:
##
@@ -296,16 +297,31 @@ def test_run_command_daemon(
)
]
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2213111090
##
airflow-core/tests/unit/serialization/test_dag_serialization.py:
##
@@ -1229,10 +1234,6 @@ def test_extra_serialized_field_and_operator_links(
link = s
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2213056863
##
airflow-core/tests/unit/api_fastapi/conftest.py:
##
@@ -126,6 +126,7 @@ def configure_git_connection_for_dag_bundle(session):
login="",
)
session
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2213052271
##
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py:
##
@@ -82,6 +88,7 @@
@pytest.fixture(autouse=True)
@provide_session
def setup(request
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2213049623
##
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py:
##
@@ -82,6 +88,7 @@
@pytest.fixture(autouse=True)
@provide_session
def setup(request
gopidesupavan commented on PR #46891:
URL: https://github.com/apache/airflow/pull/46891#issuecomment-3083545233
#protm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
gopidesupavan commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2212981865
##
dev/breeze/src/airflow_breeze/utils/publish_docs_to_s3.py:
##
@@ -234,6 +233,18 @@ def run_publish(self):
if destination.endswith("stable/")
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2212544266
##
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dags.py:
##
@@ -58,6 +63,7 @@ class TestDagEndpoint:
@staticmethod
def _clear_db():
+
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2212538221
##
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py:
##
@@ -82,6 +88,7 @@
@pytest.fixture(autouse=True)
@provide_session
def setup(request
potiuk commented on PR #46891:
URL: https://github.com/apache/airflow/pull/46891#issuecomment-3081874457
Pushed changes trying out the comments in places I am not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211857618
##
Dockerfile.ci:
##
@@ -1185,7 +1190,9 @@ function check_force_lowest_dependencies() {
# --no-binary is needed in order to avoid libxml and xmlsec using
di
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211854419
##
airflow-core/tests/unit/serialization/test_dag_serialization.py:
##
@@ -1229,10 +1234,6 @@ def test_extra_serialized_field_and_operator_links(
link = s
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211852077
##
airflow-core/tests/unit/cli/commands/test_api_server_command.py:
##
@@ -296,16 +297,31 @@ def test_run_command_daemon(
)
]
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211851312
##
airflow-core/tests/unit/cli/commands/test_api_server_command.py:
##
@@ -296,16 +297,31 @@ def test_run_command_daemon(
)
]
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211849777
##
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py:
##
@@ -82,6 +88,7 @@
@pytest.fixture(autouse=True)
@provide_session
def setup(request
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211848475
##
airflow-core/src/airflow/api_fastapi/core_api/app.py:
##
@@ -124,6 +127,13 @@ def init_flask_plugins(app: FastAPI) -> None:
try:
from airflow.provider
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211842627
##
airflow-core/pyproject.toml:
##
@@ -35,7 +35,12 @@ name = "apache-airflow-core"
description = "Core packages for Apache Airflow, schedule and API server"
readme =
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211841088
##
providers/apache/beam/pyproject.toml:
##
@@ -57,20 +57,21 @@ requires-python = ">=3.10"
# After you modify the dependencies, and rebuild your Breeze CI image with
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211842165
##
scripts/ci/pre_commit/update_airflow_pyproject_toml.py:
##
@@ -132,6 +141,23 @@ def find_min_provider_version(provider_id: str) ->
tuple[Version | None, str]:
P
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211838550
##
providers/amazon/pyproject.toml:
##
@@ -95,9 +96,12 @@ dependencies = [
"s3fs>=2023.10.0",
]
"python3-saml" = [
-"python3-saml>=1.16.0",
-"xmlsec>=1.
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211833529
##
dev/breeze/tests/test_selective_checks.py:
##
@@ -1236,7 +1236,15 @@ def test_excluded_providers():
{
"excluded-providers-as-string": json.dum
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211831396
##
.pre-commit-config.yaml:
##
@@ -1014,7 +1014,12 @@ repos:
name: Update Airflow's meta-package pyproject.toml
language: python
entry: ./sc
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211828429
##
airflow-core/tests/unit/api_fastapi/conftest.py:
##
@@ -126,6 +126,7 @@ def configure_git_connection_for_dag_bundle(session):
login="",
)
session
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211815756
##
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_plugins.py:
##
@@ -24,6 +24,13 @@
pytestmark = pytest.mark.db_test
+try:
+import flask_appb
aritra24 commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2209403618
##
Dockerfile.ci:
##
@@ -1185,7 +1190,9 @@ function check_force_lowest_dependencies() {
# --no-binary is needed in order to avoid libxml and xmlsec using
amoghrajesh commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2209317437
##
airflow-core/src/airflow/api_fastapi/core_api/app.py:
##
@@ -124,6 +127,13 @@ def init_flask_plugins(app: FastAPI) -> None:
try:
from airflow.pro
amoghrajesh commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2209289426
##
.pre-commit-config.yaml:
##
@@ -1014,7 +1014,12 @@ repos:
name: Update Airflow's meta-package pyproject.toml
language: python
entry:
Dev-iL commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2209261170
##
airflow-core/tests/unit/api_fastapi/conftest.py:
##
@@ -126,6 +126,7 @@ def configure_git_connection_for_dag_bundle(session):
login="",
)
session
vincbeck commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2208634400
##
airflow-core/tests/unit/api_fastapi/conftest.py:
##
@@ -126,6 +126,7 @@ def configure_git_connection_for_dag_bundle(session):
login="",
)
sessi
jscheffl commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2208632478
##
docker-stack-docs/index.rst:
##
@@ -66,7 +76,7 @@ via :ref:`Building the image `.
* :subst-code:`apache/airflow:slim-latest` - the latest released
jscheffl commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2208562247
##
docker-stack-docs/index.rst:
##
@@ -64,9 +74,9 @@ You can also use "slim" images that contain only core Airflow
and are about half
but you need to add all the :
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2207953813
##
.github/workflows/run-unit-tests.yml:
##
@@ -179,7 +179,8 @@ jobs:
- name: >
Migration Tests: ${{ matrix.python-version }}:${{
env.PARALLEL_TEST_
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2207839086
##
.github/workflows/run-unit-tests.yml:
##
@@ -179,7 +179,8 @@ jobs:
- name: >
Migration Tests: ${{ matrix.python-version }}:${{
env.PARALLEL_TEST_
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2207676238
##
.github/workflows/run-unit-tests.yml:
##
@@ -179,7 +179,8 @@ jobs:
- name: >
Migration Tests: ${{ matrix.python-version }}:${{
env.PARALLEL_TEST_
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2207670752
##
providers/microsoft/mssql/pyproject.toml:
##
@@ -59,6 +60,8 @@ dependencies = [
"apache-airflow>=2.10.0",
"apache-airflow-providers-common-sql>=1.23.0",
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2207558188
##
providers/weaviate/tests/unit/weaviate/hooks/test_weaviate.py:
##
@@ -624,6 +627,8 @@ def test_delete_by_property_retry(get_conn, weaviate_hook):
assert mock_c
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2206428821
##
airflow-core/tests/unit/plugins/test_plugin.py:
##
@@ -44,45 +41,54 @@ def plugin_macro():
pass
-# Creating a flask appbuilder BaseView
-class PluginTestAp
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2206418316
##
task-sdk/tests/task_sdk/definitions/test_secrets_masker.py:
##
@@ -477,6 +477,7 @@ def reset_secrets_masker_and_skip_escape(self):
with patch(
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2206378027
##
docker-stack-docs/build.rst:
##
@@ -313,17 +313,17 @@ There are two types of images you can extend your image
from:
Naming conventions for the images:
-+-
github-advanced-security[bot] commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2206000404
##
kubernetes-tests/tests/kubernetes_tests/test_base.py:
##
@@ -60,13 +61,22 @@
temp_dir = Path(tempfile.gettempdir()) # Refers to global
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203942782
##
dev/breeze/src/airflow_breeze/utils/publish_docs_to_s3.py:
##
@@ -234,6 +233,18 @@ def run_publish(self):
if destination.endswith("stable/")
]
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203942071
##
airflow-core/tests/unit/jobs/test_triggerer_job.py:
##
@@ -76,17 +76,17 @@
@pytest.fixture(autouse=True)
def clean_database():
"""Fixture that cleans the dat
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203940977
##
airflow-core/tests/unit/cli/commands/test_api_server_command.py:
##
@@ -281,16 +282,31 @@ def test_run_command_daemon(
)
]
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203940253
##
airflow-core/tests/unit/cli/commands/test_api_server_command.py:
##
@@ -281,16 +282,31 @@ def test_run_command_daemon(
)
]
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203939742
##
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_plugins.py:
##
@@ -33,29 +33,20 @@ class TestGetPlugins:
# Filters
(
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203930158
##
airflow-core/pyproject.toml:
##
@@ -35,7 +35,7 @@ name = "apache-airflow-core"
description = "Core packages for Apache Airflow, schedule and API server"
readme =
gopidesupavan commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203540619
##
dev/breeze/src/airflow_breeze/utils/publish_docs_to_s3.py:
##
@@ -234,6 +233,18 @@ def run_publish(self):
if destination.endswith("stable/")
gopidesupavan commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203538983
##
airflow-core/tests/unit/jobs/test_triggerer_job.py:
##
@@ -76,17 +76,17 @@
@pytest.fixture(autouse=True)
def clean_database():
"""Fixture that cleans
gopidesupavan commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203538717
##
airflow-core/tests/unit/cli/commands/test_api_server_command.py:
##
@@ -281,16 +282,31 @@ def test_run_command_daemon(
)
]
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203529655
##
airflow-core/pyproject.toml:
##
@@ -35,7 +35,7 @@ name = "apache-airflow-core"
description = "Core packages for Apache Airflow, schedule and API server"
readme =
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203525936
##
airflow-core/pyproject.toml:
##
@@ -35,7 +35,7 @@ name = "apache-airflow-core"
description = "Core packages for Apache Airflow, schedule and API server"
readme =
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203526976
##
providers/ydb/pyproject.toml:
##
@@ -49,17 +49,17 @@ classifiers = [
"Programming Language :: Python :: 3.12",
"Topic :: System :: Monitoring",
]
-requir
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203526857
##
providers/edge3/pyproject.toml:
##
@@ -61,6 +62,13 @@ dependencies = [
"retryhttp>=1.2.0,!=1.3.0",
]
+# The optional dependencies should be modified in plac
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203526743
##
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_plugins.py:
##
@@ -33,29 +33,20 @@ class TestGetPlugins:
# Filters
(
jscheffl commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203526736
##
airflow-core/pyproject.toml:
##
@@ -35,7 +35,7 @@ name = "apache-airflow-core"
description = "Core packages for Apache Airflow, schedule and API server"
readme
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203525936
##
airflow-core/pyproject.toml:
##
@@ -35,7 +35,7 @@ name = "apache-airflow-core"
description = "Core packages for Apache Airflow, schedule and API server"
readme =
jscheffl commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203525527
##
providers/ydb/pyproject.toml:
##
@@ -49,17 +49,17 @@ classifiers = [
"Programming Language :: Python :: 3.12",
"Topic :: System :: Monitoring",
]
-requ
jscheffl commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203524784
##
providers/edge3/pyproject.toml:
##
@@ -61,6 +62,13 @@ dependencies = [
"retryhttp>=1.2.0,!=1.3.0",
]
+# The optional dependencies should be modified in pl
jscheffl commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203523897
##
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_plugins.py:
##
@@ -33,29 +33,20 @@ class TestGetPlugins:
# Filters
(
jscheffl commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2203523563
##
airflow-core/pyproject.toml:
##
@@ -35,7 +35,7 @@ name = "apache-airflow-core"
description = "Core packages for Apache Airflow, schedule and API server"
readme
potiuk commented on PR #46891:
URL: https://github.com/apache/airflow/pull/46891#issuecomment-3065724911
> So i think we may have some incompatibilities that we are not covering
with tests as I would have expected test failure on 3.13 - I guess we can
handle it seperatly
I already co
potiuk commented on PR #46891:
URL: https://github.com/apache/airflow/pull/46891#issuecomment-3065722182
Ah . OK I see :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
potiuk commented on PR #46891:
URL: https://github.com/apache/airflow/pull/46891#issuecomment-3065717958
> When running S3 tests I see
>
> ```
> {"category": "DeprecationWarning", "message": "pathlib.Path.__enter__() is
deprecated and scheduled for removal in Python 3.13; Path obje
eladkal commented on PR #46891:
URL: https://github.com/apache/airflow/pull/46891#issuecomment-3065606382
When running S3 tests I see
```
{"category": "DeprecationWarning", "message": "pathlib.Path.__enter__() is
deprecated and scheduled for removal in Python 3.13; Path objects as
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2187100470
##
providers/microsoft/mssql/pyproject.toml:
##
@@ -59,6 +60,8 @@ dependencies = [
"apache-airflow>=2.10.0",
"apache-airflow-providers-common-sql>=1.23.0",
jscheffl commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2187076963
##
providers/microsoft/mssql/pyproject.toml:
##
@@ -59,6 +60,8 @@ dependencies = [
"apache-airflow>=2.10.0",
"apache-airflow-providers-common-sql>=1.23.0",
potiuk commented on PR #46891:
URL: https://github.com/apache/airflow/pull/46891#issuecomment-3038713112
Ok. As planned and expected - the release of providers (even RC) fixed
`pypi` constraint generation. The only remaining issue is to get
https://github.com/apache/airflow/pull/52581 compl
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2178293173
##
providers/microsoft/mssql/pyproject.toml:
##
@@ -59,6 +60,8 @@ dependencies = [
"apache-airflow>=2.10.0",
"apache-airflow-providers-common-sql>=1.23.0",
jscheffl commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2178276698
##
providers/microsoft/mssql/pyproject.toml:
##
@@ -59,6 +60,8 @@ dependencies = [
"apache-airflow>=2.10.0",
"apache-airflow-providers-common-sql>=1.23.0",
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2176004019
##
providers/microsoft/mssql/pyproject.toml:
##
@@ -58,7 +59,8 @@ requires-python = "~=3.10"
dependencies = [
"apache-airflow>=2.10.0",
"apache-airflow-prov
jscheffl commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2175796416
##
providers/microsoft/mssql/pyproject.toml:
##
@@ -58,7 +59,8 @@ requires-python = "~=3.10"
dependencies = [
"apache-airflow>=2.10.0",
"apache-airflow-pr
gopidesupavan commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160268167
##
airflow-core/src/airflow/api_fastapi/core_api/app.py:
##
@@ -125,6 +128,13 @@ def init_flask_plugins(app: FastAPI) -> None:
try:
from airflow.p
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160050420
##
providers/edge3/README.rst:
##
@@ -57,7 +57,7 @@ You can install this package on top of an existing Airflow 2
installation (see `
for the minimum Airflow version
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160045980
##
dev/pyproject.toml:
##
@@ -44,6 +44,7 @@ dependencies = [
"jsonschema>=4.19.1",
'pendulum>=2.1.2,<4.0;python_version<"3.12"',
'pendulum>=3.0.0,<4.0;p
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160048429
##
providers/apache/beam/pyproject.toml:
##
@@ -50,28 +50,31 @@ classifiers = [
"Programming Language :: Python :: 3.12",
"Topic :: System :: Monitoring",
]
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160048912
##
providers/apache/beam/pyproject.toml:
##
@@ -50,28 +50,31 @@ classifiers = [
"Programming Language :: Python :: 3.12",
"Topic :: System :: Monitoring",
]
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160051782
##
airflow-core/tests/unit/always/test_providers_manager.py:
##
@@ -253,6 +255,19 @@ def test_hook_values(self):
print(record.exc_info, file=sys.stder
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160049635
##
providers/apache/hdfs/pyproject.toml:
##
@@ -60,7 +61,8 @@ dependencies = [
"apache-airflow>=2.10.0",
'hdfs[avro,dataframe,kerberos]>=2.5.4;python_version
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160059655
##
airflow-core/tests/unit/utils/test_db.py:
##
@@ -161,6 +162,10 @@ def test_check_migrations(self):
)
@mock.patch("alembic.command")
def test_upgraded
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160053182
##
providers/edge3/provider.yaml:
##
@@ -44,6 +44,11 @@ versions:
- 1.1.0
- 1.0.0
+# Edge Executor uses Flask and Flask Application Builder and until FAB 3.13
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160052946
##
airflow-core/src/airflow/api_fastapi/core_api/app.py:
##
@@ -125,6 +128,13 @@ def init_flask_plugins(app: FastAPI) -> None:
try:
from airflow.provider
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160052474
##
task-sdk/tests/task_sdk/definitions/test_secrets_masker.py:
##
@@ -477,6 +477,7 @@ def reset_secrets_masker_and_skip_escape(self):
with patch(
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160050237
##
providers/apache/kafka/pyproject.toml:
##
@@ -59,7 +59,7 @@ requires-python = "~=3.9"
dependencies = [
"apache-airflow>=2.10.0",
"asgiref>=2.3.0",
-"
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160052229
##
providers/yandex/tests/unit/yandex/hooks/test_dataproc.py:
##
@@ -21,7 +21,7 @@
import pytest
-yandexlcloud = pytest.importorskip("yandexcloud")
+yandexcloud =
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160051987
##
providers/yandex/provider.yaml:
##
@@ -59,6 +59,7 @@ versions:
- 1.0.1
- 1.0.0
+
Review Comment:
changed
##
providers/yandex/provider.yaml:
#
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160051314
##
providers/weaviate/tests/unit/weaviate/hooks/test_weaviate.py:
##
@@ -624,6 +627,8 @@ def test_delete_by_property_retry(get_conn, weaviate_hook):
assert mock_c
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160050858
##
providers/google/pyproject.toml:
##
@@ -146,8 +149,8 @@ dependencies = [
# Any change in the dependencies is preserved when the file is regenerated
[project.optio
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160050811
##
providers/google/pyproject.toml:
##
@@ -127,11 +128,13 @@ dependencies = [
# See https://github.com/looker-open-source/sdk-codegen/issues/1518
"looker-sdk
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160049841
##
providers/apache/hdfs/pyproject.toml:
##
@@ -60,7 +61,8 @@ dependencies = [
"apache-airflow>=2.10.0",
'hdfs[avro,dataframe,kerberos]>=2.5.4;python_version
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160048083
##
providers/amazon/pyproject.toml:
##
@@ -96,11 +97,12 @@ dependencies = [
"s3fs>=2023.10.0",
]
"python3-saml" = [
-"python3-saml>=1.16.0",
+# Python 3
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160046955
##
providers/amazon/pyproject.toml:
##
@@ -96,11 +97,12 @@ dependencies = [
"s3fs>=2023.10.0",
]
"python3-saml" = [
-"python3-saml>=1.16.0",
+# Python 3
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160046747
##
docker-stack-docs/build.rst:
##
@@ -313,17 +313,17 @@ There are two types of images you can extend your image
from:
Naming conventions for the images:
-+-
potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2160046645
##
dev/pyproject.toml:
##
@@ -44,6 +44,7 @@ dependencies = [
"jsonschema>=4.19.1",
'pendulum>=2.1.2,<4.0;python_version<"3.12"',
'pendulum>=3.0.0,<4.0;p
1 - 100 of 108 matches
Mail list logo
