Re: [PR] Add Teradata Provider [airflow]

kaxil commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1956113218 > Thank you every one for your support!. When is the airflow next release. After next airflow release, hope teradata provider will be listed at

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1947589696 Thank you every one for your support!. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add Teradata Provider [airflow]

eladkal commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1946923323   Great work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add Teradata Provider [airflow]

sunilkmallam commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1946842308 Thank you, everyone, for your support! We truly appreciate it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Add Teradata Provider [airflow]

josh-fell commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1946818046 Nice work @SatishChGit, congrats! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add Teradata Provider [airflow]

potiuk commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1946812596 :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: -- This is an automated message from the Apache

Re: [PR] Add Teradata Provider [airflow]

boring-cyborg[bot] commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1946812113 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Add Teradata Provider [airflow]

potiuk merged PR #36953: URL: https://github.com/apache/airflow/pull/36953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1946270892 > LGTM! A very minor comment for code snippet formatting in the docs, but that definitely doesn't deter from the work here. Thank you for the review. Committed suggested

Re: [PR] Add Teradata Provider [airflow]

josh-fell commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1491098410 ## docs/apache-airflow-providers-teradata/operators/teradata.rst: ## @@ -0,0 +1,114 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1945663789 > Solid work here! A few changes needed notwithstanding the example DAG question. Addressed all review comments. -- This is an automated message from the Apache Git

Re: [PR] Add Teradata Provider [airflow]

eladkal commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1490540331 ## airflow/providers/teradata/CHANGELOG.rst: ## @@ -0,0 +1,31 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

Re: [PR] Add Teradata Provider [airflow]

sunilkmallam commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1945325711 @airflow team, just following up on the changes we made. Could someone please review them? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1489183843 ## airflow/providers/teradata/hooks/teradata.py: ## @@ -0,0 +1,202 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1489166276 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1489164946 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

eladkal commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1489109916 ## airflow/providers/teradata/hooks/teradata.py: ## @@ -0,0 +1,202 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Add Teradata Provider [airflow]

eladkal commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1489109916 ## airflow/providers/teradata/hooks/teradata.py: ## @@ -0,0 +1,202 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Add Teradata Provider [airflow]

dstandish commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1488508336 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

Taragolis commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1488506124 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

Taragolis commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1488475255 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

Taragolis commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1488462338 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

sunilkmallam commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1487850028 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1485977601 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1485977601 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

eladkal commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1485505954 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

sunilkmallam commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1931854290 Hi @eladkal and @josh-fell, I hope you're doing well! Satish has made all the changes you've requested. Would you mind reviewing them and letting us know if there's anything

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1480069503 ## tests/providers/teradata/operators/test_teradata.py: ## @@ -0,0 +1,122 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

Taragolis commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1478710236 ## tests/providers/teradata/operators/test_teradata.py: ## @@ -0,0 +1,122 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

Taragolis commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1478705027 ## docs/apache-airflow-providers-teradata/redirects.txt: ## Review Comment: I guess for other providers in the past connections stored into the index.rst, so

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1927589326 > Partial review for now Thank you for review. Addressed review comments. Please re-review it. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1927583430 > Solid work here! A few changes needed notwithstanding the example DAG question. Thank you. Addressed all review comments and commented on each ask. -- This is an

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1478602118 ## airflow/providers/teradata/operators/teradata.py: ## @@ -0,0 +1,71 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1478601238 ## docs/apache-airflow-providers-teradata/redirects.txt: ## Review Comment: Removed. Placed this as like other providers aws, sqlite. -- This is an

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1478600448 ## airflow/providers/teradata/hooks/teradata.py: ## @@ -0,0 +1,212 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1478597184 ## tests/providers/teradata/operators/test_teradata.py: ## @@ -0,0 +1,122 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1478598188 ## airflow/providers/teradata/hooks/teradata.py: ## @@ -0,0 +1,212 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1478594282 ## tests/providers/teradata/hooks/test_teradata.py: ## @@ -0,0 +1,272 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1478592864 ## pyproject.toml: ## @@ -533,6 +533,7 @@ alibaba = [ "oss2>=2.14.0", ] amazon = [ + "PyAthena>=3.0.10", Review Comment: No. Now it should be in sync

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477019071 ## airflow/providers/teradata/operators/teradata.py: ## @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1478588646 ## airflow/providers/teradata/example_dags/example_teradata_to_teradata_transfer_operator.py: ## @@ -0,0 +1,158 @@ +# Review Comment: example dags are

Re: [PR] Add Teradata Provider [airflow]

Taragolis commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477381779 ## airflow/providers/teradata/hooks/teradata.py: ## @@ -0,0 +1,212 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477018374 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477019071 ## airflow/providers/teradata/operators/teradata.py: ## @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477018513 ## airflow/providers/teradata/operators/teradata.py: ## @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477018374 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477016905 ## airflow/providers/teradata/hooks/teradata.py: ## @@ -0,0 +1,210 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477017037 ## docs/apache-airflow-providers-teradata/connections/teradata.rst: ## @@ -0,0 +1,82 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477016762 ## tests/providers/teradata/operators/test_teradata.py: ## @@ -0,0 +1,128 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477016704 ## docs/apache-airflow-providers-teradata/index.rst: ## @@ -0,0 +1,134 @@ + + .. Licensed to the Apache Software Foundation (ASF) under one +or more

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477016675 ## airflow/providers/teradata/hooks/teradata.py: ## @@ -0,0 +1,210 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477016665 ## airflow/providers/teradata/hooks/teradata.py: ## @@ -0,0 +1,210 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477013609 ## airflow/providers/teradata/example_dags/example_teradata_operator.py: ## @@ -0,0 +1,132 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

Re: [PR] Add Teradata Provider [airflow]

SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1477013208 ## airflow/providers/teradata/example_dags/example_teradata_operator.py: ## @@ -0,0 +1,132 @@ +# Review Comment: Removed example_dags and updated references