Re: [PR] Add legend for duration markline. [airflow]

2024-03-25 Thread via GitHub
bbovenzi merged PR #38434: URL: https://github.com/apache/airflow/pull/38434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Add legend for duration markline. [airflow]

2024-03-25 Thread via GitHub
tirkarthi commented on PR #38434: URL: https://github.com/apache/airflow/pull/38434#issuecomment-2017698461 Thanks @simond , I have updated the string "mean" to "median". I didn't know the bars are selectable from legend which is cool and lets users to select the items they want. I have rem

Re: [PR] Add legend for duration markline. [airflow]

2024-03-25 Thread via GitHub
simond commented on PR #38434: URL: https://github.com/apache/airflow/pull/38434#issuecomment-2017621861 Hey @tirkarthi I think that, given this is a stacked bar chart, a "Median Duration" is shown. This median duration would be the median of the total which is shown on the graph.

Re: [PR] Add legend for duration markline. [airflow]

2024-03-24 Thread via GitHub
dirrao commented on code in PR #38434: URL: https://github.com/apache/airflow/pull/38434#discussion_r1537079098 ## airflow/www/static/js/dag/details/dag/RunDurationChart.tsx: ## @@ -164,7 +164,43 @@ const RunDurationChart = ({ showLandingTimes }: Props) => { `; } + fu

Re: [PR] Add legend for duration markline. [airflow]

2024-03-24 Thread via GitHub
tirkarthi commented on PR #38434: URL: https://github.com/apache/airflow/pull/38434#issuecomment-2017101047 @simond Thanks, I will update the legend. Please let me know if median total duration is more useful than median run duration. -- This is an automated message from the Apache Git Se

Re: [PR] Add legend for duration markline. [airflow]

2024-03-24 Thread via GitHub
simond commented on PR #38434: URL: https://github.com/apache/airflow/pull/38434#issuecomment-2016947663 Just looking at your screenshots - you may want to change the wording to 'median total', 'median run' etc rather than 'mean' - median and mean are different things. Looks like you're usi

Re: [PR] Add legend for duration markline. [airflow]

2024-03-24 Thread via GitHub
tirkarthi commented on PR #38434: URL: https://github.com/apache/airflow/pull/38434#issuecomment-2016741776 One another thing that I noticed was that the "mean run duration" was actually "mean total duration". Since the bars are stacked the value used to calculate mean was actually "queued

Re: [PR] Add legend for duration markline. [airflow]

2024-03-24 Thread via GitHub
tirkarthi commented on PR #38434: URL: https://github.com/apache/airflow/pull/38434#issuecomment-2016721461 Using `chartInstance.clear()` causes the chart to be redrawn as noted in the issue losing the animations on existing chart. Fresh redraws affect UX. I also tried below patch to show t

Re: [PR] Add legend for duration markline. [airflow]

2024-03-23 Thread via GitHub
tirkarthi commented on PR #38434: URL: https://github.com/apache/airflow/pull/38434#issuecomment-2016693194 https://github.com/apache/echarts/issues/6202 Using `chartInstance.clear()` before setOption helps with legend issue in 1 but the issue in 2 remains. -- This is an automated

Re: [PR] Add legend for duration markline. [airflow]

2024-03-23 Thread via GitHub
tirkarthi commented on PR #38434: URL: https://github.com/apache/airflow/pull/38434#issuecomment-2016690966 Please let me know if a different color needs to be selected with respect to accessibility. I noticed sometimes when all the bars are in success state then echarts seem to select gree

[PR] Add legend for duration markline. [airflow]

2024-03-23 Thread via GitHub
tirkarthi opened a new pull request, #38434: URL: https://github.com/apache/airflow/pull/38434 closes: #38420 related: #38420 I am facing two issues and not able to debug why. 1. When show landing times is not selected and on page refresh even upon checking it the legend i