Re: [PR] Add support for impersonation chain to GKEStartPodOperator in deferrable mode [airflow]

2024-02-21 Thread via GitHub
potiuk merged PR #37486: URL: https://github.com/apache/airflow/pull/37486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add support for impersonation chain to GKEStartPodOperator in deferrable mode [airflow]

2024-02-21 Thread via GitHub
potiuk commented on PR #37486: URL: https://github.com/apache/airflow/pull/37486#issuecomment-1958302727 LGTM: @Lee-W ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add support for impersonation chain to GKEStartPodOperator in deferrable mode [airflow]

2024-02-19 Thread via GitHub
m1racoli commented on code in PR #37486: URL: https://github.com/apache/airflow/pull/37486#discussion_r1494303880 ## airflow/providers/google/cloud/hooks/kubernetes_engine.py: ## @@ -709,37 +709,34 @@ async def get_pod(self, name: str, namespace: str) -> V1Pod: :param

Re: [PR] Add support for impersonation chain to GKEStartPodOperator in deferrable mode [airflow]

2024-02-19 Thread via GitHub
m1racoli commented on code in PR #37486: URL: https://github.com/apache/airflow/pull/37486#discussion_r1494310730 ## airflow/providers/google/cloud/hooks/kubernetes_engine.py: ## @@ -709,37 +709,34 @@ async def get_pod(self, name: str, namespace: str) -> V1Pod: :param

Re: [PR] Add support for impersonation chain to GKEStartPodOperator in deferrable mode [airflow]

2024-02-19 Thread via GitHub
m1racoli commented on code in PR #37486: URL: https://github.com/apache/airflow/pull/37486#discussion_r1494303880 ## airflow/providers/google/cloud/hooks/kubernetes_engine.py: ## @@ -709,37 +709,34 @@ async def get_pod(self, name: str, namespace: str) -> V1Pod: :param