VladaZakharova opened a new pull request, #36052:
URL: https://github.com/apache/airflow/pull/36052
@RobbeSneyders @vincbeck @potiuk
Hi all!
I have opened a PR in main repository so more people can be involved in this
discussion :)
based on the conversation in this issue
github-actions[bot] closed pull request #36052: Attempt to update Connexion
library to version 3
URL: https://github.com/apache/airflow/pull/36052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-2041658611
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for
Satoshi-Sh commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-1958459086
@RobbeSneyders Thanks for the pointers. I will have a look at it and ask
you if I have a question.
--
This is an automated message from the Apache Git Service.
To respond to the
RobbeSneyders commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-1958422648
Sorry for the late response, let me try to give some pointers for the open
issues.
> 1. Based on this discussion:
> Blueprint is now can't be retrieved from connexion
Satoshi-Sh commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-1953320107
Hi @vincbeck @VladaZakharova , I started working on the bugs Vlada listed
above.
For the first bug, I just updated codes as Vinc's commented. Can you guide
me on how to test
VladaZakharova commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-1930129837
Hey @potiuk @vincbeck !
The latest update on this issue and the list of the errors we need to fix to
be able to upgrade Connexion:
1. Based on this discussion:
lewijw commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-1921462946
FYI. I was able to get past the prior issue by adding a "with":
def _handle_api_not_found(
request: ConnexionRequest, ex: starlette.exceptions.HTTPException
vincbeck commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-1898788598
You will also have to update the method in `AwsAuthManager`, but that should
be straightforward
--
This is an automated message from the Apache Git Service.
To respond to the
vincbeck commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-1898786641
> > > Update init_api_auth_provider function.
> > > In get_api_endpoints function we use connexion_app.add_api and expect
FlaskApi as a return object, but add_api function always
VladaZakharova commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-1898634172
@RobbeSneyders , hope you can help :)
```
TypeError: get() got an unexpected keyword argument 'environ_overrides' this
error is the most frequent now. For fixing it we need
VladaZakharova commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-1898612794
> > Update init_api_auth_provider function.
> > In get_api_endpoints function we use connexion_app.add_api and expect
FlaskApi as a return object, but add_api function always
vincbeck commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-1885139430
> Update init_api_auth_provider function.
In get_api_endpoints function we use connexion_app.add_api and expect
FlaskApi as a return object, but add_api function always return
MaksYermak commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-1884982252
Hello Team,
I see several issues which we need to fix for finishing this PR.
1. Fix unit tests which use `app`.
After connexion update `create_app` function returns
VladaZakharova commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-1864958699
Thank you everyone who is involved! :)
I have updated the code and Gunicorn command as it was suggested by
@RobbeSneyders in his PR (thank you, great job!)
I have also
VladaZakharova commented on PR #36052:
URL: https://github.com/apache/airflow/pull/36052#issuecomment-1849644073
> Thanks @VladaZakharova.
>
> I believe we'll need to take a slightly different approach though. We only
want to create a single `FlaskApp` and register `Apis` on them. I
RobbeSneyders commented on code in PR #36052:
URL: https://github.com/apache/airflow/pull/36052#discussion_r1414534535
##
airflow/www/extensions/init_views.py:
##
@@ -220,7 +224,7 @@ def resolve(self, operation):
return
vincbeck commented on code in PR #36052:
URL: https://github.com/apache/airflow/pull/36052#discussion_r1414449599
##
airflow/auth/managers/fab/fab_auth_manager.py:
##
@@ -147,20 +149,22 @@ def get_cli_commands() -> list[CLICommand]:
SYNC_PERM_COMMAND, # not in a
VladaZakharova opened a new pull request, #36052:
URL: https://github.com/apache/airflow/pull/36052
@RobbeSneyders @vincbeck @potiuk
Hi all!
I have opened a PR in main repository so more people can be involved in this
discussion :)
based on the conversation in this issue
19 matches
Mail list logo
