Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

potiuk merged PR #37143: URL: https://github.com/apache/airflow/pull/37143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

LipuFei commented on PR #37143: URL: https://github.com/apache/airflow/pull/37143#issuecomment-2016490984 @eladkal @potiuk @hussein-awala Here is a summary of the changes: - Commit 2d1800aa4afda2f802c44f38a4311576d267fb51 is to check the attribute `TaskInstance.task` before use.

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

LipuFei commented on code in PR #37143: URL: https://github.com/apache/airflow/pull/37143#discussion_r1536630170 ## airflow/sentry/__init__.py: ## @@ -0,0 +1,30 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

ephraimbuddy commented on code in PR #37143: URL: https://github.com/apache/airflow/pull/37143#discussion_r1535920258 ## airflow/sentry/__init__.py: ## @@ -0,0 +1,30 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

LipuFei commented on PR #37143: URL: https://github.com/apache/airflow/pull/37143#issuecomment-2015525725 @potiuk I will split the commits so they are easier to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

potiuk commented on PR #37143: URL: https://github.com/apache/airflow/pull/37143#issuecomment-2015145059 I think that would also help @eladkal and @hussein-awala to make such review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

potiuk commented on PR #37143: URL: https://github.com/apache/airflow/pull/37143#issuecomment-2015144054 > OK @potiuk reviewed the first PR so lets wait for his review That's just related - it's a bigger change that requires thorough -review -the original one was a quick fix. But

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

eladkal commented on PR #37143: URL: https://github.com/apache/airflow/pull/37143#issuecomment-2015085320 > > This PR marked as solving #37142 but #37142 is already solved by #37002 can you please explain? > > Hi @eladkal , this PR fixes the problem from another angle. Although the

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

LipuFei commented on PR #37143: URL: https://github.com/apache/airflow/pull/37143#issuecomment-2014786132 > This PR marked as solving #37142 but #37142 is already solved by #37002 can you please explain? Hi @eladkal , this PR fixes the problem from another angle. Although the issue

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

eladkal commented on PR #37143: URL: https://github.com/apache/airflow/pull/37143#issuecomment-2014779241 This PR marked as solving https://github.com/apache/airflow/issues/37142 but https://github.com/apache/airflow/issues/37142 is already solved by

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

eladkal commented on PR #37143: URL: https://github.com/apache/airflow/pull/37143#issuecomment-2007026560 Cool @hussein-awala any further comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

LipuFei commented on PR #37143: URL: https://github.com/apache/airflow/pull/37143#issuecomment-2007014433 @eladkal Static checks have been fixed.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

LipuFei commented on PR #37143: URL: https://github.com/apache/airflow/pull/37143#issuecomment-2006676078 > @LipuFei can you fix static checks? @eladkal I will work on them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

eladkal commented on PR #37143: URL: https://github.com/apache/airflow/pull/37143#issuecomment-2004020412 @LipuFei can you fix static checks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

eladkal commented on PR #37143: URL: https://github.com/apache/airflow/pull/37143#issuecomment-2003207581 Needs rebase and resolve conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Check task attribute before use in sentry.add_tagging() [airflow]

LipuFei commented on PR #37143: URL: https://github.com/apache/airflow/pull/37143#issuecomment-1932126704 @dirrao @hussein-awala I have added a test for this. I had to refactor the sentry module because the old `__init__.py` makes it very difficult to test the `ConfiguredSentry`

[PR] Check task attribute before use in sentry.add_tagging() [airflow]

LipuFei opened a new pull request, #37143: URL: https://github.com/apache/airflow/pull/37143 Check the the `TaskInstance.task` attribute before using it, because `TaskInstance.task` may not be set. closes: #37142 -- This is an automated message from the Apache Git Service. To