eladkal commented on PR #39048:
URL: https://github.com/apache/airflow/pull/39048#issuecomment-2133241318
Suppressed by https://github.com/apache/airflow/pull/39465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
eladkal closed pull request #39048: Enable none default ftp port
URL: https://github.com/apache/airflow/pull/39048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kerlion commented on PR #39048:
URL: https://github.com/apache/airflow/pull/39048#issuecomment-2081334434
> Can you please add unit test to cover this change?
Sorry, I do know know how to add unit test, but I tested it in my PROD env.
--
This is an automated message from the Apache
potiuk commented on PR #39048:
URL: https://github.com/apache/airflow/pull/39048#issuecomment-2068884388
> Hi, is this ready for merging, anything else need I to do?
Have you seen this @kerlion ?
> This probably should have a test?
--
This is an automated message
kerlion commented on PR #39048:
URL: https://github.com/apache/airflow/pull/39048#issuecomment-2068328606
Hi, is this ready for merging, anything else need I to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
uranusjr commented on PR #39048:
URL: https://github.com/apache/airflow/pull/39048#issuecomment-2065699068
This probably should have a test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kerlion commented on code in PR #39048:
URL: https://github.com/apache/airflow/pull/39048#discussion_r1569741834
##
airflow/providers/ftp/hooks/ftp.py:
##
@@ -58,7 +58,9 @@ def get_conn(self) -> ftplib.FTP:
if self.conn is None:
params =
kerlion commented on code in PR #39048:
URL: https://github.com/apache/airflow/pull/39048#discussion_r1568142864
##
airflow/providers/ftp/hooks/ftp.py:
##
@@ -58,7 +58,9 @@ def get_conn(self) -> ftplib.FTP:
if self.conn is None:
params =
hussein-awala commented on code in PR #39048:
URL: https://github.com/apache/airflow/pull/39048#discussion_r1566816096
##
airflow/providers/ftp/hooks/ftp.py:
##
@@ -58,7 +58,9 @@ def get_conn(self) -> ftplib.FTP:
if self.conn is None:
params =
