Re: [PR] Mysql change xcom value col type for MySQL backend [airflow]

2024-03-23 Thread via GitHub
pankajastro merged PR #38401: URL: https://github.com/apache/airflow/pull/38401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airf

Re: [PR] Mysql change xcom value col type for MySQL backend [airflow]

2024-03-22 Thread via GitHub
kaxil commented on PR #38401: URL: https://github.com/apache/airflow/pull/38401#issuecomment-2016148389 >If it does, and it results in a slow migration, I really wonder if we should not do this and instruct users to set up an object storage xcom backend instead. Thoughts? The current

Re: [PR] Mysql change xcom value col type for MySQL backend [airflow]

2024-03-22 Thread via GitHub
potiuk commented on PR #38401: URL: https://github.com/apache/airflow/pull/38401#issuecomment-2015810027 > > I think, if that's the case then we will likely have to at least warn the users in significant note that it might happen and that they should likely run db clean on xcom table for so

Re: [PR] Mysql change xcom value col type for MySQL backend [airflow]

2024-03-22 Thread via GitHub
Taragolis commented on PR #38401: URL: https://github.com/apache/airflow/pull/38401#issuecomment-2015454246 > I think, if that's the case then we will likely have to at least warn the users in significant note that it might happen and that they should likely run db clean on xcom table for s

Re: [PR] Mysql change xcom value col type for MySQL backend [airflow]

2024-03-22 Thread via GitHub
jedcunningham commented on code in PR #38401: URL: https://github.com/apache/airflow/pull/38401#discussion_r1535761600 ## docs/apache-airflow/howto/set-up-database.rst: ## @@ -318,6 +318,13 @@ In addition, you also should pay particular attention to MySQL's encoding. Altho

Re: [PR] Mysql change xcom value col type for MySQL backend [airflow]

2024-03-22 Thread via GitHub
potiuk commented on PR #38401: URL: https://github.com/apache/airflow/pull/38401#issuecomment-2015327642 Should be a significant newsfragment too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Mysql change xcom value col type for MySQL backend [airflow]

2024-03-22 Thread via GitHub
pankajastro commented on PR #38401: URL: https://github.com/apache/airflow/pull/38401#issuecomment-2015317115 @potiuk I have tried to add a note `docs/apache-airflow/howto/set-up-database.rst` but not sure if this right place. any suggestions? -- This is an automated message from the A

Re: [PR] Mysql change xcom value col type for MySQL backend [airflow]

2024-03-22 Thread via GitHub
pankajastro commented on PR #38401: URL: https://github.com/apache/airflow/pull/38401#issuecomment-2015148889 > Will that cause a long migration process possibly ? Yes, that will be the case if they have lots of large data in Xcom, although I don't have a specific number at the moment

Re: [PR] Mysql change xcom value col type for MySQL backend [airflow]

2024-03-22 Thread via GitHub
potiuk commented on PR #38401: URL: https://github.com/apache/airflow/pull/38401#issuecomment-2015105421 Will that cause a long migration process possibly ? or will such migration be rather fast ? I suspect if there is something to rewrite the way how the blobs are stored, it might take an