Re: [PR] Refactor dataset class inheritance [airflow]

2024-02-22 Thread via GitHub
phanikumv merged PR #37590: URL: https://github.com/apache/airflow/pull/37590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Refactor dataset class inheritance [airflow]

2024-02-22 Thread via GitHub
uranusjr commented on code in PR #37590: URL: https://github.com/apache/airflow/pull/37590#discussion_r1498830044 ## airflow/timetables/datasets.py: ## @@ -36,9 +36,11 @@ class DatasetOrTimeSchedule(DatasetTriggeredSchedule): """Combine time-based scheduling with

Re: [PR] Refactor dataset class inheritance [airflow]

2024-02-22 Thread via GitHub
sunank200 commented on PR #37590: URL: https://github.com/apache/airflow/pull/37590#issuecomment-1958898901 > I feel we should do this before #37101. There are some parts on that PR (importing from `airflow.models`, for example) that I feel very wrong to be in main. Sure I will

Re: [PR] Refactor dataset class inheritance [airflow]

2024-02-21 Thread via GitHub
Lee-W commented on code in PR #37590: URL: https://github.com/apache/airflow/pull/37590#discussion_r1498805706 ## airflow/datasets/__init__.py: ## @@ -55,3 +72,42 @@ def __eq__(self, other): def __hash__(self): return hash(self.uri) + +def

Re: [PR] Refactor dataset class inheritance [airflow]

2024-02-21 Thread via GitHub
uranusjr commented on PR #37590: URL: https://github.com/apache/airflow/pull/37590#issuecomment-1958820928 I feel we should do this before #37101. There are some parts on that PR (importing from `airflow.models`, for example) that I feel very wrong to be in main. -- This is an automated