jscheffl commented on PR #32520:
URL: https://github.com/apache/airflow/pull/32520#issuecomment-2023869229
Closing this PR as completed with #38446 - thanks for the contribution on
this branch which was the base for the efforts to make it in (hopefully, if all
runs fine) Airflow 2.9.0!
--
jscheffl closed pull request #32520: allows users to write dag_id and task_id
in their national characters, added display name for dag / task
URL: https://github.com/apache/airflow/pull/32520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ephraimbuddy commented on code in PR #32520:
URL: https://github.com/apache/airflow/pull/32520#discussion_r1537254872
##
airflow/models/taskmixin.py:
##
@@ -161,11 +161,18 @@ def node_id(self) -> str:
@property
def label(self) -> str | None:
+from airflow.mod
jscheffl commented on PR #32520:
URL: https://github.com/apache/airflow/pull/32520#issuecomment-2017051703
As linked in #38446 - I tried to spend time on the weekend to continue
working on this PR... let's see if we can get this reviewed and completed...
--
This is an automated message f
uranusjr commented on PR #32520:
URL: https://github.com/apache/airflow/pull/32520#issuecomment-1997309940
Hopefully I can spend some time on this maybe next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
jscheffl commented on PR #32520:
URL: https://github.com/apache/airflow/pull/32520#issuecomment-1992708602
I'd really love to have this in - 2.9.0 release cut is across the corner -
possible to get the conflicts resolved, the final bug fixed and have this
merged?
--
This is an automated
xgao1023 commented on PR #32520:
URL: https://github.com/apache/airflow/pull/32520#issuecomment-1920992158
> I tried to add a commit to address the error mentioned above, but there
are multiple linting errors here and a merge conflict that must be fixed first.
@uranusjr
I was tryi
pierrejeambrun commented on PR #32520:
URL: https://github.com/apache/airflow/pull/32520#issuecomment-1859240356
> I will try on this but I’m surely not a frontend expert.
No worries, try your best. If you feel like this is too much, I think we can
do that in follow up PRs.
cc:
xgao1023 commented on PR #32520:
URL: https://github.com/apache/airflow/pull/32520#issuecomment-1797701262
> I think you also want to update the react part (Grid, Cluster Activity,
Dataset) to use this new `display_name` instead of the current task_id, dag_id
I will try on this but I’
xgao1023 commented on PR #32520:
URL: https://github.com/apache/airflow/pull/32520#issuecomment-1797700322
> I tried to add a commit to address the error mentioned above, but there
are multiple linting errors here and a merge conflict that must be fixed first.
I resolved the conflicts
xgao1023 commented on PR #32520:
URL: https://github.com/apache/airflow/pull/32520#issuecomment-1784560108
I will resume working on this - fix the issues and also change UI part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
uranusjr commented on PR #32520:
URL: https://github.com/apache/airflow/pull/32520#issuecomment-1744604052
I tried to add a commit to address the error mentioned above, but there are
multiple linting errors here and a merge conflict that must be fixed first.
--
This is an automated messag
12 matches
Mail list logo
