eladkal merged PR #38961:
URL: https://github.com/apache/airflow/pull/38961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Lee-W commented on PR #38961:
URL: https://github.com/apache/airflow/pull/38961#issuecomment-2067906252
I'm planning on merging this one later today. Please let me know if anyone
wants to take a deeper look
--
This is an automated message from the Apache Git Service.
To respond to the
Lee-W commented on code in PR #38961:
URL: https://github.com/apache/airflow/pull/38961#discussion_r1566892855
##
airflow/providers/google/common/hooks/base_google.py:
##
@@ -454,6 +474,24 @@ def decorator(fun: T):
return decorator
+@staticmethod
+def
dondaum commented on code in PR #38961:
URL: https://github.com/apache/airflow/pull/38961#discussion_r1566850091
##
tests/providers/google/common/hooks/test_base_google.py:
##
@@ -98,6 +98,46 @@ def test_raise_exception_on_non_quota_exception(self):
)
+class
dondaum commented on code in PR #38961:
URL: https://github.com/apache/airflow/pull/38961#discussion_r1566849732
##
airflow/providers/google/common/hooks/base_google.py:
##
@@ -454,6 +474,24 @@ def decorator(fun: T):
return decorator
+@staticmethod
+def
Lee-W commented on code in PR #38961:
URL: https://github.com/apache/airflow/pull/38961#discussion_r1566799340
##
tests/providers/google/common/hooks/test_base_google.py:
##
@@ -98,6 +98,46 @@ def test_raise_exception_on_non_quota_exception(self):
)
+class
dondaum opened a new pull request, #38961:
URL: https://github.com/apache/airflow/pull/38961
Occasionally, acquire impersonated credentials can fail with a 502 HTTP
(Server error). It raises a `google.auth.exceptions.RefreshError`. Using task
retries is sometimes not a good
