eladkal commented on code in PR #39031:
URL: https://github.com/apache/airflow/pull/39031#discussion_r1640157564
##
helm_tests/airflow_aux/test_pod_template_file.py:
##
@@ -98,6 +98,7 @@ def
test_should_add_an_init_container_if_git_sync_is_true(self):
amoghrajesh commented on code in PR #39031:
URL: https://github.com/apache/airflow/pull/39031#discussion_r1618725802
##
helm_tests/airflow_aux/test_pod_template_file.py:
##
@@ -98,6 +98,7 @@ def
test_should_add_an_init_container_if_git_sync_is_true(self):
rasulkarimov commented on PR #39031:
URL: https://github.com/apache/airflow/pull/39031#issuecomment-2137053748
> I'd much rather we move
[gitSync.env](https://github.com/apache/airflow/blob/58820a914c9b84c378c9bc1acd4ddbcb4e4a3497/chart/values.schema.json#L7408)
to accept
rasulkarimov commented on PR #39031:
URL: https://github.com/apache/airflow/pull/39031#issuecomment-2088870335
> look good, can you fix current tests to validate your changes?
Thank you! Fixed tests.
--
This is an automated message from the Apache Git Service.
To respond to the
romsharon98 commented on PR #39031:
URL: https://github.com/apache/airflow/pull/39031#issuecomment-2067953964
look good, can you add some tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rasulkarimov commented on PR #39031:
URL: https://github.com/apache/airflow/pull/39031#issuecomment-2057982594
@jedcunningham
"restricting it artificially" - I agree with your point, I just wanted to
follow the established pattern in the "git_sync_container" template.
However, using
