This is an automated email from the ASF dual-hosted git repository.

ephraimanierobi pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new d74e677  Make AirflowDateTimePickerWidget a required field (#18602)
d74e677 is described below

commit d74e6776fce1da2c887e33d79e2fb66c83c6ff82
Author: Ephraim Anierobi <splendidzig...@gmail.com>
AuthorDate: Thu Sep 30 20:52:54 2021 +0100

    Make AirflowDateTimePickerWidget a required field (#18602)
    
    The UI breaks when a search field sends a null datetime. This fixes it
---
 airflow/www/widgets.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/airflow/www/widgets.py b/airflow/www/widgets.py
index ab2e4cf..c99c5d4 100644
--- a/airflow/www/widgets.py
+++ b/airflow/www/widgets.py
@@ -42,10 +42,12 @@ class AirflowDateTimePickerWidget:
         kwargs.setdefault("id", field.id)
         kwargs.setdefault("name", field.name)
         if not field.data:
-            field.data = ""
+            field.data = ''
         template = self.data_template
 
-        return Markup(template % {"text": html_params(type="text", 
value=field.data, **kwargs)})
+        return Markup(
+            template % {"text": html_params(type="text", value=field.data, 
required=True, **kwargs)}
+        )
 
 
 class AirflowDateTimePickerROWidget(AirflowDateTimePickerWidget):

Reply via email to