This is an automated email from the ASF dual-hosted git repository.

kaxilnaik pushed a commit to branch v1-10-test
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/v1-10-test by this push:
     new dbe308c  Restrict editing DagRun State in the old UI (#9612)
dbe308c is described below

commit dbe308c7ea31043d86ac1b563c5590fe6c40bcb5
Author: Kaxil Naik <kaxiln...@gmail.com>
AuthorDate: Wed Jul 1 17:15:07 2020 +0100

    Restrict editing DagRun State in the old UI (#9612)
    
    closes #8717
---
 UPDATING.md          | 7 +++++++
 airflow/www/views.py | 1 -
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/UPDATING.md b/UPDATING.md
index ea8c262..3dfda58 100644
--- a/UPDATING.md
+++ b/UPDATING.md
@@ -66,6 +66,13 @@ https://developers.google.com/style/inclusive-documentation
 
 Now use NULL as default value for dag.description in dag table
 
+### Restrict editing DagRun State in the old UI (Flask-admin based UI)
+
+Before 1.10.11 it was possible to edit DagRun State in the `/admin/dagrun/` 
page
+ to any text.
+
+In Airflow 1.10.11+, the user can only choose the states from the list.
+
 ## Airflow 1.10.10
 
 ### Setting Empty string to a Airflow Variable will return an empty string
diff --git a/airflow/www/views.py b/airflow/www/views.py
index 8b1e910..a3293c8 100644
--- a/airflow/www/views.py
+++ b/airflow/www/views.py
@@ -2818,7 +2818,6 @@ class DagRunModelView(ModelViewOnly):
     verbose_name_plural = "DAG Runs"
     can_edit = True
     can_create = True
-    column_editable_list = ('state',)
     verbose_name = "dag run"
     column_default_sort = ('execution_date', True)
     form_choices = {

Reply via email to