ephraimbuddy commented on issue #38935:
URL: https://github.com/apache/airflow/issues/38935#issuecomment-2055618135
I think it might be worth it if you can create a feature request and explain
how necessary this issue is, the use cases because I see it, that it's not
required because the
ephraimbuddy closed issue #38935: on_failure_callback is not called when task
is manually marked as failed
URL: https://github.com/apache/airflow/issues/38935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
FFCMSouza commented on issue #38935:
URL: https://github.com/apache/airflow/issues/38935#issuecomment-2054223724
Anyway, I managed to find a way to solve my problem overwriting the
`on_kill` method in my spark operator.
The only downside is that the `on_kill` method doesn't have access
FFCMSouza commented on issue #38935:
URL: https://github.com/apache/airflow/issues/38935#issuecomment-2054217500
> There are no plans to change the behaviour at the moment. Also, I don't
know why you would want the callback to run when you intentionally failed a task
In my case, I
ephraimbuddy commented on issue #38935:
URL: https://github.com/apache/airflow/issues/38935#issuecomment-2054154690
> Yes, I saw that. So there is no intention to change this behavior? To me
this doesn't make sense, marking a task as failed should trigger the failure
callback. If that's
FFCMSouza commented on issue #38935:
URL: https://github.com/apache/airflow/issues/38935#issuecomment-2052409632
Yes, I saw that. So there is no intention to change this behavior?
To me this doesn't make sense, marking a task as failed should trigger the
failure callback.
If that's
ephraimbuddy commented on issue #38935:
URL: https://github.com/apache/airflow/issues/38935#issuecomment-2052393366
This behaviour is documented in the code
https://github.com/apache/airflow/blob/5f6f4a5f4654d64efb4c0cabb6e0e054d13a2e0f/airflow/models/taskinstance.py#L2594-L2597.
So
FFCMSouza commented on issue #38935:
URL: https://github.com/apache/airflow/issues/38935#issuecomment-2050273127
I saw that on version 1.9.0, thats already a different type of exception for
this cases.
I believe that the following change could be made to fix that behavior:
`
boring-cyborg[bot] commented on issue #38935:
URL: https://github.com/apache/airflow/issues/38935#issuecomment-2049804187
Thanks for opening your first issue here! Be sure to follow the issue
template! If you are willing to raise PR to address this issue please do so, no
need to wait for
