dabla commented on PR #38528:
URL: https://github.com/apache/airflow/pull/38528#issuecomment-2041039654
Thank you for merging this pull request, could someone have a look to check
this one also please: https://github.com/apache/airflow/pull/38707
--
This is an automated message from the
eladkal merged PR #38528:
URL: https://github.com/apache/airflow/pull/38528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dabla commented on code in PR #38528:
URL: https://github.com/apache/airflow/pull/38528#discussion_r1551300942
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -173,7 +175,17 @@ def __init__(self, *args, schema: str | None = None,
log_sql: bool = True, **kwa
)
eladkal commented on code in PR #38528:
URL: https://github.com/apache/airflow/pull/38528#discussion_r1551212901
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -50,6 +50,7 @@
from airflow.providers.openlineage.sqlparser import DatabaseInfo
T = TypeVar("T")
dabla commented on code in PR #38528:
URL: https://github.com/apache/airflow/pull/38528#discussion_r1541044474
##
tests/providers/conftest.py:
##
@@ -55,3 +59,32 @@ def hook_conn(request):
)
yield m
+
+
+def mock_hook(hook_class: type[BaseHook],
dabla commented on code in PR #38528:
URL: https://github.com/apache/airflow/pull/38528#discussion_r1541033575
##
tests/providers/conftest.py:
##
@@ -55,3 +59,32 @@ def hook_conn(request):
)
yield m
+
+
+def mock_hook(hook_class: type[BaseHook],
Taragolis commented on code in PR #38528:
URL: https://github.com/apache/airflow/pull/38528#discussion_r1540930252
##
tests/providers/conftest.py:
##
@@ -55,3 +59,32 @@ def hook_conn(request):
)
yield m
+
+
+def mock_hook(hook_class: type[BaseHook],
