Re: [PR] Resolve `PT012` in `SFTP` provider tests [airflow]

2024-04-03 Thread via GitHub
potiuk merged PR #38518: URL: https://github.com/apache/airflow/pull/38518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Resolve `PT012` in `SFTP` provider tests [airflow]

2024-04-03 Thread via GitHub
potiuk commented on PR #38518: URL: https://github.com/apache/airflow/pull/38518#issuecomment-2035482917 臘 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Resolve `PT012` in `SFTP` provider tests [airflow]

2024-04-03 Thread via GitHub
shahar1 commented on code in PR #38518: URL: https://github.com/apache/airflow/pull/38518#discussion_r1550356533 ## tests/providers/sftp/triggers/test_sftp.py: ## @@ -175,13 +175,10 @@ async def test_sftp_trigger_run_trigger_failure_state(self, mock_get_files_by_pa

Re: [PR] Resolve `PT012` in `SFTP` provider tests [airflow]

2024-04-02 Thread via GitHub
potiuk commented on PR #38518: URL: https://github.com/apache/airflow/pull/38518#issuecomment-2032877859 Or we can merge #38525 instead - @eladkal ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Resolve `PT012` in `SFTP` provider tests [airflow]

2024-03-28 Thread via GitHub
eladkal commented on PR #38518: URL: https://github.com/apache/airflow/pull/38518#issuecomment-2025568339 Can you rebase and resolve conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Resolve `PT012` in `SFTP` provider tests [airflow]

2024-03-26 Thread via GitHub
Taragolis commented on code in PR #38518: URL: https://github.com/apache/airflow/pull/38518#discussion_r1540207045 ## tests/providers/sftp/hooks/test_sftp.py: ## @@ -405,12 +405,11 @@ def test_deprecation_ftp_conn_id(self, mock_get_connection):

Re: [PR] Resolve `PT012` in `SFTP` provider tests [airflow]

2024-03-26 Thread via GitHub
Taragolis commented on code in PR #38518: URL: https://github.com/apache/airflow/pull/38518#discussion_r1540205185 ## tests/providers/sftp/triggers/test_sftp.py: ## @@ -175,13 +175,10 @@ async def test_sftp_trigger_run_trigger_failure_state(self, mock_get_files_by_pa

Re: [PR] Resolve `PT012` in `SFTP` provider tests [airflow]

2024-03-26 Thread via GitHub
uranusjr commented on code in PR #38518: URL: https://github.com/apache/airflow/pull/38518#discussion_r1540186628 ## tests/providers/sftp/triggers/test_sftp.py: ## @@ -175,13 +175,10 @@ async def test_sftp_trigger_run_trigger_failure_state(self, mock_get_files_by_pa