Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-09 Thread via GitHub
amoghrajesh merged PR #38763: URL: https://github.com/apache/airflow/pull/38763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-09 Thread via GitHub
amoghrajesh commented on PR #38763: URL: https://github.com/apache/airflow/pull/38763#issuecomment-2044230292 @eladkal fixed spelling and spaces, we should get a green run now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-09 Thread via GitHub
eladkal commented on code in PR #38763: URL: https://github.com/apache/airflow/pull/38763#discussion_r1556978919 ## airflow/providers/apache/hive/CHANGELOG.rst: ## @@ -27,6 +27,18 @@ Changelog - +8.0.0 +. + + +Breaking changes + + +Changed the

Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-08 Thread via GitHub
eladkal commented on code in PR #38763: URL: https://github.com/apache/airflow/pull/38763#discussion_r1556176719 ## airflow/providers/apache/hive/CHANGELOG.rst: ## @@ -27,6 +27,19 @@ Changelog - +8.0.0 +. + + +Breaking changes + + +Changed the

Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-08 Thread via GitHub
potiuk commented on PR #38763: URL: https://github.com/apache/airflow/pull/38763#issuecomment-2043244944 Approved with NIT's -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-08 Thread via GitHub
potiuk commented on code in PR #38763: URL: https://github.com/apache/airflow/pull/38763#discussion_r1556155471 ## airflow/providers/apache/hive/provider.yaml: ## @@ -25,6 +25,7 @@ state: ready source-date-epoch: 1709554960 # note that those versions are maintained by release

Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-08 Thread via GitHub
potiuk commented on code in PR #38763: URL: https://github.com/apache/airflow/pull/38763#discussion_r1556154848 ## airflow/providers/apache/hive/provider.yaml: ## @@ -25,6 +25,7 @@ state: ready source-date-epoch: 1709554960 # note that those versions are maintained by release

Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-07 Thread via GitHub
amoghrajesh commented on code in PR #38763: URL: https://github.com/apache/airflow/pull/38763#discussion_r1555197923 ## airflow/providers/apache/hive/CHANGELOG.rst: ## @@ -27,6 +27,14 @@ Changelog - +7.0.2 Review Comment: Sure, made the change for that --

Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38763: URL: https://github.com/apache/airflow/pull/38763#discussion_r1555086029 ## airflow/providers/apache/hive/CHANGELOG.rst: ## @@ -27,6 +27,14 @@ Changelog - +7.0.2 Review Comment: I think it's a breaking change it should be

Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-05 Thread via GitHub
amoghrajesh commented on code in PR #38763: URL: https://github.com/apache/airflow/pull/38763#discussion_r1553888022 ## airflow/providers/apache/hive/hooks/hive.py: ## @@ -126,7 +126,7 @@ def get_connection_form_widgets(cls) -> dict[str, Any]: from wtforms import

Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-05 Thread via GitHub
amoghrajesh commented on code in PR #38763: URL: https://github.com/apache/airflow/pull/38763#discussion_r1553281936 ## airflow/providers/apache/hive/hooks/hive.py: ## @@ -126,7 +126,7 @@ def get_connection_form_widgets(cls) -> dict[str, Any]: from wtforms import

Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-05 Thread via GitHub
eladkal commented on code in PR #38763: URL: https://github.com/apache/airflow/pull/38763#discussion_r1553274933 ## airflow/providers/apache/hive/hooks/hive.py: ## @@ -126,7 +126,7 @@ def get_connection_form_widgets(cls) -> dict[str, Any]: from wtforms import