amoghrajesh merged PR #38763:
URL: https://github.com/apache/airflow/pull/38763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
amoghrajesh commented on PR #38763:
URL: https://github.com/apache/airflow/pull/38763#issuecomment-2044230292
@eladkal fixed spelling and spaces, we should get a green run now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
eladkal commented on code in PR #38763:
URL: https://github.com/apache/airflow/pull/38763#discussion_r1556978919
##
airflow/providers/apache/hive/CHANGELOG.rst:
##
@@ -27,6 +27,18 @@
Changelog
-
+8.0.0
+.
+
+
+Breaking changes
+
+
+Changed the
eladkal commented on code in PR #38763:
URL: https://github.com/apache/airflow/pull/38763#discussion_r1556176719
##
airflow/providers/apache/hive/CHANGELOG.rst:
##
@@ -27,6 +27,19 @@
Changelog
-
+8.0.0
+.
+
+
+Breaking changes
+
+
+Changed the
potiuk commented on PR #38763:
URL: https://github.com/apache/airflow/pull/38763#issuecomment-2043244944
Approved with NIT's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
potiuk commented on code in PR #38763:
URL: https://github.com/apache/airflow/pull/38763#discussion_r1556155471
##
airflow/providers/apache/hive/provider.yaml:
##
@@ -25,6 +25,7 @@ state: ready
source-date-epoch: 1709554960
# note that those versions are maintained by release
potiuk commented on code in PR #38763:
URL: https://github.com/apache/airflow/pull/38763#discussion_r1556154848
##
airflow/providers/apache/hive/provider.yaml:
##
@@ -25,6 +25,7 @@ state: ready
source-date-epoch: 1709554960
# note that those versions are maintained by release
amoghrajesh commented on code in PR #38763:
URL: https://github.com/apache/airflow/pull/38763#discussion_r1555197923
##
airflow/providers/apache/hive/CHANGELOG.rst:
##
@@ -27,6 +27,14 @@
Changelog
-
+7.0.2
Review Comment:
Sure, made the change for that
--
potiuk commented on code in PR #38763:
URL: https://github.com/apache/airflow/pull/38763#discussion_r1555086029
##
airflow/providers/apache/hive/CHANGELOG.rst:
##
@@ -27,6 +27,14 @@
Changelog
-
+7.0.2
Review Comment:
I think it's a breaking change it should be
amoghrajesh commented on code in PR #38763:
URL: https://github.com/apache/airflow/pull/38763#discussion_r1553888022
##
airflow/providers/apache/hive/hooks/hive.py:
##
@@ -126,7 +126,7 @@ def get_connection_form_widgets(cls) -> dict[str, Any]:
from wtforms import
amoghrajesh commented on code in PR #38763:
URL: https://github.com/apache/airflow/pull/38763#discussion_r1553281936
##
airflow/providers/apache/hive/hooks/hive.py:
##
@@ -126,7 +126,7 @@ def get_connection_form_widgets(cls) -> dict[str, Any]:
from wtforms import
eladkal commented on code in PR #38763:
URL: https://github.com/apache/airflow/pull/38763#discussion_r1553274933
##
airflow/providers/apache/hive/hooks/hive.py:
##
@@ -126,7 +126,7 @@ def get_connection_form_widgets(cls) -> dict[str, Any]:
from wtforms import
12 matches
Mail list logo