Re: [PR] Update ACL during job reset [airflow]

2024-04-10 Thread via GitHub
pankajkoti merged PR #38741: URL: https://github.com/apache/airflow/pull/38741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update ACL during job reset [airflow]

2024-04-09 Thread via GitHub
Lee-W commented on code in PR #38741: URL: https://github.com/apache/airflow/pull/38741#discussion_r1557069145 ## airflow/providers/databricks/operators/databricks.py: ## @@ -316,6 +316,10 @@ def execute(self, context: Context) -> int: if job_id is None:

Re: [PR] Update ACL during job reset [airflow]

2024-04-09 Thread via GitHub
Taragolis commented on code in PR #38741: URL: https://github.com/apache/airflow/pull/38741#discussion_r1557056585 ## airflow/providers/databricks/operators/databricks.py: ## @@ -316,6 +316,10 @@ def execute(self, context: Context) -> int: if job_id is None:

Re: [PR] Update ACL during job reset [airflow]

2024-04-09 Thread via GitHub
Lee-W commented on code in PR #38741: URL: https://github.com/apache/airflow/pull/38741#discussion_r1557042849 ## airflow/providers/databricks/operators/databricks.py: ## @@ -316,6 +316,10 @@ def execute(self, context: Context) -> int: if job_id is None:

Re: [PR] Update ACL during job reset [airflow]

2024-04-09 Thread via GitHub
pankajkoti commented on code in PR #38741: URL: https://github.com/apache/airflow/pull/38741#discussion_r1556969732 ## airflow/providers/databricks/operators/databricks.py: ## @@ -316,6 +316,10 @@ def execute(self, context: Context) -> int: if job_id is None:

Re: [PR] Update ACL during job reset [airflow]

2024-04-08 Thread via GitHub
subham611 commented on code in PR #38741: URL: https://github.com/apache/airflow/pull/38741#discussion_r1556066734 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -655,6 +656,16 @@ def get_repo_by_path(self, path: str) -> str | None: return None +def

Re: [PR] Update ACL during job reset [airflow]

2024-04-08 Thread via GitHub
Lee-W commented on code in PR #38741: URL: https://github.com/apache/airflow/pull/38741#discussion_r1555946331 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -655,6 +656,16 @@ def get_repo_by_path(self, path: str) -> str | None: return None +def

Re: [PR] Update ACL during job reset [airflow]

2024-04-08 Thread via GitHub
Lee-W commented on PR #38741: URL: https://github.com/apache/airflow/pull/38741#issuecomment-2042912496 Thanks @potiuk for help out! @SubhamSinghal There's one static check failure. We might need your help to fix it -- This is an automated message from the Apache Git Service. To

Re: [PR] Update ACL during job reset [airflow]

2024-04-08 Thread via GitHub
potiuk commented on PR #38741: URL: https://github.com/apache/airflow/pull/38741#issuecomment-2042844353 Rebased it -> your PR was 62 commits behind -> next time you can do it yourself too (see our contributing docs and search for rebase)

Re: [PR] Update ACL during job reset [airflow]

2024-04-08 Thread via GitHub
subham611 commented on PR #38741: URL: https://github.com/apache/airflow/pull/38741#issuecomment-2042504136 @Lee-W How to fix `Wait for CI images` error. Need help here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Update ACL during job reset [airflow]

2024-04-07 Thread via GitHub
Lee-W commented on PR #38741: URL: https://github.com/apache/airflow/pull/38741#issuecomment-2041477480 > @Lee-W `Wait for CI images ` step is failing. How should I fix this, or simply rerun would work? Let me trigger rerun and see how it works -- This is an automated message from

Re: [PR] Update ACL during job reset [airflow]

2024-04-07 Thread via GitHub
subham611 commented on PR #38741: URL: https://github.com/apache/airflow/pull/38741#issuecomment-2041350618 @Lee-W `Wait for CI images ` step is failing. How should I fix this, or simply rerun would work? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Update ACL during job reset [airflow]

2024-04-04 Thread via GitHub
SubhamSinghal commented on PR #38741: URL: https://github.com/apache/airflow/pull/38741#issuecomment-2036767775 @Lee-W Please review changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the