[GitHub] [airflow] andy-g14 commented on issue #5506: AIRFLOW-4855 Airflow task remains in queued state

2019-07-13 Thread GitBox
andy-g14 commented on issue #5506: AIRFLOW-4855 Airflow task remains in queued state URL: https://github.com/apache/airflow/pull/5506#issuecomment-511094811 @ashb @pgagnon , I will add an UT for this change and update the PR. ~ Thanks.

[GitHub] [airflow] mik-laj commented on a change in pull request #5416: [AIRFLOW-4792] Include Sentry into Contrib Airflow

2019-07-13 Thread GitBox
mik-laj commented on a change in pull request #5416: [AIRFLOW-4792] Include Sentry into Contrib Airflow URL: https://github.com/apache/airflow/pull/5416#discussion_r303194848 ## File path: scripts/ci/pylint_todo.txt ## @@ -107,6 +107,7 @@

[GitHub] [airflow] serkef commented on issue #5557: [AIRFLOW-4928] Move all config parses to class properties

2019-07-13 Thread GitBox
serkef commented on issue #5557: [AIRFLOW-4928] Move all config parses to class properties URL: https://github.com/apache/airflow/pull/5557#issuecomment-511096329 @ashb I don't have a benchmark. The default arguments are evaluated in parsing, but still we don't need to evaluate multiple

[GitHub] [airflow] codecov-io edited a comment on issue #5522: [AIRFLOW-4882] Make GCP tests and examples Pylint compatible

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5522: [AIRFLOW-4882] Make GCP tests and examples Pylint compatible URL: https://github.com/apache/airflow/pull/5522#issuecomment-508068508 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5522?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5522: [AIRFLOW-4882] Make GCP tests and examples Pylint compatible

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5522: [AIRFLOW-4882] Make GCP tests and examples Pylint compatible URL: https://github.com/apache/airflow/pull/5522#issuecomment-508068508 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5522?src=pr=h1) Report > Merging

[jira] [Assigned] (AIRFLOW-3722) Improve BiqQueryHook test coverage

2019-07-13 Thread Felix Uellendall (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Uellendall reassigned AIRFLOW-3722: - Assignee: (was: Felix Uellendall) > Improve BiqQueryHook test coverage >

[GitHub] [airflow] feluelle edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
feluelle edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511109631 I don't know but this seems not right to me, if you check the ci log, the warning is displayed a lot. Is

[GitHub] [airflow] mik-laj commented on issue #5522: [AIRFLOW-4882] Make GCP tests and examples Pylint compatible

2019-07-13 Thread GitBox
mik-laj commented on issue #5522: [AIRFLOW-4882] Make GCP tests and examples Pylint compatible URL: https://github.com/apache/airflow/pull/5522#issuecomment-50157 I rebased this PR. When travis will be green, I will merge this PR.

[GitHub] [airflow] codecov-io edited a comment on issue #5522: [AIRFLOW-4882] Make GCP tests and examples Pylint compatible

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5522: [AIRFLOW-4882] Make GCP tests and examples Pylint compatible URL: https://github.com/apache/airflow/pull/5522#issuecomment-508068508 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5522?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5522: [AIRFLOW-4882] Make GCP tests and examples Pylint compatible

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5522: [AIRFLOW-4882] Make GCP tests and examples Pylint compatible URL: https://github.com/apache/airflow/pull/5522#issuecomment-508068508 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5522?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-4882) Make GCP tests and examples Pylint compatible

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884350#comment-16884350 ] ASF subversion and git services commented on AIRFLOW-4882: -- Commit

[jira] [Commented] (AIRFLOW-4882) Make GCP tests and examples Pylint compatible

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884349#comment-16884349 ] ASF GitHub Bot commented on AIRFLOW-4882: - mik-laj commented on pull request #5522:

[GitHub] [airflow] mik-laj merged pull request #5522: [AIRFLOW-4882] Make GCP tests and examples Pylint compatible

2019-07-13 Thread GitBox
mik-laj merged pull request #5522: [AIRFLOW-4882] Make GCP tests and examples Pylint compatible URL: https://github.com/apache/airflow/pull/5522 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] feluelle commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
feluelle commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511109631 I don't know but this seems not right to me, if you check the ci log, the warning is displayed a lot. Is this

[GitHub] [airflow] mik-laj commented on issue #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI

2019-07-13 Thread GitBox
mik-laj commented on issue #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI URL: https://github.com/apache/airflow/pull/5573#issuecomment-50456 I like this feature, but travis is sad: ``` 3) FAIL: test_variables (tests.transplant_class..C) 4) FAIL:

[GitHub] [airflow] ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format

2019-07-13 Thread GitBox
ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format URL: https://github.com/apache/airflow/pull/5584#issuecomment-511154921 Thank you, and sorry to be a bit of a pain - I'm coming at this with my "I've just cherry-picked 100s of commits over the last few months" hat on.

[GitHub] [airflow] codecov-io commented on issue #5576: [AIRFLOW-4942] Drop six.next

2019-07-13 Thread GitBox
codecov-io commented on issue #5576: [AIRFLOW-4942] Drop six.next URL: https://github.com/apache/airflow/pull/5576#issuecomment-511155668 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5576: [AIRFLOW-4942] Drop six.next

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5576: [AIRFLOW-4942] Drop six.next URL: https://github.com/apache/airflow/pull/5576#issuecomment-511155668 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=h1) Report > Merging

[GitHub] [airflow] ashb commented on issue #5325: [AIRFLOW-XXX] Add missing extras package to installation.rst

2019-07-13 Thread GitBox
ashb commented on issue #5325: [AIRFLOW-XXX] Add missing extras package to installation.rst URL: https://github.com/apache/airflow/pull/5325#issuecomment-511156757 @icyfox-bupt We should probably change it, assuming the current ldap module we install isn't used for anything else (I don't

[jira] [Commented] (AIRFLOW-4918) SparkShellHook

2019-07-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884499#comment-16884499 ] Ash Berlin-Taylor commented on AIRFLOW-4918: Isn't spark-shell designed for interactive

[GitHub] [airflow] ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to update nested keys in emr_defaults conn extras.

2019-07-13 Thread GitBox
ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to update nested keys in emr_defaults conn extras. URL: https://github.com/apache/airflow/pull/5550#discussion_r303220315 ## File path: tests/utils/test_helpers.py ## @@ -52,6 +52,7 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to update nested keys in emr_defaults conn extras.

2019-07-13 Thread GitBox
ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to update nested keys in emr_defaults conn extras. URL: https://github.com/apache/airflow/pull/5550#discussion_r303220308 ## File path: tests/contrib/hooks/test_emr_hook.py ## @@ -62,7 +62,7 @@ def

[GitHub] [airflow] codecov-io edited a comment on issue #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#issuecomment-511149460 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#issuecomment-511149460 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-4911) Silence the FORBIDDEN errors from the KubernetesExecutor

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884501#comment-16884501 ] ASF subversion and git services commented on AIRFLOW-4911: -- Commit

[jira] [Commented] (AIRFLOW-4911) Silence the FORBIDDEN errors from the KubernetesExecutor

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884502#comment-16884502 ] ASF subversion and git services commented on AIRFLOW-4911: -- Commit

[jira] [Commented] (AIRFLOW-4497) KubernetesExecutor fails to launch pods when using run_as_user or fs_group options

2019-07-13 Thread Philippe Gagnon (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884503#comment-16884503 ] Philippe Gagnon commented on AIRFLOW-4497: -- [~ndigati] Is this solved by AIRFLOW-4516? I think

[GitHub] [airflow] codecov-io commented on issue #5581: [AIRFLOW-4947] Remove six types

2019-07-13 Thread GitBox
codecov-io commented on issue #5581: [AIRFLOW-4947] Remove six types URL: https://github.com/apache/airflow/pull/5581#issuecomment-511158555 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5581: [AIRFLOW-4947] Remove six types

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5581: [AIRFLOW-4947] Remove six types URL: https://github.com/apache/airflow/pull/5581#issuecomment-511158555 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=h1) Report > Merging

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303211446 ## File path: scripts/ci/docker-compose-local.yml ## @@ -0,0 +1,42 @@ +# +# Licensed

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303211773 ## File path: scripts/ci/ci_mypy.sh ## @@ -0,0 +1,40 @@ +#!/usr/bin/env bash + +# +#

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303211708 ## File path: tests/operators/test_latest_only_operator.py ## @@ -19,7 +19,6 @@

[jira] [Created] (AIRFLOW-4944) Use new types syntax

2019-07-13 Thread Kamil (JIRA)
Kamil created AIRFLOW-4944: -- Summary: Use new types syntax Key: AIRFLOW-4944 URL: https://issues.apache.org/jira/browse/AIRFLOW-4944 Project: Apache Airflow Issue Type: Improvement

[jira] [Created] (AIRFLOW-4943) Replace six assertion method with native

2019-07-13 Thread Kamil (JIRA)
Kamil created AIRFLOW-4943: -- Summary: Replace six assertion method with native Key: AIRFLOW-4943 URL: https://issues.apache.org/jira/browse/AIRFLOW-4943 Project: Apache Airflow Issue Type:

[jira] [Created] (AIRFLOW-4945) Use super() syntax

2019-07-13 Thread Kamil (JIRA)
Kamil created AIRFLOW-4945: -- Summary: Use super() syntax Key: AIRFLOW-4945 URL: https://issues.apache.org/jira/browse/AIRFLOW-4945 Project: Apache Airflow Issue Type: Improvement

[jira] [Created] (AIRFLOW-4946) Use yield from syntax

2019-07-13 Thread Kamil (JIRA)
Kamil created AIRFLOW-4946: -- Summary: Use yield from syntax Key: AIRFLOW-4946 URL: https://issues.apache.org/jira/browse/AIRFLOW-4946 Project: Apache Airflow Issue Type: Improvement

[jira] [Commented] (AIRFLOW-4945) Use super() syntax

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884435#comment-16884435 ] ASF GitHub Bot commented on AIRFLOW-4945: - mik-laj commented on pull request #5579:

[GitHub] [airflow] mik-laj opened a new pull request #5580: [AIRFLOW-4946] Use yield from syntax

2019-07-13 Thread GitBox
mik-laj opened a new pull request #5580: [AIRFLOW-4946] Use yield from syntax URL: https://github.com/apache/airflow/pull/5580 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] mik-laj opened a new pull request #5579: [AIRFLOW-4945] Use super() syntax

2019-07-13 Thread GitBox
mik-laj opened a new pull request #5579: [AIRFLOW-4945] Use super() syntax URL: https://github.com/apache/airflow/pull/5579 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] codecov-io commented on issue #5579: [AIRFLOW-4945] Use super() syntax

2019-07-13 Thread GitBox
codecov-io commented on issue #5579: [AIRFLOW-4945] Use super() syntax URL: https://github.com/apache/airflow/pull/5579#issuecomment-511145638 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5579?src=pr=h1) Report > Merging

[jira] [Updated] (AIRFLOW-4946) Use yield from syntax

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-4946: -- Issue Type: Sub-task (was: Improvement) Parent: AIRFLOW-4196 > Use yield from

[GitHub] [airflow] ashb commented on a change in pull request #5580: [AIRFLOW-4946] Use yield from syntax

2019-07-13 Thread GitBox
ashb commented on a change in pull request #5580: [AIRFLOW-4946] Use yield from syntax URL: https://github.com/apache/airflow/pull/5580#discussion_r303216456 ## File path: airflow/contrib/hooks/grpc_hook.py ## @@ -100,8 +100,7 @@ def run(self, stub_class, call_func,

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303216801 ## File path: scripts/ci/_force_python_3.6.sh ## @@ -0,0 +1,34 @@ +#!/usr/bin/env bash

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303216729 ## File path: scripts/ci/_cache_utils.sh ## @@ -0,0 +1,99 @@ +#!/usr/bin/env bash +#

[GitHub] [airflow] milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149532 @ashb I thought about applying `default_args` in the setter but I don't see how we can support the following

[GitHub] [airflow] milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149532 @ashb I thought about applying `default_args` in the setter but I don't see how we can support the following case

[GitHub] [airflow] milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149609 @feluelle I see that it is flooding the CI since there are actually quite some example dags using the setter. I feel

[GitHub] [airflow] milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149532 @ashb I thought about applying `default_args` in the setter but I don't see how we can support the following

[GitHub] [airflow] ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511150575 I'd be very careful about deprecating something as "fundamental" as `task.dag = dag` -- even for 2.0.0 that would still

[GitHub] [airflow] ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511150505 @milton0825 How does the context manager handle this case: ``` dag = DAG('dag', default_args={'email_on_failure':

[GitHub] [airflow] ashb commented on issue #4291: [AIRFLOW-1488] Add the TriggeredDagRunSensor operator

2019-07-13 Thread GitBox
ashb commented on issue #4291: [AIRFLOW-1488] Add the TriggeredDagRunSensor operator URL: https://github.com/apache/airflow/pull/4291#issuecomment-511152626 > I can not start DAT_PUBLISH if there is DAG_UPDATE_PRICES in RUNNING https://airflow.apache.org/concepts.html#pools

[jira] [Commented] (AIRFLOW-4921) scheduler stuck with schedule is 2.30am and timezone is daylight saving time

2019-07-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884488#comment-16884488 ] Ash Berlin-Taylor commented on AIRFLOW-4921: Output I get on the RC: {noformat}

[jira] [Commented] (AIRFLOW-4921) scheduler stuck with schedule is 2.30am and timezone is daylight saving time

2019-07-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884484#comment-16884484 ] Ash Berlin-Taylor commented on AIRFLOW-4921: Likely already fixed in 1.10.4RC2 by

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303210482 ## File path: Dockerfile ## @@ -278,42 +273,81 @@ RUN echo "Pip version:

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303211152 ## File path: scripts/ci/ci_mypy.sh ## @@ -0,0 +1,40 @@ +#!/usr/bin/env bash + +# +#

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303211549 ## File path: setup.py ## @@ -290,12 +275,12 @@ def write_version(filename: str =

[GitHub] [airflow] mik-laj opened a new pull request #5577: [AIRFLOW-4943] Replace six assertion method with native

2019-07-13 Thread GitBox
mik-laj opened a new pull request #5577: [AIRFLOW-4943] Replace six assertion method with native URL: https://github.com/apache/airflow/pull/5577 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-4943) Replace six assertion method with native

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884433#comment-16884433 ] ASF GitHub Bot commented on AIRFLOW-4943: - mik-laj commented on pull request #5577:

[GitHub] [airflow] mik-laj opened a new pull request #5578: [AIRFLOW-4944] Use new types syntax

2019-07-13 Thread GitBox
mik-laj opened a new pull request #5578: [AIRFLOW-4944] Use new types syntax URL: https://github.com/apache/airflow/pull/5578 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-4944) Use new types syntax

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884434#comment-16884434 ] ASF GitHub Bot commented on AIRFLOW-4944: - mik-laj commented on pull request #5578:

[jira] [Commented] (AIRFLOW-4951) Use new style classes

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884442#comment-16884442 ] ASF GitHub Bot commented on AIRFLOW-4951: - mik-laj commented on pull request #5585:

[GitHub] [airflow] mik-laj opened a new pull request #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
mik-laj opened a new pull request #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Updated] (AIRFLOW-4951) Use new style classes

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-4951: -- Issue Type: Sub-task (was: Improvement) Parent: AIRFLOW-4196 > Use new style

[jira] [Updated] (AIRFLOW-4949) Use OSError exception

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-4949: -- Issue Type: Sub-task (was: Improvement) Parent: AIRFLOW-4196 > Use OSError

[jira] [Resolved] (AIRFLOW-4945) Use super() syntax

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4945. --- Resolution: Fixed Fix Version/s: 2.0.0 > Use super() syntax > -- >

[jira] [Commented] (AIRFLOW-4945) Use super() syntax

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884456#comment-16884456 ] ASF subversion and git services commented on AIRFLOW-4945: -- Commit

[jira] [Updated] (AIRFLOW-4945) Use super() syntax

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-4945: -- Issue Type: Sub-task (was: Improvement) Parent: AIRFLOW-4196 > Use super() syntax >

[jira] [Commented] (AIRFLOW-4945) Use super() syntax

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884455#comment-16884455 ] ASF GitHub Bot commented on AIRFLOW-4945: - potiuk commented on pull request #5579:

[GitHub] [airflow] potiuk merged pull request #5579: [AIRFLOW-4945] Use super() syntax

2019-07-13 Thread GitBox
potiuk merged pull request #5579: [AIRFLOW-4945] Use super() syntax URL: https://github.com/apache/airflow/pull/5579 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] codecov-io edited a comment on issue #5583: [AIRFLOW-4949] Use OSError exception

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5583: [AIRFLOW-4949] Use OSError exception URL: https://github.com/apache/airflow/pull/5583#issuecomment-511147742 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #5583: [AIRFLOW-4949] Use OSError exception

2019-07-13 Thread GitBox
codecov-io commented on issue #5583: [AIRFLOW-4949] Use OSError exception URL: https://github.com/apache/airflow/pull/5583#issuecomment-511147742 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=h1) Report > Merging

[jira] [Updated] (AIRFLOW-4943) Replace six assertion method with native

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-4943: -- Issue Type: Sub-task (was: Improvement) Parent: AIRFLOW-4196 > Replace six

[jira] [Updated] (AIRFLOW-4942) Drop six.next

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil updated AIRFLOW-4942: --- Summary: Drop six.next (was: Replace six.next with next) > Drop six.next > - > >

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303216568 ## File path: scripts/ci/docker-compose-local.yml ## @@ -0,0 +1,42 @@ +# +# Licensed to

[GitHub] [airflow] milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149532 @ashb I thought about applying `default_args` in the setter but I don't see how we can support the following

[jira] [Updated] (AIRFLOW-4942) Drop six.next

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil updated AIRFLOW-4942: --- Issue Type: Sub-task (was: Improvement) Parent: AIRFLOW-4196 > Drop six.next > - > >

[jira] [Assigned] (AIRFLOW-4942) Drop six.next

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil reassigned AIRFLOW-4942: -- Assignee: Kamil > Drop six.next > - > > Key: AIRFLOW-4942 >

[GitHub] [airflow] BasPH commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
BasPH commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#discussion_r303217355 ## File path: airflow/_vendor/nvd3/NVD3Chart.py ## @@ -36,7 +36,7 @@ def stab(tab=1): return ' ' * 4 * tab

[GitHub] [airflow] mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#discussion_r303217602 ## File path: airflow/_vendor/nvd3/NVD3Chart.py ## @@ -36,7 +36,7 @@ def stab(tab=1): return ' ' * 4 * tab

[GitHub] [airflow] BasPH commented on issue #5057: [AIRFLOW-4257] Remove the global session from the core test

2019-07-13 Thread GitBox
BasPH commented on issue #5057: [AIRFLOW-4257] Remove the global session from the core test URL: https://github.com/apache/airflow/pull/5057#issuecomment-511150879 Unrelated to this issue; but for the concern about boilerplate code I know there's some work being done on getting pytest in

[GitHub] [airflow] ashb commented on issue #5579: [AIRFLOW-4945] Use super() syntax

2019-07-13 Thread GitBox
ashb commented on issue #5579: [AIRFLOW-4945] Use super() syntax URL: https://github.com/apache/airflow/pull/5579#issuecomment-511150796 This should have been AIRFLOW-4204 - there was already a Jira for this issue. This is an

[GitHub] [airflow] mik-laj commented on issue #5584: [AIRFLOW-4950] Simplify string format

2019-07-13 Thread GitBox
mik-laj commented on issue #5584: [AIRFLOW-4950] Simplify string format URL: https://github.com/apache/airflow/pull/5584#issuecomment-511152368 This will help maintain good health of the code. When this change is accepted, it will be possible to automatically verify the code.

[jira] [Commented] (AIRFLOW-4946) Use yield from syntax

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884481#comment-16884481 ] ASF subversion and git services commented on AIRFLOW-4946: -- Commit

[jira] [Commented] (AIRFLOW-4946) Use yield from syntax

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884479#comment-16884479 ] ASF GitHub Bot commented on AIRFLOW-4946: - BasPH commented on pull request #5580:

[GitHub] [airflow] BasPH merged pull request #5580: [AIRFLOW-4946] Use yield from syntax

2019-07-13 Thread GitBox
BasPH merged pull request #5580: [AIRFLOW-4946] Use yield from syntax URL: https://github.com/apache/airflow/pull/5580 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] mik-laj closed pull request #5584: [AIRFLOW-4950] Simplify string format

2019-07-13 Thread GitBox
mik-laj closed pull request #5584: [AIRFLOW-4950] Simplify string format URL: https://github.com/apache/airflow/pull/5584 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (AIRFLOW-4950) Simplify code formation

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884490#comment-16884490 ] ASF GitHub Bot commented on AIRFLOW-4950: - mik-laj commented on pull request #5584:

[jira] [Created] (AIRFLOW-4942) Replace six.next with next

2019-07-13 Thread Kamil (JIRA)
Kamil created AIRFLOW-4942: -- Summary: Replace six.next with next Key: AIRFLOW-4942 URL: https://issues.apache.org/jira/browse/AIRFLOW-4942 Project: Apache Airflow Issue Type: Improvement

[jira] [Created] (AIRFLOW-4948) Use items, values method instead six package

2019-07-13 Thread Kamil (JIRA)
Kamil created AIRFLOW-4948: -- Summary: Use items, values method instead six package Key: AIRFLOW-4948 URL: https://issues.apache.org/jira/browse/AIRFLOW-4948 Project: Apache Airflow Issue Type:

[jira] [Created] (AIRFLOW-4950) Simplify code formation

2019-07-13 Thread Kamil (JIRA)
Kamil created AIRFLOW-4950: -- Summary: Simplify code formation Key: AIRFLOW-4950 URL: https://issues.apache.org/jira/browse/AIRFLOW-4950 Project: Apache Airflow Issue Type: Improvement

[jira] [Created] (AIRFLOW-4951) Use new style classes

2019-07-13 Thread Kamil (JIRA)
Kamil created AIRFLOW-4951: -- Summary: Use new style classes Key: AIRFLOW-4951 URL: https://issues.apache.org/jira/browse/AIRFLOW-4951 Project: Apache Airflow Issue Type: Improvement

[jira] [Created] (AIRFLOW-4947) Remove six types

2019-07-13 Thread Kamil (JIRA)
Kamil created AIRFLOW-4947: -- Summary: Remove six types Key: AIRFLOW-4947 URL: https://issues.apache.org/jira/browse/AIRFLOW-4947 Project: Apache Airflow Issue Type: Improvement

[jira] [Created] (AIRFLOW-4949) Use OSError exception

2019-07-13 Thread Kamil (JIRA)
Kamil created AIRFLOW-4949: -- Summary: Use OSError exception Key: AIRFLOW-4949 URL: https://issues.apache.org/jira/browse/AIRFLOW-4949 Project: Apache Airflow Issue Type: Improvement

[GitHub] [airflow] potiuk commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
potiuk commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#issuecomment-511140442 Hey @ashb - I fixed all comments (or explained) - all are so far in subsequent commits (I split them per fix to easier

[GitHub] [airflow] mik-laj opened a new pull request #5576: [AIRFLOW-4942] Replace six.next with next

2019-07-13 Thread GitBox
mik-laj opened a new pull request #5576: [AIRFLOW-4942] Replace six.next with next URL: https://github.com/apache/airflow/pull/5576 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-4942) Replace six.next with next

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884431#comment-16884431 ] ASF GitHub Bot commented on AIRFLOW-4942: - mik-laj commented on pull request #5576:

[GitHub] [airflow] potiuk commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
potiuk commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#issuecomment-511144487 And one more thing ... The builds started to fail because python released new images based on newly released debian

[GitHub] [airflow] potiuk commented on issue #5581: [AIRFLOW-4947] Remove six types

2019-07-13 Thread GitBox
potiuk commented on issue #5581: [AIRFLOW-4947] Remove six types URL: https://github.com/apache/airflow/pull/5581#issuecomment-511146314 You have to fix the imports though (flake) This is an automated message from the Apache

[jira] [Updated] (AIRFLOW-4948) Use items, values method instead six package

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-4948: -- Issue Type: Sub-task (was: Improvement) Parent: AIRFLOW-4196 > Use items, values

[GitHub] [airflow] ashb commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
ashb commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#issuecomment-511149357 What was the problem with debian buster btw? This is an

  1   2   >