[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7630: [AIRFLOW-6724] Add Google Analytics 360 Accounts Retrieve Operator

2020-03-12 Thread GitBox
michalslowikowski00 commented on a change in pull request #7630: [AIRFLOW-6724] Add Google Analytics 360 Accounts Retrieve Operator URL: https://github.com/apache/airflow/pull/7630#discussion_r391460324 ## File path: airflow/providers/google/marketing_platform/hooks/analytics.py

[GitHub] [airflow] dstandish edited a comment on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM

2020-03-12 Thread GitBox
dstandish edited a comment on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#issuecomment-598084161 updated: * can only specify one "alternative" secrets backend * default search path is `env var > metastore`;

[jira] [Comment Edited] (AIRFLOW-5334) After Airflow upgrade to 1.10.3 in the gcs to bq operator it is mandatory to specify either autodetect or schema paramaters

2020-03-12 Thread nexoriv (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057747#comment-17057747 ] nexoriv edited comment on AIRFLOW-5334 at 3/12/20, 9:31 AM: If you have the

[GitHub] [airflow] craigrosie commented on issue #7227: [AIRFLOW-6530] Allow Custom Statsd Client

2020-03-12 Thread GitBox
craigrosie commented on issue #7227: [AIRFLOW-6530] Allow Custom Statsd Client URL: https://github.com/apache/airflow/pull/7227#issuecomment-598097967 Hey @kaxil / @mik-laj, are you able to give this another review now that we've added tests?  Thank you in advance!

[GitHub] [airflow] aaronfowles opened a new pull request #7704: Add TODO for unit tests

2020-03-12 Thread GitBox
aaronfowles opened a new pull request #7704: Add TODO for unit tests URL: https://github.com/apache/airflow/pull/7704 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark the boxes below before creating PR: [x] - [ ]

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7704: Add TODO for unit tests

2020-03-12 Thread GitBox
boring-cyborg[bot] commented on issue #7704: Add TODO for unit tests URL: https://github.com/apache/airflow/pull/7704#issuecomment-598118883 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything

[jira] [Commented] (AIRFLOW-5944) Rendering templated_fields without accessing DAG files

2020-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057820#comment-17057820 ] ASF GitHub Bot commented on AIRFLOW-5944: - kaxil commented on pull request #6788:

[GitHub] [airflow] kaxil merged pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files

2020-03-12 Thread GitBox
kaxil merged pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files URL: https://github.com/apache/airflow/pull/6788 This is an automated message from the Apache Git Service. To

[GitHub] [airflow] kaxil commented on a change in pull request #7633: [AIRFLOW-6989][depends on AIRFLOW-5944] Store UnRenderedTemplateFields in SerializedDag table

2020-03-12 Thread GitBox
kaxil commented on a change in pull request #7633: [AIRFLOW-6989][depends on AIRFLOW-5944] Store UnRenderedTemplateFields in SerializedDag table URL: https://github.com/apache/airflow/pull/7633#discussion_r391549177 ## File path: tests/www/test_views.py ## @@ -1922,6

[jira] [Resolved] (AIRFLOW-5944) Rendering templated_fields without accessing DAG files

2020-03-12 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-5944. - Fix Version/s: 1.10.10 Resolution: Fixed > Rendering templated_fields without accessing

[jira] [Created] (AIRFLOW-7045) Update Sqlalchemy query to support all backends

2020-03-12 Thread Kaxil Naik (Jira)
Kaxil Naik created AIRFLOW-7045: --- Summary: Update Sqlalchemy query to support all backends Key: AIRFLOW-7045 URL: https://issues.apache.org/jira/browse/AIRFLOW-7045 Project: Apache Airflow

[GitHub] [airflow] kaxil commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files

2020-03-12 Thread GitBox
kaxil commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files URL: https://github.com/apache/airflow/pull/6788#discussion_r391551166 ## File path: airflow/models/renderedtifields.py ## @@ -0,0 +1,135 @@ +#

[GitHub] [airflow] ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics

2020-03-12 Thread GitBox
ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics URL: https://github.com/apache/airflow/pull/6342#discussion_r391559959 ## File path: airflow/models/pool.py ## @@ -48,6 +50,45 @@ def

[GitHub] [airflow] kaxil commented on a change in pull request #7633: [AIRFLOW-6989] Display Rendered template_fields without accessing Dagfiles

2020-03-12 Thread GitBox
kaxil commented on a change in pull request #7633: [AIRFLOW-6989] Display Rendered template_fields without accessing Dagfiles URL: https://github.com/apache/airflow/pull/7633#discussion_r391614501 ## File path: tests/serialization/test_dag_serialization.py ## @@ -538,6

[jira] [Comment Edited] (AIRFLOW-2289) Add additional quick start to INSTALL

2020-03-12 Thread Esther Itolima (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057826#comment-17057826 ] Esther Itolima edited comment on AIRFLOW-2289 at 3/12/20, 11:17 AM:

[jira] [Commented] (AIRFLOW-2289) Add additional quick start to INSTALL

2020-03-12 Thread Esther Itolima (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057826#comment-17057826 ] Esther Itolima commented on AIRFLOW-2289: - Please I will love to contribute to this issue. >

[GitHub] [airflow] baolsen commented on issue #7619: [AIRFLOW-6975] Base AWSHook AssumeRoleWithSAML

2020-03-12 Thread GitBox
baolsen commented on issue #7619: [AIRFLOW-6975] Base AWSHook AssumeRoleWithSAML URL: https://github.com/apache/airflow/pull/7619#issuecomment-598149120 @nuclearpinguin Ready to merge :) This is an automated message from the

[GitHub] [airflow] neodino commented on issue #3138: [AIRFLOW-2221] Create DagFetcher abstraction

2020-03-12 Thread GitBox
neodino commented on issue #3138: [AIRFLOW-2221] Create DagFetcher abstraction URL: https://github.com/apache/airflow/pull/3138#issuecomment-598172656 Any news? This is an automated message from the Apache Git Service. To

[GitHub] [airflow] dstandish edited a comment on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM

2020-03-12 Thread GitBox
dstandish edited a comment on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#issuecomment-598084161 updated: * can only specify one "alternative" secrets backend * default search path is `env var > metastore`;

[jira] [Commented] (AIRFLOW-5334) After Airflow upgrade to 1.10.3 in the gcs to bq operator it is mandatory to specify either autodetect or schema paramaters

2020-03-12 Thread nexoriv (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057747#comment-17057747 ] nexoriv commented on AIRFLOW-5334: -- If you have the schema defined why do you need to set the

[jira] [Created] (AIRFLOW-7044) SSH connection (and hook) should support public host_key usage

2020-03-12 Thread Aaron Fowles (Jira)
Aaron Fowles created AIRFLOW-7044: - Summary: SSH connection (and hook) should support public host_key usage Key: AIRFLOW-7044 URL: https://issues.apache.org/jira/browse/AIRFLOW-7044 Project: Apache

[GitHub] [airflow] Khrol commented on issue #7622: [AIRFLOW-6983] Configure connection pool disabling in CLI

2020-03-12 Thread GitBox
Khrol commented on issue #7622: [AIRFLOW-6983] Configure connection pool disabling in CLI URL: https://github.com/apache/airflow/pull/7622#issuecomment-598117215 I've pushed a wider explanation. This is an automated message

[jira] [Resolved] (AIRFLOW-643) Improve coerce_to_timestamp for salesforce_hook

2020-03-12 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-643. Fix Version/s: 1.8.0 Resolution: Fixed > Improve coerce_to_timestamp for salesforce_hook >

[GitHub] [airflow] ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics

2020-03-12 Thread GitBox
ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics URL: https://github.com/apache/airflow/pull/6342#discussion_r391559174 ## File path: airflow/models/pool.py ## @@ -48,6 +50,45 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics

2020-03-12 Thread GitBox
ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics URL: https://github.com/apache/airflow/pull/6342#discussion_r391559354 ## File path: airflow/models/pool.py ## @@ -48,6 +50,45 @@ def

[jira] [Updated] (AIRFLOW-7044) SSH connection (and hook) should support public host_key usage

2020-03-12 Thread Aaron Fowles (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aaron Fowles updated AIRFLOW-7044: -- Issue Type: Improvement (was: New Feature) > SSH connection (and hook) should support

[jira] [Updated] (AIRFLOW-7044) SSH connection (and hook) should support public host_key usage

2020-03-12 Thread Aaron Fowles (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aaron Fowles updated AIRFLOW-7044: -- Issue Type: New Feature (was: Bug) > SSH connection (and hook) should support public

[jira] [Created] (AIRFLOW-7046) Support Locale-formatted datetimes in Webserver

2020-03-12 Thread Kaxil Naik (Jira)
Kaxil Naik created AIRFLOW-7046: --- Summary: Support Locale-formatted datetimes in Webserver Key: AIRFLOW-7046 URL: https://issues.apache.org/jira/browse/AIRFLOW-7046 Project: Apache Airflow

[GitHub] [airflow] dstandish edited a comment on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM

2020-03-12 Thread GitBox
dstandish edited a comment on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#issuecomment-598084161 updated: * can only specify one "alternative" secrets backend * default search path is `env var > metastore`;

[GitHub] [airflow] dstandish edited a comment on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM

2020-03-12 Thread GitBox
dstandish edited a comment on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#issuecomment-598084161 updated: * can only specify one "alternative" secrets backend * default search path is `env var > metastore`;

[GitHub] [airflow] kaxil commented on a change in pull request #7633: [AIRFLOW-6989][depends on AIRFLOW-5944] Store UnRenderedTemplateFields in SerializedDag table

2020-03-12 Thread GitBox
kaxil commented on a change in pull request #7633: [AIRFLOW-6989][depends on AIRFLOW-5944] Store UnRenderedTemplateFields in SerializedDag table URL: https://github.com/apache/airflow/pull/7633#discussion_r391561972 ## File path: airflow/models/renderedtifields.py ## @@

[GitHub] [airflow] ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics

2020-03-12 Thread GitBox
ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics URL: https://github.com/apache/airflow/pull/6342#discussion_r391561965 ## File path: airflow/jobs/scheduler_job.py ## @@ -28,7 +28,8 @@ from

[jira] [Updated] (AIRFLOW-7045) Update Sqlalchemy query to support all backends

2020-03-12 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-7045: Labels: dag-serialization (was: ) > Update Sqlalchemy query to support all backends >

[GitHub] [airflow] ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics

2020-03-12 Thread GitBox
ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics URL: https://github.com/apache/airflow/pull/6342#discussion_r391562244 ## File path: airflow/jobs/scheduler_job.py ## @@ -1647,6 +1649,13 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics

2020-03-12 Thread GitBox
ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics URL: https://github.com/apache/airflow/pull/6342#discussion_r391562470 ## File path: airflow/jobs/scheduler_job.py ## @@ -1647,6 +1649,13 @@ def

[GitHub] [airflow] kaxil commented on issue #7693: [AIRFLOW-3981] Locale-formatted datetimes (UI only)

2020-03-12 Thread GitBox
kaxil commented on issue #7693: [AIRFLOW-3981] Locale-formatted datetimes (UI only) URL: https://github.com/apache/airflow/pull/7693#issuecomment-598140505 Pushed a commit to fix static check 爛 This is an automated message

[jira] [Resolved] (AIRFLOW-6954) Use DagRunType instead of ID_PREFIX in run_id

2020-03-12 Thread Tomasz Urbaszek (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomasz Urbaszek resolved AIRFLOW-6954. -- Fix Version/s: 2.0.0 Resolution: Done > Use DagRunType instead of ID_PREFIX

[jira] [Commented] (AIRFLOW-6954) Use DagRunType instead of ID_PREFIX in run_id

2020-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057894#comment-17057894 ] ASF GitHub Bot commented on AIRFLOW-6954: - nuclearpinguin commented on pull request #7583:

[GitHub] [airflow] nuclearpinguin merged pull request #7583: [AIRFLOW-6954] Use DagRunType instead of ID_PREFIX in run_id

2020-03-12 Thread GitBox
nuclearpinguin merged pull request #7583: [AIRFLOW-6954] Use DagRunType instead of ID_PREFIX in run_id URL: https://github.com/apache/airflow/pull/7583 This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] codecov-io edited a comment on issue #7217: [AIRFLOW-5946] Store source code in db

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #7217: [AIRFLOW-5946] Store source code in db URL: https://github.com/apache/airflow/pull/7217#issuecomment-579802747 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7217?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7217: [AIRFLOW-5946] Store source code in db

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #7217: [AIRFLOW-5946] Store source code in db URL: https://github.com/apache/airflow/pull/7217#issuecomment-579802747 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7217?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-7047) build-providers-dependencies pre-commit fails on mac

2020-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057916#comment-17057916 ] ASF GitHub Bot commented on AIRFLOW-7047: - potiuk commented on pull request #7705:

[GitHub] [airflow] codecov-io edited a comment on issue #7217: [AIRFLOW-5946] Store source code in db

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #7217: [AIRFLOW-5946] Store source code in db URL: https://github.com/apache/airflow/pull/7217#issuecomment-579802747 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7217?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #7622: [AIRFLOW-6983] Configure connection pool disabling in CLI

2020-03-12 Thread GitBox
codecov-io commented on issue #7622: [AIRFLOW-6983] Configure connection pool disabling in CLI URL: https://github.com/apache/airflow/pull/7622#issuecomment-598118289 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7622?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7622: [AIRFLOW-6983] Configure connection pool disabling in CLI

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #7622: [AIRFLOW-6983] Configure connection pool disabling in CLI URL: https://github.com/apache/airflow/pull/7622#issuecomment-598118289 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7622?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files

2020-03-12 Thread GitBox
kaxil commented on a change in pull request #6788: [AIRFLOW-5944] Display rendered template_fields without accessing DAG files URL: https://github.com/apache/airflow/pull/6788#discussion_r391547348 ## File path: airflow/models/renderedtifields.py ## @@ -0,0 +1,135 @@ +#

[GitHub] [airflow] ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics

2020-03-12 Thread GitBox
ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics URL: https://github.com/apache/airflow/pull/6342#discussion_r391560565 ## File path: airflow/models/pool.py ## @@ -48,6 +50,45 @@ def

[GitHub] [airflow] codecov-io edited a comment on issue #7583: [AIRFLOW-6954] Use DagRunType instead of ID_PREFIX in run_id

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #7583: [AIRFLOW-6954] Use DagRunType instead of ID_PREFIX in run_id URL: https://github.com/apache/airflow/pull/7583#issuecomment-598153296 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7583?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #7583: [AIRFLOW-6954] Use DagRunType instead of ID_PREFIX in run_id

2020-03-12 Thread GitBox
codecov-io commented on issue #7583: [AIRFLOW-6954] Use DagRunType instead of ID_PREFIX in run_id URL: https://github.com/apache/airflow/pull/7583#issuecomment-598153296 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7583?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7583: [AIRFLOW-6954] Use DagRunType instead of ID_PREFIX in run_id

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #7583: [AIRFLOW-6954] Use DagRunType instead of ID_PREFIX in run_id URL: https://github.com/apache/airflow/pull/7583#issuecomment-598153296 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7583?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil commented on a change in pull request #7633: [AIRFLOW-6989] Display Rendered template_fields without accessing Dagfiles

2020-03-12 Thread GitBox
kaxil commented on a change in pull request #7633: [AIRFLOW-6989] Display Rendered template_fields without accessing Dagfiles URL: https://github.com/apache/airflow/pull/7633#discussion_r391614742 ## File path: tests/www/test_views.py ## @@ -1922,6 +1922,24 @@ def

[GitHub] [airflow] potiuk opened a new pull request #7705: [AIRFLOW-7047] Fixe build providers dependencies pre-commit on Mac

2020-03-12 Thread GitBox
potiuk opened a new pull request #7705: [AIRFLOW-7047] Fixe build providers dependencies pre-commit on Mac URL: https://github.com/apache/airflow/pull/7705 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark the boxes

[GitHub] [airflow] dstandish commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM

2020-03-12 Thread GitBox
dstandish commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#issuecomment-598084161 updated: * can only specify one "alternative" secrets backend * by default it is `env var > metastore`; if a backend

[jira] [Commented] (AIRFLOW-5506) Airflow scheduler stuck

2020-03-12 Thread Jira
[ https://issues.apache.org/jira/browse/AIRFLOW-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057825#comment-17057825 ] Noël BARDELOT commented on AIRFLOW-5506: We encounter the same issue. Only one DAG running a

[GitHub] [airflow] codecov-io edited a comment on issue #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #7541: [AIRFLOW-6822] AWS hooks should cache boto3 client URL: https://github.com/apache/airflow/pull/7541#issuecomment-591909170 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7541?src=pr=h1) Report > Merging

[jira] [Created] (AIRFLOW-7047) build-providers-dependencies pre-commit fails on mac

2020-03-12 Thread Jarek Potiuk (Jira)
Jarek Potiuk created AIRFLOW-7047: - Summary: build-providers-dependencies pre-commit fails on mac Key: AIRFLOW-7047 URL: https://issues.apache.org/jira/browse/AIRFLOW-7047 Project: Apache Airflow

[GitHub] [airflow] codecov-io edited a comment on issue #7703: [AIRFLOW-6481] Fix bug in SalesforceHook

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #7703: [AIRFLOW-6481] Fix bug in SalesforceHook URL: https://github.com/apache/airflow/pull/7703#issuecomment-598026076 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7703?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #7703: [AIRFLOW-6481] Fix bug in SalesforceHook

2020-03-12 Thread GitBox
codecov-io commented on issue #7703: [AIRFLOW-6481] Fix bug in SalesforceHook URL: https://github.com/apache/airflow/pull/7703#issuecomment-598026076 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7703?src=pr=h1) Report > Merging

[GitHub] [airflow] dstandish commented on a change in pull request #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM

2020-03-12 Thread GitBox
dstandish commented on a change in pull request #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#discussion_r391442408 ## File path: airflow/providers/amazon/aws/secrets/ssm.py ## @@ -0,0 +1,120 @@ +# +#

[GitHub] [airflow] dstandish commented on a change in pull request #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM

2020-03-12 Thread GitBox
dstandish commented on a change in pull request #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#discussion_r391442408 ## File path: airflow/providers/amazon/aws/secrets/ssm.py ## @@ -0,0 +1,120 @@ +# +#

[jira] [Commented] (AIRFLOW-7013) Breeze should check automatically if the image should be pulled

2020-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057718#comment-17057718 ] ASF GitHub Bot commented on AIRFLOW-7013: - potiuk commented on pull request #7656:

[GitHub] [airflow] potiuk merged pull request #7656: [AIRFLOW-7013] Automated check if Breeze image needs to be pulled

2020-03-12 Thread GitBox
potiuk merged pull request #7656: [AIRFLOW-7013] Automated check if Breeze image needs to be pulled URL: https://github.com/apache/airflow/pull/7656 This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] toddy86 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-12 Thread GitBox
toddy86 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#discussion_r391467432 ## File path: airflow/providers/google/marketing_platform/hooks/google_ads.py ## @@ -0,0

[GitHub] [airflow] potiuk commented on issue #7703: [AIRFLOW-6481] Fix bug in SalesforceHook

2020-03-12 Thread GitBox
potiuk commented on issue #7703: [AIRFLOW-6481] Fix bug in SalesforceHook URL: https://github.com/apache/airflow/pull/7703#issuecomment-598043534 Thanks @TeddyHartanto ! This is an automated message from the Apache Git

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7630: [AIRFLOW-6724] Add Google Analytics 360 Accounts Retrieve Operator

2020-03-12 Thread GitBox
michalslowikowski00 commented on a change in pull request #7630: [AIRFLOW-6724] Add Google Analytics 360 Accounts Retrieve Operator URL: https://github.com/apache/airflow/pull/7630#discussion_r391459941 ## File path: airflow/providers/google/marketing_platform/hooks/analytics.py

[GitHub] [airflow] toddy86 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-12 Thread GitBox
toddy86 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#discussion_r391464124 ## File path: airflow/providers/google/marketing_platform/example_dags/example_google_ads.py

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-12 Thread GitBox
michalslowikowski00 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#discussion_r391463863 ## File path: airflow/providers/google/marketing_platform/hooks/google_ads.py

[GitHub] [airflow] toddy86 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-12 Thread GitBox
toddy86 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#discussion_r391463662 ## File path: airflow/providers/google/marketing_platform/example_dags/example_google_ads.py

[GitHub] [airflow] michalslowikowski00 commented on issue #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-12 Thread GitBox
michalslowikowski00 commented on issue #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#issuecomment-598070454 Good job! 磊 This is an automated message from

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-12 Thread GitBox
michalslowikowski00 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#discussion_r391470712 ## File path: airflow/providers/google/marketing_platform/hooks/google_ads.py

[GitHub] [airflow] potiuk merged pull request #7695: [AIRFLOW-XXXX] Change CONTRIBUTING.md to CONTRIBUTING.rst

2020-03-12 Thread GitBox
potiuk merged pull request #7695: [AIRFLOW-] Change CONTRIBUTING.md to CONTRIBUTING.rst URL: https://github.com/apache/airflow/pull/7695 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] codecov-io commented on issue #7619: [AIRFLOW-6975] Base AWSHook AssumeRoleWithSAML

2020-03-12 Thread GitBox
codecov-io commented on issue #7619: [AIRFLOW-6975] Base AWSHook AssumeRoleWithSAML URL: https://github.com/apache/airflow/pull/7619#issuecomment-598039648 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7619?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7619: [AIRFLOW-6975] Base AWSHook AssumeRoleWithSAML

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #7619: [AIRFLOW-6975] Base AWSHook AssumeRoleWithSAML URL: https://github.com/apache/airflow/pull/7619#issuecomment-598039648 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7619?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7619: [AIRFLOW-6975] Base AWSHook AssumeRoleWithSAML

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #7619: [AIRFLOW-6975] Base AWSHook AssumeRoleWithSAML URL: https://github.com/apache/airflow/pull/7619#issuecomment-598039648 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7619?src=pr=h1) Report > Merging

[GitHub] [airflow] potiuk merged pull request #7700: [AIRFLOW-XXXX] Fix broken link in backport_packages/README.md

2020-03-12 Thread GitBox
potiuk merged pull request #7700: [AIRFLOW-] Fix broken link in backport_packages/README.md URL: https://github.com/apache/airflow/pull/7700 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk merged pull request #7703: [AIRFLOW-6481] Fix bug in SalesforceHook

2020-03-12 Thread GitBox
potiuk merged pull request #7703: [AIRFLOW-6481] Fix bug in SalesforceHook URL: https://github.com/apache/airflow/pull/7703 This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (AIRFLOW-6481) SalesforceHook attempts to use .str accessor on object dtype

2020-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057661#comment-17057661 ] ASF GitHub Bot commented on AIRFLOW-6481: - potiuk commented on pull request #7703:

[jira] [Resolved] (AIRFLOW-6481) SalesforceHook attempts to use .str accessor on object dtype

2020-03-12 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-6481. --- Fix Version/s: 2.0.0 Resolution: Fixed > SalesforceHook attempts to use .str

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7703: [AIRFLOW-6481] Fix bug in SalesforceHook

2020-03-12 Thread GitBox
boring-cyborg[bot] commented on issue #7703: [AIRFLOW-6481] Fix bug in SalesforceHook URL: https://github.com/apache/airflow/pull/7703#issuecomment-598043253 Awesome work, congrats on your first merged pull request! This

[GitHub] [airflow] potiuk merged pull request #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

2020-03-12 Thread GitBox
potiuk merged pull request #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op URL: https://github.com/apache/airflow/pull/7685 This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (AIRFLOW-7034) Remove feature: Assigning Dag to task using Bitshift Operator

2020-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057663#comment-17057663 ] ASF GitHub Bot commented on AIRFLOW-7034: - potiuk commented on pull request #7685:

[GitHub] [airflow] toddy86 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-12 Thread GitBox
toddy86 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#discussion_r391464124 ## File path: airflow/providers/google/marketing_platform/example_dags/example_google_ads.py

[GitHub] [airflow] toddy86 commented on issue #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-12 Thread GitBox
toddy86 commented on issue #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#issuecomment-598071050 Note: I will fix the static checks failure in Travis in my next commit. My local environment made formatting changes on my

[GitHub] [airflow] potiuk merged pull request #7701: [AIRFLOW-XXXX] Wrap line under 110 characters

2020-03-12 Thread GitBox
potiuk merged pull request #7701: [AIRFLOW-] Wrap line under 110 characters URL: https://github.com/apache/airflow/pull/7701 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] toddy86 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-12 Thread GitBox
toddy86 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#discussion_r391466638 ## File path: airflow/providers/google/marketing_platform/hooks/google_ads.py ## @@ -0,0

[GitHub] [airflow] toddy86 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-12 Thread GitBox
toddy86 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#discussion_r391464124 ## File path: airflow/providers/google/marketing_platform/example_dags/example_google_ads.py

[GitHub] [airflow] codecov-io edited a comment on issue #7703: [AIRFLOW-6481] Fix bug in SalesforceHook

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #7703: [AIRFLOW-6481] Fix bug in SalesforceHook URL: https://github.com/apache/airflow/pull/7703#issuecomment-598026076 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7703?src=pr=h1) Report > Merging

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator

2020-03-12 Thread GitBox
michalslowikowski00 commented on a change in pull request #7692: [AIRFLOW-6732] Add GoogleAdsHook and GoogleAdsToGcsOperator URL: https://github.com/apache/airflow/pull/7692#discussion_r391468790 ## File path: docs/howto/operator/gcp/google_ads.rst ## @@ -0,0 +1,51 @@ +

[GitHub] [airflow] potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM

2020-03-12 Thread GitBox
potiuk commented on issue #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#issuecomment-598208489 I like this approach better. Have you thought about adding generic "get secret" implementation ?I am not sure if this has

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7630: [AIRFLOW-6724] Add Google Analytics 360 Accounts Retrieve Operator

2020-03-12 Thread GitBox
nuclearpinguin commented on a change in pull request #7630: [AIRFLOW-6724] Add Google Analytics 360 Accounts Retrieve Operator URL: https://github.com/apache/airflow/pull/7630#discussion_r391688028 ## File path: airflow/providers/google/marketing_platform/operators/analytics.py

[GitHub] [airflow] potiuk commented on issue #7655: [AIRFLOW-7001] Further fix for the MySQL 5.7 UtcDateTime

2020-03-12 Thread GitBox
potiuk commented on issue #7655: [AIRFLOW-7001] Further fix for the MySQL 5.7 UtcDateTime URL: https://github.com/apache/airflow/pull/7655#issuecomment-598247243 Hey @ashb -> would love to merge it. Then I could also switch to 5.7 in tests #7570

[GitHub] [airflow] mik-laj commented on a change in pull request #7630: [AIRFLOW-6724] Add Google Analytics 360 Accounts Retrieve Operator

2020-03-12 Thread GitBox
mik-laj commented on a change in pull request #7630: [AIRFLOW-6724] Add Google Analytics 360 Accounts Retrieve Operator URL: https://github.com/apache/airflow/pull/7630#discussion_r391695761 ## File path: airflow/providers/google/marketing_platform/hooks/analytics.py ##

[GitHub] [airflow] kaxil commented on a change in pull request #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM

2020-03-12 Thread GitBox
kaxil commented on a change in pull request #6376: [AIRFLOW-5705] Add secrets backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#discussion_r391745311 ## File path: airflow/configuration.py ## @@ -304,6 +304,24 @@ def getint(self, section,

[GitHub] [airflow] dephusluke commented on issue #6377: [AIRFLOW-5589] monitor pods by labels instead of names

2020-03-12 Thread GitBox
dephusluke commented on issue #6377: [AIRFLOW-5589] monitor pods by labels instead of names URL: https://github.com/apache/airflow/pull/6377#issuecomment-598286757 was this fixed somewhere else? This is an automated message

[GitHub] [airflow] ashb commented on a change in pull request #7693: [AIRFLOW-7046] Locale-formatted datetimes (UI only)

2020-03-12 Thread GitBox
ashb commented on a change in pull request #7693: [AIRFLOW-7046] Locale-formatted datetimes (UI only) URL: https://github.com/apache/airflow/pull/7693#discussion_r391752808 ## File path: airflow/www/utils.py ## @@ -282,7 +289,18 @@ def dt(attr): f = f.isoformat()

[jira] [Updated] (AIRFLOW-7031) Airflow WinRM endpoint is hardcoded to HTTP

2020-03-12 Thread Jira
[ https://issues.apache.org/jira/browse/AIRFLOW-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noël BARDELOT updated AIRFLOW-7031: --- Description: In airflow/providers/microsoft/winrm/hooks/winrm.py the following code is

[GitHub] [airflow] anitakar commented on a change in pull request #7217: [AIRFLOW-5946] Store source code in db

2020-03-12 Thread GitBox
anitakar commented on a change in pull request #7217: [AIRFLOW-5946] Store source code in db URL: https://github.com/apache/airflow/pull/7217#discussion_r391774159 ## File path: airflow/models/dag.py ## @@ -591,6 +593,29 @@ def owner(self) -> str: """

[GitHub] [airflow] kaxil commented on issue #7374: [AIRFLOW-6399] Serialization: DAG access_control field should be deco…

2020-03-12 Thread GitBox
kaxil commented on issue #7374: [AIRFLOW-6399] Serialization: DAG access_control field should be deco… URL: https://github.com/apache/airflow/pull/7374#issuecomment-598344642 I have restarted the test This is an automated

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7630: [AIRFLOW-6724] Add Google Analytics 360 Accounts Retrieve Operator

2020-03-12 Thread GitBox
michalslowikowski00 commented on a change in pull request #7630: [AIRFLOW-6724] Add Google Analytics 360 Accounts Retrieve Operator URL: https://github.com/apache/airflow/pull/7630#discussion_r391755573 ## File path: airflow/providers/google/marketing_platform/hooks/analytics.py

[jira] [Updated] (AIRFLOW-7031) Airflow WinRM endpoint is hardcoded to HTTP

2020-03-12 Thread Jira
[ https://issues.apache.org/jira/browse/AIRFLOW-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noël BARDELOT updated AIRFLOW-7031: --- Description: In airflow/providers/microsoft/winrm/hooks/winrm.py the following code is

  1   2   3   >