[GitHub] [airflow] ashb commented on a change in pull request #12766: Kubernetes worker pod doesn't use docker container entrypoint

2020-12-03 Thread GitBox
ashb commented on a change in pull request #12766: URL: https://github.com/apache/airflow/pull/12766#discussion_r535093923 ## File path: airflow/kubernetes/pod_generator.py ## @@ -351,7 +351,7 @@ def construct_pod( # pylint: disable=too-many-arguments try_number:

[GitHub] [airflow] ashb commented on a change in pull request #12766: Kubernetes worker pod doesn't use docker container entrypoint

2020-12-03 Thread GitBox
ashb commented on a change in pull request #12766: URL: https://github.com/apache/airflow/pull/12766#discussion_r535094089 ## File path: airflow/executors/kubernetes_executor.py ## @@ -297,7 +297,7 @@ def run_next(self, next_job: KubernetesJobType) -> None:

[jira] [Commented] (AIRFLOW-2884) Fix Flask SECRET_KEY security issue in www_rbac

2020-12-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243099#comment-17243099 ] ASF subversion and git services commented on AIRFLOW-2884: -- Commit

[GitHub] [airflow] turbaszek commented on a change in pull request #12764: Improve error handling in cli and introduce consistency

2020-12-03 Thread GitBox
turbaszek commented on a change in pull request #12764: URL: https://github.com/apache/airflow/pull/12764#discussion_r535120274 ## File path: airflow/cli/commands/connection_command.py ## @@ -140,20 +136,19 @@ def connections_export(args): _, filetype =

[GitHub] [airflow-site] mik-laj merged pull request #325: User-friendly output for site.sh (#319) Copy docs for stable version to /docs/stable/ (#321) + Sanity checks

2020-12-03 Thread GitBox
mik-laj merged pull request #325: URL: https://github.com/apache/airflow-site/pull/325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] albydeca commented on issue #8087: State of this instance has been externally set to removed. Taking the poison pill.

2020-12-03 Thread GitBox
albydeca commented on issue #8087: URL: https://github.com/apache/airflow/issues/8087#issuecomment-737975233 any update on this? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] rmanvar-indeed commented on issue #12776: Update source_code field of dag_code table to MEDIUMTEXT

2020-12-03 Thread GitBox
rmanvar-indeed commented on issue #12776: URL: https://github.com/apache/airflow/issues/12776#issuecomment-738003669 Awesome. Thanks :smile: will take a look. This is an automated message from the Apache Git Service. To

[GitHub] [airflow] turbaszek edited a comment on issue #12587: dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-03 Thread GitBox
turbaszek edited a comment on issue #12587: URL: https://github.com/apache/airflow/issues/12587#issuecomment-738002984 @potiuk the problem is in `airflow/operators/dagrun_operator.py` where the `TriggerDagRunOperator` is 

[GitHub] [airflow] RikHeijdens commented on issue #12785: Macros added through plugins can not be used within Jinja templates in Airflow 2.0

2020-12-03 Thread GitBox
RikHeijdens commented on issue #12785: URL: https://github.com/apache/airflow/issues/12785#issuecomment-738058026 Hey @mik-laj, thanks for the quick response. I think that's right, we should update the entries in the `airflow.macros` module there too. I'm happy to propose a PR later

[GitHub] [airflow] mik-laj commented on a change in pull request #12764: Improve error handling in cli and introduce consistency

2020-12-03 Thread GitBox
mik-laj commented on a change in pull request #12764: URL: https://github.com/apache/airflow/pull/12764#discussion_r535097197 ## File path: airflow/cli/commands/connection_command.py ## @@ -140,20 +136,19 @@ def connections_export(args): _, filetype =

[airflow] branch v1-10-test updated (a4edcf9 -> b13a9ee)

2020-12-03 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git. omit a4edcf9 Update setup.py to get non-conflicting set of dependencies (#12636) omit 8998a55 Update

[airflow] 01/04: Add Kubernetes cleanup-pods CLI command for Helm Chart (#11802)

2020-12-03 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit c00a98eef700ef450c8c212eea189631d1be0514 Author: Kaxil Naik AuthorDate: Tue Nov 3 15:28:51 2020 + Add

[airflow] 02/04: Add Changelog for 1.10.14

2020-12-03 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 9a0c638ea02301bc34c010d2b1638edece628bd2 Author: Kaxil Naik AuthorDate: Wed Dec 2 15:25:02 2020 + Add

[airflow] 03/04: Pins PIP to 20.2.4 in our Dockerfiles (#12738)

2020-12-03 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 77f3ecd0fc542a7f2e2fcc7179b3fa1967c3549f Author: Jarek Potiuk AuthorDate: Tue Dec 1 17:39:55 2020 +0100

[airflow] 04/04: Update documentation about PIP 20.3 incompatibility

2020-12-03 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit b13a9ee01d9951a23fd700a1236e8b25081a75cb Author: Jarek Potiuk AuthorDate: Wed Dec 2 17:37:48 2020 +0100

[GitHub] [airflow] turbaszek commented on issue #12587: dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-03 Thread GitBox
turbaszek commented on issue #12587: URL: https://github.com/apache/airflow/issues/12587#issuecomment-738002984 @potiuk the problem is in `airflow/operators/dagrun.py` where the `TriggerDagRunOperator` is  This is an

[GitHub] [airflow-site] mik-laj opened a new pull request #326: @mik-laj Update URL structure to support multiple packages

2020-12-03 Thread GitBox
mik-laj opened a new pull request #326: URL: https://github.com/apache/airflow-site/pull/326 Hello, To support many documentation packages, we need to update our URL structure. Before: ``` https://airflow.apache.org/docs/1.10.12/ After: ```

[GitHub] [airflow] potiuk commented on pull request #12740: Fix the exception that the port is empty when using db shell

2020-12-03 Thread GitBox
potiuk commented on pull request #12740: URL: https://github.com/apache/airflow/pull/12740#issuecomment-738043522 Cool! Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] Nick-0723 commented on a change in pull request #12740: Fix the exception that the port is empty when using db shell

2020-12-03 Thread GitBox
Nick-0723 commented on a change in pull request #12740: URL: https://github.com/apache/airflow/pull/12740#discussion_r535297026 ## File path: airflow/cli/commands/db_command.py ## @@ -71,6 +71,7 @@ def shell(args): database = {url.database}

[airflow] branch master updated: Change DEBUG color to green in coloured logger (#12784)

2020-12-03 Thread turbaszek
This is an automated email from the ASF dual-hosted git repository. turbaszek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 56f82ba Change DEBUG color to green in

[GitHub] [airflow] turbaszek commented on pull request #12677: Refactor SQL/BigQuery Check operators

2020-12-03 Thread GitBox
turbaszek commented on pull request #12677: URL: https://github.com/apache/airflow/pull/12677#issuecomment-737880892 Hey @xinbinhuang there seems to be some pylint issues. Can you take a look? This is an automated message

[GitHub] [airflow] nathadfield commented on issue #10790: Copy of [AIRFLOW-5071] JIRA: Thousands of Executor reports task instance X finished (success) although the task says its queued. Was the task

2020-12-03 Thread GitBox
nathadfield commented on issue #10790: URL: https://github.com/apache/airflow/issues/10790#issuecomment-737896491 To add some further context, I can consistently replicate this error on 2.0.0b3 on a very simple environment running two Docker containers - webserver and postgres - on a

[GitHub] [airflow] mik-laj closed pull request #12546: Fix redirects from deprecated pages

2020-12-03 Thread GitBox
mik-laj closed pull request #12546: URL: https://github.com/apache/airflow/pull/12546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] rmanvar-indeed commented on issue #12776: Update source_code field of dag_code table to MEDIUMTEXT

2020-12-03 Thread GitBox
rmanvar-indeed commented on issue #12776: URL: https://github.com/apache/airflow/issues/12776#issuecomment-737931160 Do the migration files at https://github.com/apache/airflow/tree/master/airflow/migrations/versions include non-sql databases too? How can we apply only for sql if so

[GitHub] [airflow] ashb commented on issue #12776: Update source_code field of dag_code table to MEDIUMTEXT

2020-12-03 Thread GitBox
ashb commented on issue #12776: URL: https://github.com/apache/airflow/issues/12776#issuecomment-737937789 Again -- this is only a problem for MySQL -- PostgreSQL's TEXT type can store 4gb https://www.postgresql.org/docs/13/datatype-character.html So your migration only

[GitHub] [airflow] turbaszek opened a new issue #12783: Sensors in reschedule mode are not rescheduled

2020-12-03 Thread GitBox
turbaszek opened a new issue #12783: URL: https://github.com/apache/airflow/issues/12783 **Apache Airflow version**: 2.0.0dev **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): **Environment**: ``` ./breeze --python=3.8 --backend=postgres

[GitHub] [airflow-site] mik-laj commented on a change in pull request #326: @mik-laj Update URL structure to support multiple packages

2020-12-03 Thread GitBox
mik-laj commented on a change in pull request #326: URL: https://github.com/apache/airflow-site/pull/326#discussion_r535285812 ## File path: landing-pages/site/static/.htaccess ## @@ -1,6 +1,8 @@ -RedirectMatch Permanent ^/docs/(stable|1.10.10)/api(\.html)?$

[GitHub] [airflow] ielizarov commented on issue #12757: Graph View is empty when Operator has multiline string in args (v2.0)

2020-12-03 Thread GitBox
ielizarov commented on issue #12757: URL: https://github.com/apache/airflow/issues/12757#issuecomment-738040222 @kaxil Sure, here it is. I simplified my DAG, this version gives the same error exactly. You'll need to add TEST_VAR to Airflow DB. `"""Demo DAG""" from datetime

[airflow] 28/34: [AIRFLOW-2886] Generate random Flask SECRET_KEY in default config (#3738)

2020-12-03 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 6b065840323f9a4fc8e372b458d26e419e4fa99b Author: Xiaodong AuthorDate: Wed Aug 15 03:08:48 2018 +0800

[airflow] 32/34: Pins PIP to 20.2.4 in our Dockerfiles (#12738)

2020-12-03 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit edcd18e0f54a7a3efcfd55cfba282dfa8e7cc31f Author: Jarek Potiuk AuthorDate: Tue Dec 1 17:39:55 2020 +0100 Pins PIP

[GitHub] [airflow] ashb commented on issue #12776: Update source_code field of dag_code table to MEDIUMTEXT

2020-12-03 Thread GitBox
ashb commented on issue #12776: URL: https://github.com/apache/airflow/issues/12776#issuecomment-737883554 What is the current column type? This only applies to mysql, not other DBs I think This is an automated

[GitHub] [airflow] boring-cyborg[bot] commented on issue #12782: Github Oauth issue

2020-12-03 Thread GitBox
boring-cyborg[bot] commented on issue #12782: URL: https://github.com/apache/airflow/issues/12782#issuecomment-737987267 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[GitHub] [airflow] jykae opened a new issue #12782: Github Oauth issue

2020-12-03 Thread GitBox
jykae opened a new issue #12782: URL: https://github.com/apache/airflow/issues/12782 Could you work out with Flask-AppBuilder to get Github Oauth pass more info about user? There is solution already but it has been closed https://github.com/dpgaspar/Flask-AppBuilder/pull/1020

[GitHub] [airflow] potiuk commented on issue #12587: dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-03 Thread GitBox
potiuk commented on issue #12587: URL: https://github.com/apache/airflow/issues/12587#issuecomment-737997145 > https://user-images.githubusercontent.com/2644098/100959466-2a753400-34d3-11eb-958a-feeb5bae4b9f.png;> > > crazy that it shows up in my IDE but not in our static checks.

[GitHub] [airflow] potiuk edited a comment on issue #12587: dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-03 Thread GitBox
potiuk edited a comment on issue #12587: URL: https://github.com/apache/airflow/issues/12587#issuecomment-737997145 > https://user-images.githubusercontent.com/2644098/100959466-2a753400-34d3-11eb-958a-feeb5bae4b9f.png;> > > crazy that it shows up in my IDE but not in our static

[GitHub] [airflow] potiuk edited a comment on issue #12587: dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-03 Thread GitBox
potiuk edited a comment on issue #12587: URL: https://github.com/apache/airflow/issues/12587#issuecomment-737997145 > https://user-images.githubusercontent.com/2644098/100959466-2a753400-34d3-11eb-958a-feeb5bae4b9f.png;> > > crazy that it shows up in my IDE but not in our static

[GitHub] [airflow] potiuk commented on issue #12776: Update source_code field of dag_code table to MEDIUMTEXT

2020-12-03 Thread GitBox
potiuk commented on issue #12776: URL: https://github.com/apache/airflow/issues/12776#issuecomment-738001608 > Yup, planning to create a MR for the fix. Might take few days tho as I don't have the airflow dev setup. Takes literally few minutes with Breeze:

[airflow] branch v1-10-test updated: Don't let webserver run with dangerous config (#12747)

2020-12-03 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v1-10-test by this push: new dd00196 Don't let webserver run

[GitHub] [airflow] ielizarov removed a comment on issue #12757: Graph View is empty when Operator has multiline string in args (v2.0)

2020-12-03 Thread GitBox
ielizarov removed a comment on issue #12757: URL: https://github.com/apache/airflow/issues/12757#issuecomment-738040222 @kaxil Sure, here it is. I simplified my DAG, this version gives the same error exactly. You'll need to add TEST_VAR to Airflow DB. ```python """Demo DAG"""

[GitHub] [airflow] kaxil commented on issue #12757: Graph View is empty when Operator has multiline string in args (v2.0)

2020-12-03 Thread GitBox
kaxil commented on issue #12757: URL: https://github.com/apache/airflow/issues/12757#issuecomment-738042863 Thanks @ielizarov This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] turbaszek commented on issue #12783: Sensors in reschedule mode are not rescheduled

2020-12-03 Thread GitBox
turbaszek commented on issue #12783: URL: https://github.com/apache/airflow/issues/12783#issuecomment-738076275 On of the problems is that scheduler schedule a task two times: ``` [2020-12-03 15:23:03,332] {scheduler_job.py:1066} INFO - Setting the following tasks to queued state:

[GitHub] [airflow] rm3195 commented on pull request #8017: Call delete_dag on subdag without AttributeError

2020-12-03 Thread GitBox
rm3195 commented on pull request #8017: URL: https://github.com/apache/airflow/pull/8017#issuecomment-737887732 Did this ever got included in 1.10.x? We get AttributeError that's fixed by this PR in 1.10.13 :( This is an

[GitHub] [airflow] rmanvar-indeed commented on issue #12776: Update source_code field of dag_code table to MEDIUMTEXT

2020-12-03 Thread GitBox
rmanvar-indeed commented on issue #12776: URL: https://github.com/apache/airflow/issues/12776#issuecomment-737928014 Currently it's TEXT which has limit of 65K characters. MEDIUMTEXT will have 16777K characters limit. yup was primarily aiming for sql, haven't use Airflow with other

[GitHub] [airflow] kaxil commented on a change in pull request #12770: BugFix: Editing a DAG run or Task Instance on UI causes an Error

2020-12-03 Thread GitBox
kaxil commented on a change in pull request #12770: URL: https://github.com/apache/airflow/pull/12770#discussion_r535278902 ## File path: airflow/www/forms.py ## @@ -158,6 +163,59 @@ def populate_obj(self, item): item.conf = json.loads(item.conf) +class

[GitHub] [airflow] turbaszek merged pull request #12784: Change DEBUG color to green in coloured logger

2020-12-03 Thread GitBox
turbaszek merged pull request #12784: URL: https://github.com/apache/airflow/pull/12784 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] turbaszek commented on pull request #12784: Change DEBUG color to green in coloured logger

2020-12-03 Thread GitBox
turbaszek commented on pull request #12784: URL: https://github.com/apache/airflow/pull/12784#issuecomment-738061395 I'm merging this one as it's not worth to waste CI recourses for this change This is an automated message

[GitHub] [airflow] ashb commented on a change in pull request #12766: Kubernetes worker pod doesn't use docker container entrypoint

2020-12-03 Thread GitBox
ashb commented on a change in pull request #12766: URL: https://github.com/apache/airflow/pull/12766#discussion_r535093360 ## File path: scripts/in_container/prod/entrypoint_prod.sh ## @@ -129,7 +129,7 @@ if [[ ${AIRFLOW_COMMAND} == "bash" ]]; then elif [[ ${AIRFLOW_COMMAND}

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243147#comment-17243147 ] ASF GitHub Bot commented on AIRFLOW-5071: - nathadfield commented on issue #10790: URL:

[GitHub] [airflow] nathadfield commented on issue #10790: Copy of [AIRFLOW-5071] JIRA: Thousands of Executor reports task instance X finished (success) although the task says its queued. Was the task

2020-12-03 Thread GitBox
nathadfield commented on issue #10790: URL: https://github.com/apache/airflow/issues/10790#issuecomment-737899403 Not sure if this is relevant but, when the tasks was rescheduled five minutes later, I saw this. ``` [2020-12-03 11:57:07,266] {scheduler_job.py:1237} ERROR -

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243148#comment-17243148 ] ASF GitHub Bot commented on AIRFLOW-5071: - nathadfield edited a comment on issue #10790: URL:

[GitHub] [airflow] nathadfield edited a comment on issue #10790: Copy of [AIRFLOW-5071] JIRA: Thousands of Executor reports task instance X finished (success) although the task says its queued. Was th

2020-12-03 Thread GitBox
nathadfield edited a comment on issue #10790: URL: https://github.com/apache/airflow/issues/10790#issuecomment-737899403 Not sure if this is relevant but, when the task was rescheduled five minutes later, I saw this. ``` [2020-12-03 11:57:07,266] {scheduler_job.py:1237} ERROR -

[GitHub] [airflow] ashb commented on pull request #12781: add exit code to cli command `airflow list_dags`

2020-12-03 Thread GitBox
ashb commented on pull request #12781: URL: https://github.com/apache/airflow/pull/12781#issuecomment-737923956 PRs should target master please. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] rmanvar-indeed edited a comment on issue #12776: Update source_code field of dag_code table to MEDIUMTEXT

2020-12-03 Thread GitBox
rmanvar-indeed edited a comment on issue #12776: URL: https://github.com/apache/airflow/issues/12776#issuecomment-737931160 Do the migration files at https://github.com/apache/airflow/tree/master/airflow/migrations/versions include non-sql databases too? How can we apply only for sql if

[GitHub] [airflow] potiuk commented on a change in pull request #12740: Fix the exception that the port is empty when using db shell

2020-12-03 Thread GitBox
potiuk commented on a change in pull request #12740: URL: https://github.com/apache/airflow/pull/12740#discussion_r535255244 ## File path: airflow/cli/commands/db_command.py ## @@ -71,6 +71,7 @@ def shell(args): database = {url.database} """

[GitHub] [airflow] ashb commented on a change in pull request #11652: Support for sorting DAGs in the web UI

2020-12-03 Thread GitBox
ashb commented on a change in pull request #11652: URL: https://github.com/apache/airflow/pull/11652#discussion_r535266580 ## File path: airflow/www/views.py ## @@ -449,6 +490,8 @@ def get_int_arg(value, default=0): arg_search_query = request.args.get('search')

[GitHub] [airflow] mik-laj edited a comment on issue #12785: Macros added through plugins can not be used within Jinja templates in Airflow 2.0

2020-12-03 Thread GitBox
mik-laj edited a comment on issue #12785: URL: https://github.com/apache/airflow/issues/12785#issuecomment-738049983 Good catch. Do you need help to prepare PR? I am happy to help with the review. It seems to me that the fix will require adding a one/few lines of code here.

[jira] [Commented] (AIRFLOW-2886) Secure Flask SECRET_KEY

2020-12-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243100#comment-17243100 ] ASF subversion and git services commented on AIRFLOW-2886: -- Commit

[GitHub] [airflow] mik-laj commented on a change in pull request #12764: Improve error handling in cli and introduce consistency

2020-12-03 Thread GitBox
mik-laj commented on a change in pull request #12764: URL: https://github.com/apache/airflow/pull/12764#discussion_r535096096 ## File path: airflow/cli/commands/connection_command.py ## @@ -140,20 +136,19 @@ def connections_export(args): _, filetype =

[GitHub] [airflow] kaxil commented on issue #12757: Graph View is empty when Operator has multiline string in args (v2.0)

2020-12-03 Thread GitBox
kaxil commented on issue #12757: URL: https://github.com/apache/airflow/issues/12757#issuecomment-738014833 @ielizarov Can you post your DAG please for us to replicate the exact error? This is an automated message from the

[GitHub] [airflow] potiuk commented on issue #12744: Difference of extras Airflow 2.0 vs. Airflow 1.10

2020-12-03 Thread GitBox
potiuk commented on issue #12744: URL: https://github.com/apache/airflow/issues/12744#issuecomment-738027087 > Anyone know how pip would cope with circular dependencies? I.e. could `apache-airflow` depend upon `apache-airflow-provider-http` (which in turn depends upon `apache-airflow`

[GitHub] [airflow] turbaszek opened a new pull request #12784: Change DEBUG color to green in coloured logger

2020-12-03 Thread GitBox
turbaszek opened a new pull request #12784: URL: https://github.com/apache/airflow/pull/12784 In this way it's easier to see difference between debug and error. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] mik-laj commented on issue #12785: Macros added through plugins can not be used within Jinja templates in Airflow 2.0

2020-12-03 Thread GitBox
mik-laj commented on issue #12785: URL: https://github.com/apache/airflow/issues/12785#issuecomment-738049983 Good catch. Do you need help to prepare PR? I am happy to help with the review. This is an automated message from

[GitHub] [airflow] Kurganov opened a new pull request #12781: add exit code to cli command `airflow list_dags`

2020-12-03 Thread GitBox
Kurganov opened a new pull request #12781: URL: https://github.com/apache/airflow/pull/12781 small feature to check errors before add dags. `airflow list_dags` return 1 if DagBag has import_errors This is an

[airflow-site] branch asf-site updated: Update asf-site to output generated at 74672f1

2020-12-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/asf-site by this push: new de370cd Update asf-site to

[GitHub] [airflow] RikHeijdens opened a new issue #12785: Macros added through plugins can not be used within Jinja templates in Airflow 2.0

2020-12-03 Thread GitBox
RikHeijdens opened a new issue #12785: URL: https://github.com/apache/airflow/issues/12785 **Apache Airflow version**: 2.0.0b3 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): N/A **Environment**: - **OS** (e.g. from /etc/os-release): Debian

[GitHub] [airflow] boring-cyborg[bot] commented on issue #12785: Macros added through plugins can not be used within Jinja templates in Airflow 2.0

2020-12-03 Thread GitBox
boring-cyborg[bot] commented on issue #12785: URL: https://github.com/apache/airflow/issues/12785#issuecomment-738044180 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[GitHub] [airflow] ielizarov commented on issue #12757: Graph View is empty when Operator has multiline string in args (v2.0)

2020-12-03 Thread GitBox
ielizarov commented on issue #12757: URL: https://github.com/apache/airflow/issues/12757#issuecomment-738044191 @kaxil My bad, it seems I forgot to add "dag=dag" to this particular operator, and it led to this error. Perhaps there should be more clear behavior (i.e. DAG should still be

[GitHub] [airflow] ohashmi-cei commented on issue #12765: Success call back function running twice

2020-12-03 Thread GitBox
ohashmi-cei commented on issue #12765: URL: https://github.com/apache/airflow/issues/12765#issuecomment-738066795 **Apache Airflow version: 1.10.12 Google Cloud Composer: composer-1.13.0-airflow-1.10.10** Hi I am having the same issue, the success call back function is called

[GitHub] [airflow] RikHeijdens commented on a change in pull request #12788: Fix plugin macros not being exposed through airflow.macros

2020-12-03 Thread GitBox
RikHeijdens commented on a change in pull request #12788: URL: https://github.com/apache/airflow/pull/12788#discussion_r535512072 ## File path: tests/plugins/test_plugins_manager.py ## @@ -213,6 +214,34 @@ def test_entrypoint_plugin_errors_dont_raise_exceptions(self, caplog):

[GitHub] [airflow] RikHeijdens commented on a change in pull request #12788: Fix plugin macros not being exposed through airflow.macros

2020-12-03 Thread GitBox
RikHeijdens commented on a change in pull request #12788: URL: https://github.com/apache/airflow/pull/12788#discussion_r535525847 ## File path: tests/plugins/test_plugins_manager.py ## @@ -213,6 +214,34 @@ def test_entrypoint_plugin_errors_dont_raise_exceptions(self, caplog):

[airflow-site] branch asf-site updated: Deploying to asf-site from @ f29712cccd74a97f6f00ba11783a9003b53b6642 

2020-12-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 620a0d6 Deploying to asf-site

[GitHub] [airflow] mik-laj commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0

2020-12-03 Thread GitBox
mik-laj commented on a change in pull request #12792: URL: https://github.com/apache/airflow/pull/12792#discussion_r535579688 ## File path: docs/apache-airflow/alembic_revisions.rst ## @@ -0,0 +1,328 @@ + .. Licensed to the Apache Software Foundation (ASF) under one Review

[airflow] branch v1-10-test updated (46002a4 -> 6221f30)

2020-12-03 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 46002a4 fixup! Replace pkg_resources with importlib.metadata to avoid VersionConflict errors (#12694)

[GitHub] [airflow] potiuk commented on pull request #12786: Get airflow version from importlib.metadata rather than hard-coding

2020-12-03 Thread GitBox
potiuk commented on pull request #12786: URL: https://github.com/apache/airflow/pull/12786#issuecomment-738350135 > > scripts/ci/libraries/_initialization.sh - it reads version from airflow/version.py, it should from setup.py > > We could use `python setup.py --version`, but do we

[GitHub] [airflow] potiuk edited a comment on pull request #12786: Get airflow version from importlib.metadata rather than hard-coding

2020-12-03 Thread GitBox
potiuk edited a comment on pull request #12786: URL: https://github.com/apache/airflow/pull/12786#issuecomment-738350135 > > scripts/ci/libraries/_initialization.sh - it reads version from airflow/version.py, it should from setup.py > > We could use `python setup.py --version`, but

[GitHub] [airflow] ashb commented on a change in pull request #12786: Get airflow version from importlib.metadata rather than hard-coding

2020-12-03 Thread GitBox
ashb commented on a change in pull request #12786: URL: https://github.com/apache/airflow/pull/12786#discussion_r535678716 ## File path: scripts/ci/libraries/_initialization.sh ## @@ -134,8 +134,8 @@ function initialization::initialize_base_variables() { # otherwise it

svn commit: r44835 - /release/airflow/KEYS

2020-12-03 Thread kaxilnaik
Author: kaxilnaik Date: Thu Dec 3 18:43:21 2020 New Revision: 44835 Log: Add New PGP keys for Kaxil Modified: release/airflow/KEYS Modified: release/airflow/KEYS == --- release/airflow/KEYS (original) +++

[GitHub] [airflow] DavHau commented on issue #12789: Error in wheel metadata (requirements)

2020-12-03 Thread GitBox
DavHau commented on issue #12789: URL: https://github.com/apache/airflow/issues/12789#issuecomment-738218005 Thanks for this very quick fix. Are you guys planning on fixing the metadata for old releases by re-uploading them?

[GitHub] [airflow] ashb commented on a change in pull request #12766: Kubernetes worker pod doesn't use docker container entrypoint

2020-12-03 Thread GitBox
ashb commented on a change in pull request #12766: URL: https://github.com/apache/airflow/pull/12766#discussion_r535509845 ## File path: airflow/kubernetes/pod_generator.py ## @@ -351,7 +351,7 @@ def construct_pod( # pylint: disable=too-many-arguments try_number:

[GitHub] [airflow] RikHeijdens commented on a change in pull request #12788: Fix plugin macros not being exposed through airflow.macros

2020-12-03 Thread GitBox
RikHeijdens commented on a change in pull request #12788: URL: https://github.com/apache/airflow/pull/12788#discussion_r535517135 ## File path: airflow/plugins_manager.py ## @@ -419,4 +420,9 @@ def integrate_macros_plugins() -> None: if macros_module:

[GitHub] [airflow] potiuk commented on issue #12789: Error in wheel metadata (requirements)

2020-12-03 Thread GitBox
potiuk commented on issue #12789: URL: https://github.com/apache/airflow/issues/12789#issuecomment-738241038 There is no way. PIP releases are immutable. This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow-site] potiuk commented on pull request #330: Update directory structure to support multiple documentaation packages

2020-12-03 Thread GitBox
potiuk commented on pull request #330: URL: https://github.com/apache/airflow-site/pull/330#issuecomment-738244676 I di dnot check all 5000 files though :( This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow-site] mik-laj merged pull request #330: Update directory structure to support multiple documentaation packages

2020-12-03 Thread GitBox
mik-laj merged pull request #330: URL: https://github.com/apache/airflow-site/pull/330 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] RikHeijdens commented on a change in pull request #12788: Fix plugin macros not being exposed through airflow.macros

2020-12-03 Thread GitBox
RikHeijdens commented on a change in pull request #12788: URL: https://github.com/apache/airflow/pull/12788#discussion_r535540115 ## File path: tests/plugins/test_plugins_manager.py ## @@ -213,6 +214,34 @@ def test_entrypoint_plugin_errors_dont_raise_exceptions(self, caplog):

[GitHub] [airflow] github-actions[bot] commented on pull request #12788: Fix plugin macros not being exposed through airflow.macros

2020-12-03 Thread GitBox
github-actions[bot] commented on pull request #12788: URL: https://github.com/apache/airflow/pull/12788#issuecomment-738277515 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] mik-laj commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0

2020-12-03 Thread GitBox
mik-laj commented on a change in pull request #12792: URL: https://github.com/apache/airflow/pull/12792#discussion_r535579688 ## File path: docs/apache-airflow/alembic_revisions.rst ## @@ -0,0 +1,328 @@ + .. Licensed to the Apache Software Foundation (ASF) under one Review

[GitHub] [airflow-site] mik-laj commented on pull request #331: Improvements for Github Action Artifacts

2020-12-03 Thread GitBox
mik-laj commented on pull request #331: URL: https://github.com/apache/airflow-site/pull/331#issuecomment-738298127 @potiuk Do you have any idea why Github Action didn't start? This is an automated message from the Apache

[GitHub] [airflow] ashb edited a comment on pull request #12786: Get airflow version from importlib.metadata rather than hard-coding

2020-12-03 Thread GitBox
ashb edited a comment on pull request #12786: URL: https://github.com/apache/airflow/pull/12786#issuecomment-738304448 > scripts/ci/libraries/_initialization.sh - it reads version from airflow/version.py, it should from setup.py We could use `python setup.py --version`, but do we

[GitHub] [airflow] github-actions[bot] commented on pull request #12794: Convert state values in ExternalTaskSensor to list

2020-12-03 Thread GitBox
github-actions[bot] commented on pull request #12794: URL: https://github.com/apache/airflow/pull/12794#issuecomment-738316226 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] github-actions[bot] commented on pull request #12793: Artifacts in Github Action have a short retention period

2020-12-03 Thread GitBox
github-actions[bot] commented on pull request #12793: URL: https://github.com/apache/airflow/pull/12793#issuecomment-738315416 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] p-madduri commented on issue #10126: Add download function at gdrive hook

2020-12-03 Thread GitBox
p-madduri commented on issue #10126: URL: https://github.com/apache/airflow/issues/10126#issuecomment-738333746 any update on this? This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] SamWheating opened a new pull request #12797: Add documentation on AIRFLOW__{SECTION}__{KEY}_SECRET config

2020-12-03 Thread GitBox
SamWheating opened a new pull request #12797: URL: https://github.com/apache/airflow/pull/12797 Re: https://github.com/apache/airflow/issues/12774 Also, Fixing up some broken references in the contributing docs. I am planning on completing

[jira] [Commented] (AIRFLOW-2809) Fix security issue regarding Flask SECRET_KEY

2020-12-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243098#comment-17243098 ] ASF subversion and git services commented on AIRFLOW-2809: -- Commit

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243141#comment-17243141 ] ASF GitHub Bot commented on AIRFLOW-5071: - nathadfield commented on issue #10790: URL:

[airflow-site] branch master updated: User-friendly output for site.sh + Bug fixes for the build process(#325)

2020-12-03 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/master by this push: new 74672f1 User-friendly output for

[GitHub] [airflow] potiuk commented on issue #12776: Update source_code field of dag_code table to MEDIUMTEXT

2020-12-03 Thread GitBox
potiuk commented on issue #12776: URL: https://github.com/apache/airflow/issues/12776#issuecomment-737989380 I think this shoudl be solved for 2.0 (marked is as such) @rmanvar-indeed - do you plan to contribute fix for that back to Airlfow?

[GitHub] [airflow] rmanvar-indeed commented on issue #12776: Update source_code field of dag_code table to MEDIUMTEXT

2020-12-03 Thread GitBox
rmanvar-indeed commented on issue #12776: URL: https://github.com/apache/airflow/issues/12776#issuecomment-737999473 Yup, planning to create a MR for the fix. Might take few days tho as I don't have the airflow dev setup.

[GitHub] [airflow] potiuk commented on issue #12587: dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-03 Thread GitBox
potiuk commented on issue #12587: URL: https://github.com/apache/airflow/issues/12587#issuecomment-738010315 > @potiuk the problem is in `airflow/operators/dagrun_operator.py` where the `TriggerDagRunOperator` is I know but the dag_run is DagRun object, isn't it?

[GitHub] [airflow] Etienne-Carriere commented on issue #12771: Instrument Airflow with Opentracing/Opentelemetry

2020-12-03 Thread GitBox
Etienne-Carriere commented on issue #12771: URL: https://github.com/apache/airflow/issues/12771#issuecomment-738018370 Hello @mik-laj , thank you for the link about sentry. It will helps to design a hook (in a first time in an external repo and perhaps merged in a second time)

[GitHub] [airflow] ashb commented on a change in pull request #12770: BugFix: Editing a DAG run or Task Instance on UI causes an Error

2020-12-03 Thread GitBox
ashb commented on a change in pull request #12770: URL: https://github.com/apache/airflow/pull/12770#discussion_r535258964 ## File path: airflow/www/forms.py ## @@ -158,6 +163,59 @@ def populate_obj(self, item): item.conf = json.loads(item.conf) +class

  1   2   3   4   >