[GitHub] [airflow] potiuk commented on issue #24988: sendgrid as a data source provider? #24815

2022-11-28 Thread GitBox
potiuk commented on issue #24988: URL: https://github.com/apache/airflow/issues/24988#issuecomment-1329685452 > Just to double check my understanding of the release cycle as outlined [here](https://github.com/apache/airflow#release-process-for-providers). If I implement this provider, does

[GitHub] [airflow] potiuk commented on pull request #27866: Cloudera Airflow provider.

2022-11-28 Thread GitBox
potiuk commented on PR #27866: URL: https://github.com/apache/airflow/pull/27866#issuecomment-1329740644 Also one extra requirement. With such a big chunk of code and functionality and Cloudera behind it, I think we can only accept the code knowing that both ICLA ( by the person

[GitHub] [airflow] bt- commented on issue #27523: Jumping tasks in grid

2022-11-28 Thread GitBox
bt- commented on issue #27523: URL: https://github.com/apache/airflow/issues/27523#issuecomment-1329752163 I am running into the same thing with my DAG. I have the tasks within my TaskGroups dynamically generated based on a list parsed from a yaml file. After watching more closely, it is

[GitHub] [airflow] potiuk commented on issue #26492: Cannot fetch log from Celery worker

2022-11-28 Thread GitBox
potiuk commented on issue #26492: URL: https://github.com/apache/airflow/issues/26492#issuecomment-1329780031 > Hi @potiuk , I ran into this error on 2.4.3. The env I'm using is directly from the official docker compose file from

[GitHub] [airflow] potiuk commented on a diff in pull request #27971: Experiment: Run static checks and postgres tests before all else

2022-11-28 Thread GitBox
potiuk commented on code in PR #27971: URL: https://github.com/apache/airflow/pull/27971#discussion_r1034095249 ## .github/workflows/ci.yml: ## @@ -778,8 +780,8 @@ jobs: needs: [build-info, wait-for-ci-images] strategy: matrix: -python-version:

[GitHub] [airflow] potiuk commented on pull request #27962: Add pre-commits preventing accidental API changes in common.sql

2022-11-28 Thread GitBox
potiuk commented on PR #27962: URL: https://github.com/apache/airflow/pull/27962#issuecomment-1329896616 All looks good :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] dstandish commented on issue #27593: Object of type V1Pod is not JSON serializable after detecting zombie jobs cause Scheduler CrashLoopBack

2022-11-28 Thread GitBox
dstandish commented on issue #27593: URL: https://github.com/apache/airflow/issues/27593#issuecomment-1329558713 actually, @KulykDmytro it might be best to just create a new issue with your bug report. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk commented on a diff in pull request #27971: Experiment: Run static checks and postgres tests before all else

2022-11-28 Thread GitBox
potiuk commented on code in PR #27971: URL: https://github.com/apache/airflow/pull/27971#discussion_r1034097967 ## .github/workflows/ci.yml: ## @@ -366,7 +368,7 @@ jobs: ${{needs.build-info.outputs.build-job-description}} PROD images

[GitHub] [airflow] potiuk commented on a diff in pull request #27971: Experiment: Run static checks and postgres tests before all else

2022-11-28 Thread GitBox
potiuk commented on code in PR #27971: URL: https://github.com/apache/airflow/pull/27971#discussion_r1034097967 ## .github/workflows/ci.yml: ## @@ -366,7 +368,7 @@ jobs: ${{needs.build-info.outputs.build-job-description}} PROD images

[GitHub] [airflow] potiuk commented on pull request #27966: Clarify docstrings for updated DbApiHook

2022-11-28 Thread GitBox
potiuk commented on PR #27966: URL: https://github.com/apache/airflow/pull/27966#issuecomment-1329836965 > > Installed pre-commits really save on iterating with CI @dstandish  > > yeah, sigh... i have them enabled but i have flake8 and mypy disabled because > > iteration

[GitHub] [airflow] dstandish commented on a diff in pull request #27971: Experiment: Run static checks and postgres tests before all else

2022-11-28 Thread GitBox
dstandish commented on code in PR #27971: URL: https://github.com/apache/airflow/pull/27971#discussion_r1034114562 ## .github/workflows/ci.yml: ## @@ -778,8 +780,8 @@ jobs: needs: [build-info, wait-for-ci-images] strategy: matrix: -python-version:

[GitHub] [airflow] potiuk commented on pull request #27971: Experiment: Run static checks and postgres tests before all else

2022-11-28 Thread GitBox
potiuk commented on PR #27971: URL: https://github.com/apache/airflow/pull/27971#issuecomment-1329820819 I am not sure if this is helpful, For non-hosted runners it should be no difference. We already have 900 runners by the ASF and we should have no more queueing here (at least we

[GitHub] [airflow] dstandish commented on a diff in pull request #27971: Experiment: Run static checks and postgres tests before all else

2022-11-28 Thread GitBox
dstandish commented on code in PR #27971: URL: https://github.com/apache/airflow/pull/27971#discussion_r1034103825 ## .github/workflows/ci.yml: ## @@ -366,7 +368,7 @@ jobs: ${{needs.build-info.outputs.build-job-description}} PROD images

[GitHub] [airflow] dstandish commented on pull request #27966: Clarify docstrings for updated DbApiHook

2022-11-28 Thread GitBox
dstandish commented on PR #27966: URL: https://github.com/apache/airflow/pull/27966#issuecomment-1329836048 > Installed pre-commits really save on iterating with CI @dstandish  yeah, sigh... i have them enabled but i have flake8 and mypy disabled because iteration time 

[GitHub] [airflow] pierrejeambrun commented on pull request #27974: [AIP-51] Add helper to import default executor class

2022-11-28 Thread GitBox
pierrejeambrun commented on PR #27974: URL: https://github.com/apache/airflow/pull/27974#issuecomment-1329857439 Really useful indeed, thanks. I'll update that when this one is merged :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] boring-cyborg[bot] commented on issue #27976: `SQLColumnCheckOperator` failures after upgrading to `common-sql==1.3.0`

2022-11-28 Thread GitBox
boring-cyborg[bot] commented on issue #27976: URL: https://github.com/apache/airflow/issues/27976#issuecomment-1329865991 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mag3141592 opened a new issue, #27976: `SQLColumnCheckOperator` failures after upgrading to `common-sql==1.3.0`

2022-11-28 Thread GitBox
mag3141592 opened a new issue, #27976: URL: https://github.com/apache/airflow/issues/27976 ### Apache Airflow Provider(s) common-sql ### Versions of Apache Airflow Providers apache-airflow-providers-google==8.2.0 apache-airflow-providers-http==4.0.0

[GitHub] [airflow] dstandish merged pull request #27966: Clarify docstrings for updated DbApiHook

2022-11-28 Thread GitBox
dstandish merged PR #27966: URL: https://github.com/apache/airflow/pull/27966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Clarify docstrings for updated DbApiHook (#27966)

2022-11-28 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a158fbb6bd Clarify docstrings for updated

[GitHub] [airflow] Taragolis opened a new pull request, #27970: Replace `unittests` in amazon provider tests by pure `pytest`

2022-11-28 Thread GitBox
Taragolis opened a new pull request, #27970: URL: https://github.com/apache/airflow/pull/27970 Migrate Amazon provider's tests to `pytest`. All changes are more or less straightforward: - Get rid of `unittests.TestCase` class and **TestCase.assert*** methods - Replace decorator

[GitHub] [airflow] potiuk commented on pull request #27866: Cloudera Airflow provider.

2022-11-28 Thread GitBox
potiuk commented on PR #27866: URL: https://github.com/apache/airflow/pull/27866#issuecomment-1329736900 > What is not 100% clear from the documentation in our case is that Cloudera provider would be introduced with a min dependency of 2.3.0. Yes. As a rule comunity does not maintain

[GitHub] [airflow] potiuk commented on issue #23512: Random "duplicate key value violates unique constraint" errors when initializing the postgres database

2022-11-28 Thread GitBox
potiuk commented on issue #23512: URL: https://github.com/apache/airflow/issues/23512#issuecomment-1329825007 Can you please open a new issue for 2.4.3 @zachliu with more details? I have a feeling this is somehow different issue. -- This is an automated message from the Apache Git

[GitHub] [airflow] skyboi1233 commented on issue #27975: expand or expand_kwargs()

2022-11-28 Thread GitBox
skyboi1233 commented on issue #27975: URL: https://github.com/apache/airflow/issues/27975#issuecomment-1329864233 On Mon, Nov 28, 2022 at 4:59 PM tkansara ***@***.***> wrote: > Closed #27975 as > completed. > > — > Reply to

[GitHub] [airflow] jedcunningham commented on a diff in pull request #27779: Chart: add airflow_local_settings to all airflow containers

2022-11-28 Thread GitBox
jedcunningham commented on code in PR #27779: URL: https://github.com/apache/airflow/pull/27779#discussion_r1034190493 ## tests/charts/test_cleanup_pods.py: ## @@ -239,6 +239,42 @@ def test_should_set_job_history_limits(self): assert 2 ==

[GitHub] [airflow] bdsoha opened a new pull request, #27969: Completed D400 for multiple folders

2022-11-28 Thread GitBox
bdsoha opened a new pull request, #27969: URL: https://github.com/apache/airflow/pull/27969 Completed D400 for: - `airflow/jobs/*` - `airflow/executors/*` Related to #10742 . -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk commented on pull request #27843: Restore removed (but used) methods in common.sql

2022-11-28 Thread GitBox
potiuk commented on PR #27843: URL: https://github.com/apache/airflow/pull/27843#issuecomment-1329707915 > Is there an ETA to officially release new version 1.3.1 and get rid of 1.3.0? All my pipelines in Dev are broken until "_get_failed_checks" is recovered. Thanks! We are in the

[GitHub] [airflow] potiuk commented on pull request #27966: Clarify docstrings for updated DbApiHook

2022-11-28 Thread GitBox
potiuk commented on PR #27966: URL: https://github.com/apache/airflow/pull/27966#issuecomment-1329805947 Installed pre-commits really save on iterating with CI @dstandish  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] potiuk commented on pull request #27969: Completed D400 for multiple folders

2022-11-28 Thread GitBox
potiuk commented on PR #27969: URL: https://github.com/apache/airflow/pull/27969#issuecomment-1329806323 Checks :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] dstandish commented on a diff in pull request #27966: Clarify docstrings for updated DbApiHook

2022-11-28 Thread GitBox
dstandish commented on code in PR #27966: URL: https://github.com/apache/airflow/pull/27966#discussion_r1034112520 ## airflow/providers/common/sql/hooks/sql.py: ## @@ -272,33 +273,33 @@ def run( where each element in the list are results of one of the queries

[GitHub] [airflow] boring-cyborg[bot] commented on issue #27973: Azure OAuth CSRF State Not Equal Error

2022-11-28 Thread GitBox
boring-cyborg[bot] commented on issue #27973: URL: https://github.com/apache/airflow/issues/27973#issuecomment-1329841579 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ahipp13 opened a new issue, #27973: Azure OAuth CSRF State Not Equal Error

2022-11-28 Thread GitBox
ahipp13 opened a new issue, #27973: URL: https://github.com/apache/airflow/issues/27973 ### Apache Airflow version 2.4.3 ### What happened We have enabled Microsoft Azure OAuth for our Airflow implementation. When we try to log in, we get a CSRF error:

[GitHub] [airflow] ahipp13 opened a new issue, #27977: Webserver IntegrityError When Loaded

2022-11-28 Thread GitBox
ahipp13 opened a new issue, #27977: URL: https://github.com/apache/airflow/issues/27977 ### Apache Airflow version 2.4.3 ### What happened We just upgraded from Airflow 2.2.5 to 2.4.3. When using Azure OAuth, whenever you load the webserver, it loads it with an error

[GitHub] [airflow] ahipp13 commented on issue #23512: Random "duplicate key value violates unique constraint" errors when initializing the postgres database

2022-11-28 Thread GitBox
ahipp13 commented on issue #23512: URL: https://github.com/apache/airflow/issues/23512#issuecomment-1329870020 Issue submitted https://github.com/apache/airflow/issues/27977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] ashb commented on issue #26497: Upgrading to airflow 2.4.0 from 2.3.4 causes NotNullViolation error

2022-11-28 Thread GitBox
ashb commented on issue #26497: URL: https://github.com/apache/airflow/issues/26497#issuecomment-1329683155 Argh! Good catch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] potiuk commented on pull request #27866: Cloudera Airflow provider.

2022-11-28 Thread GitBox
potiuk commented on PR #27866: URL: https://github.com/apache/airflow/pull/27866#issuecomment-1329743517 > With such a big chunk of code and functionality and Cloudera behind it, I think we can only accept the code knowing that both ICLA ( by the person submitting it) and CCLA (by

[GitHub] [airflow] dstandish closed pull request #27971: Experiment: Run static checks and postgres tests before all else

2022-11-28 Thread GitBox
dstandish closed pull request #27971: Experiment: Run static checks and postgres tests before all else URL: https://github.com/apache/airflow/pull/27971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk merged pull request #27972: Documentation for the LocalTaskJob return code counter

2022-11-28 Thread GitBox
potiuk merged PR #27972: URL: https://github.com/apache/airflow/pull/27972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (b39457f0e3 -> 4a391150aa)

2022-11-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b39457f0e3 Fix deprecation warnings from `tests/api_connexion/endpoints/test_extra_link_endpoint.py` (#27956)

[GitHub] [airflow] ahipp13 commented on issue #23512: Random "duplicate key value violates unique constraint" errors when initializing the postgres database

2022-11-28 Thread GitBox
ahipp13 commented on issue #23512: URL: https://github.com/apache/airflow/issues/23512#issuecomment-1329812257 We are still having this issue in 2.4.3. We set [webserver].workers to 1 for a workaround. Here were the logs we were seeing: airflow-web 127.0.0.1 - - [23/Nov/2022:15:35:59

[GitHub] [airflow] o-nikolas commented on pull request #27974: [AIP-51] Add helper to import default executor class

2022-11-28 Thread GitBox
o-nikolas commented on PR #27974: URL: https://github.com/apache/airflow/pull/27974#issuecomment-1329843566 @pierrejeambrun This would be nice to use for #27941 and future PRs! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk commented on issue #23512: Random "duplicate key value violates unique constraint" errors when initializing the postgres database

2022-11-28 Thread GitBox
potiuk commented on issue #23512: URL: https://github.com/apache/airflow/issues/23512#issuecomment-1329853497 Not sure why - but yes. I ping the wrong person :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] tkansara commented on issue #27975: expand or expand_kwargs()

2022-11-28 Thread GitBox
tkansara commented on issue #27975: URL: https://github.com/apache/airflow/issues/27975#issuecomment-1329862566 I believe documentation is correct, and I am missing some link here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] tkansara closed issue #27975: expand or expand_kwargs()

2022-11-28 Thread GitBox
tkansara closed issue #27975: expand or expand_kwargs() URL: https://github.com/apache/airflow/issues/27975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] bbovenzi closed issue #27936: Datasets triggered run modal is not scrollable

2022-11-28 Thread GitBox
bbovenzi closed issue #27936: Datasets triggered run modal is not scrollable URL: https://github.com/apache/airflow/issues/27936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] bbovenzi merged pull request #27965: Allow scroll in triggered dag runs modal

2022-11-28 Thread GitBox
bbovenzi merged PR #27965: URL: https://github.com/apache/airflow/pull/27965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: allow scroll in triggered dag runs modal (#27965)

2022-11-28 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5e4f4a3556 allow scroll in triggered dag runs

[GitHub] [airflow] uranusjr commented on pull request #27898: fix: current_state method on TaskInstance doesn't filter by map_index

2022-11-28 Thread GitBox
uranusjr commented on PR #27898: URL: https://github.com/apache/airflow/pull/27898#issuecomment-1329979545 Please fix the CI failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on pull request #27787: POC / WIP testing out using logfmt for more structured logging

2022-11-28 Thread GitBox
potiuk commented on PR #27787: URL: https://github.com/apache/airflow/pull/27787#issuecomment-1329787455 > I looked at the AIP, but it looks like logging was deliberately excluded from it: Rather deferred until it's ready. The AIP was approved few months ago and it will take likely

[GitHub] [airflow] potiuk commented on issue #27963: DatabricksSQLOperator ValueError “too many values to unpack”

2022-11-28 Thread GitBox
potiuk commented on issue #27963: URL: https://github.com/apache/airflow/issues/27963#issuecomment-1329788860 > Interesting note: the 3.3.0 DatabricksSQLOperator had a parameter for control writing to xcom. It appears to be removed in 4.0.0. This is causing the dump of a lot of PII into

[GitHub] [airflow] potiuk closed issue #27963: DatabricksSQLOperator ValueError “too many values to unpack”

2022-11-28 Thread GitBox
potiuk closed issue #27963: DatabricksSQLOperator ValueError “too many values to unpack” URL: https://github.com/apache/airflow/issues/27963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on issue #27963: DatabricksSQLOperator ValueError “too many values to unpack”

2022-11-28 Thread GitBox
potiuk commented on issue #27963: URL: https://github.com/apache/airflow/issues/27963#issuecomment-1329791335 Closing as fixed - provisionally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on issue #27593: Object of type V1Pod is not JSON serializable after detecting zombie jobs cause Scheduler CrashLoopBack

2022-11-28 Thread GitBox
potiuk commented on issue #27593: URL: https://github.com/apache/airflow/issues/27593#issuecomment-1329796733 Yes. Please provide the details. Asking to "reopen" without providing any more details is not really helpful in diagnosing and fixing an issue. Already closed issue has no

[GitHub] [airflow] potiuk commented on a diff in pull request #27962: Add pre-commits preventing accidental API changes in common.sql

2022-11-28 Thread GitBox
potiuk commented on code in PR #27962: URL: https://github.com/apache/airflow/pull/27962#discussion_r1034088447 ## airflow/providers/common/sql/README_API.md: ## @@ -0,0 +1,103 @@ + + +# Keeping the API of common.sql provider backwards compatible + +The API of the `common.sql`

[GitHub] [airflow] howardyoo commented on pull request #27787: POC / WIP testing out using logfmt for more structured logging

2022-11-28 Thread GitBox
howardyoo commented on PR #27787: URL: https://github.com/apache/airflow/pull/27787#issuecomment-1329803476 Right, the logging is currently experimental. That's why it was excluded for now. On Mon, Nov 28, 2022 at 3:32 PM Jarek Potiuk ***@***.***> wrote: > I looked at the

[GitHub] [airflow] dstandish commented on pull request #27966: Clarify docstrings for updated DbApiHook

2022-11-28 Thread GitBox
dstandish commented on PR #27966: URL: https://github.com/apache/airflow/pull/27966#issuecomment-1329838369 > BTW. `SKIP=run-mypy,run-flake8` as global env might help even if there are some slow-downs yes this is how i have it configured -- This is an automated message from the

[GitHub] [airflow] potiuk commented on pull request #27966: Clarify docstrings for updated DbApiHook

2022-11-28 Thread GitBox
potiuk commented on PR #27966: URL: https://github.com/apache/airflow/pull/27966#issuecomment-1329838043 BTW. `SKIP=run-mypy,run-flake8` as global env might help even if there are some slow-downs -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] park-peter opened a new issue, #27978: KeyError: 0 error with common-sql version 1.3.0

2022-11-28 Thread GitBox
park-peter opened a new issue, #27978: URL: https://github.com/apache/airflow/issues/27978 ### Apache Airflow Provider(s) common-sql ### Versions of Apache Airflow Providers ``` apache-airflow-providers-amazon==6.0.0 apache-airflow-providers-apache-hive==4.0.1

[GitHub] [airflow] uranusjr commented on a diff in pull request #27834: Make sure we can get out of a faulty scheduler state

2022-11-28 Thread GitBox
uranusjr commented on code in PR #27834: URL: https://github.com/apache/airflow/pull/27834#discussion_r1034231937 ## airflow/models/dagrun.py: ## @@ -780,8 +780,7 @@ def _expand_mapped_task_if_needed(ti: TI) -> Iterable[TI] | None: except NotMapped: # Not a

[GitHub] [airflow] joshowen commented on issue #26497: Upgrading to airflow 2.4.0 from 2.3.4 causes NotNullViolation error

2022-11-28 Thread GitBox
joshowen commented on issue #26497: URL: https://github.com/apache/airflow/issues/26497#issuecomment-1329681251 > > We started with 1.8.xx, went to 1.9.xx, 1.10.xx, and somehow all of our FAB tables ended up without sequences set for their IDs, but had the sequences created. We were seeing

[GitHub] [airflow] dstandish opened a new pull request, #27971: Experiment: Run static checks and postgres tests before all else

2022-11-28 Thread GitBox
dstandish opened a new pull request, #27971: URL: https://github.com/apache/airflow/pull/27971 This should allow for faster failure / iteration time on non-hosted runners. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] IKholopov opened a new pull request, #27972: Documentation for the LocalTaskJob return code counter

2022-11-28 Thread GitBox
IKholopov opened a new pull request, #27972: URL: https://github.com/apache/airflow/pull/27972 Adding a missing documentation for the recently added metric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] dstandish commented on pull request #27971: Experiment: Run static checks and postgres tests before all else

2022-11-28 Thread GitBox
dstandish commented on PR #27971: URL: https://github.com/apache/airflow/pull/27971#issuecomment-1329825428 it would help if there were too many PRs competing for too few runners -- then we quickly get a quick read on the tests most likely to fail. but that doesn't really seem to be the

[GitHub] [airflow] pierrejeambrun commented on pull request #27966: Clarify docstrings for updated DbApiHook

2022-11-28 Thread GitBox
pierrejeambrun commented on PR #27966: URL: https://github.com/apache/airflow/pull/27966#issuecomment-1329842548 Haha I am familiar to this as well . What I do now is configure mypy and flake as linter in my IDE. This way it is really easy to see/resolve and iterate on typing error.

[GitHub] [airflow] o-nikolas opened a new pull request, #27974: [AIP-51] Add helper to import default executor class

2022-11-28 Thread GitBox
o-nikolas opened a new pull request, #27974: URL: https://github.com/apache/airflow/pull/27974 This will be useful for the several points during AIP-51 where the default executor class needs to be imported to replace specific points of coupling. Also add missing testing for executor

[GitHub] [airflow] zachliu commented on issue #23512: Random "duplicate key value violates unique constraint" errors when initializing the postgres database

2022-11-28 Thread GitBox
zachliu commented on issue #23512: URL: https://github.com/apache/airflow/issues/23512#issuecomment-1329847946 @potiuk you probably `@` the wrong guy :grin: @ahipp13 Can you please open a new issue for 2.4.3 with more details? I also have a feeling this is a different issue. this

[GitHub] [airflow] github-actions[bot] commented on pull request #27063: [WIP/Preview] Feature/26215 Proposal for AIP-50 Trigger UI based on FAB

2022-11-28 Thread GitBox
github-actions[bot] commented on PR #27063: URL: https://github.com/apache/airflow/pull/27063#issuecomment-1329908972 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] jedcunningham commented on a diff in pull request #27419: Add webserverConfigConfigmapName

2022-11-28 Thread GitBox
jedcunningham commented on code in PR #27419: URL: https://github.com/apache/airflow/pull/27419#discussion_r1034194499 ## chart/values.yaml: ## @@ -976,6 +978,7 @@ webserver: # # Flask-WTF flag for CSRF # CSRF_ENABLED = True + webserverConfigConfigmapName: ~

[GitHub] [airflow] uranusjr commented on pull request #27961: add some missing options for the gcs to bq operator

2022-11-28 Thread GitBox
uranusjr commented on PR #27961: URL: https://github.com/apache/airflow/pull/27961#issuecomment-1329973707 CI is failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] potiuk commented on pull request #27962: Add pre-commits preventing accidental API changes in common.sql

2022-11-28 Thread GitBox
potiuk commented on PR #27962: URL: https://github.com/apache/airflow/pull/27962#issuecomment-1329655368 > Just a minor comment, other than that, LGTM :) Fixed and also updated the description a little for the future work. -- This is an automated message from the Apache Git

[GitHub] [airflow] vincbeck commented on a diff in pull request #27962: Add pre-commits preventing accidental API changes in common.sql

2022-11-28 Thread GitBox
vincbeck commented on code in PR #27962: URL: https://github.com/apache/airflow/pull/27962#discussion_r1033990823 ## airflow/providers/common/sql/README_API.md: ## @@ -0,0 +1,103 @@ + + +# Keeping the API of common.sql provider backwards compatible + +The API of the

[GitHub] [airflow] tkansara opened a new issue, #27975: expand or expand_kwargs()

2022-11-28 Thread GitBox
tkansara opened a new issue, #27975: URL: https://github.com/apache/airflow/issues/27975 ### What do you see as an issue? In the section:

[airflow] branch constraints-main updated: Updating constraints. Build id:

2022-11-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new daeb30fc5d Updating

[GitHub] [airflow] potiuk commented on pull request #27966: Clarify docstrings for updated DbApiHook

2022-11-28 Thread GitBox
potiuk commented on PR #27966: URL: https://github.com/apache/airflow/pull/27966#issuecomment-1329805138 Line too long :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] JCoder01 commented on issue #27523: Jumping tasks in grid

2022-11-28 Thread GitBox
JCoder01 commented on issue #27523: URL: https://github.com/apache/airflow/issues/27523#issuecomment-1329804692 Taking a longer look at mine, I'm seeing the same thing. This occurs on a dag with a task group, when the task group is expanded the task group and downstream tasks move around.

[GitHub] [airflow] dstandish closed pull request #27971: Experiment: Run static checks and postgres tests before all else

2022-11-28 Thread GitBox
dstandish closed pull request #27971: Experiment: Run static checks and postgres tests before all else URL: https://github.com/apache/airflow/pull/27971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] dstandish commented on pull request #27971: Experiment: Run static checks and postgres tests before all else

2022-11-28 Thread GitBox
dstandish commented on PR #27971: URL: https://github.com/apache/airflow/pull/27971#issuecomment-1329823364 yeah i agree. i was actually just about to close the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] potiuk commented on pull request #27264: Attempt to add Python 3.11 support

2022-11-28 Thread GitBox
potiuk commented on PR #27264: URL: https://github.com/apache/airflow/pull/27264#issuecomment-1329829469 FYI. Databricks-connector-sql has just been released with Python 3.11 compatibility. One step less to go. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] tkansara commented on issue #27975: expand or expand_kwargs()

2022-11-28 Thread GitBox
tkansara commented on issue #27975: URL: https://github.com/apache/airflow/issues/27975#issuecomment-1329860852 Or am is this correct and I am missing something... Ty for checking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] sunghospark-calm commented on issue #27561: Helm chart tries to patch immutable Job resources on helm upgrade

2022-11-28 Thread GitBox
sunghospark-calm commented on issue #27561: URL: https://github.com/apache/airflow/issues/27561#issuecomment-1329870939 Running into the same problem here. Had to disable the hooks because migration was not running properly during upgrade, without hooks the followup deployment fails

[GitHub] [airflow] o-nikolas commented on issue #26511: Retrieve AWS Cloudwatch logs using aws_conn_id connection for GlueOperator

2022-11-28 Thread GitBox
o-nikolas commented on issue #26511: URL: https://github.com/apache/airflow/issues/26511#issuecomment-1330029164 > @o-nikolas - given there is no response for more than a month, can we close this issue for now? > @ChirangaL - feel free to open it again if the solution doesn't work for

[GitHub] [airflow] bdsoha commented on a diff in pull request #27974: [AIP-51] Add helper to import default executor class

2022-11-28 Thread GitBox
bdsoha commented on code in PR #27974: URL: https://github.com/apache/airflow/pull/27974#discussion_r1034335803 ## airflow/executors/executor_loader.py: ## @@ -65,18 +65,23 @@ class ExecutorLoader: DEBUG_EXECUTOR: "airflow.executors.debug_executor.DebugExecutor",

[GitHub] [airflow] uranusjr commented on a diff in pull request #27969: Completed D400 for multiple folders

2022-11-28 Thread GitBox
uranusjr commented on code in PR #27969: URL: https://github.com/apache/airflow/pull/27969#discussion_r1034345312 ## airflow/executors/kubernetes_executor.py: ## @@ -454,7 +454,7 @@ def __init__(self): @provide_session def clear_not_launched_queued_tasks(self,

[GitHub] [airflow] uranusjr commented on a diff in pull request #27797: Add tests to PythonOperator

2022-11-28 Thread GitBox
uranusjr commented on code in PR #27797: URL: https://github.com/apache/airflow/pull/27797#discussion_r1034362366 ## tests/operators/test_python.py: ## @@ -1155,6 +1169,21 @@ def f(): ) copy.deepcopy(task) +def test_except_value_error(self): +def

[GitHub] [airflow] Bowrna commented on a diff in pull request #27905: listener plugin example added

2022-11-28 Thread GitBox
Bowrna commented on code in PR #27905: URL: https://github.com/apache/airflow/pull/27905#discussion_r1034275922 ## airflow/example_dags/plugins/event_listener.py: ## @@ -0,0 +1,77 @@ +from airflow.listeners import hookimpl Review Comment: I am checking this now. --

[GitHub] [airflow] Taragolis commented on a diff in pull request #27970: Replace `unittests` in amazon provider tests by pure `pytest`

2022-11-28 Thread GitBox
Taragolis commented on code in PR #27970: URL: https://github.com/apache/airflow/pull/27970#discussion_r1034300256 ## tests/providers/amazon/aws/hooks/test_emr_containers.py: ## @@ -110,7 +109,9 @@ def test_query_status_polling_with_timeout(self, mock_session):

[GitHub] [airflow] bdsoha commented on a diff in pull request #27974: [AIP-51] Add helper to import default executor class

2022-11-28 Thread GitBox
bdsoha commented on code in PR #27974: URL: https://github.com/apache/airflow/pull/27974#discussion_r1034335803 ## airflow/executors/executor_loader.py: ## @@ -65,18 +65,23 @@ class ExecutorLoader: DEBUG_EXECUTOR: "airflow.executors.debug_executor.DebugExecutor",

[GitHub] [airflow] uranusjr commented on a diff in pull request #27797: Add tests to PythonOperator

2022-11-28 Thread GitBox
uranusjr commented on code in PR #27797: URL: https://github.com/apache/airflow/pull/27797#discussion_r1034360950 ## tests/operators/test_python.py: ## @@ -375,6 +375,20 @@ def func(): "INFO:airflow.task.operators:Done. Returned value not shown" in cm.output

[GitHub] [airflow] uranusjr commented on a diff in pull request #27797: Add tests to PythonOperator

2022-11-28 Thread GitBox
uranusjr commented on code in PR #27797: URL: https://github.com/apache/airflow/pull/27797#discussion_r1034361731 ## tests/operators/test_python.py: ## @@ -1155,6 +1169,21 @@ def f(): ) copy.deepcopy(task) +def test_except_value_error(self): +def

[GitHub] [airflow] ephraimbuddy merged pull request #27964: Fix deadlock when chaining multiple empty mapped tasks

2022-11-28 Thread GitBox
ephraimbuddy merged PR #27964: URL: https://github.com/apache/airflow/pull/27964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ephraimbuddy closed issue #27824: DAG Run fails when chaining multiple empty mapped tasks

2022-11-28 Thread GitBox
ephraimbuddy closed issue #27824: DAG Run fails when chaining multiple empty mapped tasks URL: https://github.com/apache/airflow/issues/27824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch main updated (b60006ae26 -> f89ca94c3e)

2022-11-28 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b60006ae26 Add information on running tests with Breeze in PyCharm (#27901) add f89ca94c3e Fix deadlock

[GitHub] [airflow] o-nikolas opened a new issue, #27979: Cancel a step created from EmrAddStepsOperator

2022-11-28 Thread GitBox
o-nikolas opened a new issue, #27979: URL: https://github.com/apache/airflow/issues/27979 ### Description Support an EMR operator for cancelling jobs/steps. Created from the following Github Discussion: https://github.com/apache/airflow/discussions/27959 ### Use

[GitHub] [airflow] uranusjr commented on a diff in pull request #27710: add a new conf to wait past_deps before skipping a task

2022-11-28 Thread GitBox
uranusjr commented on code in PR #27710: URL: https://github.com/apache/airflow/pull/27710#discussion_r1034343974 ## airflow/cli/cli_parser.py: ## @@ -543,6 +543,11 @@ def string_lower_type(val): help="Ignore depends_on_past dependencies (but respect upstream

[GitHub] [airflow] uranusjr commented on a diff in pull request #27710: add a new conf to wait past_deps before skipping a task

2022-11-28 Thread GitBox
uranusjr commented on code in PR #27710: URL: https://github.com/apache/airflow/pull/27710#discussion_r1034344907 ## airflow/cli/commands/task_command.py: ## @@ -227,6 +227,7 @@ def _run_task_by_executor(args, dag, ti): pickle_id=pickle_id,

[GitHub] [airflow] shubham22 commented on issue #26511: Retrieve AWS Cloudwatch logs using aws_conn_id connection for GlueOperator

2022-11-28 Thread GitBox
shubham22 commented on issue #26511: URL: https://github.com/apache/airflow/issues/26511#issuecomment-1330024053 @o-nikolas - given there is no response for more than a month, can we close this issue for now? @ChirangaL - feel free to open it again if the solution doesn't work for your

[GitHub] [airflow] o-nikolas closed issue #26511: Retrieve AWS Cloudwatch logs using aws_conn_id connection for GlueOperator

2022-11-28 Thread GitBox
o-nikolas closed issue #26511: Retrieve AWS Cloudwatch logs using aws_conn_id connection for GlueOperator URL: https://github.com/apache/airflow/issues/26511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] Taragolis commented on a diff in pull request #27970: Replace `unittests` in amazon provider tests by pure `pytest`

2022-11-28 Thread GitBox
Taragolis commented on code in PR #27970: URL: https://github.com/apache/airflow/pull/27970#discussion_r1034300256 ## tests/providers/amazon/aws/hooks/test_emr_containers.py: ## @@ -110,7 +109,9 @@ def test_query_status_polling_with_timeout(self, mock_session):

[airflow] branch main updated: Add information on running tests with Breeze in PyCharm (#27901)

2022-11-28 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b60006ae26 Add information on running tests with

[GitHub] [airflow] uranusjr merged pull request #27901: Add information on running tests with Breeze in PyCharm

2022-11-28 Thread GitBox
uranusjr merged PR #27901: URL: https://github.com/apache/airflow/pull/27901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] shubham22 commented on pull request #26269: Added Feature - Glue job continuously log printing in Airflow task logs

2022-11-28 Thread GitBox
shubham22 commented on PR #26269: URL: https://github.com/apache/airflow/pull/26269#issuecomment-1330028294 @nikhi-suthar - checking once more, are you still working on this? cc: @o-nikolas -- This is an automated message from the Apache Git Service. To respond to the message, please

  1   2   >