Re: [I] Status of testing Providers that were prepared on February 12, 2024 [airflow]

2024-02-13 Thread via GitHub
eladkal commented on issue #37358: URL: https://github.com/apache/airflow/issues/37358#issuecomment-1940678655 Providers `amazon`, `cncf.kubernetes` and `common.sql` will be excluded from RC1. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Restore KPO trigger event param name [airflow]

2024-02-13 Thread via GitHub
pankajkoti commented on code in PR #37363: URL: https://github.com/apache/airflow/pull/37363#discussion_r1487373964 ## airflow/providers/cncf/kubernetes/triggers/pod.py: ## @@ -155,18 +155,32 @@ def serialize(self) -> tuple[str, dict[str, Any]]: }, ) +

Re: [PR] Restore KPO trigger event param name [airflow]

2024-02-13 Thread via GitHub
pankajkoti commented on code in PR #37363: URL: https://github.com/apache/airflow/pull/37363#discussion_r1487373964 ## airflow/providers/cncf/kubernetes/triggers/pod.py: ## @@ -155,18 +155,32 @@ def serialize(self) -> tuple[str, dict[str, Any]]: }, ) +

Re: [PR] Restore KPO trigger event param name [airflow]

2024-02-13 Thread via GitHub
pankajkoti commented on code in PR #37363: URL: https://github.com/apache/airflow/pull/37363#discussion_r1487373964 ## airflow/providers/cncf/kubernetes/triggers/pod.py: ## @@ -155,18 +155,32 @@ def serialize(self) -> tuple[str, dict[str, Any]]: }, ) +

Re: [PR] Restore KPO trigger event param name [airflow]

2024-02-13 Thread via GitHub
pankajkoti commented on code in PR #37363: URL: https://github.com/apache/airflow/pull/37363#discussion_r1487378821 ## airflow/providers/cncf/kubernetes/triggers/pod.py: ## @@ -155,18 +155,32 @@ def serialize(self) -> tuple[str, dict[str, Any]]: }, ) +

Re: [PR] Restore KPO trigger event param name [airflow]

2024-02-13 Thread via GitHub
pankajkoti commented on code in PR #37363: URL: https://github.com/apache/airflow/pull/37363#discussion_r1487373964 ## airflow/providers/cncf/kubernetes/triggers/pod.py: ## @@ -155,18 +155,32 @@ def serialize(self) -> tuple[str, dict[str, Any]]: }, ) +

Re: [PR] Restore KPO trigger event param name [airflow]

2024-02-13 Thread via GitHub
pankajkoti commented on code in PR #37363: URL: https://github.com/apache/airflow/pull/37363#discussion_r1487388263 ## airflow/providers/cncf/kubernetes/triggers/pod.py: ## @@ -155,18 +155,32 @@ def serialize(self) -> tuple[str, dict[str, Any]]: }, ) +

Re: [I] airflow db init error [airflow]

2024-02-13 Thread via GitHub
Taragolis closed issue #37377: airflow db init error URL: https://github.com/apache/airflow/issues/37377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] airflow db init error [airflow]

2024-02-13 Thread via GitHub
Taragolis commented on issue #37377: URL: https://github.com/apache/airflow/issues/37377#issuecomment-1940793638 If you want (i guess so) to install Airflow reproducibly, we would recommend to follow follow our way of installing airflow in reproducible way https://airflow.apache.org/docs/ap

Re: [PR] Add extra operator links for EMR Serverless [airflow]

2024-02-13 Thread via GitHub
Taragolis merged PR #34225: URL: https://github.com/apache/airflow/pull/34225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [I] Add extra links for EMR Serverless [airflow]

2024-02-13 Thread via GitHub
Taragolis closed issue #31620: Add extra links for EMR Serverless URL: https://github.com/apache/airflow/issues/31620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

(airflow) branch main updated: Add extra operator links for EMR Serverless (#34225)

2024-02-13 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b5b452b590 Add extra operator links for EMR Serv

[I] show_trigger_form_if_no_params allows to trigger without params even when params required [airflow]

2024-02-13 Thread via GitHub
kmehkeri opened a new issue, #37379: URL: https://github.com/apache/airflow/issues/37379 ### Apache Airflow version 2.8.1 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? For show_trigger_form_if_no_params=False (default

Re: [PR] Added Supported Database Types [airflow]

2024-02-13 Thread via GitHub
Taragolis commented on code in PR #37376: URL: https://github.com/apache/airflow/pull/37376#discussion_r1487488370 ## docs/apache-airflow-providers-common-sql/index.rst: ## @@ -18,6 +18,20 @@ ``apache-airflow-providers-common-sql`` === +Su

[PR] Fix typo in light HTTP server for documentation command [airflow]

2024-02-13 Thread via GitHub
Taragolis opened a new pull request, #37380: URL: https://github.com/apache/airflow/pull/37380 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#

Re: [PR] Add GKEStartKueueInsideClusterOperator to support Kueue inside clusters [airflow]

2024-02-13 Thread via GitHub
VladaZakharova commented on PR #37072: URL: https://github.com/apache/airflow/pull/37072#issuecomment-1940964341 > why build operators specific to GKE ? All the operators that we have for operations on cluster (create and delete) were implemented as a part of google provider as GKE o

Re: [PR] Add GKEStartKueueInsideClusterOperator to support Kueue inside clusters [airflow]

2024-02-13 Thread via GitHub
raphaelauv commented on PR #37072: URL: https://github.com/apache/airflow/pull/37072#issuecomment-1940982879 create a GKE is calling GCP API deploy a https://github.com/kubernetes-sigs/kueue is calling K8S API not GCP API -- This is an automated message from the Apache Git

Re: [PR] Add Teradata Provider [airflow]

2024-02-13 Thread via GitHub
SatishChGit commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1485977601 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

[PR] Feature: Return rowcount from SQL Operators [airflow]

2024-02-13 Thread via GitHub
Joffreybvn opened a new pull request, #37381: URL: https://github.com/apache/airflow/pull/37381 This PR add [rowcounts](https://peps.python.org/pep-0249/#rowcount) to the output of the SQLExecuteQueryOperator. **Use-case**: This way it can be passed as XCom, and use

[I] Airflow worker : if _store_result fail cause db is not accessible, task stay in running [airflow]

2024-02-13 Thread via GitHub
raphaelauv opened a new issue, #37382: URL: https://github.com/apache/airflow/issues/37382 ### Apache Airflow version 2.8.1 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? in CeleryExecutor if the db is not avai

Re: [PR] Add GKEStartKueueInsideClusterOperator to support Kueue inside clusters [airflow]

2024-02-13 Thread via GitHub
VladaZakharova commented on PR #37072: URL: https://github.com/apache/airflow/pull/37072#issuecomment-1941154392 > create a GKE is calling GCP API > > deploy a https://github.com/kubernetes-sigs/kueue is calling K8S API not GCP API Based on this documentation for [Kueue](https

Re: [PR] Add GKEStartKueueInsideClusterOperator to support Kueue inside clusters [airflow]

2024-02-13 Thread via GitHub
VladaZakharova commented on PR #37072: URL: https://github.com/apache/airflow/pull/37072#issuecomment-1941160640 Hi @eladkal ! Can you please check changes in this PR too? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Add GKEStartKueueInsideClusterOperator to support Kueue inside clusters [airflow]

2024-02-13 Thread via GitHub
raphaelauv commented on PR #37072: URL: https://github.com/apache/airflow/pull/37072#issuecomment-1941163935 ``` Based on this documentation for [Kueue](https://kueue.sigs.k8s.io/docs/installation/) the conditions to meet before we actually can install Kueue are different from the condit

Re: [I] show_trigger_form_if_no_params allows to trigger without params even when params required [airflow]

2024-02-13 Thread via GitHub
kmehkeri commented on issue #37379: URL: https://github.com/apache/airflow/issues/37379#issuecomment-1941179926 Hm... I just realized this is a reverse of #33392. If a trigger form was shown for DAGs that have params it was important for me and my users to get exactly same experience

Re: [PR] Add GKEStartKueueInsideClusterOperator to support Kueue inside clusters [airflow]

2024-02-13 Thread via GitHub
VladaZakharova commented on PR #37072: URL: https://github.com/apache/airflow/pull/37072#issuecomment-1941186088 > ``` > Based on this documentation for [Kueue](https://kueue.sigs.k8s.io/docs/installation/) the conditions to meet before we actually can install Kueue are different from th

Re: [I] Status of testing Providers that were prepared on February 12, 2024 [airflow]

2024-02-13 Thread via GitHub
SuperBo commented on issue #37358: URL: https://github.com/apache/airflow/issues/37358#issuecomment-1941187375 Databricks providers, confirm [#37025](https://github.com/apache/airflow/pull/37025) works when xcom is disabled. However it raises error with xcom enabled when serializing named

[PR] Enable PT014: Checks for duplicate test cases in `pytest.mark.parametrize` [airflow]

2024-02-13 Thread via GitHub
Taragolis opened a new pull request, #37383: URL: https://github.com/apache/airflow/pull/37383 Simple validation rule that we have a duplicates in our parametrised tests. See: https://docs.astral.sh/ruff/rules/pytest-duplicate-parametrize-test-cases/ --- **^

Re: [PR] Remove flakiness introduced by cleanup in configuration test [airflow]

2024-02-13 Thread via GitHub
potiuk merged PR #37375: URL: https://github.com/apache/airflow/pull/37375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Rmeove flakiness introduced by cleanup in configuration test (#37375)

2024-02-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new cbc9af09dd Rmeove flakiness introduced by cleanup i

[PR] Add redirect for deprecated page [airflow]

2024-02-13 Thread via GitHub
romsharon98 opened a new pull request, #37384: URL: https://github.com/apache/airflow/pull/37384 related: https://github.com/apache/airflow/pull/37049 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apach

Re: [PR] Add SUSE INTHEWILD [airflow]

2024-02-13 Thread via GitHub
boring-cyborg[bot] commented on PR #37385: URL: https://github.com/apache/airflow/pull/37385#issuecomment-1941295470 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Add SUSE INTHEWILD [airflow]

2024-02-13 Thread via GitHub
ruospalo opened a new pull request, #37385: URL: https://github.com/apache/airflow/pull/37385 Add SUSE information --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing

Re: [PR] Add Use Case SUSE [airflow-site]

2024-02-13 Thread via GitHub
potiuk commented on PR #952: URL: https://github.com/apache/airflow-site/pull/952#issuecomment-1941301904 Nice one. Thank you @ruospalo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] Status of testing Providers that were prepared on February 12, 2024 [airflow]

2024-02-13 Thread via GitHub
Taragolis commented on issue #37358: URL: https://github.com/apache/airflow/issues/37358#issuecomment-1941326115 > However it raises error with xcom enabled when serializing named tuple to json. Serializing named tuple should be add into the core first, e.g. it might be added by http

Re: [I] Status of testing Providers that were prepared on February 12, 2024 [airflow]

2024-02-13 Thread via GitHub
Taragolis commented on issue #37358: URL: https://github.com/apache/airflow/issues/37358#issuecomment-1941335389 Checked all my changes, looking good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add SUSE INTHEWILD [airflow]

2024-02-13 Thread via GitHub
boring-cyborg[bot] commented on PR #37385: URL: https://github.com/apache/airflow/pull/37385#issuecomment-1941349101 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Add SUSE INTHEWILD [airflow]

2024-02-13 Thread via GitHub
Taragolis merged PR #37385: URL: https://github.com/apache/airflow/pull/37385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: Add SUSE INTHEWILD (#37385)

2024-02-13 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new da3f1edbf8 Add SUSE INTHEWILD (#37385) da3f1edbf

Re: [PR] Added Supported Database Types [airflow]

2024-02-13 Thread via GitHub
potiuk commented on code in PR #37376: URL: https://github.com/apache/airflow/pull/37376#discussion_r1487726741 ## docs/apache-airflow-providers-common-sql/index.rst: ## @@ -18,6 +18,20 @@ ``apache-airflow-providers-common-sql`` === +Suppo

Re: [PR] Fix Airflow serialization for namedtuple [airflow]

2024-02-13 Thread via GitHub
bolkedebruin commented on code in PR #37168: URL: https://github.com/apache/airflow/pull/37168#discussion_r1487739235 ## airflow/serialization/serde.py: ## @@ -134,19 +134,25 @@ def serialize(o: object, depth: int = 0) -> U | None: cls = type(o) qn = qualname(o) +

Re: [PR] Fix/html validation forms [airflow]

2024-02-13 Thread via GitHub
chrfoyer commented on code in PR #37316: URL: https://github.com/apache/airflow/pull/37316#discussion_r1487750730 ## airflow/www/forms.py: ## @@ -234,13 +234,42 @@ def process(self, formdata=None, obj=None, **kwargs): "corresponding Airflow Provider Package."

Re: [PR] [OpenLineage] Add support for JobTypeJobFacet properties. [airflow]

2024-02-13 Thread via GitHub
JDarDagran commented on code in PR #37255: URL: https://github.com/apache/airflow/pull/37255#discussion_r1487770711 ## airflow/providers/openlineage/plugins/adapter.py: ## @@ -350,6 +358,7 @@ def _build_run( @staticmethod def _build_job( job_name: str, +

[PR] Bring back accidentally commented out tests [airflow]

2024-02-13 Thread via GitHub
potiuk opened a new pull request, #37386: URL: https://github.com/apache/airflow/pull/37386 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul

Re: [PR] Add dagrun first task scheduling delay, dag processing duration [airflow]

2024-02-13 Thread via GitHub
KaYunKIM commented on PR #36399: URL: https://github.com/apache/airflow/pull/36399#issuecomment-1941501259 > Hmm, we need to have this as version controlled or it will break backward compatibility in my opinion. Could you help me with some solutions? -- This is an automated message

(airflow) branch constraints-main updated: Updating constraints. Github run id:7886092723

2024-02-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 5c7dfbf2ac Updating con

Re: [PR] Added Supported Database Types [airflow]

2024-02-13 Thread via GitHub
Satoshi-Sh commented on code in PR #37376: URL: https://github.com/apache/airflow/pull/37376#discussion_r1487848170 ## docs/apache-airflow-providers-common-sql/index.rst: ## @@ -18,6 +18,20 @@ ``apache-airflow-providers-common-sql`` === +S

Re: [PR] Fix typo in light HTTP server for documentation command [airflow]

2024-02-13 Thread via GitHub
potiuk merged PR #37380: URL: https://github.com/apache/airflow/pull/37380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (da3f1edbf8 -> 7f64dacadb)

2024-02-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from da3f1edbf8 Add SUSE INTHEWILD (#37385) add 7f64dacadb Fix typo in light HTTP server for documentation command (#3

Re: [PR] Add Teradata Provider [airflow]

2024-02-13 Thread via GitHub
sunilkmallam commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1487850028 ## airflow/providers/teradata/transfers/teradata_to_teradata.py: ## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Added Supported Database Types [airflow]

2024-02-13 Thread via GitHub
potiuk commented on code in PR #37376: URL: https://github.com/apache/airflow/pull/37376#discussion_r1487850409 ## docs/apache-airflow-providers-common-sql/index.rst: ## @@ -18,6 +18,20 @@ ``apache-airflow-providers-common-sql`` === +Suppo

Re: [PR] Added Supported Database Types [airflow]

2024-02-13 Thread via GitHub
Satoshi-Sh commented on code in PR #37376: URL: https://github.com/apache/airflow/pull/37376#discussion_r1487858777 ## docs/apache-airflow-providers-common-sql/index.rst: ## @@ -18,6 +18,20 @@ ``apache-airflow-providers-common-sql`` === +S

Re: [PR] feat: enable mysql keda support for triggerer [airflow]

2024-02-13 Thread via GitHub
claneys commented on code in PR #37365: URL: https://github.com/apache/airflow/pull/37365#discussion_r1487887403 ## helm_tests/other/test_keda_triggerer.py: ## Review Comment: Indeed, thanks to point me this out. -- This is an automated message from the Apache Git Servi

Re: [PR] Fix Airflow serialization for namedtuple [airflow]

2024-02-13 Thread via GitHub
Joffreybvn commented on PR #37168: URL: https://github.com/apache/airflow/pull/37168#issuecomment-1941624178 We do need to specify the classname, which should be "builtins.tuple": The `serialize` method (in [airflow/serialization/serializers/builtin.py](https://github.com/apache/airf

[PR] Include `airflow_pre_installed_providers.txt` into sdist distribution [airflow]

2024-02-13 Thread via GitHub
Taragolis opened a new pull request, #37388: URL: https://github.com/apache/airflow/pull/37388 Found that is not possible to build wheel or install airflow from the `sdist` distribution. How to reproduce (manual steps) 1. Build sdist from the `main` ```consol

Re: [PR] Bring back accidentally commented out tests [airflow]

2024-02-13 Thread via GitHub
Taragolis merged PR #37386: URL: https://github.com/apache/airflow/pull/37386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: Bring back accidentally commented out tests (#37386)

2024-02-13 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a5c6540567 Bring back accidentally commented out

Re: [PR] Enable PT014: Checks for duplicate test cases in `pytest.mark.parametrize` [airflow]

2024-02-13 Thread via GitHub
hussein-awala merged PR #37383: URL: https://github.com/apache/airflow/pull/37383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

(airflow) branch main updated (a5c6540567 -> c020fbd360)

2024-02-13 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from a5c6540567 Bring back accidentally commented out tests (#37386) add c020fbd360 Enable PT014: Checks for dupl

Re: [I] Variable entity: additional attribute to define its type [airflow]

2024-02-13 Thread via GitHub
boring-cyborg[bot] commented on issue #37390: URL: https://github.com/apache/airflow/issues/37390#issuecomment-1941685406 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] Variable entity: additional attribute to define its type [airflow]

2024-02-13 Thread via GitHub
Docdez opened a new issue, #37390: URL: https://github.com/apache/airflow/issues/37390 ### Description With first Airflow based project initialization I use Connection and Variable entities. Some variables must be json type only. I just do json.dumps to the value now. It is assumed t

[PR] fix: Signature of "insert_rows" incompatible with supertype "DbApiHook" [airflow]

2024-02-13 Thread via GitHub
rawwar opened a new pull request, #37391: URL: https://github.com/apache/airflow/pull/37391 This PR fixes the following mypy check failures for the google provider. ``` airflow/providers/google/cloud/hooks/bigquery.py:228: error: Signature of "insert_rows" incompatible with super

(airflow) branch main updated: Include `airflow_pre_installed_providers.txt` into sdist distribution (#37388)

2024-02-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2e1561015c Include `airflow_pre_installed_providers

Re: [PR] Include `airflow_pre_installed_providers.txt` into sdist distribution [airflow]

2024-02-13 Thread via GitHub
potiuk merged PR #37388: URL: https://github.com/apache/airflow/pull/37388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] [OpenLineage] Add support for JobTypeJobFacet properties. [airflow]

2024-02-13 Thread via GitHub
mattiabertorello commented on code in PR #37255: URL: https://github.com/apache/airflow/pull/37255#discussion_r1488119872 ## airflow/providers/openlineage/plugins/adapter.py: ## @@ -350,6 +358,7 @@ def _build_run( @staticmethod def _build_job( job_name: str, +

[PR] [OpenLineage] Check for disabled operators in DefaultExtractor.extract_on_complete [airflow]

2024-02-13 Thread via GitHub
kacpermuda opened a new pull request, #37392: URL: https://github.com/apache/airflow/pull/37392 In `BaseExtractor.extract()` we check if operator is disabled but in `DefaultExtractor.extract_on_complete()` we missed this check. This PR adds this check and some tests to make

Re: [PR] [OpenLineage] Add support for JobTypeJobFacet properties. [airflow]

2024-02-13 Thread via GitHub
mobuchowski commented on code in PR #37255: URL: https://github.com/apache/airflow/pull/37255#discussion_r1488149736 ## airflow/providers/openlineage/plugins/adapter.py: ## @@ -350,6 +358,7 @@ def _build_run( @staticmethod def _build_job( job_name: str, +

Re: [PR] [OpenLineage] Add support for JobTypeJobFacet properties. [airflow]

2024-02-13 Thread via GitHub
mobuchowski commented on code in PR #37255: URL: https://github.com/apache/airflow/pull/37255#discussion_r1488155997 ## airflow/providers/openlineage/plugins/adapter.py: ## @@ -181,6 +188,7 @@ def start_task( ), job=self._build_job( job

Re: [PR] removing additional .* that prevents proper metric mapping to airflow_dagrun_dependency_check [airflow]

2024-02-13 Thread via GitHub
jedcunningham commented on PR #37339: URL: https://github.com/apache/airflow/pull/37339#issuecomment-1941901006 This unfortunately is a breaking change. If you need to fix this mapping, you'll need to use `statsd.overrideMappings` in your environment. -- This is an automated message from

(airflow) 02/02: Include `airflow_pre_installed_providers.txt` into sdist distribution (#37388)

2024-02-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-8-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 458dd029bef26eb0107d065418bcc00303f4705a Author: Andrey Anshin AuthorDate: Tue Feb 13 19:36:12 2024 +0400 Inclu

(airflow) 01/02: Bring back accidentally commented out tests (#37386)

2024-02-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-8-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 41c86522f0abde692cc250fe9a8185723a256409 Author: Jarek Potiuk AuthorDate: Tue Feb 13 15:30:57 2024 +0100 Bring

(airflow) branch v2-8-test updated (96551a77f2 -> 458dd029be)

2024-02-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch v2-8-test in repository https://gitbox.apache.org/repos/asf/airflow.git from 96551a77f2 Fix static checks new 41c86522f0 Bring back accidentally commented out tests (#37386) new 458

[PR] Revert "removing additional .* that prevents proper metric mapping to airflow_dagrun_dependency_check (#37339)" [airflow]

2024-02-13 Thread via GitHub
jedcunningham opened a new pull request, #37393: URL: https://github.com/apache/airflow/pull/37393 This reverts commit ca30f00dc909bc39efaf54f0187fc6b90796f722 from #37339. This is a breaking change to how metrics are exposed in the exporter. Before we merge this, we might enter

Re: [I] Unable to execute a file, by placing the absolute path of it, ending with .sql extension to the AWS SqlToS3Operator [airflow]

2024-02-13 Thread via GitHub
Altonymous commented on issue #37372: URL: https://github.com/apache/airflow/issues/37372#issuecomment-1941973119 Tried using just the file name and updating the template_path to be the exact directory the file lives in with the same result... `template_searchpath=["/app/dags/template

Re: [I] Unable to execute a file, by placing the absolute path of it, ending with .sql extension to the AWS SqlToS3Operator [airflow]

2024-02-13 Thread via GitHub
potiuk commented on issue #37372: URL: https://github.com/apache/airflow/issues/37372#issuecomment-1942017438 Then no idea, It should work, maybe someone will be able to investigate it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Add ti attributes to react ti details [airflow]

2024-02-13 Thread via GitHub
bbovenzi closed pull request #37262: Add ti attributes to react ti details URL: https://github.com/apache/airflow/pull/37262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add ti attributes to react ti details [airflow]

2024-02-13 Thread via GitHub
bbovenzi commented on PR #37262: URL: https://github.com/apache/airflow/pull/37262#issuecomment-1942020264 Gonna try to do this all via the rest api instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Unable to execute a file, by placing the absolute path of it, ending with .sql extension to the AWS SqlToS3Operator [airflow]

2024-02-13 Thread via GitHub
potiuk closed issue #37372: Unable to execute a file, by placing the absolute path of it, ending with .sql extension to the AWS SqlToS3Operator URL: https://github.com/apache/airflow/issues/37372 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [I] Unable to execute a file, by placing the absolute path of it, ending with .sql extension to the AWS SqlToS3Operator [airflow]

2024-02-13 Thread via GitHub
potiuk commented on issue #37372: URL: https://github.com/apache/airflow/issues/37372#issuecomment-1942027797 You can see how you can combine task-flow tasks and classic operator tasks in single DAG here https://airflow.apache.org/docs/apache-airflow/stable/tutorial/taskflow.html#adding-dep

[PR] Add more task details from rest api [airflow]

2024-02-13 Thread via GitHub
bbovenzi opened a new pull request, #37394: URL: https://github.com/apache/airflow/pull/37394 Use the getTaskInstance endpoint from the REST API to fill in more task details in the grid view. https://github.com/apache/airflow/assets/4600967/eb857c1c-21cf-4016-8f0f-aff6f49b40fc";>

[PR] Fix bug with clicking url-unsafe tags [airflow]

2024-02-13 Thread via GitHub
patgarz opened a new pull request, #37395: URL: https://github.com/apache/airflow/pull/37395 --- When using the text input box, filtering DAGs on a tag with url-unsafe characters (for example, `#slack-channel`) replaces the url-unsafe characters with their url

Re: [PR] [OpenLineage] Add support for JobTypeJobFacet properties. [airflow]

2024-02-13 Thread via GitHub
JDarDagran commented on code in PR #37255: URL: https://github.com/apache/airflow/pull/37255#discussion_r148828 ## airflow/providers/openlineage/plugins/adapter.py: ## @@ -350,6 +358,7 @@ def _build_run( @staticmethod def _build_job( job_name: str, +

Re: [I] Status of testing Providers that were prepared on February 12, 2024 [airflow]

2024-02-13 Thread via GitHub
ahzaz commented on issue #37358: URL: https://github.com/apache/airflow/issues/37358#issuecomment-1942052614 #37014 works as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] Remove `markdown` from core dependencies [airflow]

2024-02-13 Thread via GitHub
Taragolis opened a new pull request, #37396: URL: https://github.com/apache/airflow/pull/37396 I can't find any reference to markdown in Airflow codebase ```console ❯ grep -inr --include \*.py 'from markdown ' airflow ❯ grep -inr --include \*.py 'import markdo

(airflow) branch constraints-main updated: Updating constraints. Github run id:7888954665

2024-02-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new e0382ed40b Updating con

Re: [I] Airflow worker : if _store_result fail cause db is not accessible, task stay in running [airflow]

2024-02-13 Thread via GitHub
potiuk commented on issue #37382: URL: https://github.com/apache/airflow/issues/37382#issuecomment-1942075070 I believe just shutting down in this case will not solve the problem and retrying by cleery is a good strategy, accounting for possible intermittent reason for the problem. H

Re: [PR] Add Use Case SUSE [airflow-site]

2024-02-13 Thread via GitHub
potiuk merged PR #952: URL: https://github.com/apache/airflow-site/pull/952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

(airflow-site) branch main updated: Add Use Case SUSE (#952)

2024-02-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/main by this push: new 742f09 Add Use Case SUSE (#952) 742f09

[PR] Standardize use of get_app with flask appbuilder [airflow]

2024-02-13 Thread via GitHub
mvanree00 opened a new pull request, #37397: URL: https://github.com/apache/airflow/pull/37397 Standardizes the use of get_app within the FabAirflowSecurityManagerOverride. This makes mocking the appbuilder object simpler for testing, and matches how this was done in the

Re: [PR] Standardize use of get_app with flask appbuilder [airflow]

2024-02-13 Thread via GitHub
boring-cyborg[bot] commented on PR #37397: URL: https://github.com/apache/airflow/pull/37397#issuecomment-1942076353 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

Re: [PR] Remove `markdown` from core dependencies [airflow]

2024-02-13 Thread via GitHub
Taragolis commented on PR #37396: URL: https://github.com/apache/airflow/pull/37396#issuecomment-1942095516 I guess it should be remaining in constraints, because `markdown` is dependency for `apprise` which is dependency for `apache-airflow-providers-apprise` -- This is an automated mes

Re: [I] Airflow worker : if _store_result fail cause db is not accessible, task stay in running [airflow]

2024-02-13 Thread via GitHub
raphaelauv commented on issue #37382: URL: https://github.com/apache/airflow/issues/37382#issuecomment-1942100187 the airflow is deployed with the apache airflow helm chart but with restriction on the pgbouncer (that only accept precise port-range of source connection) and the forked proces

(airflow-site) branch gh-pages updated (8dcdea7b86 -> e1c1b836cc)

2024-02-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch gh-pages in repository https://gitbox.apache.org/repos/asf/airflow-site.git discard 8dcdea7b86 Rewritten history to remove past gh-pages deployments new e1c1b836cc Rewritten history to

[PR] Revert "removing additional .* that prevents proper metric mapping to… [airflow]

2024-02-13 Thread via GitHub
potiuk opened a new pull request, #37398: URL: https://github.com/apache/airflow/pull/37398 … airflow_dagrun_dependency_check (#37339)" This reverts commit ca30f00dc909bc39efaf54f0187fc6b90796f722. --- **^ Add meaningful description above** Read

Re: [PR] Revert "removing additional .* that prevents proper metric mapping to… [airflow]

2024-02-13 Thread via GitHub
potiuk commented on PR #37398: URL: https://github.com/apache/airflow/pull/37398#issuecomment-1942139500 Ah I see @jedcunningham you opened it already . Closing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Revert "removing additional .* that prevents proper metric mapping to… [airflow]

2024-02-13 Thread via GitHub
potiuk closed pull request #37398: Revert "removing additional .* that prevents proper metric mapping to… URL: https://github.com/apache/airflow/pull/37398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] Airflow Helm chart fails to deploy with ArgoCD [airflow]

2024-02-13 Thread via GitHub
alex-slynko opened a new issue, #37399: URL: https://github.com/apache/airflow/issues/37399 ### Official Helm Chart version 1.12.0 (latest released) ### Apache Airflow version latest ### Kubernetes Version 1.29 ### Helm Chart configuration No p

Re: [I] Airflow Helm chart fails to deploy with ArgoCD [airflow]

2024-02-13 Thread via GitHub
boring-cyborg[bot] commented on issue #37399: URL: https://github.com/apache/airflow/issues/37399#issuecomment-1942141149 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [PR] Standardize use of get_app with flask appbuilder [airflow]

2024-02-13 Thread via GitHub
vincbeck merged PR #37397: URL: https://github.com/apache/airflow/pull/37397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Standardize use of get_app with flask appbuilder [airflow]

2024-02-13 Thread via GitHub
boring-cyborg[bot] commented on PR #37397: URL: https://github.com/apache/airflow/pull/37397#issuecomment-1942162636 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

(airflow) branch main updated (2e1561015c -> ec97a07197)

2024-02-13 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 2e1561015c Include `airflow_pre_installed_providers.txt` into sdist distribution (#37388) add ec97a07197 standa

  1   2   3   >