[GitHub] [airflow] K3UL commented on issue #6145: [AIRFLOW-5518] Use correct scheme for Http connection parsed from URI

2019-09-18 Thread GitBox
K3UL commented on issue #6145: [AIRFLOW-5518] Use correct scheme for Http 
connection parsed from URI
URL: https://github.com/apache/airflow/pull/6145#issuecomment-532974905
 
 
   @mik-laj Ah ! I had looked into it but didn't find this one ; From what I 
see, the only thing missing is the use of schema to know if it's http or https.
   How would you like to proceed, for me to review it or continue working on 
your PR ? I'm not sure how one does that, I'm a little new to GitHub workflows.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-18 Thread GitBox
dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key 
in SSHHook
URL: https://github.com/apache/airflow/pull/6104#issuecomment-532965215
 
 
   Sounds like you don't like the `private_key` hook init param.  I don't care 
about this I was just adding it to be consistent with with existing hook, in 
which pretty much every attribute was overridable in init.  There was already 
`password`, so an invitation to be a knucklehead already exists ;).  If you 
want to remove this init param I have absolutely no objection.
   
   But concerning allowing private key to be provided directly in airflow 
connection, as opposed to only key file `path`, I assume you do not mean to 
object to that.  There is absolutely no difference between providing a private 
key here and `keyfile_dict` in GCP, or `password` in _any_ other conn uri.  The 
connection framework is fundamental to airflow and if we object to that, then 
we object to all hooks.  Moreover I think the case is strong that to require 
distributing keys across all nodes -- in other words adding special extra 
processing relative to other connection types -- rather _increases_ likelihood 
of security lapses relative to just being able to lean on the connection 
framework alone.
   
   Perhaps it makes sense to make a new PR with your proposed change and we can 
discuss there?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] lepture commented on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
lepture commented on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with 
Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532962533
 
 
   @potiuk It will take me some time to figure out how to write tests for 
airflow. Maybe in next week.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] lepture commented on a change in pull request #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
lepture commented on a change in pull request #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#discussion_r325986433
 
 

 ##
 File path: setup.py
 ##
 @@ -216,9 +216,7 @@ def write_version(filename: str = 
os.path.join(*["airflow", "git_version"])):
 ]
 grpc = ['grpcio>=1.15.0']
 flask_oauth = [
 
 Review comment:
   Can I change this name? It was named `flask_oauth`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] pgagnon commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-18 Thread GitBox
pgagnon commented on issue #6104: [AIRFLOW-4574] allow providing private_key in 
SSHHook
URL: https://github.com/apache/airflow/pull/6104#issuecomment-532948106
 
 
   @mik-laj 
   
   > I think that it is very useful to be able to configure connections using 
environment variables.
   
   I agree that it is useful, but as a side effect it creates an avenue for 
users to easily leak credentials by inadvertance.
   
   > Incorrect use is possible, but it is very limited and not very obvious.
   
   This type of credentials compromise is actually [so 
pervasive](https://www.zdnet.com/article/over-10-github-repos-have-leaked-api-or-cryptographic-keys/)
 that GitHub is now [scanning repositories for key 
patterns](https://help.github.com/en/articles/about-token-scanning). Google 
does [the 
same](https://cloud.google.com/source-repositories/docs/detecting-security-keys).
 Similarly AWS released a [git hook to prevent users from accidentally 
committing key material](https://github.com/awslabs/git-secrets).
   
   I don't think it can be qualified as limited at all, especially since in our 
case we need to keep in mind that a lot of Airflow users are data scientist 
types that just want to get their work done and aren't necessarily expected to 
have an acute understanding of proper security practices.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (AIRFLOW-5512) Development dependencies need gcp modules

2019-09-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933012#comment-16933012
 ] 

ASF GitHub Bot commented on AIRFLOW-5512:
-

haoliang7 commented on pull request #6147: [AIRFLOW-5512] Add gcp dependencies 
into devel
URL: https://github.com/apache/airflow/pull/6147
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
 - https://issues.apache.org/jira/browse/AIRFLOW-5512
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Development dependencies need gcp modules
> -
>
> Key: AIRFLOW-5512
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5512
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: dependencies
>Affects Versions: 1.10.5
>Reporter: Hao Liang
>Assignee: Hao Liang
>Priority: Minor
>
> Since airflow/example_dags/example_gcs_to_bq.py requires GCP modules, running 
> {code:bash}
> airflow db init
> {code}
> after
> {code:bash}
> pip install -e ".[devel]"
> {code}
> raises error: ModuleNotFoundError: No module named 'google.cloud'.
> Maybe we should add GCP dependencies to devel.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] haoliang7 opened a new pull request #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-18 Thread GitBox
haoliang7 opened a new pull request #6147: [AIRFLOW-5512] Add gcp dependencies 
into devel
URL: https://github.com/apache/airflow/pull/6147
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
 - https://issues.apache.org/jira/browse/AIRFLOW-5512
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics

2019-09-18 Thread GitBox
mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a 
whitelist mechanism for the StatsD metrics
URL: https://github.com/apache/airflow/pull/6130#discussion_r325946986
 
 

 ##
 File path: scripts/ci/kubernetes/kube/templates/configmaps.template.yaml
 ##
 @@ -54,6 +54,9 @@ data:
 statsd_port = 8125
 statsd_prefix = airflow
 
+# optional comma-separated prefix whitelist (e.g: 
scheduler,executor,dagrun)
+statsd_whitelist =
 
 Review comment:
   But isn't a good idea to keep the configmap.yaml templates aligned with the 
default `.cfg` template?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics

2019-09-18 Thread GitBox
mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a 
whitelist mechanism for the StatsD metrics
URL: https://github.com/apache/airflow/pull/6130#discussion_r325946586
 
 

 ##
 File path: docs/metrics.rst
 ##
 @@ -41,6 +41,13 @@ Add the following lines to your configuration file e.g. 
``airflow.cfg``
 statsd_port = 8125
 statsd_prefix = airflow
 
+If you want to avoid send all the available metrics to StatsD, you can 
configure a whitelist of prefixes to send only
+the metrics that start with the elements of the list:
+
+.. code-block:: bash
 
 Review comment:
   Oh now makes sense! I'll do it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] mik-laj commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-18 Thread GitBox
mik-laj commented on issue #6104: [AIRFLOW-4574] allow providing private_key in 
SSHHook
URL: https://github.com/apache/airflow/pull/6104#issuecomment-532911018
 
 
   I think that it is very useful to be able to configure connections using 
environment variables. Airflow is launched very often in clusters in an 
automated manner and the ability to easily define a connection is key.  
Incorrect use is possible, but it is very limited and not very obvious. 
   
   I think that in order to dispel any doubts it is worth adding a short 
warning notice when describing the ``private_key`` parameter. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] mik-laj commented on a change in pull request #5998: [AIRFLOW-5398] Update contrib example DAGs to context manager

2019-09-18 Thread GitBox
mik-laj commented on a change in pull request #5998: [AIRFLOW-5398] Update 
contrib example DAGs to context manager
URL: https://github.com/apache/airflow/pull/5998#discussion_r325938130
 
 

 ##
 File path: docs/howto/operator/papermill.rst
 ##
 @@ -50,33 +50,11 @@ supports S3, GCS, Azure and Local. HDFS is *not* supported.
 Example DAG
 '''
 
-.. code:: python
-
-import airflow
-
-from airflow.models import DAG
-from airflow.operators.papermill_operator import PapermillOperator
-
-from datetime import timedelta
-
-args = {
-'owner': 'Airflow',
-'start_date': airflow.utils.dates.days_ago(2)
-}
-
-dag = DAG(
-dag_id='example_papermill_operator', default_args=args,
-schedule_interval='0 0 * * *',
-dagrun_timeout=timedelta(minutes=60))
-
-run_this = PapermillOperator(
-task_id="run_example_notebook",
-dag=dag,
-input_nb="/tmp/hello_world.ipynb",
-output_nb="/tmp/out-{{ execution_date }}.ipynb",
-parameters={"msgs": "Ran from Airflow at {{ execution_date }}!"}
-)
-
-This DAG will use Papermill to run the notebook "hello_world", based on the 
execution date
-it will create an output notebook "out-". All fields, including the keys 
in the parameters, are
-templated.
+Use the 
:class:`~airflow/contrib/operators/papermill_operator.PapermillOperator`
+to send Dingding message:
 
 Review comment:
   I'm afraid there is a mistake here. Dinding is not related papermill. Can 
you check it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] mik-laj commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-18 Thread GitBox
mik-laj commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to 
Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#issuecomment-532907085
 
 
   Can you do rebase?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] mik-laj commented on a change in pull request #6123: [AIRFLOW-5502][depends on AIRFLOW-5498, AIRFLOW-5499] Move GCP base hook to core

2019-09-18 Thread GitBox
mik-laj commented on a change in pull request #6123: [AIRFLOW-5502][depends on 
AIRFLOW-5498, AIRFLOW-5499] Move GCP base hook to core
URL: https://github.com/apache/airflow/pull/6123#discussion_r325936782
 
 

 ##
 File path: airflow/contrib/utils/gcp_field_sanitizer.py
 ##
 @@ -16,150 +16,16 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-"""Sanitizer for body fields sent via GCP API.
-
-The sanitizer removes fields specified from the body.
-
-Context

-In some cases where GCP operation requires modification of existing resources 
(such
-as instances or instance templates) we need to sanitize body of the resources 
returned
-via GCP APIs. This is in the case when we retrieve information from GCP first,
-modify the body and either update the existing resource or create a new one 
with the
-modified body. Usually when you retrieve resource from GCP you get some extra 
fields which
-are Output-only, and we need to delete those fields if we want to use
-the body as input for subsequent create/insert type operation.
-
-
-Field specification

-
-Specification of fields is an array of strings which denote names of fields to 
be removed.
-The field can be either direct field name to remove from the body or the full
-specification of the path you should delete - separated with '.'
-
-
->>> FIELDS_TO_SANITIZE = [
->>>"kind",
->>>"properties.disks.kind",
->>>"properties.metadata.kind",
->>>]
->>> body = {
->>> "kind": "compute#instanceTemplate",
->>> "name": "instance",
->>> "properties": {
->>> "disks": [
->>> {
->>> "name": "a",
->>> "kind": "compute#attachedDisk",
->>> "type": "PERSISTENT",
->>> "mode": "READ_WRITE",
->>> },
->>> {
->>> "name": "b",
->>> "kind": "compute#attachedDisk",
->>> "type": "PERSISTENT",
->>> "mode": "READ_WRITE",
->>> }
->>> ],
->>> "metadata": {
->>> "kind": "compute#metadata",
->>> "fingerprint": "GDPUYxlwHe4="
->>> },
->>> }
->>> }
->>> sanitizer=GcpBodyFieldSanitizer(FIELDS_TO_SANITIZE)
->>> SANITIZED_BODY = sanitizer.sanitize(body)
->>> json.dumps(SANITIZED_BODY, indent=2)
-{
-"name":  "instance",
-"properties": {
-"disks": [
-{
-"name": "a",
-"type": "PERSISTENT",
-"mode": "READ_WRITE",
-},
-{
-"name": "b",
-"type": "PERSISTENT",
-"mode": "READ_WRITE",
-}
-],
-"metadata": {
-"fingerprint": "GDPUYxlwHe4="
-},
-}
-}
-
-Note that the components of the path can be either dictionaries or arrays of 
dictionaries.
-In case  they are dictionaries, subsequent component names key of the field, 
in case of
-arrays - the sanitizer iterates through all dictionaries in the array and 
searches
-components in all elements of the array.
+"""
+This module is deprecated. Please use `airflow.gcp.utils.field_sanitizer`.
 """
 
-from typing import List
-
-from airflow import LoggingMixin, AirflowException
-
-
-class GcpFieldSanitizerException(AirflowException):
-"""Thrown when sanitizer finds unexpected field type in the path
-(other than dict or array).
-"""
-
-
-class GcpBodyFieldSanitizer(LoggingMixin):
-"""Sanitizes the body according to specification.
-
-:param sanitize_specs: array of strings that specifies which fields to 
remove
-:type sanitize_specs: list[str]
-
-"""
-def __init__(self, sanitize_specs: List[str]) -> None:
-super().__init__()
-self._sanitize_specs = sanitize_specs
+import warnings
 
-def _sanitize(self, dictionary, remaining_field_spec, current_path):
-field_split = remaining_field_spec.split(".", 1)
-if len(field_split) == 1:  # pylint: disable=too-many-nested-blocks
-field_name = field_split[0]
-if field_name in dictionary:
-self.log.info("Deleted %s [%s]", field_name, current_path)
-del dictionary[field_name]
-else:
-self.log.debug(
-"The field %s is missing in %s at the path %s.", 
field_name, dictionary, current_path
-)
-else:
-field_name = field_split[0]
-remaining_path = field_split[1]
-child = dictionary.get(field_name)
-if child is None:
-self.log.debug(
-"The field %s is missing in %s at the path %s. ", 
field_name, dictionary, current_path
-)
-elif isinstance(child, dict):
-self._sanitize(child, remaining_path, "{}.{}".format(
-

[GitHub] [airflow] mik-laj commented on a change in pull request #6123: [AIRFLOW-5502][depends on AIRFLOW-5498, AIRFLOW-5499] Move GCP base hook to core

2019-09-18 Thread GitBox
mik-laj commented on a change in pull request #6123: [AIRFLOW-5502][depends on 
AIRFLOW-5498, AIRFLOW-5499] Move GCP base hook to core
URL: https://github.com/apache/airflow/pull/6123#discussion_r325936631
 
 

 ##
 File path: airflow/contrib/hooks/gcp_api_base_hook.py
 ##
 @@ -16,299 +16,14 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-#
-"""
-This module contains a Google Cloud API base hook.
-"""
-
-import json
-import functools
-import os
-import tempfile
-from typing import Any, Optional, Dict, Callable, TypeVar, Sequence
-
-import httplib2
-
-import google.auth
-import google.oauth2.service_account
-from google.api_core.gapic_v1.client_info import ClientInfo
-from google.api_core.exceptions import GoogleAPICallError, AlreadyExists, 
RetryError
-from google.auth.environment_vars import CREDENTIALS
-
-import google_auth_httplib2
-from googleapiclient.errors import HttpError
-
-from airflow import version
-from airflow.exceptions import AirflowException
-from airflow.hooks.base_hook import BaseHook
-
-
-_DEFAULT_SCOPES = ('https://www.googleapis.com/auth/cloud-platform',)  # type: 
Sequence[str]
-
-
-RT = TypeVar('RT')  # pylint: disable=invalid-name
-
-
-class GoogleCloudBaseHook(BaseHook):
-"""
-A base hook for Google cloud-related hooks. Google cloud has a shared REST
-API client that is built in the same way no matter which service you use.
-This class helps construct and authorize the credentials needed to then
-call googleapiclient.discovery.build() to actually discover and build a 
client
-for a Google cloud service.
-
-The class also contains some miscellaneous helper functions.
-
-All hook derived from this base hook use the 'Google Cloud Platform' 
connection
-type. Three ways of authentication are supported:
-
-Default credentials: Only the 'Project Id' is required. You'll need to
-have set up default credentials, such as by the
-``GOOGLE_APPLICATION_DEFAULT`` environment variable or from the metadata
-server on Google Compute Engine.
-
-JSON key file: Specify 'Project Id', 'Keyfile Path' and 'Scope'.
-
-Legacy P12 key files are not supported.
-
-JSON data provided in the UI: Specify 'Keyfile JSON'.
-
-:param gcp_conn_id: The connection ID to use when fetching connection info.
-:type gcp_conn_id: str
-:param delegate_to: The account to impersonate, if any.
-For this to work, the service account making the request must have
-domain-wide delegation enabled.
-:type delegate_to: str
-"""
-
-def __init__(self, gcp_conn_id: str = 'google_cloud_default', delegate_to: 
str = None) -> None:
-self.gcp_conn_id = gcp_conn_id
-self.delegate_to = delegate_to
-self.extras = self.get_connection(self.gcp_conn_id).extra_dejson  # 
type: Dict
-
-def _get_credentials_and_project_id(self) -> 
google.auth.credentials.Credentials:
-"""
-Returns the Credentials object for Google API and the associated 
project_id
-"""
-key_path = self._get_field('key_path', None)  # type: Optional[str]
-keyfile_dict = self._get_field('keyfile_dict', None)  # type: 
Optional[str]
-if not key_path and not keyfile_dict:
-self.log.info('Getting connection using `google.auth.default()` '
-  'since no key file is defined for hook.')
-credentials, project_id = google.auth.default(scopes=self.scopes)
-elif key_path:
-# Get credentials from a JSON file.
-if key_path.endswith('.json'):
-self.log.debug('Getting connection using JSON key file %s' % 
key_path)
-credentials = (
-
google.oauth2.service_account.Credentials.from_service_account_file(
-key_path, scopes=self.scopes)
-)
-project_id = credentials.project_id
-elif key_path.endswith('.p12'):
-raise AirflowException('Legacy P12 key file are not supported, 
'
-   'use a JSON key file.')
-else:
-raise AirflowException('Unrecognised extension for key file.')
-else:
-# Get credentials from JSON data provided in the UI.
-try:
-assert keyfile_dict is not None
-keyfile_dict_json = json.loads(keyfile_dict)  # type: 
Dict[str, str]
-
-# Depending on how the JSON was formatted, it may contain
-# escaped newlines. Convert those to actual newlines.
-keyfile_dict_json['private_key'] = 
keyfile_dict_json['private_key'].replace(
-'\\n', '\n')
-
-credentials = (
-
google.oauth2.service_account.Credentials.from_service_account_info(
-keyfile_dict_json, 

[GitHub] [airflow] mik-laj commented on a change in pull request #6123: [AIRFLOW-5502][depends on AIRFLOW-5498, AIRFLOW-5499] Move GCP base hook to core

2019-09-18 Thread GitBox
mik-laj commented on a change in pull request #6123: [AIRFLOW-5502][depends on 
AIRFLOW-5498, AIRFLOW-5499] Move GCP base hook to core
URL: https://github.com/apache/airflow/pull/6123#discussion_r325936746
 
 

 ##
 File path: airflow/contrib/operators/google_api_to_s3_transfer.py
 ##
 @@ -16,162 +16,14 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-#
-"""
-This module allows you to transfer data from any Google API endpoint into a S3 
Bucket.
-"""
-import json
-import sys
-
-from airflow.models import BaseOperator
-from airflow.models.xcom import MAX_XCOM_SIZE
-from airflow.utils.decorators import apply_defaults
-
-from airflow.contrib.hooks.google_discovery_api_hook import 
GoogleDiscoveryApiHook
-from airflow.hooks.S3_hook import S3Hook
-
-
-class GoogleApiToS3Transfer(BaseOperator):
-"""
-Basic class for transferring data from a Google API endpoint into a S3 
Bucket.
-
-:param google_api_service_name: The specific API service that is being 
requested.
-:type google_api_service_name: str
-:param google_api_service_version: The version of the API that is being 
requested.
-:type google_api_service_version: str
-:param google_api_endpoint_path: The client libraries path to the api 
call's executing method.
-For example: 'analyticsreporting.reports.batchGet'
-
-.. note:: See https://developers.google.com/apis-explorer
-for more information on which methods are available.
-
-:type google_api_endpoint_path: str
-:param google_api_endpoint_params: The params to control the corresponding 
endpoint result.
-:type google_api_endpoint_params: dict
-:param s3_destination_key: The url where to put the data retrieved from 
the endpoint in S3.
-:type s3_destination_key: str
-:param google_api_response_via_xcom: Can be set to expose the google api 
response to xcom.
-:type google_api_response_via_xcom: str
-:param google_api_endpoint_params_via_xcom: If set to a value this value 
will be used as a key
-for pulling from xcom and updating the google api endpoint params.
-:type google_api_endpoint_params_via_xcom: str
-:param google_api_endpoint_params_via_xcom_task_ids: Task ids to filter 
xcom by.
-:type google_api_endpoint_params_via_xcom_task_ids: str or list of str
-:param google_api_pagination: If set to True Pagination will be enabled 
for this request
-to retrieve all data.
-
-.. note:: This means the response will be a list of responses.
-
-:type google_api_pagination: bool
-:param google_api_num_retries: Define the number of retries for the google 
api requests being made
-if it fails.
-:type google_api_num_retries: int
-:param s3_overwrite: Specifies whether the s3 file will be overwritten if 
exists.
-:type s3_overwrite: bool
-:param gcp_conn_id: The connection ID to use when fetching connection info.
-:type gcp_conn_id: string
-:param delegate_to: The account to impersonate, if any.
-For this to work, the service account making the request must have
-domain-wide delegation enabled.
-:type delegate_to: string
-:param aws_conn_id: The connection id specifying the authentication 
information for the S3 Bucket.
-:type aws_conn_id: str
-"""
-
-template_fields = (
-'google_api_endpoint_params',
-'s3_destination_key',
-)
-template_ext = ()
-ui_color = '#cc181e'
-
-@apply_defaults
-def __init__(
-self,
-google_api_service_name,
-google_api_service_version,
-google_api_endpoint_path,
-google_api_endpoint_params,
-s3_destination_key,
-*args,
-google_api_response_via_xcom=None,
-google_api_endpoint_params_via_xcom=None,
-google_api_endpoint_params_via_xcom_task_ids=None,
-google_api_pagination=False,
-google_api_num_retries=0,
-s3_overwrite=False,
-gcp_conn_id='google_cloud_default',
-delegate_to=None,
-aws_conn_id='aws_default',
-**kwargs
-):
-super(GoogleApiToS3Transfer, self).__init__(*args, **kwargs)
-self.google_api_service_name = google_api_service_name
-self.google_api_service_version = google_api_service_version
-self.google_api_endpoint_path = google_api_endpoint_path
-self.google_api_endpoint_params = google_api_endpoint_params
-self.s3_destination_key = s3_destination_key
-self.google_api_response_via_xcom = google_api_response_via_xcom
-self.google_api_endpoint_params_via_xcom = 
google_api_endpoint_params_via_xcom
-self.google_api_endpoint_params_via_xcom_task_ids = 
google_api_endpoint_params_via_xcom_task_ids
-self.google_api_pagination = google_api_pagination
-self.google_api_num_retries = google_api_num_retries
-

[GitHub] [airflow] mik-laj commented on a change in pull request #6123: [AIRFLOW-5502][depends on AIRFLOW-5498, AIRFLOW-5499] Move GCP base hook to core

2019-09-18 Thread GitBox
mik-laj commented on a change in pull request #6123: [AIRFLOW-5502][depends on 
AIRFLOW-5498, AIRFLOW-5499] Move GCP base hook to core
URL: https://github.com/apache/airflow/pull/6123#discussion_r325936701
 
 

 ##
 File path: airflow/contrib/hooks/google_discovery_api_hook.py
 ##
 @@ -16,132 +16,14 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-#
-"""
-This module allows you to connect to the Google Discovery API Service and 
query it.
-"""
-from googleapiclient.discovery import build
-
-from airflow.contrib.hooks.gcp_api_base_hook import GoogleCloudBaseHook
-
-
-class GoogleDiscoveryApiHook(GoogleCloudBaseHook):
-"""
-A hook to use the Google API Discovery Service.
-
-:param api_service_name: The name of the api service that is needed to get 
the data
-for example 'youtube'.
-:type api_service_name: str
-:param api_version: The version of the api that will be requested for 
example 'v3'.
-:type api_version: str
-:param gcp_conn_id: The connection ID to use when fetching connection info.
-:type gcp_conn_id: str
-:param delegate_to: The account to impersonate, if any.
-For this to work, the service account making the request must have
-domain-wide delegation enabled.
-:type delegate_to: str
-"""
-_conn = None
-
-def __init__(self, api_service_name, api_version, 
gcp_conn_id='google_cloud_default', delegate_to=None):
-super(GoogleDiscoveryApiHook, self).__init__(gcp_conn_id=gcp_conn_id, 
delegate_to=delegate_to)
-self.api_service_name = api_service_name
-self.api_version = api_version
-
-def get_conn(self):
-"""
-Creates an authenticated api client for the given api service name and 
credentials.
-
-:return: the authenticated api service.
-:rtype: Resource
-"""
-self.log.info("Authenticating Google API Client")
-
-if not self._conn:
-http_authorized = self._authorize()
-self._conn = build(
-serviceName=self.api_service_name,
-version=self.api_version,
-http=http_authorized,
-cache_discovery=False
-)
-return self._conn
-
-def query(self, endpoint, data, paginate=False, num_retries=0):
-"""
-Creates a dynamic API call to any Google API registered in Google's 
API Client Library
-and queries it.
-
-:param endpoint: The client libraries path to the api call's executing 
method.
-For example: 'analyticsreporting.reports.batchGet'
-
-.. seealso:: https://developers.google.com/apis-explorer
-for more information on what methods are available.
-:type endpoint: str
-:param data: The data (endpoint params) needed for the specific 
request to given endpoint.
-:type data: dict
-:param paginate: If set to True, it will collect all pages of data.
-:type paginate: bool
-:param num_retries: Define the number of retries for the requests 
being made if it fails.
-:type num_retries: int
-:return: the API response from the passed endpoint.
-:rtype: dict
-"""
-google_api_conn_client = self.get_conn()
-
-api_response = self._call_api_request(google_api_conn_client, 
endpoint, data, paginate, num_retries)
-return api_response
-
-def _call_api_request(self, google_api_conn_client, endpoint, data, 
paginate, num_retries):
-api_endpoint_parts = endpoint.split('.')
-
-google_api_endpoint_instance = self._build_api_request(
-google_api_conn_client,
-api_sub_functions=api_endpoint_parts[1:],
-api_endpoint_params=data
-)
-
-if paginate:
-return self._paginate_api(
-google_api_endpoint_instance, google_api_conn_client, 
api_endpoint_parts, num_retries
-)
-
-return google_api_endpoint_instance.execute(num_retries=num_retries)
-
-def _build_api_request(self, google_api_conn_client, api_sub_functions, 
api_endpoint_params):
-for sub_function in api_sub_functions:
-google_api_conn_client = getattr(google_api_conn_client, 
sub_function)
-if sub_function != api_sub_functions[-1]:
-google_api_conn_client = google_api_conn_client()
-else:
-google_api_conn_client = 
google_api_conn_client(**api_endpoint_params)
-
-return google_api_conn_client
-
-def _paginate_api(
-self, google_api_endpoint_instance, google_api_conn_client, 
api_endpoint_parts, num_retries
-):
-api_responses = []
-
-while google_api_endpoint_instance:
-api_response = 
google_api_endpoint_instance.execute(num_retries=num_retries)
-api_responses.append(api_response)
-

[GitHub] [airflow] mik-laj commented on a change in pull request #6123: [AIRFLOW-5502][depends on AIRFLOW-5498, AIRFLOW-5499] Move GCP base hook to core

2019-09-18 Thread GitBox
mik-laj commented on a change in pull request #6123: [AIRFLOW-5502][depends on 
AIRFLOW-5498, AIRFLOW-5499] Move GCP base hook to core
URL: https://github.com/apache/airflow/pull/6123#discussion_r325936838
 
 

 ##
 File path: airflow/contrib/utils/gcp_field_validator.py
 ##
 @@ -16,417 +16,20 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-"""Validator for body fields sent via GCP API.
-
-The validator performs validation of the body (being dictionary of fields) that
-is sent in the API request to Google Cloud (via googleclient API usually).
-
-Context

-The specification mostly focuses on helping Airflow DAG developers in the 
development
-phase. You can build your own GCP operator (such as GcfDeployOperator for 
example) which
-can have built-in validation specification for the particular API. It's super 
helpful
-when developer plays with different fields and their values at the initial 
phase of
-DAG development. Most of the Google Cloud APIs perform their own validation on 
the
-server side, but most of the requests are asynchronous and you need to wait 
for result
-of the operation. This takes precious times and slows
-down iteration over the API. BodyFieldValidator is meant to be used on the 
client side
-and it should therefore provide an instant feedback to the developer on 
misspelled or
-wrong type of parameters.
-
-The validation should be performed in "execute()" method call in order to allow
-template parameters to be expanded before validation is performed.
-
-Types of fields

-
-Specification is an array of dictionaries - each dictionary describes field, 
its type,
-validation, optionality, api_version supported and nested fields (for unions 
and dicts).
-
-Typically (for clarity and in order to aid syntax highlighting) the array of
-dicts should be defined as series of dict() executions. Fragment of example
-specification might look as follows::
-
-SPECIFICATION =[
-   dict(name="an_union", type="union", optional=True, fields=[
-   dict(name="variant_1", type="dict"),
-   dict(name="variant_2", regexp=r'^.+$', api_version='v1beta2'),
-   ),
-   dict(name="an_union", type="dict", fields=[
-   dict(name="field_1", type="dict"),
-   dict(name="field_2", regexp=r'^.+$'),
-   ),
-   ...
-]
-
-
-Each field should have key = "name" indicating field name. The field can be of 
one of the
-following types:
-
-* Dict fields: (key = "type", value="dict"):
-  Field of this type should contain nested fields in form of an array of dicts.
-  Each of the fields in the array is then expected (unless marked as optional)
-  and validated recursively. If an extra field is present in the dictionary, 
warning is
-  printed in log file (but the validation succeeds - see the 
Forward-compatibility notes)
-* List fields: (key = "type", value="list"):
-  Field of this type should be a list. Only the type correctness is validated.
-  The contents of a list are not subject to validation.
-* Union fields (key = "type", value="union"): field of this type should 
contain nested
-  fields in form of an array of dicts. One of the fields (and only one) should 
be
-  present (unless the union is marked as optional). If more than one union 
field is
-  present, FieldValidationException is raised. If none of the union fields is
-  present - warning is printed in the log (see below Forward-compatibility 
notes).
-* Fields validated for non-emptiness: (key = "allow_empty") - this applies 
only to
-  fields the value of which is a string, and it allows to check for 
non-emptiness of
-  the field (allow_empty=False).
-* Regexp-validated fields: (key = "regexp") - fields of this type are assumed 
to be
-  strings and they are validated with the regexp specified. Remember that the 
regexps
-  should ideally contain ^ at the beginning and $ at the end to make sure that
-  the whole field content is validated. Typically such regexp
-  validations should be used carefully and sparingly (see Forward-compatibility
-  notes below).
-* Custom-validated fields: (key = "custom_validation") - fields of this type 
are validated
-  using method specified via custom_validation field. Any exception thrown in 
the custom
-  validation will be turned into FieldValidationException and will cause 
validation to
-  fail. Such custom validations might be used to check numeric fields 
(including
-  ranges of values), booleans or any other types of fields.
-* API version: (key="api_version") if API version is specified, then the field 
will only
-  be validated when api_version used at field validator initialization matches 
exactly the
-  the version specified. If you want to declare fields that are available in 
several
-  versions of the APIs, you should specify the field as many times as many API 
versions
-  should be supported (each time with different 

[GitHub] [airflow] mik-laj commented on issue #6139: [AIRFLOW-5513] Move example_pubsub_flow.py to GCP package

2019-09-18 Thread GitBox
mik-laj commented on issue #6139: [AIRFLOW-5513] Move example_pubsub_flow.py to 
GCP package
URL: https://github.com/apache/airflow/pull/6139#issuecomment-532906210
 
 
   Can you explain the difference between `airflow/  
contrib/example_dags/example_pubsub.py  file and this file? Isn't it worth 
combining these two examples?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] mik-laj edited a comment on issue #6142: [AIRFLOW-5515] Add stacklevel to GCP deprecation warnings

2019-09-18 Thread GitBox
mik-laj edited a comment on issue #6142: [AIRFLOW-5515] Add stacklevel to GCP 
deprecation warnings
URL: https://github.com/apache/airflow/pull/6142#issuecomment-532905478
 
 
   Can you also add stacklevel in following files?
   ```
   airflow/contrib/utils/mlengine_prediction_summary.py
   airflow/contrib/utils/mlengine_operator_utils.py
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] mik-laj commented on issue #6142: [AIRFLOW-5515] Add stacklevel to GCP deprecation warnings

2019-09-18 Thread GitBox
mik-laj commented on issue #6142: [AIRFLOW-5515] Add stacklevel to GCP 
deprecation warnings
URL: https://github.com/apache/airflow/pull/6142#issuecomment-532905478
 
 
   Can you also add stacklevel in following files?
   ``
   airflow/contrib/utils/mlengine_prediction_summary.py
   airflow/contrib/utils/mlengine_operator_utils.py
   ``


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] houqp commented on issue #5407: [AIRFLOW-4741] Include Sentry into core Airflow

2019-09-18 Thread GitBox
houqp commented on issue #5407: [AIRFLOW-4741] Include Sentry into core Airflow
URL: https://github.com/apache/airflow/pull/5407#issuecomment-532901176
 
 
   we are almost there! @tiopi let me know if there is anything I can help to 
get it over the finish line.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (AIRFLOW-5520) DataflowPythonOperator dependency management requires side effects

2019-09-18 Thread Jacob Ferriero (Jira)
Jacob Ferriero created AIRFLOW-5520:
---

 Summary: DataflowPythonOperator dependency management requires 
side effects
 Key: AIRFLOW-5520
 URL: https://issues.apache.org/jira/browse/AIRFLOW-5520
 Project: Apache Airflow
  Issue Type: Improvement
  Components: gcp
Affects Versions: 1.10.2
Reporter: Jacob Ferriero


When using DataflowPythonOperator it is difficult to manage apache beam 
version, (and other python dependencies) without affecting your entire airflow 
environment. It seems the Dataflow hook just submits a subprocess and python 

The operator / hook should be improved to isolate python dependencies for 
running run py_file.

Perhaps this could be achieved in a virtual environment (similar to 
PythonVirtualEnvOperator).

For beam it's often customary to specify a --requirements_file or --setup_file 
to manage python dependencies, we could run one of these in the venv to get it 
setup. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] serkef commented on issue #5557: [AIRFLOW-4928] Move all config parses to class properties

2019-09-18 Thread GitBox
serkef commented on issue #5557: [AIRFLOW-4928] Move all config parses to class 
properties
URL: https://github.com/apache/airflow/pull/5557#issuecomment-532877001
 
 
   @ashb It's good to go


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #5557: [AIRFLOW-4928] Move all config parses to class properties

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #5557: [AIRFLOW-4928] Move all config 
parses to class properties
URL: https://github.com/apache/airflow/pull/5557#issuecomment-510265478
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=h1) 
Report
   > Merging 
[#5557](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/31f19fbd6e826a6af356af4b28636ada6f7567fd?src=pr=desc)
 will **decrease** coverage by `0.6%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5557/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5557  +/-   ##
   ==
   - Coverage   80.05%   79.45%   -0.61% 
   ==
 Files 607  607  
 Lines   3504035042   +2 
   ==
   - Hits2805327841 -212 
   - Misses   6987 7201 +214
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/dagbag.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnYmFnLnB5)
 | `92.52% <100%> (+0.07%)` | :arrow_up: |
   | 
[airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5)
 | `40.74% <0%> (-35.56%)` | :arrow_down: |
   | 
[airflow/utils/log/wasb\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvd2FzYl90YXNrX2hhbmRsZXIucHk=)
 | `32.87% <0%> (-9.59%)` | :arrow_down: |
   | 
[airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5)
 | `84.74% <0%> (-8.48%)` | :arrow_down: |
   | 
[airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5)
 | `88.07% <0%> (-3.67%)` | :arrow_down: |
   | 
[airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5)
 | `84.74% <0%> (-3.39%)` | :arrow_down: |
   | ... and [9 
more](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=footer). 
Last update 
[31f19fb...d70acb4](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #5557: [AIRFLOW-4928] Move all config parses to class properties

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #5557: [AIRFLOW-4928] Move all config 
parses to class properties
URL: https://github.com/apache/airflow/pull/5557#issuecomment-510265478
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=h1) 
Report
   > Merging 
[#5557](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/31f19fbd6e826a6af356af4b28636ada6f7567fd?src=pr=desc)
 will **decrease** coverage by `0.6%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5557/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5557  +/-   ##
   ==
   - Coverage   80.05%   79.45%   -0.61% 
   ==
 Files 607  607  
 Lines   3504035042   +2 
   ==
   - Hits2805327841 -212 
   - Misses   6987 7201 +214
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/dagbag.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnYmFnLnB5)
 | `92.52% <100%> (+0.07%)` | :arrow_up: |
   | 
[airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5)
 | `40.74% <0%> (-35.56%)` | :arrow_down: |
   | 
[airflow/utils/log/wasb\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvd2FzYl90YXNrX2hhbmRsZXIucHk=)
 | `32.87% <0%> (-9.59%)` | :arrow_down: |
   | 
[airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5)
 | `84.74% <0%> (-8.48%)` | :arrow_down: |
   | 
[airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5)
 | `88.07% <0%> (-3.67%)` | :arrow_down: |
   | 
[airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5)
 | `84.74% <0%> (-3.39%)` | :arrow_down: |
   | ... and [9 
more](https://codecov.io/gh/apache/airflow/pull/5557/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=footer). 
Last update 
[31f19fb...d70acb4](https://codecov.io/gh/apache/airflow/pull/5557?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (AIRFLOW-5519) Fix missing apply default in sql_to_gcs operator

2019-09-18 Thread Jarek Potiuk (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-5519.
---
Fix Version/s: 2.0.0
   Resolution: Fixed

> Fix missing apply default in sql_to_gcs operator
> 
>
> Key: AIRFLOW-5519
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5519
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: operators
>Affects Versions: 1.10.4
>Reporter: Yiming Liu
>Assignee: Yiming Liu
>Priority: Major
> Fix For: 2.0.0
>
>
>  
> We don't have a apply_defaults decorator in sql_to_gcs operator, which will 
> cause multi-level argument defaults missing. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5519) Fix missing apply default in sql_to_gcs operator

2019-09-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932843#comment-16932843
 ] 

ASF subversion and git services commented on AIRFLOW-5519:
--

Commit d313d8d24b1969be9154b555dd91466a2489e1c7 in airflow's branch 
refs/heads/master from Yiming Liu
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=d313d8d ]

[AIRFLOW-5519] Fix sql_to_gcs operator missing multi-level default args by 
adding apply_defaults decorator  (#6146)



> Fix missing apply default in sql_to_gcs operator
> 
>
> Key: AIRFLOW-5519
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5519
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: operators
>Affects Versions: 1.10.4
>Reporter: Yiming Liu
>Assignee: Yiming Liu
>Priority: Major
>
>  
> We don't have a apply_defaults decorator in sql_to_gcs operator, which will 
> cause multi-level argument defaults missing. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5519) Fix missing apply default in sql_to_gcs operator

2019-09-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932842#comment-16932842
 ] 

ASF GitHub Bot commented on AIRFLOW-5519:
-

potiuk commented on pull request #6146: [AIRFLOW-5519] Fix sql_to_gcs operator 
missing multi-level default args by adding apply_defaults decorator 
URL: https://github.com/apache/airflow/pull/6146
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix missing apply default in sql_to_gcs operator
> 
>
> Key: AIRFLOW-5519
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5519
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: operators
>Affects Versions: 1.10.4
>Reporter: Yiming Liu
>Assignee: Yiming Liu
>Priority: Major
>
>  
> We don't have a apply_defaults decorator in sql_to_gcs operator, which will 
> cause multi-level argument defaults missing. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] potiuk merged pull request #6146: [AIRFLOW-5519] Fix sql_to_gcs operator missing multi-level default args by adding apply_defaults decorator

2019-09-18 Thread GitBox
potiuk merged pull request #6146: [AIRFLOW-5519] Fix sql_to_gcs operator 
missing multi-level default args by adding apply_defaults decorator 
URL: https://github.com/apache/airflow/pull/6146
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (AIRFLOW-5511) MSSQL resetdb /initdb for 1.10.5 fails to set ti_pool non nullable

2019-09-18 Thread Jarek Potiuk (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-5511.
---
Resolution: Won't Fix

> MSSQL resetdb /initdb for 1.10.5 fails to set ti_pool non nullable
> --
>
> Key: AIRFLOW-5511
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5511
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: celery, database
>Affects Versions: 1.10.5
>Reporter: ROHIT K RAMWAL
>Priority: Minor
> Attachments: airflowbug
>
>
> Airflow 1.10.5 installation with MSSQL backend and celery fails with below 
> error .
>  
> Traceback (most recent call last):
>   File "/bin/airflow", line 32, in 
>     args.func(args)
>   File "/usr/lib/python2.7/site-packages/airflow/bin/cli.py", line 1112, in 
> resetdb
>     db.resetdb(settings.RBAC)
>   File "/usr/lib/python2.7/site-packages/airflow/utils/db.py", line 406, in 
> resetdb
>     initdb(rbac)
>   File "/usr/lib/python2.7/site-packages/airflow/utils/db.py", line 106, in 
> initdb
>     upgradedb()
>   File "/usr/lib/python2.7/site-packages/airflow/utils/db.py", line 377, in 
> upgradedb
>     command.upgrade(config, 'heads')
>   File "/usr/lib/python2.7/site-packages/alembic/command.py", line 279, in 
> upgrade
>     script.run_env()
>   File "/usr/lib/python2.7/site-packages/alembic/script/base.py", line 475, 
> in run_env
>     util.load_python_file(self.dir, "env.py")
>   File "/usr/lib/python2.7/site-packages/alembic/util/pyfiles.py", line 98, 
> in load_python_file
>     module = load_module_py(module_id, path)
>   File "/usr/lib/python2.7/site-packages/alembic/util/compat.py", line 240, 
> in load_module_py
>     mod = imp.load_source(module_id, path, fp)
>   File "/usr/lib/python2.7/site-packages/airflow/migrations/env.py", line 92, 
> in 
>     run_migrations_online()
>   File "/usr/lib/python2.7/site-packages/airflow/migrations/env.py", line 86, 
> in run_migrations_online
>     context.run_migrations()
>   File "", line 8, in run_migrations
>   File "/usr/lib/python2.7/site-packages/alembic/runtime/environment.py", 
> line 846, in run_migrations
>     self.get_context().run_migrations(**kw)
>   File "/usr/lib/python2.7/site-packages/alembic/runtime/migration.py", line 
> 365, in run_migrations
>     step.migration_fn(**kw)
>   File 
> "/usr/lib/python2.7/site-packages/airflow/migrations/versions/6e96a59344a4_make_taskinstance_pool_not_nullable.py",
>  line 101, in upgrade
>     nullable=False,
>   File "/usr/lib64/python2.7/contextlib.py", line 24, in __exit__
>     self.gen.next()
>   File "/usr/lib/python2.7/site-packages/alembic/operations/base.py", line 
> 325, in batch_alter_table
>     impl.flush()
>   File "/usr/lib/python2.7/site-packages/alembic/operations/batch.py", line 
> 79, in flush
>     fn(*arg, **kw)
>   File "/usr/lib/python2.7/site-packages/alembic/ddl/mssql.py", line 85, in 
> alter_column
>     **kw
>   File "/usr/lib/python2.7/site-packages/alembic/ddl/impl.py", line 172, in 
> alter_column
>     existing_comment=existing_comment,
>   File "/usr/lib/python2.7/site-packages/alembic/ddl/mssql.py", line 36, in 
> _exec
>     result = super(MSSQLImpl, self)._exec(construct, *args, **kw)
>   File "/usr/lib/python2.7/site-packages/alembic/ddl/impl.py", line 134, in 
> _exec
>     return conn.execute(construct, *multiparams, **params)
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 
> 988, in execute
>     return meth(self, multiparams, params)
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/sql/ddl.py", line 72, 
> in _execute_on_connection
>     return connection._execute_ddl(self, multiparams, params)
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 
> 1050, in _execute_ddl
>     compiled,
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 
> 1253, in _execute_context
>     e, statement, parameters, cursor, context
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 
> 1473, in _handle_dbapi_exception
>     util.raise_from_cause(sqlalchemy_exception, exc_info)
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/util/compat.py", line 
> 398, in raise_from_cause
>     reraise(type(exception), exception, tb=exc_tb, cause=cause)
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 
> 1249, in _execute_context
>     cursor, statement, parameters, context
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/default.py", 
> line 552, in do_execute
>     cursor.execute(statement, parameters)
> sqlalchemy.exc.ProgrammingError: (pyodbc.ProgrammingError) ('42000', "[42000] 
> [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The index 'ti_pool' is 
> dependent on column 'pool'. (5074) 

[jira] [Commented] (AIRFLOW-5511) MSSQL resetdb /initdb for 1.10.5 fails to set ti_pool non nullable

2019-09-18 Thread Jarek Potiuk (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932791#comment-16932791
 ] 

Jarek Potiuk commented on AIRFLOW-5511:
---

Mssql is not supported officially and we are not going to fix it. 
MySQL/Postgres/SQLite are the only officially supported backends.

> MSSQL resetdb /initdb for 1.10.5 fails to set ti_pool non nullable
> --
>
> Key: AIRFLOW-5511
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5511
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: celery, database
>Affects Versions: 1.10.5
>Reporter: ROHIT K RAMWAL
>Priority: Minor
> Attachments: airflowbug
>
>
> Airflow 1.10.5 installation with MSSQL backend and celery fails with below 
> error .
>  
> Traceback (most recent call last):
>   File "/bin/airflow", line 32, in 
>     args.func(args)
>   File "/usr/lib/python2.7/site-packages/airflow/bin/cli.py", line 1112, in 
> resetdb
>     db.resetdb(settings.RBAC)
>   File "/usr/lib/python2.7/site-packages/airflow/utils/db.py", line 406, in 
> resetdb
>     initdb(rbac)
>   File "/usr/lib/python2.7/site-packages/airflow/utils/db.py", line 106, in 
> initdb
>     upgradedb()
>   File "/usr/lib/python2.7/site-packages/airflow/utils/db.py", line 377, in 
> upgradedb
>     command.upgrade(config, 'heads')
>   File "/usr/lib/python2.7/site-packages/alembic/command.py", line 279, in 
> upgrade
>     script.run_env()
>   File "/usr/lib/python2.7/site-packages/alembic/script/base.py", line 475, 
> in run_env
>     util.load_python_file(self.dir, "env.py")
>   File "/usr/lib/python2.7/site-packages/alembic/util/pyfiles.py", line 98, 
> in load_python_file
>     module = load_module_py(module_id, path)
>   File "/usr/lib/python2.7/site-packages/alembic/util/compat.py", line 240, 
> in load_module_py
>     mod = imp.load_source(module_id, path, fp)
>   File "/usr/lib/python2.7/site-packages/airflow/migrations/env.py", line 92, 
> in 
>     run_migrations_online()
>   File "/usr/lib/python2.7/site-packages/airflow/migrations/env.py", line 86, 
> in run_migrations_online
>     context.run_migrations()
>   File "", line 8, in run_migrations
>   File "/usr/lib/python2.7/site-packages/alembic/runtime/environment.py", 
> line 846, in run_migrations
>     self.get_context().run_migrations(**kw)
>   File "/usr/lib/python2.7/site-packages/alembic/runtime/migration.py", line 
> 365, in run_migrations
>     step.migration_fn(**kw)
>   File 
> "/usr/lib/python2.7/site-packages/airflow/migrations/versions/6e96a59344a4_make_taskinstance_pool_not_nullable.py",
>  line 101, in upgrade
>     nullable=False,
>   File "/usr/lib64/python2.7/contextlib.py", line 24, in __exit__
>     self.gen.next()
>   File "/usr/lib/python2.7/site-packages/alembic/operations/base.py", line 
> 325, in batch_alter_table
>     impl.flush()
>   File "/usr/lib/python2.7/site-packages/alembic/operations/batch.py", line 
> 79, in flush
>     fn(*arg, **kw)
>   File "/usr/lib/python2.7/site-packages/alembic/ddl/mssql.py", line 85, in 
> alter_column
>     **kw
>   File "/usr/lib/python2.7/site-packages/alembic/ddl/impl.py", line 172, in 
> alter_column
>     existing_comment=existing_comment,
>   File "/usr/lib/python2.7/site-packages/alembic/ddl/mssql.py", line 36, in 
> _exec
>     result = super(MSSQLImpl, self)._exec(construct, *args, **kw)
>   File "/usr/lib/python2.7/site-packages/alembic/ddl/impl.py", line 134, in 
> _exec
>     return conn.execute(construct, *multiparams, **params)
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 
> 988, in execute
>     return meth(self, multiparams, params)
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/sql/ddl.py", line 72, 
> in _execute_on_connection
>     return connection._execute_ddl(self, multiparams, params)
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 
> 1050, in _execute_ddl
>     compiled,
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 
> 1253, in _execute_context
>     e, statement, parameters, cursor, context
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 
> 1473, in _handle_dbapi_exception
>     util.raise_from_cause(sqlalchemy_exception, exc_info)
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/util/compat.py", line 
> 398, in raise_from_cause
>     reraise(type(exception), exception, tb=exc_tb, cause=cause)
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 
> 1249, in _execute_context
>     cursor, statement, parameters, context
>   File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/default.py", 
> line 552, in do_execute
>     cursor.execute(statement, parameters)
> sqlalchemy.exc.ProgrammingError: (pyodbc.ProgrammingError) 

[GitHub] [airflow] potiuk commented on a change in pull request #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
potiuk commented on a change in pull request #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#discussion_r325870554
 
 

 ##
 File path: setup.py
 ##
 @@ -216,9 +216,7 @@ def write_version(filename: str = 
os.path.join(*["airflow", "git_version"])):
 ]
 grpc = ['grpcio>=1.15.0']
 flask_oauth = [
 
 Review comment:
   I think it should be renamed to "oauth" :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (AIRFLOW-5514) No implicit optional flag for mypy

2019-09-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932781#comment-16932781
 ] 

ASF GitHub Bot commented on AIRFLOW-5514:
-

potiuk commented on pull request #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> No implicit optional flag for mypy 
> ---
>
> Key: AIRFLOW-5514
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5514
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 1.10.5
>Reporter: Tobiasz Kedzierski
>Assignee: Tobiasz Kedzierski
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5514) No implicit optional flag for mypy

2019-09-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932782#comment-16932782
 ] 

ASF subversion and git services commented on AIRFLOW-5514:
--

Commit 31f19fbd6e826a6af356af4b28636ada6f7567fd in airflow's branch 
refs/heads/master from TobKed
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=31f19fb ]

[AIRFLOW-5514] No implicit optional flag for mypy (#6141)



> No implicit optional flag for mypy 
> ---
>
> Key: AIRFLOW-5514
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5514
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 1.10.5
>Reporter: Tobiasz Kedzierski
>Assignee: Tobiasz Kedzierski
>Priority: Minor
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (AIRFLOW-5514) No implicit optional flag for mypy

2019-09-18 Thread Jarek Potiuk (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-5514.
---
Fix Version/s: 2.0.0
   Resolution: Fixed

> No implicit optional flag for mypy 
> ---
>
> Key: AIRFLOW-5514
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5514
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 1.10.5
>Reporter: Tobiasz Kedzierski
>Assignee: Tobiasz Kedzierski
>Priority: Minor
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] potiuk merged pull request #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
potiuk merged pull request #6141: [AIRFLOW-5514] No implicit optional flag for 
mypy
URL: https://github.com/apache/airflow/pull/6141
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6141: [AIRFLOW-5514] No implicit optional 
flag for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io commented on issue #6141: [AIRFLOW-5514] No implicit optional flag for mypy

2019-09-18 Thread GitBox
codecov-io commented on issue #6141: [AIRFLOW-5514] No implicit optional flag 
for mypy
URL: https://github.com/apache/airflow/pull/6141#issuecomment-532842617
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=h1) 
Report
   > Merging 
[#6141](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `97.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6141/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6141  +/-   ##
   ==
   + Coverage   80.02%   80.05%   +0.03% 
   ==
 Files 607  607  
 Lines   3503235036   +4 
   ==
   + Hits2803428049  +15 
   + Misses   6998 6987  -11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/bigquery\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmlncXVlcnlfdG9fbXlzcWwucHk=)
 | `74% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/trigger\_dag.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC90cmlnZ2VyX2RhZy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/slack\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc2xhY2tfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `91.97% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYXV0b21sLnB5)
 | `99.17% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `81.68% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/translate.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdHJhbnNsYXRlLnB5)
 | `86.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `55.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5)
 | `95.75% <ø> (ø)` | :arrow_up: |
   | ... and [60 
more](https://codecov.io/gh/apache/airflow/pull/6141/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=footer). 
Last update 
[7ad1544...1e5e26b](https://codecov.io/gh/apache/airflow/pull/6141?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io edited a comment on issue #6140: [AIRFLOW-3753] Replace 
Flask-OAuthlib with Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io commented on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

2019-09-18 Thread GitBox
codecov-io commented on issue #6140: [AIRFLOW-3753] Replace Flask-OAuthlib with 
Authlib
URL: https://github.com/apache/airflow/pull/6140#issuecomment-532830925
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=h1) 
Report
   > Merging 
[#6140](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7ad1544303c79c4ce9704a53dc6f7f5f1a9e8033?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6140/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6140  +/-   ##
   ==
   + Coverage   80.02%   80.02%   +<.01% 
   ==
 Files 607  607  
 Lines   3503235041   +9 
   ==
   + Hits2803428042   +8 
   - Misses   6998 6999   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `58.8% <0%> (-0.19%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.43% <0%> (+1.52%)` | :arrow_up: |
   | 
[airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/6140/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5)
 | `90% <0%> (+5%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=footer). 
Last update 
[7ad1544...1016311](https://codecov.io/gh/apache/airflow/pull/6140?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] mik-laj commented on issue #6145: [AIRFLOW-5518] Use correct scheme for Http connection parsed from URI

2019-09-18 Thread GitBox
mik-laj commented on issue #6145: [AIRFLOW-5518] Use correct scheme for Http 
connection parsed from URI
URL: https://github.com/apache/airflow/pull/6145#issuecomment-532820914
 
 
   Can you look at this PR? 
   https://github.com/apache/airflow/pull/5239
   I once started working on it, but I didn't find time to finish it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-18 Thread GitBox
dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key 
in SSHHook
URL: https://github.com/apache/airflow/pull/6104#issuecomment-532817543
 
 
   I did provide an example connection string in the documentation file, 
following the example with existing param `key_file`.  I did not warn against 
including creds in code, though.  On that, I am definitely sympathetic to your 
concern, but I guess my thought is it's a type of general advice that is not 
specific to this operator, or to airflow for that matter.  
   
   I think providing connection string examples in docstings is not a terrible 
idea.  In this case it's pretty straightforward to figure out because you see 
very cleary how it pulls the value from extras, along with the others.  For 
some reason with GCP connections I remember being very confused trying to 
traceback how to get the keyfile info to the right place.
   
   I ended up writing a connection string generator that I use when adding new 
types of connections to our setup.   Maybe including something like that, as a 
part of the hook, is a possibility.  But could be confusing as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] andrejbaran commented on issue #5281: WIP: [AIRFLOW-4506] Make GIT_SYNC_DEPTH and GIT_SYNC_REV configurable

2019-09-18 Thread GitBox
andrejbaran commented on issue #5281: WIP: [AIRFLOW-4506] Make GIT_SYNC_DEPTH 
and GIT_SYNC_REV configurable
URL: https://github.com/apache/airflow/pull/5281#issuecomment-532807657
 
 
   @mik-laj @dimberman hey guys, sorry for not responding. I will try to finish 
this up next week.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] seelmann commented on issue #5908: Revert "[AIRFLOW-4797] Improve performance and behaviour of zombie de…

2019-09-18 Thread GitBox
seelmann commented on issue #5908: Revert "[AIRFLOW-4797] Improve performance 
and behaviour of zombie de…
URL: https://github.com/apache/airflow/pull/5908#issuecomment-532800702
 
 
   The 2nd commit should fix the zombie detection issue. I was not able yet to 
test it in our environment, cannot promise if I can find time soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] widewing commented on issue #2830: [AIRFLOW-342] Do not use amqp, rpc as result backend

2019-09-18 Thread GitBox
widewing commented on issue #2830: [AIRFLOW-342] Do not use amqp, rpc as result 
backend
URL: https://github.com/apache/airflow/pull/2830#issuecomment-532797066
 
 
   Can you explain a little bit more? Why we need to store result long enough? 
I use redis as result backend for a long time and not experiencing any issue .
   Also this commit exposes the connection information (including password) 
directly to the log, I think it's a serious security vulnerability.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (AIRFLOW-5519) Fix missing apply default in sql_to_gcs operator

2019-09-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932674#comment-16932674
 ] 

ASF GitHub Bot commented on AIRFLOW-5519:
-

yimingl17 commented on pull request #6146: [AIRFLOW-5519] Fix sql_to_gcs 
operator missing multi-level default args by adding apply_defaults decorator 
URL: https://github.com/apache/airflow/pull/6146
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. 
 - https://issues.apache.org/jira/browse/AIRFLOW-5519
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   The apply_defaults decorator is missing in sql_to_gcs operator 
(BaseSQLToGoogleCloudStorageOperator), which will cause missing multi-level 
default args such as google_cloud_storage_conn_id. 
   
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
 1. Subject is separated from body by a blank line
 1. Subject is limited to 50 characters (not including Jira issue reference)
 1. Subject does not end with a period
 1. Subject uses the imperative mood ("add", not "adding")
 1. Body wraps at 72 characters
 1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
 - All the public functions and the classes in the PR contain docstrings 
that explain what it does
 - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix missing apply default in sql_to_gcs operator
> 
>
> Key: AIRFLOW-5519
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5519
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: operators
>Affects Versions: 1.10.4
>Reporter: Yiming Liu
>Assignee: Yiming Liu
>Priority: Major
>
>  
> We don't have a apply_defaults decorator in sql_to_gcs operator, which will 
> cause multi-level argument defaults missing. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] yimingl17 opened a new pull request #6146: [AIRFLOW-5519] Fix sql_to_gcs operator missing multi-level default args by adding apply_defaults decorator

2019-09-18 Thread GitBox
yimingl17 opened a new pull request #6146: [AIRFLOW-5519] Fix sql_to_gcs 
operator missing multi-level default args by adding apply_defaults decorator 
URL: https://github.com/apache/airflow/pull/6146
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. 
 - https://issues.apache.org/jira/browse/AIRFLOW-5519
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   The apply_defaults decorator is missing in sql_to_gcs operator 
(BaseSQLToGoogleCloudStorageOperator), which will cause missing multi-level 
default args such as google_cloud_storage_conn_id. 
   
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
 1. Subject is separated from body by a blank line
 1. Subject is limited to 50 characters (not including Jira issue reference)
 1. Subject does not end with a period
 1. Subject uses the imperative mood ("add", not "adding")
 1. Body wraps at 72 characters
 1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
 - All the public functions and the classes in the PR contain docstrings 
that explain what it does
 - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (AIRFLOW-5518) Mix between scheme and schema for HTTP connections

2019-09-18 Thread Mickael V (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mickael V updated AIRFLOW-5518:
---
Labels: pull-request-available  (was: )

> Mix between scheme and schema for HTTP connections
> --
>
> Key: AIRFLOW-5518
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5518
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: hooks
>Affects Versions: 1.10.5
>Reporter: Mickael V
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.10.6
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> There is an inconsistence in the usage of *scheme* and *schema* when using an 
> HTTP connection.
> If the connection is made through the UI or imported through config files (or 
> to sum up, if it's kept in the Airflow DB), the *schema* represents the 
> *scheme* ({{http}}, {{https}}).
> But if the connection is parsed from a URI (for example if it's overloaded 
> through an environment variable), the {{schema}} is the {{path}} or the URI.
> This is wrong because then the {{HttpHook}} uses the {{schema}} to prefix the 
> {{base_url}}. It is particularly visible when using https, which gets 
> transformed to default http. As a result the URLs are built with HTTP instead 
> of HTTPS.
>  
> There are two possibilities that I see to fix this :
>  * At the {{Connection}} level, in {{parse_from_uri()}}, implement a special 
> treatment for http connection to have {{conn_type='http'}} and 
> {{schema=scheme}}
>  * At the {{HttpHook}} level, in {{get_conn}}, look up {{conn_type}} to get 
> the real {{scheme}}.
>  
> I propose using the first solution, as it is more consistent with what 
> happens when a connection is added through other ways (UI and config files).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] pgagnon commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-18 Thread GitBox
pgagnon commented on issue #6104: [AIRFLOW-4574] allow providing private_key in 
SSHHook
URL: https://github.com/apache/airflow/pull/6104#issuecomment-532774200
 
 
   @dstandish I see your point. My issue with this is that from the user's 
standpoint it's much less intuitive to figure out how to add a private key to a 
connection contrasted with a password, which is a standard connection field. 
Perhaps we could update the docs/docstring to provide an example and warn users 
against hardcoding keys in their dags?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (AIRFLOW-5147) Annotations for k8s executors should support extended alphabet (like '/'))

2019-09-18 Thread Tao Feng (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tao Feng resolved AIRFLOW-5147.
---
Resolution: Fixed

> Annotations for k8s executors should support extended alphabet (like '/')) 
> ---
>
> Key: AIRFLOW-5147
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5147
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: executor-kubernetes, executors
>Affects Versions: 1.10.3, 1.10.4
>Reporter: Andrei Loginov
>Assignee: Daniel Imberman
>Priority: Major
>
> The fix to introduce k8s annotations for executors 
> ([https://github.com/apache/airflow/pull/4589] for 
> https://issues.apache.org/jira/browse/AIRFLOW-3766) limited the character set 
> allowed for the annotation key to [-._a-zA-Z0-9] set. However many 
> annotations contain `/` in it, for example: 
> {code:java}
> injector.tumblr.com/request{code}
>  or
> {code:java}
> iam.amazonaws.com/role{code}
> Which would not be allowed in the current solution.
>  
> I believe original solution should be completely revisited. And instead of 
> using a separate *kubernetes_annotations* section there should be a key which 
> will contain a set of key:value annotations in some format. E.g. json:
> {code:java}
> [kubernetes]
> annotations = { "iam.amazonaws.com/role": 
> "arn:aws:iam:::role/some-role-CKU5HL9BIPXG", "some-other-anno-key": 
> "some/value" }
> {code}
>  
> Supported character set for annotations:
> https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/#syntax-and-character-set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   3   >