[jira] [Updated] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-07-07 Thread Szymon Grzemski (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szymon Grzemski updated AIRFLOW-5071: - Attachment: image-2020-07-08-07-58-42-972.png > Thousand os Executor reports task

[GitHub] [airflow] hlokired commented on issue #9096: Calendar Based Scheduling Pattern - Scheduler Feature in DAG

2020-07-07 Thread GitBox
hlokired commented on issue #9096: URL: https://github.com/apache/airflow/issues/9096#issuecomment-655282131 Hi, Can you please provide the mailer list, when we can discuss with in the group. Thanks, This is

[GitHub] [airflow] jhtimmins opened a new pull request #9716: Remove 3.7 tests for MySQL, Postgres, and Sqlite.

2020-07-07 Thread GitBox
jhtimmins opened a new pull request #9716: URL: https://github.com/apache/airflow/pull/9716 Currently, the test suite involves 70 different test runs. This is in part bc we test Pythons 3.6, 3.7, and 3.8, against multiple different datastores. To reduce the number of tests, and speed up

[GitHub] [airflow] potiuk edited a comment on pull request #9715: create CODE_OF_CONDUCT.md

2020-07-07 Thread GitBox
potiuk edited a comment on pull request #9715: URL: https://github.com/apache/airflow/pull/9715#issuecomment-655273339 cc: @msumit @arthur @Fokko @jghoman @aoen @KevinYang21 @alexvanboxel @ashb @aijamalnk @feng-tao @kaxil @bolkedebruin @criccomini @mistercrunch @hiteshs @saguziel

[GitHub] [airflow] potiuk commented on pull request #9715: create CODE_OF_CONDUCT.md

2020-07-07 Thread GitBox
potiuk commented on pull request #9715: URL: https://github.com/apache/airflow/pull/9715#issuecomment-655273339 cc: @ashb -> we were discussing that we want to add explicit COC indeed. For now we are all bound by the Apache COC http://www.apache.org/foundation/policies/conduct.html and I

[GitHub] [airflow] vlasvlasvlas opened a new pull request #9715: create CODE_OF_CONDUCT.md

2020-07-07 Thread GitBox
vlasvlasvlas opened a new pull request #9715: URL: https://github.com/apache/airflow/pull/9715 hope we can get a code of conduct for issues! thanks :D --- Make sure to mark the boxes below before creating PR: [x] - [ ] Description above provides context of the change - [

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9715: create CODE_OF_CONDUCT.md

2020-07-07 Thread GitBox
boring-cyborg[bot] commented on pull request #9715: URL: https://github.com/apache/airflow/pull/9715#issuecomment-655270213 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] jhtimmins commented on a change in pull request #9597: [WIP] Add read-only endpoints for task instances

2020-07-07 Thread GitBox
jhtimmins commented on a change in pull request #9597: URL: https://github.com/apache/airflow/pull/9597#discussion_r451266925 ## File path: airflow/api_connexion/endpoints/task_instance_endpoint.py ## @@ -14,23 +14,110 @@ # KIND, either express or implied. See the License

[GitHub] [airflow] jhtimmins commented on a change in pull request #9597: [WIP] Add read-only endpoints for task instances

2020-07-07 Thread GitBox
jhtimmins commented on a change in pull request #9597: URL: https://github.com/apache/airflow/pull/9597#discussion_r451266466 ## File path: airflow/api_connexion/endpoints/task_instance_endpoint.py ## @@ -14,23 +14,110 @@ # KIND, either express or implied. See the License

[GitHub] [airflow] jhtimmins commented on issue #8111: Authentication in API

2020-07-07 Thread GitBox
jhtimmins commented on issue #8111: URL: https://github.com/apache/airflow/issues/8111#issuecomment-655258363 @mik-laj I'm a bit confused about the need to have a customizable auth scheme, where the user can pick a common implementation or add their own. Connexion seems to support a small

[airflow] tag nightly-master updated (ac12401 -> 6c15885)

2020-07-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from ac12401 (commit) to 6c15885 (commit) from

[GitHub] [airflow] coopergillan commented on a change in pull request #9517: [AIRFLOW-XXXX] Remove now-inaccurate docstring

2020-07-07 Thread GitBox
coopergillan commented on a change in pull request #9517: URL: https://github.com/apache/airflow/pull/9517#discussion_r451247522 ## File path: airflow/providers/amazon/aws/operators/athena.py ## @@ -28,9 +28,6 @@ class AWSAthenaOperator(BaseOperator): """ An operator

[GitHub] [airflow] alanbrent edited a comment on issue #8212: Can't read S3 remote logs using Airflow 1.10.9

2020-07-07 Thread GitBox
alanbrent edited a comment on issue #8212: URL: https://github.com/apache/airflow/issues/8212#issuecomment-655216002 Can confirm that using a threaded `gunicorn` worker (`gevent` in our case) breaks the web component's ability to show task logs that are in S3. Moving back to `sync` works

[GitHub] [airflow] alanbrent commented on issue #8212: Can't read S3 remote logs using Airflow 1.10.9

2020-07-07 Thread GitBox
alanbrent commented on issue #8212: URL: https://github.com/apache/airflow/issues/8212#issuecomment-655216002 Can confirm that using a threaded `gunicorn` worker (`gevent` in our case) breaks the web component's ability to show task logs that are in S3. Moving back to `sync` works for us,

[GitHub] [airflow] kaxil commented on a change in pull request #9645: Get Airflow configs with sensitive data from Secret Backends

2020-07-07 Thread GitBox
kaxil commented on a change in pull request #9645: URL: https://github.com/apache/airflow/pull/9645#discussion_r451199613 ## File path: docs/howto/set-config.rst ## @@ -73,6 +91,7 @@ The universal order of precedence for all configuration options is as follows: #. set as a

[GitHub] [airflow] kaxil commented on a change in pull request #9645: Get Airflow configs with sensitive data from Secret Backends

2020-07-07 Thread GitBox
kaxil commented on a change in pull request #9645: URL: https://github.com/apache/airflow/pull/9645#discussion_r451199524 ## File path: docs/howto/set-config.rst ## @@ -46,7 +46,18 @@ the key like this: [core] sql_alchemy_conn_cmd = bash_command_to_run -The

[GitHub] [airflow] kaxil commented on a change in pull request #9645: Get Airflow configs with sensitive data from Secret Backends

2020-07-07 Thread GitBox
kaxil commented on a change in pull request #9645: URL: https://github.com/apache/airflow/pull/9645#discussion_r451199040 ## File path: airflow/configuration.py ## @@ -267,17 +278,32 @@ def _get_env_var_option(self, section, key): env_var_cmd = env_var + '_CMD'

[GitHub] [airflow] kaxil commented on a change in pull request #9645: Get Airflow configs with sensitive data from Secret Backends

2020-07-07 Thread GitBox
kaxil commented on a change in pull request #9645: URL: https://github.com/apache/airflow/pull/9645#discussion_r451199109 ## File path: airflow/secrets/base_secrets.py ## @@ -73,3 +75,12 @@ def get_variable(self, key: str) -> Optional[str]: :return: Variable Value

[GitHub] [airflow] kaxil commented on a change in pull request #9645: Get Airflow configs with sensitive data from Secret Backends

2020-07-07 Thread GitBox
kaxil commented on a change in pull request #9645: URL: https://github.com/apache/airflow/pull/9645#discussion_r451196233 ## File path: airflow/configuration.py ## @@ -267,17 +278,32 @@ def _get_env_var_option(self, section, key): env_var_cmd = env_var + '_CMD'

[GitHub] [airflow] kaxil commented on a change in pull request #9452: JSON serialize Log extras

2020-07-07 Thread GitBox
kaxil commented on a change in pull request #9452: URL: https://github.com/apache/airflow/pull/9452#discussion_r451195371 ## File path: airflow/www/decorators.py ## @@ -44,7 +45,7 @@ def wrapper(*args, **kwargs): event=f.__name__,

[jira] [Commented] (AIRFLOW-4431) Gantt chart tab do not showing

2020-07-07 Thread Joy Peterson (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153082#comment-17153082 ] Joy Peterson commented on AIRFLOW-4431: --- [~diederikwp], This is happening for me when I

[GitHub] [airflow] ephraimbuddy opened a new pull request #9714: Move gcs & wasb task handlers to their respective provider packages

2020-07-07 Thread GitBox
ephraimbuddy opened a new pull request #9714: URL: https://github.com/apache/airflow/pull/9714 --- Closes: #9386 This PR completes the move of task log handlers to their providers package. `GCSTaskHandler` and `WasbTaskHandler` have been moved to their respective provider

[GitHub] [airflow] benbenbang opened a new issue #9713: Looping issue using Hashicorp Vault

2020-07-07 Thread GitBox
benbenbang opened a new issue #9713: URL: https://github.com/apache/airflow/issues/9713 - Issue: We encountered an issue that is mainly caused by overloading calls from Airflow to Vault while Vault was experiencing downtime. - Context: A few days ago while Vault was down for

[GitHub] [airflow] tanjinP commented on pull request #9079: [8970] Improve KubernetesPodOperator guide

2020-07-07 Thread GitBox
tanjinP commented on pull request #9079: URL: https://github.com/apache/airflow/pull/9079#issuecomment-655076947 Looks like some static checks failing, will address This is an automated message from the Apache Git Service.

[GitHub] [airflow] royberkoweee commented on pull request #9667: Allow `replace` flag in gcs_to_gcs operator.

2020-07-07 Thread GitBox
royberkoweee commented on pull request #9667: URL: https://github.com/apache/airflow/pull/9667#issuecomment-655068112 Thanks @turbaszek, appreciate all the guidance  This is an automated message from the Apache Git

[GitHub] [airflow] kaxil closed pull request #9427: Remove redundant functions in airflow/security/utils.py

2020-07-07 Thread GitBox
kaxil closed pull request #9427: URL: https://github.com/apache/airflow/pull/9427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch master updated: generate go client from openapi spec (#9502)

2020-07-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 6c15885 generate go client from openapi spec

[airflow] branch master updated: generate go client from openapi spec (#9502)

2020-07-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 6c15885 generate go client from openapi spec

[jira] [Commented] (AIRFLOW-6497) Scheduler creates DagBag in the same process with outdated info

2020-07-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152950#comment-17152950 ] ASF GitHub Bot commented on AIRFLOW-6497: - mik-laj edited a comment on pull request #7597: URL:

[GitHub] [airflow] mik-laj edited a comment on pull request #7597: [AIRFLOW-6497] Avoid loading DAGs in the main scheduler loop

2020-07-07 Thread GitBox
mik-laj edited a comment on pull request #7597: URL: https://github.com/apache/airflow/pull/7597#issuecomment-593430117 It is worth noting that this also solves one more problem. The modules are always reloaded.

[GitHub] [airflow] potiuk merged pull request #9502: generate go client from openapi spec

2020-07-07 Thread GitBox
potiuk merged pull request #9502: URL: https://github.com/apache/airflow/pull/9502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9701: Update Thumbtack points of contact for Airflow

2020-07-07 Thread GitBox
boring-cyborg[bot] commented on pull request #9701: URL: https://github.com/apache/airflow/pull/9701#issuecomment-655019770 Awesome work, congrats on your first merged pull request! This is an automated message from the

[airflow] branch master updated: Update Thumbtack points of contact in Airflow Users list (#9701)

2020-07-07 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 397b33f Update Thumbtack points of contact

[GitHub] [airflow] kaxil merged pull request #9701: Update Thumbtack points of contact for Airflow

2020-07-07 Thread GitBox
kaxil merged pull request #9701: URL: https://github.com/apache/airflow/pull/9701 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] ashb commented on pull request #9636: invoke handleCallback on dag when manually marking a DagRun success/failed from tree view

2020-07-07 Thread GitBox
ashb commented on pull request #9636: URL: https://github.com/apache/airflow/pull/9636#issuecomment-655010166 So this is definitely a missing feature but there are two problems. 1. This PR doesn't have unit tests, and it needs them before it's going to be merged 2. This ends up

[airflow] branch master updated: use the correct claim name in the webserver (#9688)

2020-07-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 502b6ea use the correct claim name in the

[GitHub] [airflow] potiuk commented on pull request #9688: use the correct name in the webserver & configmap when using an existing volume claim

2020-07-07 Thread GitBox
potiuk commented on pull request #9688: URL: https://github.com/apache/airflow/pull/9688#issuecomment-655001610 Cool! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk merged pull request #9688: use the correct name in the webserver & configmap when using an existing volume claim

2020-07-07 Thread GitBox
potiuk merged pull request #9688: URL: https://github.com/apache/airflow/pull/9688 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] kaxil commented on a change in pull request #9670: Make airflow/migrations/env.py Pylint Compatible

2020-07-07 Thread GitBox
kaxil commented on a change in pull request #9670: URL: https://github.com/apache/airflow/pull/9670#discussion_r451015688 ## File path: airflow/migrations/env.py ## @@ -21,7 +21,7 @@ from alembic import context from airflow import models, settings -from

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2020-07-07 Thread Lindsay Portelli (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152897#comment-17152897 ] Lindsay Portelli commented on AIRFLOW-5071: --- Running 1.10.10 deployed on K8s using kubernetes

[GitHub] [airflow] potiuk closed pull request #9706: Specify simple_salesforce version requirements in 1.10.x

2020-07-07 Thread GitBox
potiuk closed pull request #9706: URL: https://github.com/apache/airflow/pull/9706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on pull request #9706: Specify simple_salesforce version requirements in 1.10.x

2020-07-07 Thread GitBox
potiuk commented on pull request #9706: URL: https://github.com/apache/airflow/pull/9706#issuecomment-654980251 I think it should be fine - especially in the future. We are switching to separation of providers to "providers packages". Actually we already have the backport packages that

[GitHub] [airflow] feluelle edited a comment on pull request #7903: Add property conn_name and connection to dbapi_hook

2020-07-07 Thread GitBox
feluelle edited a comment on pull request #7903: URL: https://github.com/apache/airflow/pull/7903#issuecomment-654978821 Please rebase once again - just to be sure. :) It is very long ago since you last pushed a commit.

[GitHub] [airflow] feluelle commented on pull request #7903: Add property conn_name and connection to dbapi_hook

2020-07-07 Thread GitBox
feluelle commented on pull request #7903: URL: https://github.com/apache/airflow/pull/7903#issuecomment-654978821 Please rebase once again - just to be sure. :) This is an automated message from the Apache Git Service. To

[GitHub] [airflow] zhongjiajie edited a comment on pull request #7903: Add property conn_name and connection to dbapi_hook

2020-07-07 Thread GitBox
zhongjiajie edited a comment on pull request #7903: URL: https://github.com/apache/airflow/pull/7903#issuecomment-654977519 Ok, we have +1 here, if no one disapproval here in a few day I will merge this patch to master.

[GitHub] [airflow] zhongjiajie commented on pull request #7903: Add property conn_name and connection to dbapi_hook

2020-07-07 Thread GitBox
zhongjiajie commented on pull request #7903: URL: https://github.com/apache/airflow/pull/7903#issuecomment-654977519 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] zhongjiajie removed a comment on pull request #7903: Add property conn_name and connection to dbapi_hook

2020-07-07 Thread GitBox
zhongjiajie removed a comment on pull request #7903: URL: https://github.com/apache/airflow/pull/7903#issuecomment-654977536 Ok, we have +1 here, if no one disapproval here I will merge this patch to master. This is an

[GitHub] [airflow] zhongjiajie commented on issue #9134: Support Flink operator

2020-07-07 Thread GitBox
zhongjiajie commented on issue #9134: URL: https://github.com/apache/airflow/issues/9134#issuecomment-654976434 I think it depend on what we could add streaming to airflow, if it will task many times, maybe support parts of flink function on flink operator is acceptable.

[GitHub] [airflow] gregbrowndev commented on issue #9707: DockerOperator AWS ECR Login Unauthorised

2020-07-07 Thread GitBox
gregbrowndev commented on issue #9707: URL: https://github.com/apache/airflow/issues/9707#issuecomment-654968688 Apologies, I misunderstood how the Docker Registry connection worked. For anyone else running into this, here is a simple DAG which updates a 'docker_ecr' connection

[GitHub] [airflow] gregbrowndev closed issue #9707: DockerOperator AWS ECR Login Unauthorised

2020-07-07 Thread GitBox
gregbrowndev closed issue #9707: URL: https://github.com/apache/airflow/issues/9707 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on a change in pull request #9670: Make airflow/migrations/env.py Pylint Compatible

2020-07-07 Thread GitBox
potiuk commented on a change in pull request #9670: URL: https://github.com/apache/airflow/pull/9670#discussion_r450980760 ## File path: airflow/migrations/env.py ## @@ -21,7 +21,7 @@ from alembic import context from airflow import models, settings -from

[GitHub] [airflow] potiuk closed issue #9101: Rename all Transfer operators in Providers to XTYOperator convention

2020-07-07 Thread GitBox
potiuk closed issue #9101: URL: https://github.com/apache/airflow/issues/9101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on issue #9101: Rename all Transfer operators in Providers to XTYOperator convention

2020-07-07 Thread GitBox
potiuk commented on issue #9101: URL: https://github.com/apache/airflow/issues/9101#issuecomment-654964030 Indeed! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] coopergillan commented on pull request #9517: [AIRFLOW-XXXX] Remove now-inaccurate docstring

2020-07-07 Thread GitBox
coopergillan commented on pull request #9517: URL: https://github.com/apache/airflow/pull/9517#issuecomment-654955944 @turbaszek - just rebased and cleaned up the wording a bit. Apologies that I didn't see your approval first. Please let me know if it still stands.

[GitHub] [airflow] turbaszek commented on a change in pull request #9517: [AIRFLOW-XXXX] Remove now-inaccurate docstring

2020-07-07 Thread GitBox
turbaszek commented on a change in pull request #9517: URL: https://github.com/apache/airflow/pull/9517#discussion_r450964004 ## File path: airflow/providers/amazon/aws/operators/athena.py ## @@ -28,9 +28,6 @@ class AWSAthenaOperator(BaseOperator): """ An operator

[GitHub] [airflow] turbaszek commented on a change in pull request #9667: Allow `replace` flag in gcs_to_gcs operator.

2020-07-07 Thread GitBox
turbaszek commented on a change in pull request #9667: URL: https://github.com/apache/airflow/pull/9667#discussion_r450960127 ## File path: tests/providers/google/cloud/transfers/test_gcs_to_gcs.py ## @@ -86,6 +86,21 @@ def test_execute_no_suffix(self, mock_hook):

[GitHub] [airflow] turbaszek removed a comment on pull request #9712: Use namedtuple for TaskInstanceKeyType

2020-07-07 Thread GitBox
turbaszek removed a comment on pull request #9712: URL: https://github.com/apache/airflow/pull/9712#issuecomment-654947095 TIL: `NameTuple` is supported by json.loads while `tuple` rises TypeError This is an automated

[GitHub] [airflow] turbaszek commented on pull request #9712: Use namedtuple for TaskInstanceKeyType

2020-07-07 Thread GitBox
turbaszek commented on pull request #9712: URL: https://github.com/apache/airflow/pull/9712#issuecomment-654947095 TIL: `NameTuple` is supported by json.loads while `tuple` rises TypeError This is an automated message from

[GitHub] [airflow] turbaszek opened a new pull request #9712: Use namedtuple for TaskInstanceKeyType

2020-07-07 Thread GitBox
turbaszek opened a new pull request #9712: URL: https://github.com/apache/airflow/pull/9712 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation

[airflow] branch master updated: Fix _process_executor_events method to use in-memory try_number (#9692)

2020-07-07 Thread turbaszek
This is an automated email from the ASF dual-hosted git repository. turbaszek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 4ad3bb5 Fix _process_executor_events

[GitHub] [airflow] turbaszek closed issue #9689: Exception when executing execute_helper

2020-07-07 Thread GitBox
turbaszek closed issue #9689: URL: https://github.com/apache/airflow/issues/9689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] turbaszek merged pull request #9692: Fix _process_executor_events method to use in-memory try_number

2020-07-07 Thread GitBox
turbaszek merged pull request #9692: URL: https://github.com/apache/airflow/pull/9692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] turbaszek commented on issue #9101: Rename all Transfer operators in Providers to XTYOperator convention

2020-07-07 Thread GitBox
turbaszek commented on issue #9101: URL: https://github.com/apache/airflow/issues/9101#issuecomment-654920252 I think it's already done @potiuk ? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj commented on issue #9708: Increase typing coverage

2020-07-07 Thread GitBox
mik-laj commented on issue #9708: URL: https://github.com/apache/airflow/issues/9708#issuecomment-654908258 @coopergillan I assigned you to this ticket. When you create a PR, add a link to this ticket so that others can see your work.

[GitHub] [airflow] 51yu commented on issue #9213: FILTER_BY_ONWER does not work for multi-owner dags

2020-07-07 Thread GitBox
51yu commented on issue #9213: URL: https://github.com/apache/airflow/issues/9213#issuecomment-654906639 @kaxil Thanks for helping. I create another relevant issue https://github.com/apache/airflow/issues/9711 This is an

[GitHub] [airflow] 51yu opened a new issue #9711: airflow 1.10 filter logs based on DAG owner

2020-07-07 Thread GitBox
51yu opened a new issue #9711: URL: https://github.com/apache/airflow/issues/9711 **Apache Airflow version**: 1.10 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): not k8s issue **Environment**: linux **What happened**: when

[GitHub] [airflow] kaxil commented on issue #9213: FILTER_BY_ONWER does not work for multi-owner dags

2020-07-07 Thread GitBox
kaxil commented on issue #9213: URL: https://github.com/apache/airflow/issues/9213#issuecomment-654904122 That commit is 4 years old :D so something else might have reverted back that behaviour. I will mark it for 1.10.12

[GitHub] [airflow] coopergillan commented on issue #9708: Increase typing coverage

2020-07-07 Thread GitBox
coopergillan commented on issue #9708: URL: https://github.com/apache/airflow/issues/9708#issuecomment-654895399 Hi @mik-laj - I would love to grab at least one of these providers. May just need a little bit of time  This

[GitHub] [airflow] takunnithan commented on pull request #9556: API Endpoint - DagRuns Batch

2020-07-07 Thread GitBox
takunnithan commented on pull request #9556: URL: https://github.com/apache/airflow/pull/9556#issuecomment-654893895 Hi @mik-laj, Is this good to merge ? Could you please review the PR. This is an automated message from the

[GitHub] [airflow] coopergillan commented on a change in pull request #9517: [AIRFLOW-XXXX] Remove now-inaccurate docstring

2020-07-07 Thread GitBox
coopergillan commented on a change in pull request #9517: URL: https://github.com/apache/airflow/pull/9517#discussion_r450897421 ## File path: airflow/providers/amazon/aws/operators/athena.py ## @@ -28,9 +28,6 @@ class AWSAthenaOperator(BaseOperator): """ An operator

[GitHub] [airflow] coopergillan commented on a change in pull request #9517: [AIRFLOW-XXXX] Remove now-inaccurate docstring

2020-07-07 Thread GitBox
coopergillan commented on a change in pull request #9517: URL: https://github.com/apache/airflow/pull/9517#discussion_r450894155 ## File path: airflow/providers/amazon/aws/operators/athena.py ## @@ -28,9 +28,6 @@ class AWSAthenaOperator(BaseOperator): """ An operator

[GitHub] [airflow] roskoN closed issue #9709: Decouple DAG tagging from RBAC

2020-07-07 Thread GitBox
roskoN closed issue #9709: URL: https://github.com/apache/airflow/issues/9709 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] roskoN commented on issue #9709: Decouple DAG tagging from RBAC

2020-07-07 Thread GitBox
roskoN commented on issue #9709: URL: https://github.com/apache/airflow/issues/9709#issuecomment-654858990 @mik-laj Thank you for the detailed but concise explanation. It perfectly makes sense. And, of course, for those who do not like this, there is an easy workaround.

[GitHub] [airflow] kaxil commented on a change in pull request #9670: Make airflow/migrations/env.py Pylint Compatible

2020-07-07 Thread GitBox
kaxil commented on a change in pull request #9670: URL: https://github.com/apache/airflow/pull/9670#discussion_r450862296 ## File path: airflow/migrations/env.py ## @@ -21,7 +21,7 @@ from alembic import context from airflow import models, settings -from

[GitHub] [airflow] boring-cyborg[bot] commented on issue #9710: airflow.kubernetes module not included in v1.10.10

2020-07-07 Thread GitBox
boring-cyborg[bot] commented on issue #9710: URL: https://github.com/apache/airflow/issues/9710#issuecomment-654848253 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] Nandito4 opened a new issue #9710: airflow.kubernetes module not included in v1.10.10

2020-07-07 Thread GitBox
Nandito4 opened a new issue #9710: URL: https://github.com/apache/airflow/issues/9710 **Apache Airflow version**: 1.10.10 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): v1.15.11 **Environment**: - **Cloud provider or hardware

[GitHub] [airflow] mik-laj edited a comment on issue #9709: Decouple DAG tagging from RBAC

2020-07-07 Thread GitBox
mik-laj edited a comment on issue #9709: URL: https://github.com/apache/airflow/issues/9709#issuecomment-654844898 @roskoN Airflow 2.0 will not have a non-RBAC interface. For this reason, we try to encourage users to use RBAC. One way to do this is to create additional reasons for

[GitHub] [airflow] mik-laj commented on issue #9709: Decouple DAG tagging from RBAC

2020-07-07 Thread GitBox
mik-laj commented on issue #9709: URL: https://github.com/apache/airflow/issues/9709#issuecomment-654844898 @roskoN Airflow 2.0 will not have a non-RBAC interface. For this reason, we try to encourage users to use RBAC. One way to do this is to create additional reasons for migrating to

[GitHub] [airflow] shaneikennedy commented on pull request #9706: Specify simple_salesforce version requirements in 1.10.x

2020-07-07 Thread GitBox
shaneikennedy commented on pull request #9706: URL: https://github.com/apache/airflow/pull/9706#issuecomment-654843321 @potiuk after looking setup.py actually specifies simple-salesforce < 1.0.0 (branch v1-10-test), so I think my installation method was just wrong (got an error for

[GitHub] [airflow] jacobhjkim commented on a change in pull request #7944: Get Airflow Variables from Hashicorp Vault

2020-07-07 Thread GitBox
jacobhjkim commented on a change in pull request #7944: URL: https://github.com/apache/airflow/pull/7944#discussion_r450845896 ## File path: airflow/providers/hashicorp/secrets/vault.py ## @@ -150,7 +156,29 @@ def get_conn_uri(self, conn_id: str) -> Optional[str]:

[GitHub] [airflow] kaxil commented on a change in pull request #7944: Get Airflow Variables from Hashicorp Vault

2020-07-07 Thread GitBox
kaxil commented on a change in pull request #7944: URL: https://github.com/apache/airflow/pull/7944#discussion_r450844959 ## File path: airflow/providers/hashicorp/secrets/vault.py ## @@ -150,7 +156,29 @@ def get_conn_uri(self, conn_id: str) -> Optional[str]: :param

[GitHub] [airflow] jacobhjkim commented on a change in pull request #7944: Get Airflow Variables from Hashicorp Vault

2020-07-07 Thread GitBox
jacobhjkim commented on a change in pull request #7944: URL: https://github.com/apache/airflow/pull/7944#discussion_r450823815 ## File path: airflow/providers/hashicorp/secrets/vault.py ## @@ -150,7 +156,29 @@ def get_conn_uri(self, conn_id: str) -> Optional[str]:

[GitHub] [airflow] kaxil commented on a change in pull request #7944: Get Airflow Variables from Hashicorp Vault

2020-07-07 Thread GitBox
kaxil commented on a change in pull request #7944: URL: https://github.com/apache/airflow/pull/7944#discussion_r450844959 ## File path: airflow/providers/hashicorp/secrets/vault.py ## @@ -150,7 +156,29 @@ def get_conn_uri(self, conn_id: str) -> Optional[str]: :param

[GitHub] [airflow] roskoN opened a new issue #9709: Decouple DAG tagging from RBAC

2020-07-07 Thread GitBox
roskoN opened a new issue #9709: URL: https://github.com/apache/airflow/issues/9709 **Description** Currently, in order to use DAG tags, one needs to enable RBAC. Thus, one needs to set it up in order to be able to use the feature. **Use case / motivation** While, this

[GitHub] [airflow] boring-cyborg[bot] commented on issue #9709: Decouple DAG tagging from RBAC

2020-07-07 Thread GitBox
boring-cyborg[bot] commented on issue #9709: URL: https://github.com/apache/airflow/issues/9709#issuecomment-654836311 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] shaneikennedy commented on pull request #9706: Specify simple_salesforce version requirements in 1.10.x

2020-07-07 Thread GitBox
shaneikennedy commented on pull request #9706: URL: https://github.com/apache/airflow/pull/9706#issuecomment-654834671 > So I believe setup.py is wrong (it says >1.0.0) . Is it possible that you add change to setup.py for that ? Note that you will have to generate requirements for this

[GitHub] [airflow] OmairK commented on issue #9708: Increase typing coverage

2020-07-07 Thread GitBox
OmairK commented on issue #9708: URL: https://github.com/apache/airflow/issues/9708#issuecomment-654831164 > I'm interested too. We would do it one PR per provider I guess? Yeah this sounds like a good idea. This

[GitHub] [airflow] mik-laj commented on issue #9708: Increase typing coverage

2020-07-07 Thread GitBox
mik-laj commented on issue #9708: URL: https://github.com/apache/airflow/issues/9708#issuecomment-654830501 @OmairK I assigned you to this ticket. I also added a small note to the first post. > If you decide to finish this ticket you don't have to do all the work yourself.

[GitHub] [airflow] ephraimbuddy commented on issue #9708: Increase typing coverage

2020-07-07 Thread GitBox
ephraimbuddy commented on issue #9708: URL: https://github.com/apache/airflow/issues/9708#issuecomment-654830776 I'm interested too. We would do it one PR per provider I guess? This is an automated message from the Apache

[GitHub] [airflow] OmairK commented on issue #9708: Increase typing coverage

2020-07-07 Thread GitBox
OmairK commented on issue #9708: URL: https://github.com/apache/airflow/issues/9708#issuecomment-654825998 This looks interesting, can you assign me this task @mik-laj This is an automated message from the Apache Git

[GitHub] [airflow] mik-laj commented on issue #9134: Support Flink operator

2020-07-07 Thread GitBox
mik-laj commented on issue #9134: URL: https://github.com/apache/airflow/issues/9134#issuecomment-654820970 @SteNicholas I think we can add two operators. One that starts streaming operations on a remote cluster, return ID to XCOM and the other that stops these operations. However, I have

[GitHub] [airflow] royberkoweee commented on a change in pull request #9667: Allow `replace` flag in gcs_to_gcs operator.

2020-07-07 Thread GitBox
royberkoweee commented on a change in pull request #9667: URL: https://github.com/apache/airflow/pull/9667#discussion_r450825113 ## File path: airflow/providers/google/cloud/transfers/gcs_to_gcs.py ## @@ -276,6 +280,21 @@ def _copy_source_with_wildcard(self, hook, prefix):

[GitHub] [airflow] jacobhjkim commented on a change in pull request #7944: Get Airflow Variables from Hashicorp Vault

2020-07-07 Thread GitBox
jacobhjkim commented on a change in pull request #7944: URL: https://github.com/apache/airflow/pull/7944#discussion_r450823815 ## File path: airflow/providers/hashicorp/secrets/vault.py ## @@ -150,7 +156,29 @@ def get_conn_uri(self, conn_id: str) -> Optional[str]:

[GitHub] [airflow] royberkoweee commented on a change in pull request #9667: Allow `replace` flag in gcs_to_gcs operator.

2020-07-07 Thread GitBox
royberkoweee commented on a change in pull request #9667: URL: https://github.com/apache/airflow/pull/9667#discussion_r450822599 ## File path: tests/providers/google/cloud/transfers/test_gcs_to_gcs.py ## @@ -86,6 +86,19 @@ def test_execute_no_suffix(self, mock_hook):

[GitHub] [airflow] mik-laj opened a new issue #9708: Increase typing coverage

2020-07-07 Thread GitBox
mik-laj opened a new issue #9708: URL: https://github.com/apache/airflow/issues/9708 Helllo, We've introduced mypy, but it's not very useful if we don't have type annotations. I think it's worth starting with the providers package, which is most often used by end-users. Currently,

[GitHub] [airflow] potiuk commented on pull request #9706: Specify simple_salesforce version requirements in 1.10.x

2020-07-07 Thread GitBox
potiuk commented on pull request #9706: URL: https://github.com/apache/airflow/pull/9706#issuecomment-654812039 So I believe setup.py is wrong (it says >1.0.0) . Is it possible that you add change to setup.py for that ? Note that you will have to generate requirements for this (as

[GitHub] [airflow] mik-laj edited a comment on issue #9096: Calendar Based Scheduling Pattern - Scheduler Feature in DAG

2020-07-07 Thread GitBox
mik-laj edited a comment on issue #9096: URL: https://github.com/apache/airflow/issues/9096#issuecomment-654807990 @hlokired Apache Airflow is an Open Source project, so the community manages it. Each feature that is added to this project is the result of volunteer work or was done by

[GitHub] [airflow] mik-laj edited a comment on issue #9096: Calendar Based Scheduling Pattern - Scheduler Feature in DAG

2020-07-07 Thread GitBox
mik-laj edited a comment on issue #9096: URL: https://github.com/apache/airflow/issues/9096#issuecomment-654807990 @hlokired Apache Airflow is an Open Source project, so the community manages it. Each feature that is added to this project is the result of volunteer work or was done by

[GitHub] [airflow] mik-laj edited a comment on issue #9096: Calendar Based Scheduling Pattern - Scheduler Feature in DAG

2020-07-07 Thread GitBox
mik-laj edited a comment on issue #9096: URL: https://github.com/apache/airflow/issues/9096#issuecomment-654807990 @hlokired Apache Airflow is an Open Source project, so the community manages it. Each feature that is added to this project is the result of volunteer work or was done by

[GitHub] [airflow] mik-laj commented on issue #9096: Calendar Based Scheduling Pattern - Scheduler Feature in DAG

2020-07-07 Thread GitBox
mik-laj commented on issue #9096: URL: https://github.com/apache/airflow/issues/9096#issuecomment-654807990 @hlokired This is an Open Source project, so the community manages it. Each feature that is added to this project is the result of volunteer work or was done by other companies

  1   2   >