[GitHub] [airflow] github-actions[bot] commented on pull request #17746: Bump `pip` version to `21.2.4`

2021-08-19 Thread GitBox
github-actions[bot] commented on pull request #17746: URL: https://github.com/apache/airflow/pull/17746#issuecomment-902424604 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] uranusjr commented on pull request #17749: Example xcom update

2021-08-19 Thread GitBox
uranusjr commented on pull request #17749: URL: https://github.com/apache/airflow/pull/17749#issuecomment-902423781 Also your code won’t pass the static checks. I recommend setting up pre-commit to check the code before pushing. -- This is an automated message from the Apache Git

[GitHub] [airflow] uranusjr commented on a change in pull request #17749: Example xcom update

2021-08-19 Thread GitBox
uranusjr commented on a change in pull request #17749: URL: https://github.com/apache/airflow/pull/17749#discussion_r692651846 ## File path: airflow/example_dags/example_xcom.py ## @@ -81,3 +83,20 @@ def puller(**kwargs): ) pull << [push1, push2] + +bash_push =

[GitHub] [airflow] github-actions[bot] commented on pull request #17747: Ensure ``DateTimeTrigger`` receives a datetime object

2021-08-19 Thread GitBox
github-actions[bot] commented on pull request #17747: URL: https://github.com/apache/airflow/pull/17747#issuecomment-902417934 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] uranusjr commented on a change in pull request #17732: Add Next Run to UI

2021-08-19 Thread GitBox
uranusjr commented on a change in pull request #17732: URL: https://github.com/apache/airflow/pull/17732#discussion_r692647739 ## File path: airflow/www/templates/airflow/dags.html ## @@ -98,7 +98,10 @@ {{ page_title }} Schedule

[GitHub] [airflow] eladkal commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-08-19 Thread GitBox
eladkal commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r692636472 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay if

[GitHub] [airflow] LionelZhao28 opened a new pull request #17749: Example xcom update

2021-08-19 Thread GitBox
LionelZhao28 opened a new pull request #17749: URL: https://github.com/apache/airflow/pull/17749 For the integration of my work, I have to push some values into the `xcom` in the BashOperator. But I didn't find the examples in the `example_xcom.py`. I think we'd better make a clear

[GitHub] [airflow] andrewgodwin commented on pull request #17748: Fix ``TimeSensorAsync`` and adds ``TimeTrigger``

2021-08-19 Thread GitBox
andrewgodwin commented on pull request #17748: URL: https://github.com/apache/airflow/pull/17748#issuecomment-902390924 What is the need for `TimeTrigger` here? It seems to perform the same function as the other trigger but with the timezone passed in separately, rather than in `moment`?

[airflow] branch main updated: Rename ``none_failed_or_skipped`` by ``none_failed_min_one_success`` trigger rule (#17683)

2021-08-19 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8fde9a4 Rename ``none_failed_or_skipped`` by

[GitHub] [airflow] kaxil closed issue #17012: NONE_FAILED_OR_SKIPPED is unclear

2021-08-19 Thread GitBox
kaxil closed issue #17012: URL: https://github.com/apache/airflow/issues/17012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil merged pull request #17683: Rename ``none_failed_or_skipped`` by ``none_failed_min_one_success`` trigger rule

2021-08-19 Thread GitBox
kaxil merged pull request #17683: URL: https://github.com/apache/airflow/pull/17683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil opened a new pull request #17748: Fix ``TimeSensorAsync`` and adds ``TimeTrigger``

2021-08-19 Thread GitBox
kaxil opened a new pull request #17748: URL: https://github.com/apache/airflow/pull/17748 When using the following example dag, it currently fails with `You cannot pass naive datetimes` error. This happens because `TimeSensorAsync` passes a `datetime.time` object while

[GitHub] [airflow] eladkal edited a comment on issue #17585: New Tasks to an existing DAG do not get scheduled if they have depends_on_past = True

2021-08-19 Thread GitBox
eladkal edited a comment on issue #17585: URL: https://github.com/apache/airflow/issues/17585#issuecomment-902014936 > Add another task with depends_on_past=True to the existing DAG I think the issue here is that you assume that when you add a new task Airflow knows that it starts

[GitHub] [airflow] eladkal edited a comment on issue #17585: New Tasks to an existing DAG do not get scheduled if they have depends_on_past = True

2021-08-19 Thread GitBox
eladkal edited a comment on issue #17585: URL: https://github.com/apache/airflow/issues/17585#issuecomment-902014936 > Add another task with depends_on_past=True to the existing DAG I think the issue here is that you assume that when you add a new task Airflow knows that it starts

[GitHub] [airflow] subkanthi commented on pull request #17068: Influxdb Hook

2021-08-19 Thread GitBox
subkanthi commented on pull request #17068: URL: https://github.com/apache/airflow/pull/17068#issuecomment-902371051 > LGTM and heppy to merge as soon as as you rebase @subkanthi - there were some unrelated errors in main (fixed since then). Can you please rebase? Thanks @potiuk for

[GitHub] [airflow] kaxil opened a new pull request #17747: Ensure ``DateTimeTrigger`` receives a datetime object

2021-08-19 Thread GitBox
kaxil opened a new pull request #17747: URL: https://github.com/apache/airflow/pull/17747 While using the following example DAG, the task failed with `moment` does not have `tzinfo` attribute. This happened because a string was passed from `DateTimeSensor` to `DateTimeTrigger`. This PR

[GitHub] [airflow] github-actions[bot] commented on pull request #17736: Add links to provider's documentation

2021-08-19 Thread GitBox
github-actions[bot] commented on pull request #17736: URL: https://github.com/apache/airflow/pull/17736#issuecomment-902353265 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] kaxil opened a new pull request #17746: Bump `pip` version to `21.2.4`

2021-08-19 Thread GitBox
kaxil opened a new pull request #17746: URL: https://github.com/apache/airflow/pull/17746 Updates `pip` version from `21.2.2` to `21.2.4` --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] kaxil commented on pull request #17121: [WIP] Deactivating DAGs which have been removed from files

2021-08-19 Thread GitBox
kaxil commented on pull request #17121: URL: https://github.com/apache/airflow/pull/17121#issuecomment-902340103 One of the tests is failing, can you take a look please: https://github.com/apache/airflow/pull/17121/checks?check_run_id=3284172968#step:6:10746 -- This is an automated

[GitHub] [airflow] github-actions[bot] commented on issue #10686: Common tasks in downstream of multiple branches always set to skipped due to 'Not Previously Skipped' dependency

2021-08-19 Thread GitBox
github-actions[bot] commented on issue #10686: URL: https://github.com/apache/airflow/issues/10686#issuecomment-902333636 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] github-actions[bot] commented on pull request #10606: Use private docker repository for K8S Operator & sidecar container

2021-08-19 Thread GitBox
github-actions[bot] commented on pull request #10606: URL: https://github.com/apache/airflow/pull/10606#issuecomment-902333653 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] kaxil opened a new pull request #17745: Add triggerer to `docker-compose.yaml` file

2021-08-19 Thread GitBox
kaxil opened a new pull request #17745: URL: https://github.com/apache/airflow/pull/17745 Adds triggerer component added in #15389 (AIP-40) to the docker-compose.yaml file for quick start --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] thesuperzapper opened a new issue #17744: Problems with how SecurityContext is handled in the helm chart

2021-08-19 Thread GitBox
thesuperzapper opened a new issue #17744: URL: https://github.com/apache/airflow/issues/17744 I think the official helm chart should consider using the approach the [User-Community helm chart](https://github.com/airflow-helm/charts/tree/main/charts/airflow) has taken with

[GitHub] [airflow] github-actions[bot] commented on pull request #17122: AIP-39: Add logical_date to OpenAPI DAGRun schema

2021-08-19 Thread GitBox
github-actions[bot] commented on pull request #17122: URL: https://github.com/apache/airflow/pull/17122#issuecomment-902315599 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] kaxil opened a new pull request #17743: Add Triggerer to Helm Chart

2021-08-19 Thread GitBox
kaxil opened a new pull request #17743: URL: https://github.com/apache/airflow/pull/17743 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] ephraimbuddy commented on issue #16625: Task is not retried when worker pod fails to start

2021-08-19 Thread GitBox
ephraimbuddy commented on issue #16625: URL: https://github.com/apache/airflow/issues/16625#issuecomment-902296823 > @ephraimbuddy So the metadata database is seeing the task as failed (as was reported by the executor) so that's what's showing up in the UI, but the scheduler still thinks

[GitHub] [airflow] ephraimbuddy edited a comment on issue #16625: Task is not retried when worker pod fails to start

2021-08-19 Thread GitBox
ephraimbuddy edited a comment on issue #16625: URL: https://github.com/apache/airflow/issues/16625#issuecomment-896076615 This PR https://github.com/apache/airflow/pull/15929 fixed the issue of not having to clear the task before it can be rerun again and that is a major issue otherwise

[GitHub] [airflow] ashb commented on pull request #15013: Enable Connection creation from Vault parameters

2021-08-19 Thread GitBox
ashb commented on pull request #15013: URL: https://github.com/apache/airflow/pull/15013#issuecomment-902258603 (Code on this looks good now! A nice simple change too!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] ashb commented on a change in pull request #15013: Enable Connection creation from Vault parameters

2021-08-19 Thread GitBox
ashb commented on a change in pull request #15013: URL: https://github.com/apache/airflow/pull/15013#discussion_r692496427 ## File path: docs/apache-airflow-providers-hashicorp/secrets-backends/hashicorp-vault.rst ## @@ -100,6 +100,46 @@ Verify that you can get the secret

[GitHub] [airflow] ashb commented on a change in pull request #17732: Add Next Run to UI

2021-08-19 Thread GitBox
ashb commented on a change in pull request #17732: URL: https://github.com/apache/airflow/pull/17732#discussion_r692494626 ## File path: airflow/www/templates/airflow/dag.html ## @@ -84,8 +84,17 @@ {{ state_token }} {% endif %} -schedule: {{

[GitHub] [airflow] ashb commented on a change in pull request #17732: Add Next Run to UI

2021-08-19 Thread GitBox
ashb commented on a change in pull request #17732: URL: https://github.com/apache/airflow/pull/17732#discussion_r692493903 ## File path: airflow/www/templates/airflow/dags.html ## @@ -98,7 +98,10 @@ {{ page_title }} Schedule Last

[GitHub] [airflow] kaxil merged pull request #17742: Fix comment in Helm Chart for worker ``logGroomerSidecar``

2021-08-19 Thread GitBox
kaxil merged pull request #17742: URL: https://github.com/apache/airflow/pull/17742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (f654db8 -> 83678b6)

2021-08-19 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from f654db8 Fix clean-logs after improper skipping of lost+found (#17739) add 83678b6 Fix comment in Helm Chart

[GitHub] [airflow] github-actions[bot] commented on pull request #17742: Fix comment in Helm Chart for worker ``logGroomerSidecar``

2021-08-19 Thread GitBox
github-actions[bot] commented on pull request #17742: URL: https://github.com/apache/airflow/pull/17742#issuecomment-902246472 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[airflow] branch worker-scheduler-comment created (now 5b2befb)

2021-08-19 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch worker-scheduler-comment in repository https://gitbox.apache.org/repos/asf/airflow.git. at 5b2befb Fix comment in Helm Chart for worker ``logGroomerSidecar`` No new revisions were

[GitHub] [airflow] kaxil opened a new pull request #17742: Fix comment in Helm Chart for worker ``logGroomerSidecar``

2021-08-19 Thread GitBox
kaxil opened a new pull request #17742: URL: https://github.com/apache/airflow/pull/17742 It said `scheduler` instead of `worker` --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] ashb commented on a change in pull request #17719: Change TaskInstance and TaskReschedule from execution_date to run_id

2021-08-19 Thread GitBox
ashb commented on a change in pull request #17719: URL: https://github.com/apache/airflow/pull/17719#discussion_r692481164 ## File path: airflow/jobs/scheduler_job.py ## @@ -321,12 +247,12 @@ def _executable_task_instances_to_queued(self, max_tis: int, session: Session =

[GitHub] [airflow] ashb commented on a change in pull request #17719: Change TaskInstance and TaskReschedule from execution_date to run_id

2021-08-19 Thread GitBox
ashb commented on a change in pull request #17719: URL: https://github.com/apache/airflow/pull/17719#discussion_r692480923 ## File path: airflow/jobs/scheduler_job.py ## @@ -189,80 +189,6 @@ def is_alive(self, grace_multiplier: Optional[float] = None) -> bool:

[GitHub] [airflow] ashb commented on a change in pull request #17719: Change TaskInstance and TaskReschedule from execution_date to run_id

2021-08-19 Thread GitBox
ashb commented on a change in pull request #17719: URL: https://github.com/apache/airflow/pull/17719#discussion_r692479872 ## File path: tests/core/test_core.py ## @@ -314,64 +330,12 @@ def test_task_get_template(self): assert value == expected_value

[GitHub] [airflow] ashb commented on pull request #17719: Change TaskInstance and TaskReschedule from execution_date to run_id

2021-08-19 Thread GitBox
ashb commented on pull request #17719: URL: https://github.com/apache/airflow/pull/17719#issuecomment-902237213 I'm not quite expecting _all_ tests to pass on this yet, but I'd like a review on this, so I'm marking it ready while I work on fixing up the remaining tests -- This is an

[GitHub] [airflow] denimalpaca closed pull request #17738: Add Snowflake Data Quality Operators

2021-08-19 Thread GitBox
denimalpaca closed pull request #17738: URL: https://github.com/apache/airflow/pull/17738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] denimalpaca opened a new pull request #17741: Snowflake DQ Operators

2021-08-19 Thread GitBox
denimalpaca opened a new pull request #17741: URL: https://github.com/apache/airflow/pull/17741 Add three new Snowflake operators based on SQL Checks The SnowflakeCheckOperator, SnowflakeValueCheckOperator, and SnowflakeIntervalCheckOperators are added as subclasses of their

[GitHub] [airflow] EliMor opened a new issue #17740: Allow custom rules for (Cluster)Role to be provided/exposed in values.yaml helm chart

2021-08-19 Thread GitBox
EliMor opened a new issue #17740: URL: https://github.com/apache/airflow/issues/17740 **Description** I may be the only one with this use-case but I would love it if I could specify the rules for pod-launcher (give it extra permissions on kube) **Use case /

[GitHub] [airflow] ashb commented on pull request #16766: Add an Amazon EMR on EKS provider package

2021-08-19 Thread GitBox
ashb commented on pull request #16766: URL: https://github.com/apache/airflow/pull/16766#issuecomment-90417 @ferruzzi @o-nikolas Any opinions on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] dacort commented on a change in pull request #16766: Add an Amazon EMR on EKS provider package

2021-08-19 Thread GitBox
dacort commented on a change in pull request #16766: URL: https://github.com/apache/airflow/pull/16766#discussion_r692455216 ## File path: airflow/providers/amazon/aws/hooks/emr_containers.py ## @@ -0,0 +1,205 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] collinmcnulty commented on issue #16625: Task is not retried when worker pod fails to start

2021-08-19 Thread GitBox
collinmcnulty commented on issue #16625: URL: https://github.com/apache/airflow/issues/16625#issuecomment-902214988 @ephraimbuddy So the metadata database is seeing the task as failed (as was reported by the executor) so that's what's showing up in the UI, but the scheduler still thinks

[airflow] branch main updated (af9dc8b -> f654db8)

2021-08-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from af9dc8b Remove ``[core] store_dag_code`` & use DB to get Dag Code (#16342) add f654db8 Fix clean-logs after

[GitHub] [airflow] potiuk closed issue #17733: Scheduler-gc fails on helm chart when running 'find'

2021-08-19 Thread GitBox
potiuk closed issue #17733: URL: https://github.com/apache/airflow/issues/17733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk merged pull request #17739: Fix clean-logs after improper skipping of lost+found

2021-08-19 Thread GitBox
potiuk merged pull request #17739: URL: https://github.com/apache/airflow/pull/17739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

2021-08-19 Thread GitBox
potiuk commented on pull request #17321: URL: https://github.com/apache/airflow/pull/17321#issuecomment-902190048 > @potiuk Might we expect the core Airflow aspect of this to appear in 2.2? I guess there would also need to be a Google provider version release afterwards too. Yeah.

[GitHub] [airflow] github-actions[bot] commented on pull request #17739: Fix clean-logs after improper skipping of lost+found

2021-08-19 Thread GitBox
github-actions[bot] commented on pull request #17739: URL: https://github.com/apache/airflow/pull/17739#issuecomment-902189489 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[airflow] branch main updated (35b8f50 -> af9dc8b)

2021-08-19 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 35b8f50 Make sure "podcution-readiness` of docker-compose is well explained (#17731) add af9dc8b Remove

[GitHub] [airflow] kaxil merged pull request #16342: Remove ``[core] store_dag_code`` & use DB to get Dag Code

2021-08-19 Thread GitBox
kaxil merged pull request #16342: URL: https://github.com/apache/airflow/pull/16342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #16342: Remove ``[core] store_dag_code`` & use DB to get Dag Code

2021-08-19 Thread GitBox
github-actions[bot] commented on pull request #16342: URL: https://github.com/apache/airflow/pull/16342#issuecomment-902186401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] jedcunningham commented on a change in pull request #16342: Remove ``[core] store_dag_code`` & use DB to get Dag Code

2021-08-19 Thread GitBox
jedcunningham commented on a change in pull request #16342: URL: https://github.com/apache/airflow/pull/16342#discussion_r692424237 ## File path: UPDATING.md ## @@ -174,6 +174,20 @@ with DAG(dag_id="task_concurrency_example"): When marking a task success/failed in Graph

[GitHub] [airflow] xasx commented on pull request #17739: Fix clean-logs after improper skipping of lost+found

2021-08-19 Thread GitBox
xasx commented on pull request #17739: URL: https://github.com/apache/airflow/pull/17739#issuecomment-902182382 Thanks for fixing my bug 珞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk edited a comment on pull request #17738: Add Snowflake Data Quality Operators

2021-08-19 Thread GitBox
potiuk edited a comment on pull request #17738: URL: https://github.com/apache/airflow/pull/17738#issuecomment-902181465 > > Something very wrong happened during this rebase :) > > Yes it did I am trying to figure it out. Hopefully all the work wasn't lost. GIT never

[GitHub] [airflow] potiuk commented on pull request #17738: Add Snowflake Data Quality Operators

2021-08-19 Thread GitBox
potiuk commented on pull request #17738: URL: https://github.com/apache/airflow/pull/17738#issuecomment-902181465 > > Something very wrong happened during this rebase :) > > Yes it did I am trying to figure it out. Hopefully all the work wasn't lost. GIT never forgets

[GitHub] [airflow] denimalpaca commented on pull request #17738: Add Snowflake Data Quality Operators

2021-08-19 Thread GitBox
denimalpaca commented on pull request #17738: URL: https://github.com/apache/airflow/pull/17738#issuecomment-902180693 > Something very wrong happened during this rebase :) Yes it did I am trying to figure it out. Hopefully all the work wasn't lost. -- This is an automated

[GitHub] [airflow] potiuk commented on pull request #17738: Add Snowflake Data Quality Operators

2021-08-19 Thread GitBox
potiuk commented on pull request #17738: URL: https://github.com/apache/airflow/pull/17738#issuecomment-902180085 Something very wrong happened during this rebase :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] potiuk commented on pull request #17739: Fix clean-logs after improper skipping of lost+found

2021-08-19 Thread GitBox
potiuk commented on pull request #17739: URL: https://github.com/apache/airflow/pull/17739#issuecomment-902177689 cc: @xasx @sushi30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk opened a new pull request #17739: Fix clean-logs after improper skipping of lost+found

2021-08-19 Thread GitBox
potiuk opened a new pull request #17739: URL: https://github.com/apache/airflow/pull/17739 The fisxin #17547 was not working properly because -prune and -delete in find cannot be combined. The -prune is still needed to solve the problem of non-readable `lost+found` directory that

[GitHub] [airflow] tanujdhiman commented on pull request #16170: Adding extra requirements for build and runtime of the PROD image.

2021-08-19 Thread GitBox
tanujdhiman commented on pull request #16170: URL: https://github.com/apache/airflow/pull/16170#issuecomment-902167930 Thanks @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] denimalpaca opened a new pull request #17738: Add Snowflake Data Quality Operators

2021-08-19 Thread GitBox
denimalpaca opened a new pull request #17738: URL: https://github.com/apache/airflow/pull/17738 Add three new Snowflake operators based on SQL Checks The SnowflakeCheckOperator, SnowflakeValueCheckOperator, and SnowflakeIntervalCheckOperators are added as subclasses of their

[GitHub] [airflow] potiuk commented on issue #17641: Import Errors Flapping

2021-08-19 Thread GitBox
potiuk commented on issue #17641: URL: https://github.com/apache/airflow/issues/17641#issuecomment-902163270 It almost looks like you have two schedulers running at the same time - one with the properly set environment variable and the other without. Are you sure you do not have two

[GitHub] [airflow] tanujdhiman commented on pull request #16170: Adding extra requirements for build and runtime of the PROD image.

2021-08-19 Thread GitBox
tanujdhiman commented on pull request #16170: URL: https://github.com/apache/airflow/pull/16170#issuecomment-902160222 Hmm Actually I tried this command too :: `_PIP_ADDITIONAL_REQUIREMENTS: ${_PIP_ADDITIONAL_REQUIREMENTS:-pydub dropbox patool}` But got an error of invalid

[GitHub] [airflow] potiuk edited a comment on pull request #16170: Adding extra requirements for build and runtime of the PROD image.

2021-08-19 Thread GitBox
potiuk edited a comment on pull request #16170: URL: https://github.com/apache/airflow/pull/16170#issuecomment-902159273 Just set env variables. Here is the first googled result about them

[GitHub] [airflow] potiuk edited a comment on pull request #16170: Adding extra requirements for build and runtime of the PROD image.

2021-08-19 Thread GitBox
potiuk edited a comment on pull request #16170: URL: https://github.com/apache/airflow/pull/16170#issuecomment-902159273 Just set env variables. Here is the first googled result about them

[GitHub] [airflow] potiuk commented on pull request #16170: Adding extra requirements for build and runtime of the PROD image.

2021-08-19 Thread GitBox
potiuk commented on pull request #16170: URL: https://github.com/apache/airflow/pull/16170#issuecomment-902159273 Just set env variables. Here is the first googled result about them

[GitHub] [airflow] tanujdhiman commented on pull request #16170: Adding extra requirements for build and runtime of the PROD image.

2021-08-19 Thread GitBox
tanujdhiman commented on pull request #16170: URL: https://github.com/apache/airflow/pull/16170#issuecomment-902156327 Thanks @potiuk for a quick reply. But I saw this page actually but umm, okay. Can you write down a command which I put in compose file for installing `pydub,

[GitHub] [airflow] potiuk commented on a change in pull request #17342: From feature request #17314: add support to enable kinit options [-f|-F] and [-a|-A]

2021-08-19 Thread GitBox
potiuk commented on a change in pull request #17342: URL: https://github.com/apache/airflow/pull/17342#discussion_r692395630 ## File path: docker-context-files/README.md ## @@ -1,32 +0,0 @@

[GitHub] [airflow] potiuk commented on pull request #16170: Adding extra requirements for build and runtime of the PROD image.

2021-08-19 Thread GitBox
potiuk commented on pull request #16170: URL: https://github.com/apache/airflow/pull/16170#issuecomment-902150123 https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html#environment-variables-supported-by-docker-compose -- This is an automated message from the Apache Git

[GitHub] [airflow] potiuk commented on a change in pull request #17448: Aws secrets manager backend

2021-08-19 Thread GitBox
potiuk commented on a change in pull request #17448: URL: https://github.com/apache/airflow/pull/17448#discussion_r692382093 ## File path: docs/apache-airflow-providers-amazon/secrets-backends/aws-secrets-manager.rst ## @@ -71,18 +68,43 @@ Verify that you can get the secret:

[GitHub] [airflow] tanujdhiman edited a comment on pull request #16170: Adding extra requirements for build and runtime of the PROD image.

2021-08-19 Thread GitBox
tanujdhiman edited a comment on pull request #16170: URL: https://github.com/apache/airflow/pull/16170#issuecomment-902142739 Hello, How can I use this variable? `_PIP_ADDITIONAL_REQUIREMENTS: ${_PIP_ADDITIONAL_REQUIREMENTS:- pydub dropbox}` I'm using this but didn't get

[GitHub] [airflow] tanujdhiman commented on pull request #16170: Adding extra requirements for build and runtime of the PROD image.

2021-08-19 Thread GitBox
tanujdhiman commented on pull request #16170: URL: https://github.com/apache/airflow/pull/16170#issuecomment-902142739 Hello, How can I use this variable? `_PIP_ADDITIONAL_REQUIREMENTS: ${_PIP_ADDITIONAL_REQUIREMENTS:- pydub dropbox}` I'm using this but didn't get good

[GitHub] [airflow] JavierLopezT commented on a change in pull request #17448: Aws secrets manager backend

2021-08-19 Thread GitBox
JavierLopezT commented on a change in pull request #17448: URL: https://github.com/apache/airflow/pull/17448#discussion_r692378470 ## File path: docs/apache-airflow-providers-amazon/secrets-backends/aws-secrets-manager.rst ## @@ -71,18 +68,43 @@ Verify that you can get the

[GitHub] [airflow] JavierLopezT commented on a change in pull request #17448: Aws secrets manager backend

2021-08-19 Thread GitBox
JavierLopezT commented on a change in pull request #17448: URL: https://github.com/apache/airflow/pull/17448#discussion_r692378470 ## File path: docs/apache-airflow-providers-amazon/secrets-backends/aws-secrets-manager.rst ## @@ -71,18 +68,43 @@ Verify that you can get the

[GitHub] [airflow] potiuk commented on a change in pull request #17448: Aws secrets manager backend

2021-08-19 Thread GitBox
potiuk commented on a change in pull request #17448: URL: https://github.com/apache/airflow/pull/17448#discussion_r692371810 ## File path: docs/apache-airflow-providers-amazon/secrets-backends/aws-secrets-manager.rst ## @@ -71,18 +68,43 @@ Verify that you can get the secret:

[GitHub] [airflow] potiuk commented on pull request #17736: Add links to provider's documentation

2021-08-19 Thread GitBox
potiuk commented on pull request #17736: URL: https://github.com/apache/airflow/pull/17736#issuecomment-902127148 > Looks good. I think you'll need to modify the test in `tests/www/views/test_views.py` though. Indeed. Fixed -- This is an automated message from the Apache Git

[airflow] branch main updated: Make sure "podcution-readiness` of docker-compose is well explained (#17731)

2021-08-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 35b8f50 Make sure "podcution-readiness` of

[GitHub] [airflow] potiuk merged pull request #17731: Make sure "production-readiness` of docker-compose is well explained

2021-08-19 Thread GitBox
potiuk merged pull request #17731: URL: https://github.com/apache/airflow/pull/17731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] EliMor commented on issue #11708: Git sync for plugins in the Helm Chart

2021-08-19 Thread GitBox
EliMor commented on issue #11708: URL: https://github.com/apache/airflow/issues/11708#issuecomment-902120486 FYI; https://github.com/bitnami/charts/blob/master/bitnami/airflow/values.yaml#L781 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] EliMor opened a new issue #17737: Allow multiple repos to be source for dags in helm chart

2021-08-19 Thread GitBox
EliMor opened a new issue #17737: URL: https://github.com/apache/airflow/issues/17737 **Description** Hi folks. Forgive me if this is already possible but I didn't see in the values.yaml file a clear way to specify multiple git repos as sources for dags. If this is possible

[GitHub] [airflow] jedcunningham commented on pull request #17736: Add links to provider's documentation

2021-08-19 Thread GitBox
jedcunningham commented on pull request #17736: URL: https://github.com/apache/airflow/pull/17736#issuecomment-902117151 Looks good. I think you'll need to modify the test in `tests/www/views/test_views.py` though. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] potiuk commented on pull request #17736: Add links to provider's documentation

2021-08-19 Thread GitBox
potiuk commented on pull request #17736: URL: https://github.com/apache/airflow/pull/17736#issuecomment-902114700 cc: @ShakaibKhan @jedcunningham @kaxil Example with hover over zendesk:

[GitHub] [airflow] potiuk opened a new pull request #17736: Add links to provider's documentation

2021-08-19 Thread GitBox
potiuk opened a new pull request #17736: URL: https://github.com/apache/airflow/pull/17736 The provider package names in the UI are now linked to the documentation of the provider (in the exact version provider is installed in!). Follow up after #15385 --- **^

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17735: Permission error for error file when run_as_user is used

2021-08-19 Thread GitBox
boring-cyborg[bot] commented on issue #17735: URL: https://github.com/apache/airflow/issues/17735#issuecomment-902097786 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] kcphila opened a new issue #17735: Permission error for error file when run_as_user is used

2021-08-19 Thread GitBox
kcphila opened a new issue #17735: URL: https://github.com/apache/airflow/issues/17735 I'm highlighting the line of the code at issue. When the base_task_runner prepares to execute the task, it opens a temporary error file AND passes the error file name into the task. This temp file is

[GitHub] [airflow] potiuk commented on pull request #15385: Added table to view providers in airflow ui under admin tab

2021-08-19 Thread GitBox
potiuk commented on pull request #15385: URL: https://github.com/apache/airflow/pull/15385#issuecomment-902095202 ❤️ it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] kaxil commented on pull request #15385: Added table to view providers in airflow ui under admin tab

2021-08-19 Thread GitBox
kaxil commented on pull request #15385: URL: https://github.com/apache/airflow/pull/15385#issuecomment-902091605 Thank you for your contribution @ShakaibKhan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[airflow] branch main updated (e107891 -> 12709bf)

2021-08-19 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from e107891 Extend init_containers defined in pod_override (#17537) add 12709bf Added table to view providers

[GitHub] [airflow] kaxil merged pull request #15385: Added table to view providers in airflow ui under admin tab

2021-08-19 Thread GitBox
kaxil merged pull request #15385: URL: https://github.com/apache/airflow/pull/15385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil closed issue #12469: Display providers in Web UI

2021-08-19 Thread GitBox
kaxil closed issue #12469: URL: https://github.com/apache/airflow/issues/12469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15385: Added table to view providers in airflow ui under admin tab

2021-08-19 Thread GitBox
boring-cyborg[bot] commented on pull request #15385: URL: https://github.com/apache/airflow/pull/15385#issuecomment-902091256 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] busunkim96 commented on a change in pull request #17671: Allow google-auth < 3 and google-api-core < 3

2021-08-19 Thread GitBox
busunkim96 commented on a change in pull request #17671: URL: https://github.com/apache/airflow/pull/17671#discussion_r692297581 ## File path: setup.py ## @@ -319,7 +319,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version

[GitHub] [airflow] charliegriefer edited a comment on issue #11225: celery executer with SQS and predefined_queues

2021-08-19 Thread GitBox
charliegriefer edited a comment on issue #11225: URL: https://github.com/apache/airflow/issues/11225#issuecomment-901995246 @sudarshan2906 - can you show the `celery_config_options` line in your `airflow.cfg`? I'm doing something similar, but getting an error on the scheduler saying:

[GitHub] [airflow] jedcunningham commented on pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

2021-08-19 Thread GitBox
jedcunningham commented on pull request #17666: URL: https://github.com/apache/airflow/pull/17666#issuecomment-902046953 Looks like static checks are failing. I'd also suggest that you [set up the pre-commit

[GitHub] [airflow] jedcunningham commented on pull request #17537: Extend init_containers defined in pod_override

2021-08-19 Thread GitBox
jedcunningham commented on pull request #17537: URL: https://github.com/apache/airflow/pull/17537#issuecomment-902027971 Thanks for the bugfix @repocho and congrats on your first commit ! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[airflow] branch main updated (35a6c30 -> e107891)

2021-08-19 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 35a6c30 Rename ``task_concurrency`` to ``max_active_tis_per_dag`` (#17708) add e107891 Extend

[GitHub] [airflow] jedcunningham merged pull request #17537: Extend init_containers defined in pod_override

2021-08-19 Thread GitBox
jedcunningham merged pull request #17537: URL: https://github.com/apache/airflow/pull/17537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >