[GitHub] [airflow] eejbyfeldt opened a new pull request #17821: Improve graph view load time for dags with open groups

2021-08-24 Thread GitBox
eejbyfeldt opened a new pull request #17821: URL: https://github.com/apache/airflow/pull/17821 The main improvement is calling the expensive draw function only one time during the initial load instead of for each saved group. The previous behavior could

[GitHub] [airflow] iblaine commented on a change in pull request #17777: get_pandas_df() fails when it tries to read an empty table

2021-08-24 Thread GitBox
iblaine commented on a change in pull request #1: URL: https://github.com/apache/airflow/pull/1#discussion_r695350649 ## File path: tests/test_utils/mock_process.py ## @@ -85,3 +84,15 @@ def __next__(self): def __iter__(self): yield from self.iterable +

[GitHub] [airflow] leahecole opened a new pull request #17820: Allow omission of `initial_node_count` if `node_pools` is specified

2021-08-24 Thread GitBox
leahecole opened a new pull request #17820: URL: https://github.com/apache/airflow/pull/17820 According to the [API reference](https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/projects.locations.clusters#Cluster), the `initial_node_count` is not needed when you are

[airflow] branch constraints-main updated: Updating constraints. Build id:1164695940

2021-08-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 1861cb6 Updating

[GitHub] [airflow] uranusjr commented on a change in pull request #17809: Fix typos in documentation and command example in comment in bug_report template

2021-08-24 Thread GitBox
uranusjr commented on a change in pull request #17809: URL: https://github.com/apache/airflow/pull/17809#discussion_r695302104 ## File path: BREEZE.rst ## @@ -718,13 +718,13 @@ The above will run mypy check for all files. -If you want ever need to get a list of

[GitHub] [airflow] uranusjr commented on pull request #17797: Fix broken MSSQL test

2021-08-24 Thread GitBox
uranusjr commented on pull request #17797: URL: https://github.com/apache/airflow/pull/17797#issuecomment-905061157 Hmm one MSSQL test is failing with ``` pyodbc.Error: ('40001', '[40001] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Transaction (Process ID 56) was

[GitHub] [airflow] uranusjr commented on a change in pull request #17777: get_pandas_df() fails when it tries to read an empty table

2021-08-24 Thread GitBox
uranusjr commented on a change in pull request #1: URL: https://github.com/apache/airflow/pull/1#discussion_r695297546 ## File path: tests/test_utils/mock_process.py ## @@ -85,3 +84,15 @@ def __next__(self): def __iter__(self): yield from self.iterable

[GitHub] [airflow] jedcunningham commented on a change in pull request #17397: Update to Celery 5

2021-08-24 Thread GitBox
jedcunningham commented on a change in pull request #17397: URL: https://github.com/apache/airflow/pull/17397#discussion_r695298146 ## File path: Dockerfile.ci ## @@ -278,7 +278,7 @@ ENV AIRFLOW_REPO=${AIRFLOW_REPO}\ # * lazy-object-proxy<1.5.0: required by astroid # *

[GitHub] [airflow] uranusjr commented on a change in pull request #17777: get_pandas_df() fails when it tries to read an empty table

2021-08-24 Thread GitBox
uranusjr commented on a change in pull request #1: URL: https://github.com/apache/airflow/pull/1#discussion_r695297546 ## File path: tests/test_utils/mock_process.py ## @@ -85,3 +84,15 @@ def __next__(self): def __iter__(self): yield from self.iterable

[GitHub] [airflow] uranusjr commented on pull request #17121: [WIP] Deactivating DAGs which have been removed from files

2021-08-24 Thread GitBox
uranusjr commented on pull request #17121: URL: https://github.com/apache/airflow/pull/17121#issuecomment-905055788 No hard deadline yet but features probably need to finish in ~2 weeks or so to be included. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] closed pull request #16647: Move FABs base Security Manager into Airflow.

2021-08-24 Thread GitBox
github-actions[bot] closed pull request #16647: URL: https://github.com/apache/airflow/pull/16647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on issue #16888: Bug on KubernetesJobWatcher in Scheduler

2021-08-24 Thread GitBox
github-actions[bot] commented on issue #16888: URL: https://github.com/apache/airflow/issues/16888#issuecomment-905055628 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] github-actions[bot] commented on issue #16298: Scheduler fails with BrokenPipeError

2021-08-24 Thread GitBox
github-actions[bot] commented on issue #16298: URL: https://github.com/apache/airflow/issues/16298#issuecomment-905055687 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] commented on issue #15883: airflow(2.0.2): kubernetes_executor task never recived a scheduler_job_id

2021-08-24 Thread GitBox
github-actions[bot] commented on issue #15883: URL: https://github.com/apache/airflow/issues/15883#issuecomment-905055696 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] github-actions[bot] closed issue #16298: Scheduler fails with BrokenPipeError

2021-08-24 Thread GitBox
github-actions[bot] closed issue #16298: URL: https://github.com/apache/airflow/issues/16298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ephraimbuddy closed pull request #17819: Handle task callback inside the scheduler

2021-08-24 Thread GitBox
ephraimbuddy closed pull request #17819: URL: https://github.com/apache/airflow/pull/17819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ephraimbuddy commented on pull request #17819: Handle task callback inside the scheduler

2021-08-24 Thread GitBox
ephraimbuddy commented on pull request #17819: URL: https://github.com/apache/airflow/pull/17819#issuecomment-905047147 > We don't want to run any user code in Scheduler. That is why callbacks are currently run in the DAG file processor. Long term they should be run in the Worker

[GitHub] [airflow] jedcunningham commented on pull request #17764: Helm chart: add the number of retention days for log groomer through env vars.

2021-08-24 Thread GitBox
jedcunningham commented on pull request #17764: URL: https://github.com/apache/airflow/pull/17764#issuecomment-905044339 Thanks @cccs-seb! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch main updated: Chart: configurable number of retention days for log groomers (#17764)

2021-08-24 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 06e53f2 Chart: configurable number of

[GitHub] [airflow] jedcunningham merged pull request #17764: Helm chart: add the number of retention days for log groomer through env vars.

2021-08-24 Thread GitBox
jedcunningham merged pull request #17764: URL: https://github.com/apache/airflow/pull/17764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ephraimbuddy opened a new pull request #17819: Handle task callback inside the scheduler

2021-08-24 Thread GitBox
ephraimbuddy opened a new pull request #17819: URL: https://github.com/apache/airflow/pull/17819 Task callbacks in scheduler are sent to DAG file processor to process and are quite problematic. Most times, task instances that have retries are not retried up to the number required, see

[GitHub] [airflow] iblaine commented on a change in pull request #17777: get_pandas_df() fails when it tries to read an empty table

2021-08-24 Thread GitBox
iblaine commented on a change in pull request #1: URL: https://github.com/apache/airflow/pull/1#discussion_r695266601 ## File path: tests/providers/apache/hive/hooks/test_hive.py ## @@ -687,6 +687,13 @@ def test_get_pandas_df(self):

[GitHub] [airflow] mik-laj commented on a change in pull request #17741: Add Snowflake DQ Operators

2021-08-24 Thread GitBox
mik-laj commented on a change in pull request #17741: URL: https://github.com/apache/airflow/pull/17741#discussion_r695248660 ## File path: airflow/providers/snowflake/operators/snowflake.py ## @@ -125,3 +126,299 @@ def execute(self, context: Any) -> None: if

[GitHub] [airflow] mik-laj commented on a change in pull request #17741: Add Snowflake DQ Operators

2021-08-24 Thread GitBox
mik-laj commented on a change in pull request #17741: URL: https://github.com/apache/airflow/pull/17741#discussion_r695248154 ## File path: airflow/providers/snowflake/operators/snowflake.py ## @@ -125,3 +126,299 @@ def execute(self, context: Any) -> None: if

[GitHub] [airflow] mik-laj commented on pull request #17816: Pull Request #17342: add support to enable kinit options [-f|-F] and [-a|-A]

2021-08-24 Thread GitBox
mik-laj commented on pull request #17816: URL: https://github.com/apache/airflow/pull/17816#issuecomment-905004300 Can you add docs for these options?https://airflow.apache.org/docs/apache-airflow/stable/security/kerberos.html -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] DeOldSax commented on issue #15994: Use inclusive words in Apache Airflow project

2021-08-24 Thread GitBox
DeOldSax commented on issue #15994: URL: https://github.com/apache/airflow/issues/15994#issuecomment-904974941 How about SentinelOperator? Imho in the domain of algorithms and data structures it's exactly that. -- This is an automated message from the Apache Git Service. To respond to

[airflow] branch constraints-2-2 created (now 6610e2d)

2021-08-24 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch constraints-2-2 in repository https://gitbox.apache.org/repos/asf/airflow.git. at 6610e2d Updating constraints. Build id:1161365036 No new revisions were added by this update.

[GitHub] [airflow] SamWheating commented on pull request #17121: [WIP] Deactivating DAGs which have been removed from files

2021-08-24 Thread GitBox
SamWheating commented on pull request #17121: URL: https://github.com/apache/airflow/pull/17121#issuecomment-904960763 I'm away on vacation for the next week - I can get these tests fixed afterwards. Is there a deadline for the next release? -- This is an automated message from

[airflow] branch main updated (806f06b -> c203e77)

2021-08-24 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 806f06b Fixed numeric list (#17813) add c203e77 Show import errors in DAG views (#17818) No new

[GitHub] [airflow] ephraimbuddy merged pull request #17818: Show import errors in DAG views

2021-08-24 Thread GitBox
ephraimbuddy merged pull request #17818: URL: https://github.com/apache/airflow/pull/17818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #17818: Show import errors in DAG views

2021-08-24 Thread GitBox
github-actions[bot] commented on pull request #17818: URL: https://github.com/apache/airflow/pull/17818#issuecomment-904939645 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] zealpatel1990 commented on issue #17814: Last Dagrun is not working.

2021-08-24 Thread GitBox
zealpatel1990 commented on issue #17814: URL: https://github.com/apache/airflow/issues/17814#issuecomment-904919140 Thanks @uranusjr for quick fix. Now I understand that I have DAG which schedule is set to None, that also breaks last run of other dags as well. As soon as DAG is manually

[GitHub] [airflow] argzeal removed a comment on issue #17814: Last Dagrun is not working.

2021-08-24 Thread GitBox
argzeal removed a comment on issue #17814: URL: https://github.com/apache/airflow/issues/17814#issuecomment-904917308 Thanks @uranusjr for quick fix. Now I understand that I have DAG which schedule is set to `None`, that also breaks last run of other dags as well. As soon as DAG is

[GitHub] [airflow] vladdoster commented on a change in pull request #17806: (docs): update README.md

2021-08-24 Thread GitBox
vladdoster commented on a change in pull request #17806: URL: https://github.com/apache/airflow/pull/17806#discussion_r695144549 ## File path: README.md ## @@ -254,44 +252,44 @@ Apache Airflow version life cycle: | Version | Current Patch/Minor | State | First Release |

[GitHub] [airflow] argzeal commented on issue #17814: Last Dagrun is not working.

2021-08-24 Thread GitBox
argzeal commented on issue #17814: URL: https://github.com/apache/airflow/issues/17814#issuecomment-904917308 Thanks @uranusjr for quick fix. Now I understand that I have DAG which schedule is set to `None`, that also breaks last run of other dags as well. As soon as DAG is manually

[GitHub] [airflow] evanhlavaty commented on pull request #17798: Prepare release for Kubernetes Provider

2021-08-24 Thread GitBox
evanhlavaty commented on pull request #17798: URL: https://github.com/apache/airflow/pull/17798#issuecomment-904885671 Thanks for the quick replies all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] ephraimbuddy commented on pull request #17818: Show import errors in DAG views

2021-08-24 Thread GitBox
ephraimbuddy commented on pull request #17818: URL: https://github.com/apache/airflow/pull/17818#issuecomment-904881341 ![importerrors](https://user-images.githubusercontent.com/4122866/130671414-b55b199c-35d5-43bb-8b9c-fad9641805cb.PNG) -- This is an automated message from the

[GitHub] [airflow] ephraimbuddy opened a new pull request #17818: Show import errors in DAG views

2021-08-24 Thread GitBox
ephraimbuddy opened a new pull request #17818: URL: https://github.com/apache/airflow/pull/17818 Currently, import errors are not shown on DAG views(gragh, tree etc). This PR addresses it. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] potiuk commented on a change in pull request #17806: (docs): update README.md

2021-08-24 Thread GitBox
potiuk commented on a change in pull request #17806: URL: https://github.com/apache/airflow/pull/17806#discussion_r695103294 ## File path: README.md ## @@ -254,44 +252,44 @@ Apache Airflow version life cycle: | Version | Current Patch/Minor | State | First Release |

[GitHub] [airflow] potiuk commented on a change in pull request #17806: (docs): update README.md

2021-08-24 Thread GitBox
potiuk commented on a change in pull request #17806: URL: https://github.com/apache/airflow/pull/17806#discussion_r695102647 ## File path: README.md ## @@ -254,44 +252,44 @@ Apache Airflow version life cycle: | Version | Current Patch/Minor | State | First Release |

[GitHub] [airflow] kaxil commented on pull request #17798: Prepare release for Kubernetes Provider

2021-08-24 Thread GitBox
kaxil commented on pull request #17798: URL: https://github.com/apache/airflow/pull/17798#issuecomment-904872262 Yup we will do that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17813: Fixed numeric list

2021-08-24 Thread GitBox
boring-cyborg[bot] commented on pull request #17813: URL: https://github.com/apache/airflow/pull/17813#issuecomment-904871978 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[airflow] branch main updated: Fixed numeric list (#17813)

2021-08-24 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 806f06b Fixed numeric list (#17813) 806f06b is

[GitHub] [airflow] kaxil merged pull request #17813: Fixed numeric list

2021-08-24 Thread GitBox
kaxil merged pull request #17813: URL: https://github.com/apache/airflow/pull/17813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil commented on pull request #17813: Fixed numeric list

2021-08-24 Thread GitBox
kaxil commented on pull request #17813: URL: https://github.com/apache/airflow/pull/17813#issuecomment-904871862 > I don’t think this would render as we want. The paragraph and code block likely need to be indented. > > p.s. you can check how this renders with `./breeze build-docs

[airflow] branch constraints-main updated: Updating constraints. Build id:1163532119

2021-08-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 4ed9e3f Updating

[GitHub] [airflow] eladkal commented on issue #17585: New Tasks to an existing DAG do not get scheduled if they have depends_on_past = True

2021-08-24 Thread GitBox
eladkal commented on issue #17585: URL: https://github.com/apache/airflow/issues/17585#issuecomment-904864396 > Thanks @eladkal, I am currently using `start_date=days_ago(1)`, for a DAG that runs every 30 minutes, would you suggest using `start_date=days_ago(0)` instead? No, I'm

[GitHub] [airflow] kaxil commented on pull request #17121: [WIP] Deactivating DAGs which have been removed from files

2021-08-24 Thread GitBox
kaxil commented on pull request #17121: URL: https://github.com/apache/airflow/pull/17121#issuecomment-904855730 @SamWheating Can you take a look at failing tests please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] potiuk edited a comment on pull request #17798: Prepare release for Kubernetes Provider

2021-08-24 Thread GitBox
potiuk edited a comment on pull request #17798: URL: https://github.com/apache/airflow/pull/17798#issuecomment-904854629 Yes. Due to popularity of this one, once the voting completes and we release K8S provider, we will push new constraints and images including it for 2.1.3 -- This is

[GitHub] [airflow] potiuk commented on pull request #17798: Prepare release for Kubernetes Provider

2021-08-24 Thread GitBox
potiuk commented on pull request #17798: URL: https://github.com/apache/airflow/pull/17798#issuecomment-904854629 Yes. Due to popularity of this one, once the voting completes and we release K8S provider, we will push new constraints and images including it. -- This is an automated

[GitHub] [airflow] evanhlavaty commented on pull request #17798: Prepare release for Kubernetes Provider

2021-08-24 Thread GitBox
evanhlavaty commented on pull request #17798: URL: https://github.com/apache/airflow/pull/17798#issuecomment-904852186 Will there be a rebuild/deploy of the 2.1.3 dockerhub images? I just pulled 2.1.3 image this morning and this fix was not included, leaving the KPO still broken. --

[airflow] branch constaints-2-2 created (now 6610e2d)

2021-08-24 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch constaints-2-2 in repository https://gitbox.apache.org/repos/asf/airflow.git. at 6610e2d Updating constraints. Build id:1161365036 No new revisions were added by this update.

[airflow] branch v2-2-test created (now 97f0065)

2021-08-24 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git. at 97f0065 Show all import_errors from zip files (#17759) No new revisions were added by this update.

[airflow] branch main updated (98d45cb -> 97f0065)

2021-08-24 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 98d45cb Improves documentation about modules management (#17757) add 97f0065 Show all import_errors

[GitHub] [airflow] jedcunningham merged pull request #17759: Show all import_errors from zip files

2021-08-24 Thread GitBox
jedcunningham merged pull request #17759: URL: https://github.com/apache/airflow/pull/17759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on pull request #17759: Show all import_errors from zip files

2021-08-24 Thread GitBox
jedcunningham commented on pull request #17759: URL: https://github.com/apache/airflow/pull/17759#issuecomment-904829155 (The mssql failures are unrelated to this change) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] kaxil commented on pull request #17813: Fixed numeric list

2021-08-24 Thread GitBox
kaxil commented on pull request #17813: URL: https://github.com/apache/airflow/pull/17813#issuecomment-904827251 Or the following to skip spelling checks: ``` ❯ ./breeze build-docs -- --package-filter=apache-airflow --docs-only ``` -- This is an automated message from the

[airflow-ci-infra] 01/01: Merge pull request #39 from apache/update-to-2.280.3

2021-08-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-ci-infra.git commit c109f275e1fb97ceb27511a1a0ba5dee14285dc0 Merge: c60802e bb3ce21 Author: Jarek Potiuk AuthorDate: Tue Aug 24

[airflow-ci-infra] branch main updated (c60802e -> c109f27)

2021-08-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow-ci-infra.git. from c60802e Merge pull request #38 from apache/upgrade-to-latest-runner add bb3ce21 Update runner to

[GitHub] [airflow-ci-infra] potiuk merged pull request #39: Update runner to 2.280.3

2021-08-24 Thread GitBox
potiuk merged pull request #39: URL: https://github.com/apache/airflow-ci-infra/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (c4fd84a -> 98d45cb)

2021-08-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from c4fd84a fix EXTRA_LOGGER_NAMES param and related docs (#17808) add 98d45cb Improves documentation about

[GitHub] [airflow] potiuk merged pull request #17757: Improves documentation about modules management

2021-08-24 Thread GitBox
potiuk merged pull request #17757: URL: https://github.com/apache/airflow/pull/17757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] joshk-kang commented on issue #17585: New Tasks to an existing DAG do not get scheduled if they have depends_on_past = True

2021-08-24 Thread GitBox
joshk-kang commented on issue #17585: URL: https://github.com/apache/airflow/issues/17585#issuecomment-904825754 Thanks @eladkal, I am currently using `start_date=days_ago(1)`, for a DAG that runs every 30 minutes, would you suggest using `start_date=days_ago(0)` instead? -- This is an

[airflow] branch main updated (83167a6 -> c4fd84a)

2021-08-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 83167a6 API documentation spelling fix (#17811) add c4fd84a fix EXTRA_LOGGER_NAMES param and related docs

[GitHub] [airflow] potiuk merged pull request #17808: fix EXTRA_LOGGER_NAMES param and related docs

2021-08-24 Thread GitBox
potiuk merged pull request #17808: URL: https://github.com/apache/airflow/pull/17808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #17808: fix EXTRA_LOGGER_NAMES param and related docs

2021-08-24 Thread GitBox
potiuk commented on pull request #17808: URL: https://github.com/apache/airflow/pull/17808#issuecomment-904822898 > Not sure that the failing tests are related to this PR, should I look into it or retry running the tests? Not related - we seem to have again some mssql (it's a bit

[GitHub] [airflow] gmsantos opened a new pull request #17817: Increase width for "Run" column

2021-08-24 Thread GitBox
gmsantos opened a new pull request #17817: URL: https://github.com/apache/airflow/pull/17817 closes: #17810 After Airflow 2.1.3 upgrade the "Run" column became too small for the scheduled status:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17817: Increase width for "Run" column

2021-08-24 Thread GitBox
boring-cyborg[bot] commented on pull request #17817: URL: https://github.com/apache/airflow/pull/17817#issuecomment-904815896 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] kiwy42 opened a new pull request #17816: Pull Request #17342: add support to enable kinit options [-f|-F] and [-a|-A]

2021-08-24 Thread GitBox
kiwy42 opened a new pull request #17816: URL: https://github.com/apache/airflow/pull/17816 Feature request #17314 Add to default option in `config.yaml` and `default_airflow.cfg` to cause no regression. kinit can now emit non forwardable ticket and ticket without originate IP. Add

[GitHub] [airflow] potiuk edited a comment on issue #17812: Unable to install Airflow 2.1.3 with pipenv due to conflicting constraints on markupsafe dependency version

2021-08-24 Thread GitBox
potiuk edited a comment on issue #17812: URL: https://github.com/apache/airflow/issues/17812#issuecomment-904811189 > Thanks @potiuk. I had previously read through the installation tools section, but I wasn't familiar with poetry or pip-tools and didn't realize that the same advice

[GitHub] [airflow] potiuk commented on issue #17812: Unable to install Airflow 2.1.3 with pipenv due to conflicting constraints on markupsafe dependency version

2021-08-24 Thread GitBox
potiuk commented on issue #17812: URL: https://github.com/apache/airflow/issues/17812#issuecomment-904811189 > Thanks @potiuk. I had previously read through the installation tools section, but I wasn't familiar with poetry or pip-tools and didn't realize that the same advice applied to

[GitHub] [airflow] kiwy42 closed pull request #17342: From feature request #17314: add support to enable kinit options [-f|-F] and [-a|-A]

2021-08-24 Thread GitBox
kiwy42 closed pull request #17342: URL: https://github.com/apache/airflow/pull/17342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on a change in pull request #17797: Fix broken MSSQL test

2021-08-24 Thread GitBox
potiuk commented on a change in pull request #17797: URL: https://github.com/apache/airflow/pull/17797#discussion_r695028515 ## File path: tests/task/task_runner/test_standard_task_runner.py ## @@ -181,40 +179,40 @@ def test_on_kill(self): except OSError:

[GitHub] [airflow] potiuk commented on pull request #17551: Fix Invalid log order in ElasticsearchTaskHandler

2021-08-24 Thread GitBox
potiuk commented on pull request #17551: URL: https://github.com/apache/airflow/pull/17551#issuecomment-904804777 ~ week or so. We are following about monthly cadence of releasing providers. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] whitleykeith commented on issue #16001: Can't view running tasks logs using KubernetesExecutor.

2021-08-24 Thread GitBox
whitleykeith commented on issue #16001: URL: https://github.com/apache/airflow/issues/16001#issuecomment-904798933 I've had this issue for a while now, but I was able to resolve it by adding this to the top of my `dag.py` file. ```python # Set Task Logger to INFO for better

[GitHub] [airflow] uranusjr commented on a change in pull request #17552: AIP 39: Documentation

2021-08-24 Thread GitBox
uranusjr commented on a change in pull request #17552: URL: https://github.com/apache/airflow/pull/17552#discussion_r695019071 ## File path: docs/apache-airflow/howto/timetable.rst ## @@ -0,0 +1,261 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] [airflow] uranusjr commented on a change in pull request #17552: AIP 39: Documentation

2021-08-24 Thread GitBox
uranusjr commented on a change in pull request #17552: URL: https://github.com/apache/airflow/pull/17552#discussion_r695018461 ## File path: docs/apache-airflow/howto/timetable.rst ## @@ -0,0 +1,261 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] [airflow] uranusjr commented on a change in pull request #17552: AIP 39: Documentation

2021-08-24 Thread GitBox
uranusjr commented on a change in pull request #17552: URL: https://github.com/apache/airflow/pull/17552#discussion_r695017703 ## File path: docs/apache-airflow/howto/timetable.rst ## @@ -0,0 +1,261 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] [airflow] uranusjr commented on issue #17814: Last Dagrun is not working.

2021-08-24 Thread GitBox
uranusjr commented on issue #17814: URL: https://github.com/apache/airflow/issues/17814#issuecomment-904787987 The code is in `airflow/www/views.py`. Search for `def last_dagruns` and the error is toward the bottom of the function. Change this ```python resp = {

[GitHub] [airflow] uranusjr commented on pull request #17813: Fixed numeric list

2021-08-24 Thread GitBox
uranusjr commented on pull request #17813: URL: https://github.com/apache/airflow/pull/17813#issuecomment-904784135 I don’t think this would render as we want. The paragraph and code block likely need to be indented. p.s. you can check how this renders with `./breeze build-docs

[GitHub] [airflow] jayantsande25 commented on issue #17815: Missing example for Salesforce DAG

2021-08-24 Thread GitBox
jayantsande25 commented on issue #17815: URL: https://github.com/apache/airflow/issues/17815#issuecomment-904767709 @xinbinhuang issue created for salesforce DAG. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] jayantsande25 opened a new issue #17815: Missing example for Salesforce DAG

2021-08-24 Thread GitBox
jayantsande25 opened a new issue #17815: URL: https://github.com/apache/airflow/issues/17815 **Description** airflow/providers/salesforce/example_dags/__init__.py Missing example of Salesforce DAG ( rest api, bulk api) **Use case / motivation** An example DAG on

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17815: Missing example for Salesforce DAG

2021-08-24 Thread GitBox
boring-cyborg[bot] commented on issue #17815: URL: https://github.com/apache/airflow/issues/17815#issuecomment-904766619 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] commented on pull request #17813: Fixed numeric list

2021-08-24 Thread GitBox
github-actions[bot] commented on pull request #17813: URL: https://github.com/apache/airflow/pull/17813#issuecomment-904762946 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] potiuk commented on pull request #17342: From feature request #17314: add support to enable kinit options [-f|-F] and [-a|-A]

2021-08-24 Thread GitBox
potiuk commented on pull request #17342: URL: https://github.com/apache/airflow/pull/17342#issuecomment-904752772 Just close the PR and open a new one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] Aakcht commented on pull request #17808: fix EXTRA_LOGGER_NAMES param and related docs

2021-08-24 Thread GitBox
Aakcht commented on pull request #17808: URL: https://github.com/apache/airflow/pull/17808#issuecomment-904741368 Not sure that the failing tests are related to this PR, should I look into it or retry running the tests? -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] kiwy42 edited a comment on pull request #17342: From feature request #17314: add support to enable kinit options [-f|-F] and [-a|-A]

2021-08-24 Thread GitBox
kiwy42 edited a comment on pull request #17342: URL: https://github.com/apache/airflow/pull/17342#issuecomment-904738950 So I'm quiet bad when it come to git so I destroy my repo and reforked and add my changes and my 3 changes only in this repo: https://github.com/kiwy42/airflow However

[GitHub] [airflow] kiwy42 commented on pull request #17342: From feature request #17314: add support to enable kinit options [-f|-F] and [-a|-A]

2021-08-24 Thread GitBox
kiwy42 commented on pull request #17342: URL: https://github.com/apache/airflow/pull/17342#issuecomment-904738950 So I'm quiet bad when it come to git so I destroy my repo and reforked and add my changes and my 3 changes only in this repo: https://github.com/kiwy42/airflow However it

[GitHub] [airflow] github-actions[bot] commented on pull request #17764: Helm chart: add the number of retention days for log groomer through env vars.

2021-08-24 Thread GitBox
github-actions[bot] commented on pull request #17764: URL: https://github.com/apache/airflow/pull/17764#issuecomment-904738613 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] jedcunningham closed pull request #17764: Helm chart: add the number of retention days for log groomer through env vars.

2021-08-24 Thread GitBox
jedcunningham closed pull request #17764: URL: https://github.com/apache/airflow/pull/17764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on pull request #17764: Helm chart: add the number of retention days for log groomer through env vars.

2021-08-24 Thread GitBox
jedcunningham commented on pull request #17764: URL: https://github.com/apache/airflow/pull/17764#issuecomment-904738372 (Rekicking CI) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] github-actions[bot] commented on pull request #17757: Improves documentation about modules management

2021-08-24 Thread GitBox
github-actions[bot] commented on pull request #17757: URL: https://github.com/apache/airflow/pull/17757#issuecomment-904731026 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] jedcunningham commented on a change in pull request #17757: Improves documentation about modules management

2021-08-24 Thread GitBox
jedcunningham commented on a change in pull request #17757: URL: https://github.com/apache/airflow/pull/17757#discussion_r694946565 ## File path: docs/apache-airflow/modules_management.rst ## @@ -68,99 +81,190 @@ In the next section, you will learn how to create your own

[GitHub] [airflow] bbovenzi commented on a change in pull request #17732: Add Next Run to UI

2021-08-24 Thread GitBox
bbovenzi commented on a change in pull request #17732: URL: https://github.com/apache/airflow/pull/17732#discussion_r694945886 ## File path: airflow/www/templates/airflow/dag.html ## @@ -84,8 +84,17 @@ {{ state_token }} {% endif %} -schedule:

[GitHub] [airflow] jedcunningham commented on a change in pull request #17757: Improves documentation about modules management

2021-08-24 Thread GitBox
jedcunningham commented on a change in pull request #17757: URL: https://github.com/apache/airflow/pull/17757#discussion_r694945287 ## File path: docs/apache-airflow/modules_management.rst ## @@ -68,99 +81,192 @@ In the next section, you will learn how to create your own

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17814: Last Dagrun is not working.

2021-08-24 Thread GitBox
boring-cyborg[bot] commented on issue #17814: URL: https://github.com/apache/airflow/issues/17814#issuecomment-904722248 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] zealpatel1990 opened a new issue #17814: Last Dagrun is not working.

2021-08-24 Thread GitBox
zealpatel1990 opened a new issue #17814: URL: https://github.com/apache/airflow/issues/17814 **Apache Airflow version**:2.1.3 **OS**: Running Airflow in docker container. NAME="Ubuntu" VERSION="20.04.2 LTS (Focal Fossa)" ID=ubuntu ID_LIKE=debian

[GitHub] [airflow] jedcunningham commented on a change in pull request #17797: Fix broken MSSQL test

2021-08-24 Thread GitBox
jedcunningham commented on a change in pull request #17797: URL: https://github.com/apache/airflow/pull/17797#discussion_r694931041 ## File path: tests/task/task_runner/test_standard_task_runner.py ## @@ -228,6 +225,8 @@ def test_on_kill(self): for process in

[GitHub] [airflow] agrounds commented on issue #17812: Unable to install Airflow 2.1.3 with pipenv due to conflicting constraints on markupsafe dependency version

2021-08-24 Thread GitBox
agrounds commented on issue #17812: URL: https://github.com/apache/airflow/issues/17812#issuecomment-904714178 Thanks @potiuk. I had previously read through the installation tools section, but I wasn't familiar with poetry or pip-tools and didn't realize that the same advice applied to

[GitHub] [airflow] bbovenzi commented on a change in pull request #17732: Add Next Run to UI

2021-08-24 Thread GitBox
bbovenzi commented on a change in pull request #17732: URL: https://github.com/apache/airflow/pull/17732#discussion_r694926015 ## File path: airflow/www/templates/airflow/dags.html ## @@ -98,7 +98,10 @@ {{ page_title }} Schedule

  1   2   3   >