[GitHub] [airflow] boring-cyborg[bot] commented on issue #17843: Traceback Error Resulting from Deleting a Dag

2021-08-25 Thread GitBox
boring-cyborg[bot] commented on issue #17843: URL: https://github.com/apache/airflow/issues/17843#issuecomment-906105699 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] edctorr opened a new issue #17843: Traceback Error Resulting from Deleting a Dag

2021-08-25 Thread GitBox
edctorr opened a new issue #17843: URL: https://github.com/apache/airflow/issues/17843 Python version: 3.8.10 Airflow version: 2.1.3 Hello, Whenever I try and delete a DAG, I receive a Traceback Error. I have tried to change load_examples = False inside airflow.cfg and

[GitHub] [airflow] anuj-condenast opened a new issue #17842: Add a config or variable which will schedule the DAG at the same time as given instead of end of that schedule.

2021-08-25 Thread GitBox
anuj-condenast opened a new issue #17842: URL: https://github.com/apache/airflow/issues/17842 **Description** We all have faced issues with Airflow scheduling, where it schedules a DAG at the end of the given schedule. We want a variable or config that could turn that end

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17842: Add a config or variable which will schedule the DAG at the same time as given instead of end of that schedule.

2021-08-25 Thread GitBox
boring-cyborg[bot] commented on issue #17842: URL: https://github.com/apache/airflow/issues/17842#issuecomment-906101685 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] aprettyloner edited a comment on issue #10288: gcs_to_bigquery using deprecated methods

2021-08-25 Thread GitBox
aprettyloner edited a comment on issue #10288: URL: https://github.com/apache/airflow/issues/10288#issuecomment-906012109 My team is also seeing the deprecation warning for decorator in `gcs_to_bigquery` on all `GCSToBigQueryOperator` imports. This is noisy and is misleading some of our

[GitHub] [airflow] aprettyloner edited a comment on issue #10288: gcs_to_bigquery using deprecated methods

2021-08-25 Thread GitBox
aprettyloner edited a comment on issue #10288: URL: https://github.com/apache/airflow/issues/10288#issuecomment-906012109 My team is also seeing the deprecation warning for decorator in `gcs_to_bigquery` on all `GCSToBigQueryOperator` imports. This is noisy and leads some of our

[GitHub] [airflow] aprettyloner edited a comment on issue #10288: gcs_to_bigquery using deprecated methods

2021-08-25 Thread GitBox
aprettyloner edited a comment on issue #10288: URL: https://github.com/apache/airflow/issues/10288#issuecomment-906012109 My team is also seeing the deprecation warning for decorator in `gcs_to_bigquery` on all `GCSToBigQueryOperator` imports. This is noisy as it is not coming from our

[GitHub] [airflow] aprettyloner edited a comment on issue #10288: gcs_to_bigquery using deprecated methods

2021-08-25 Thread GitBox
aprettyloner edited a comment on issue #10288: URL: https://github.com/apache/airflow/issues/10288#issuecomment-906012109 My team is also seeing the deprecation warning. ```

[GitHub] [airflow] aprettyloner commented on issue #10288: gcs_to_bigquery using deprecated methods

2021-08-25 Thread GitBox
aprettyloner commented on issue #10288: URL: https://github.com/apache/airflow/issues/10288#issuecomment-906012109 My team is also seeing the deprecation warning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] andrewgodwin commented on issue #17834: Python Sensor cannot be turned into a Smart Sensor

2021-08-25 Thread GitBox
andrewgodwin commented on issue #17834: URL: https://github.com/apache/airflow/issues/17834#issuecomment-906001148 It's not _quite_ that flexible sadly - Operators must have an async version written along with an accompanying trigger, and since the trigger runs on a different process it

[GitHub] [airflow] bbenshalom opened a new pull request #17839: Add DAG run abort endpoint

2021-08-25 Thread GitBox
bbenshalom opened a new pull request #17839: URL: https://github.com/apache/airflow/pull/17839 Fixes #15888 The new endpoint will set the DAG run state and all of the task instances' state to FAILED I couldn't find any tests for the endpoints directly, so did not add a unit

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17839: Add DAG run abort endpoint

2021-08-25 Thread GitBox
boring-cyborg[bot] commented on pull request #17839: URL: https://github.com/apache/airflow/pull/17839#issuecomment-905972040 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] jedcunningham opened a new pull request #17838: Avoid redirect loop for users with no permissions

2021-08-25 Thread GitBox
jedcunningham opened a new pull request #17838: URL: https://github.com/apache/airflow/pull/17838 Like we recently did for users with no roles, also handle it gracefully when users have no permissions instead of letting them get stuck in a redirect loop. This also changes the

[GitHub] [airflow] github-actions[bot] closed pull request #10606: Use private docker repository for K8S Operator & sidecar container

2021-08-25 Thread GitBox
github-actions[bot] closed pull request #10606: URL: https://github.com/apache/airflow/pull/10606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on issue #13853: Clearing of historic Task or DagRuns leads to failed DagRun

2021-08-25 Thread GitBox
github-actions[bot] commented on issue #13853: URL: https://github.com/apache/airflow/issues/13853#issuecomment-905956858 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[airflow] branch constraints-main updated: Updating constraints. Build id:1168386641

2021-08-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new f8339ec Updating

[GitHub] [airflow] jedcunningham commented on issue #17684: Role permissions and displaying dag load errors on webserver UI

2021-08-25 Thread GitBox
jedcunningham commented on issue #17684: URL: https://github.com/apache/airflow/issues/17684#issuecomment-905944084 Thanks again for the report @kn6405, the fix will be in 2.2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[airflow] branch main updated (ea49c96 -> 7e93828)

2021-08-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from ea49c96 Fix typos in docs & ``bug_report`` template (#17809) add 7e93828 (docs): update README.md (#17806) No

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17806: (docs): update README.md

2021-08-25 Thread GitBox
boring-cyborg[bot] commented on pull request #17806: URL: https://github.com/apache/airflow/pull/17806#issuecomment-905929533 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] potiuk merged pull request #17806: (docs): update README.md

2021-08-25 Thread GitBox
potiuk merged pull request #17806: URL: https://github.com/apache/airflow/pull/17806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #17806: (docs): update README.md

2021-08-25 Thread GitBox
github-actions[bot] commented on pull request #17806: URL: https://github.com/apache/airflow/pull/17806#issuecomment-905929170 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[airflow] branch main updated (45e61a9 -> ea49c96)

2021-08-25 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 45e61a9 Only show import errors for DAGs a user can access (#17835) add ea49c96 Fix typos in docs &

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17809: Fix typos in documentation and command example in comment in bug_report template

2021-08-25 Thread GitBox
boring-cyborg[bot] commented on pull request #17809: URL: https://github.com/apache/airflow/pull/17809#issuecomment-905928284 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] kaxil merged pull request #17809: Fix typos in documentation and command example in comment in bug_report template

2021-08-25 Thread GitBox
kaxil merged pull request #17809: URL: https://github.com/apache/airflow/pull/17809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #17809: Fix typos in documentation and command example in comment in bug_report template

2021-08-25 Thread GitBox
github-actions[bot] commented on pull request #17809: URL: https://github.com/apache/airflow/pull/17809#issuecomment-905928116 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[airflow] branch main updated: Only show import errors for DAGs a user can access (#17835)

2021-08-25 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 45e61a9 Only show import errors for DAGs a

[GitHub] [airflow] kaxil merged pull request #17835: Only show import errors for DAGs a user can access

2021-08-25 Thread GitBox
kaxil merged pull request #17835: URL: https://github.com/apache/airflow/pull/17835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil closed issue #17684: Role permissions and displaying dag load errors on webserver UI

2021-08-25 Thread GitBox
kaxil closed issue #17684: URL: https://github.com/apache/airflow/issues/17684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on issue #17836: sqlalchemy.exc.ProgrammingError: (psycopg2.errors.UndefinedTable) relation "dag" does not exist

2021-08-25 Thread GitBox
jedcunningham commented on issue #17836: URL: https://github.com/apache/airflow/issues/17836#issuecomment-905916378 @fe2906 please open another issue with details if you found a bug. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] jedcunningham closed issue #17836: sqlalchemy.exc.ProgrammingError: (psycopg2.errors.UndefinedTable) relation "dag" does not exist

2021-08-25 Thread GitBox
jedcunningham closed issue #17836: URL: https://github.com/apache/airflow/issues/17836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] msolano00 edited a comment on issue #16398: Enhance impersonation on Restful API

2021-08-25 Thread GitBox
msolano00 edited a comment on issue #16398: URL: https://github.com/apache/airflow/issues/16398#issuecomment-905896893 @ashb Hi, thanks you for reply and sorry for the late response, got pulled into something at work. Yes, exactly that is the behavior. Have a property that allows

[GitHub] [airflow] msolano00 commented on issue #16398: Enhance impersonation on Restful API

2021-08-25 Thread GitBox
msolano00 commented on issue #16398: URL: https://github.com/apache/airflow/issues/16398#issuecomment-905896893 @ashb Hi, thanks you for reply! Yes, exactly that is the behavior. Have a property that allows authenticated users (like a service account) to run jobs as other users.

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17836: sqlalchemy.exc.ProgrammingError: (psycopg2.errors.UndefinedTable) relation "dag" does not exist

2021-08-25 Thread GitBox
boring-cyborg[bot] commented on issue #17836: URL: https://github.com/apache/airflow/issues/17836#issuecomment-905887844 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] fe2906 opened a new issue #17836: sqlalchemy.exc.ProgrammingError: (psycopg2.errors.UndefinedTable) relation "dag" does not exist

2021-08-25 Thread GitBox
fe2906 opened a new issue #17836: URL: https://github.com/apache/airflow/issues/17836 **Apache Airflow version**: **OS**: **Apache Airflow Provider versions**: **Deployment**: **What happened**:

[GitHub] [airflow] jedcunningham opened a new pull request #17835: Only show import errors for DAGs a user can access

2021-08-25 Thread GitBox
jedcunningham opened a new pull request #17835: URL: https://github.com/apache/airflow/pull/17835 We should only show import errors for DAGs that the user can access. For new DAGs (ones that have not previously parsed successfully), import errors will only be shown to users who can

[GitHub] [airflow] mnojek commented on a change in pull request #17809: Fix typos in documentation and command example in comment in bug_report template

2021-08-25 Thread GitBox
mnojek commented on a change in pull request #17809: URL: https://github.com/apache/airflow/pull/17809#discussion_r696084606 ## File path: .github/ISSUE_TEMPLATE/bug_report.md ## @@ -19,7 +19,7 @@ Please complete the next sections or the issue will be closed. **OS**: - +

[GitHub] [airflow] potiuk edited a comment on pull request #17745: Add triggerer to `docker-compose.yaml` file

2021-08-25 Thread GitBox
potiuk edited a comment on pull request #17745: URL: https://github.com/apache/airflow/pull/17745#issuecomment-905837509 Yep. Because we stopped using it. I am just about to delete `apache/airflow-ci` images because we switched to `ghcr.io` github images ~ 2 weeks ago and last week we

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #17819: Promptly handle task callback from _process_executor_events

2021-08-25 Thread GitBox
ephraimbuddy commented on a change in pull request #17819: URL: https://github.com/apache/airflow/pull/17819#discussion_r696076214 ## File path: tests/jobs/test_scheduler_job.py ## @@ -207,17 +207,18 @@ def test_process_executor_events(self, mock_stats_incr,

[GitHub] [airflow] potiuk commented on pull request #17745: Add triggerer to `docker-compose.yaml` file

2021-08-25 Thread GitBox
potiuk commented on pull request #17745: URL: https://github.com/apache/airflow/pull/17745#issuecomment-905837509 Yep. Because we stopped using it. I am just about to delete `apache/airflow-ci' images because we switched to `ghcr.io` github images ~ 2 weeks ago and last week we disabled

[GitHub] [airflow] potiuk closed issue #17834: Python Sensor cannot be turned into a Smart Sensor

2021-08-25 Thread GitBox
potiuk closed issue #17834: URL: https://github.com/apache/airflow/issues/17834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham closed pull request #17797: Fix broken MSSQL test

2021-08-25 Thread GitBox
jedcunningham closed pull request #17797: URL: https://github.com/apache/airflow/pull/17797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #17834: Python Sensor cannot be turned into a Smart Sensor

2021-08-25 Thread GitBox
potiuk commented on issue #17834: URL: https://github.com/apache/airflow/issues/17834#issuecomment-905831938 It's not supported because it has "callable" which cannot be serialised. But FEAR NOUGHT ! @andrewgodwin is working on implementing AIP-40

[GitHub] [airflow] jedcunningham closed pull request #17397: Update to Celery 5

2021-08-25 Thread GitBox
jedcunningham closed pull request #17397: URL: https://github.com/apache/airflow/pull/17397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] atorres-eqrx commented on pull request #12809: Add 'headers' to template_fields in HttpSensor

2021-08-25 Thread GitBox
atorres-eqrx commented on pull request #12809: URL: https://github.com/apache/airflow/pull/12809#issuecomment-905821908 > > How does one know in which release of airflow this change has been deployed? > > I'm on airflow 1.10.15 and it seems that `headers` is not included in

[GitHub] [airflow] eladkal commented on pull request #12809: Add 'headers' to template_fields in HttpSensor

2021-08-25 Thread GitBox
eladkal commented on pull request #12809: URL: https://github.com/apache/airflow/pull/12809#issuecomment-905815868 > How does one know in which release of airflow this change has been deployed? > > I'm on airflow 1.10.15 and it seems that `headers` is not included in

[GitHub] [airflow] jbsilva edited a comment on pull request #17745: Add triggerer to `docker-compose.yaml` file

2021-08-25 Thread GitBox
jbsilva edited a comment on pull request #17745: URL: https://github.com/apache/airflow/pull/17745#issuecomment-905808906 I read the 2.2.0 warning, but seems that the most recent image on Docker Hub (_apache/airflow-ci:main-python3.9_) still does not have the _triggerer_ command:

[GitHub] [airflow] jbsilva commented on pull request #17745: Add triggerer to `docker-compose.yaml` file

2021-08-25 Thread GitBox
jbsilva commented on pull request #17745: URL: https://github.com/apache/airflow/pull/17745#issuecomment-905808906 I read the 2.2.0 warning, but seems that the most recent Docker Hub image (_apache/airflow-ci:main-python3.9_) still does not have the _triggerer_ command: `airflow

[GitHub] [airflow] atorres-eqrx commented on pull request #12809: Add 'headers' to template_fields in HttpSensor

2021-08-25 Thread GitBox
atorres-eqrx commented on pull request #12809: URL: https://github.com/apache/airflow/pull/12809#issuecomment-905808828 How does one know in which release of airflow this change has been deployed? I'm on airflow 1.10.15 and it seems that `headers` is not included in

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #17819: Promptly handle task callback from _process_executor_events

2021-08-25 Thread GitBox
ephraimbuddy commented on a change in pull request #17819: URL: https://github.com/apache/airflow/pull/17819#discussion_r695882206 ## File path: tests/jobs/test_scheduler_job.py ## @@ -207,17 +207,18 @@ def test_process_executor_events(self, mock_stats_incr,

[airflow] branch constraints-main updated: Updating constraints. Build id:1167561582

2021-08-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 62166ec Updating

[GitHub] [airflow] potiuk commented on issue #17833: AwsBaseHook isn't using connection.host, using connection.extra.host instead

2021-08-25 Thread GitBox
potiuk commented on issue #17833: URL: https://github.com/apache/airflow/issues/17833#issuecomment-905773352 Nice one. @alwaysmpe - I can assign you this one. You can make it in the way that it checks if "host" is in extra an uses it from there if it's there (+raise a deprecation

[GitHub] [airflow] potiuk edited a comment on issue #17828: Docker image entrypoint does not parse redis URLs correctly with no password

2021-08-25 Thread GitBox
potiuk edited a comment on issue #17828: URL: https://github.com/apache/airflow/issues/17828#issuecomment-905761599 1. How do you set your broker variable ? 2. Can you show us result of `echo "'$(airflow config get-value celery broker_url)'"` - i added ' to see the boundaries of what

[GitHub] [airflow] potiuk commented on issue #17828: Docker image entrypoint does not parse redis URLs correctly with no password

2021-08-25 Thread GitBox
potiuk commented on issue #17828: URL: https://github.com/apache/airflow/issues/17828#issuecomment-905761599 1. How do you set your broker variable 2. Can you show us result of `echo "'$(airflow config get-value celery broker_url)'"` - i added ' to see the boundaries of what it prints.

[GitHub] [airflow] potiuk edited a comment on issue #17828: Docker image entrypoint does not parse redis URLs correctly with no password

2021-08-25 Thread GitBox
potiuk edited a comment on issue #17828: URL: https://github.com/apache/airflow/issues/17828#issuecomment-905758371 BTW. The regexp pattern is correct .. It should nicely match the `redis://redis-analytics-airflow.signal:6379/1`. I am just thinking maybe it's about End-of-line or " "

[GitHub] [airflow] cablespaghetti edited a comment on pull request #17211: Chart: Use stable API versions where available

2021-08-25 Thread GitBox
cablespaghetti edited a comment on pull request #17211: URL: https://github.com/apache/airflow/pull/17211#issuecomment-905692061 Ok hopefully I've done enough now. Also upgraded the default it tests against to 1.22. Rerunning everything locally to check this hasn't broken anything at the

[GitHub] [airflow] potiuk commented on issue #17828: Docker image entrypoint does not parse redis URLs correctly with no password

2021-08-25 Thread GitBox
potiuk commented on issue #17828: URL: https://github.com/apache/airflow/issues/17828#issuecomment-905758371 BTW. The regexp pattern is correct .. It should nicely match the `redis://redis-analytics-airflow.signal:6379/1`. I am just thinking maybe it's about End-of-line returned by

[airflow] branch main updated (96f7e3f -> a759499)

2021-08-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 96f7e3f Increase width for Run column (#17817) add a759499 Update INTHEWILD.md (#17832) No new revisions were

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17832: Update INTHEWILD.md

2021-08-25 Thread GitBox
boring-cyborg[bot] commented on pull request #17832: URL: https://github.com/apache/airflow/pull/17832#issuecomment-905751884 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] potiuk merged pull request #17832: Update INTHEWILD.md

2021-08-25 Thread GitBox
potiuk merged pull request #17832: URL: https://github.com/apache/airflow/pull/17832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jeffvswanson opened a new issue #17834: Python Sensor cannot be turned into a Smart Sensor

2021-08-25 Thread GitBox
jeffvswanson opened a new issue #17834: URL: https://github.com/apache/airflow/issues/17834 **Apache Airflow version**: 2.02 **OS**: Amazon Linux AMI **Apache Airflow Provider versions**: apache-airflow-providers-amazon, v2.1.0

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17834: Python Sensor cannot be turned into a Smart Sensor

2021-08-25 Thread GitBox
boring-cyborg[bot] commented on issue #17834: URL: https://github.com/apache/airflow/issues/17834#issuecomment-905751259 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk commented on pull request #15177: Import connections from a file

2021-08-25 Thread GitBox
potiuk commented on pull request #15177: URL: https://github.com/apache/airflow/pull/15177#issuecomment-905751128 'And answering your other question @mm-lehmann - in case you have not noticed the "import" command is counterpart of the "export" command

[GitHub] [airflow] subkanthi commented on pull request #17068: Influxdb Hook

2021-08-25 Thread GitBox
subkanthi commented on pull request #17068: URL: https://github.com/apache/airflow/pull/17068#issuecomment-905734948 > LGTM and heppy to merge as soon as as you rebase @subkanthi - there were some unrelated errors in main (fixed since then). Can you please rebase? @potiuk , The docs

[GitHub] [airflow] potiuk edited a comment on issue #17828: Docker image entrypoint does not parse redis URLs correctly with no password

2021-08-25 Thread GitBox
potiuk edited a comment on issue #17828: URL: https://github.com/apache/airflow/issues/17828#issuecomment-905724680 Hm I somehow have a feeling (do no know yet) that it could be side-effect of this change: which instead of reading the `__CELERY__` env variable, uses `airflow get-value`:

[GitHub] [airflow] potiuk edited a comment on issue #17828: Docker image entrypoint does not parse redis URLs correctly with no password

2021-08-25 Thread GitBox
potiuk edited a comment on issue #17828: URL: https://github.com/apache/airflow/issues/17828#issuecomment-905724680 Hm I somehow have a feeling (do no know yet) that it could be side-effect of this change: which instead of reading the `__CELERY__` env variable, uses `airflow get config`:

[GitHub] [airflow] potiuk commented on issue #17828: Docker image entrypoint does not parse redis URLs correctly with no password

2021-08-25 Thread GitBox
potiuk commented on issue #17828: URL: https://github.com/apache/airflow/issues/17828#issuecomment-905724680 Hm I somehow have a feeling (do no know yet) that it could be side-effect of this change: which instead of running the `__CELERY__` env variable, uses `airflow get config`:

[GitHub] [airflow] alwaysmpe opened a new issue #17833: AwsBaseHook isn't using connection.host, using connection.extra.host instead

2021-08-25 Thread GitBox
alwaysmpe opened a new issue #17833: URL: https://github.com/apache/airflow/issues/17833 **Apache Airflow version**: Version: v2.1.2 Git Version: .release:2.1.2+d25854dd413aa68ea70fb1ade7fe01425f456192 **OS**: PRETTY_NAME="Debian GNU/Linux 10 (buster)"

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17833: AwsBaseHook isn't using connection.host, using connection.extra.host instead

2021-08-25 Thread GitBox
boring-cyborg[bot] commented on issue #17833: URL: https://github.com/apache/airflow/issues/17833#issuecomment-905723673 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] Jorricks commented on pull request #16634: Require can_edit on DAG privileges to modify TaskInstances and DagRuns

2021-08-25 Thread GitBox
Jorricks commented on pull request #16634: URL: https://github.com/apache/airflow/pull/16634#issuecomment-905710216 CI pipeline still not running.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] cablespaghetti commented on a change in pull request #17211: Chart: Use stable API versions where available

2021-08-25 Thread GitBox
cablespaghetti commented on a change in pull request #17211: URL: https://github.com/apache/airflow/pull/17211#discussion_r695925270 ## File path: chart/values.yaml ## @@ -120,24 +129,24 @@ ingress: annotations: {} # The path for the flower Ingress -path: "" +

[GitHub] [airflow] cablespaghetti commented on pull request #17211: Chart: Use stable API versions where available

2021-08-25 Thread GitBox
cablespaghetti commented on pull request #17211: URL: https://github.com/apache/airflow/pull/17211#issuecomment-905692061 Ok hopefully I've done enough now. Also upgraded the default it tests against to 1.22. Rerunning everything locally to check this hasn't broken anything at the moment.

[GitHub] [airflow] cablespaghetti edited a comment on pull request #17211: Chart: Use stable API versions where available

2021-08-25 Thread GitBox
cablespaghetti edited a comment on pull request #17211: URL: https://github.com/apache/airflow/pull/17211#issuecomment-904661269 Really sorry this has taken so long, I have been super busy both at work and outside. I will put in some time to try and get this done tomorrow. -- This is an

[GitHub] [airflow] potiuk edited a comment on pull request #15177: Import connections from a file

2021-08-25 Thread GitBox
potiuk edited a comment on pull request #15177: URL: https://github.com/apache/airflow/pull/15177#issuecomment-905665622 If you really cared to ask this kind of question @MM-Lehmann, then I believe because apparently you wanted to hear the answer rather than show your superiority over

[GitHub] [airflow] potiuk commented on pull request #15177: Import connections from a file

2021-08-25 Thread GitBox
potiuk commented on pull request #15177: URL: https://github.com/apache/airflow/pull/15177#issuecomment-905665622 If you really cared to ask this kind of question @MM-Lehmann, then I believe because apparently you wanted to here the answer rather than show your superiority over those who

[GitHub] [airflow] mik-laj commented on a change in pull request #17741: Add Snowflake DQ Operators

2021-08-25 Thread GitBox
mik-laj commented on a change in pull request #17741: URL: https://github.com/apache/airflow/pull/17741#discussion_r695897882 ## File path: airflow/providers/snowflake/operators/snowflake.py ## @@ -125,3 +126,284 @@ def execute(self, context: Any) -> None: if

[GitHub] [airflow] mik-laj commented on a change in pull request #17741: Add Snowflake DQ Operators

2021-08-25 Thread GitBox
mik-laj commented on a change in pull request #17741: URL: https://github.com/apache/airflow/pull/17741#discussion_r695897882 ## File path: airflow/providers/snowflake/operators/snowflake.py ## @@ -125,3 +126,284 @@ def execute(self, context: Any) -> None: if

[GitHub] [airflow] KarthikRajashekaran closed issue #17831: MSSQL: Adaptive Server connection failed

2021-08-25 Thread GitBox
KarthikRajashekaran closed issue #17831: URL: https://github.com/apache/airflow/issues/17831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on a change in pull request #17797: Fix broken MSSQL test

2021-08-25 Thread GitBox
jedcunningham commented on a change in pull request #17797: URL: https://github.com/apache/airflow/pull/17797#discussion_r695890136 ## File path: tests/task/task_runner/test_standard_task_runner.py ## @@ -181,40 +179,40 @@ def test_on_kill(self): except OSError:

[GitHub] [airflow] jedcunningham commented on pull request #17797: Fix broken MSSQL test

2021-08-25 Thread GitBox
jedcunningham commented on pull request #17797: URL: https://github.com/apache/airflow/pull/17797#issuecomment-905641274 > Hmm one MSSQL test is failing with I wasn't able to reproduce that locally, and with it being in `test_scheduler_job.py` makes me suspicious it may simply be

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #17819: Promptly handle task callback from _process_executor_events

2021-08-25 Thread GitBox
ephraimbuddy commented on a change in pull request #17819: URL: https://github.com/apache/airflow/pull/17819#discussion_r695882206 ## File path: tests/jobs/test_scheduler_job.py ## @@ -207,17 +207,18 @@ def test_process_executor_events(self, mock_stats_incr,

[GitHub] [airflow] potiuk commented on issue #17827: Task stuck in running status

2021-08-25 Thread GitBox
potiuk commented on issue #17827: URL: https://github.com/apache/airflow/issues/17827#issuecomment-905622252 Siince the discussion is quite extensive there and there seem to be no conclusion whether it is a configuration issue or a bug in Airflow..let's keep it as discussion. There is no

[GitHub] [airflow] potiuk closed issue #17827: Task stuck in running status

2021-08-25 Thread GitBox
potiuk closed issue #17827: URL: https://github.com/apache/airflow/issues/17827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] leahecole commented on pull request #17820: Allow omission of `initial_node_count` if `node_pools` is specified

2021-08-25 Thread GitBox
leahecole commented on pull request #17820: URL: https://github.com/apache/airflow/pull/17820#issuecomment-905603682 Apologies - I'll fix the static checks later today. I also have a second check I think i need to add to make sure you don't have both an initial node count AND nodepools

[GitHub] [airflow] ashb commented on a change in pull request #17414: Allow custom timetable as a DAG argument

2021-08-25 Thread GitBox
ashb commented on a change in pull request #17414: URL: https://github.com/apache/airflow/pull/17414#discussion_r695823577 ## File path: airflow/models/dag.py ## @@ -92,11 +91,34 @@ log = logging.getLogger(__name__) -ScheduleInterval = Union[str, timedelta, relativedelta]

[GitHub] [airflow] ashb commented on a change in pull request #17414: Allow custom timetable as a DAG argument

2021-08-25 Thread GitBox
ashb commented on a change in pull request #17414: URL: https://github.com/apache/airflow/pull/17414#discussion_r695821210 ## File path: airflow/models/dag.py ## @@ -92,11 +91,34 @@ log = logging.getLogger(__name__) -ScheduleInterval = Union[str, timedelta, relativedelta]

[GitHub] [airflow] ashb commented on a change in pull request #17414: Allow custom timetable as a DAG argument

2021-08-25 Thread GitBox
ashb commented on a change in pull request #17414: URL: https://github.com/apache/airflow/pull/17414#discussion_r695820908 ## File path: airflow/models/dag.py ## @@ -92,11 +91,34 @@ log = logging.getLogger(__name__) -ScheduleInterval = Union[str, timedelta, relativedelta]

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17832: Update INTHEWILD.md

2021-08-25 Thread GitBox
boring-cyborg[bot] commented on pull request #17832: URL: https://github.com/apache/airflow/pull/17832#issuecomment-905549527 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] AliToro opened a new pull request #17832: Update INTHEWILD.md

2021-08-25 Thread GitBox
AliToro opened a new pull request #17832: URL: https://github.com/apache/airflow/pull/17832 Add Tapsi to the list of Airflow users -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] KarthikRajashekaran opened a new issue #17831: MSSQL: Adaptive Server connection failed

2021-08-25 Thread GitBox
KarthikRajashekaran opened a new issue #17831: URL: https://github.com/apache/airflow/issues/17831 **Apache Airflow version**: v2.0.2 **OS**: MWAA **Apache Airflow Provider versions**: apache-airflow-providers-microsoft-mssql==1.0.1

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17831: MSSQL: Adaptive Server connection failed

2021-08-25 Thread GitBox
boring-cyborg[bot] commented on issue #17831: URL: https://github.com/apache/airflow/issues/17831#issuecomment-905544763 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] denimalpaca commented on a change in pull request #17741: Add Snowflake DQ Operators

2021-08-25 Thread GitBox
denimalpaca commented on a change in pull request #17741: URL: https://github.com/apache/airflow/pull/17741#discussion_r695794477 ## File path: airflow/providers/snowflake/operators/snowflake.py ## @@ -125,3 +126,299 @@ def execute(self, context: Any) -> None: if

[GitHub] [airflow] ephraimbuddy commented on pull request #17819: Promptly handle task callback from _process_executor_events

2021-08-25 Thread GitBox
ephraimbuddy commented on pull request #17819: URL: https://github.com/apache/airflow/pull/17819#issuecomment-905524522 This is how to reproduce the error: Run this dag and assert that it's successful. Then uncomment the `depend_on_past` arg so it's proper but `depend_on_past` instead of

[GitHub] [airflow] MM-Lehmann commented on pull request #15177: Import connections from a file

2021-08-25 Thread GitBox
MM-Lehmann commented on pull request #15177: URL: https://github.com/apache/airflow/pull/15177#issuecomment-905511912 How did this not get a documentation entry? Any definition of how the json must look like? Even the sample.json mentioned in the tests is not in this PR, is it? -- This

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #17819: Promptly handle task callback from _process_executor_events

2021-08-25 Thread GitBox
ephraimbuddy commented on a change in pull request #17819: URL: https://github.com/apache/airflow/pull/17819#discussion_r695735143 ## File path: tests/jobs/test_scheduler_job.py ## @@ -207,30 +207,32 @@ def test_process_executor_events(self, mock_stats_incr,

[GitHub] [airflow] ephraimbuddy commented on pull request #17819: Promptly handle task callback from _process_executor_events

2021-08-25 Thread GitBox
ephraimbuddy commented on pull request #17819: URL: https://github.com/apache/airflow/pull/17819#issuecomment-905475151 Hi @kaxil, what do you think about this implementation? still working on tests... -- This is an automated message from the Apache Git Service. To respond to the

[airflow] branch main updated (06e53f2 -> 96f7e3f)

2021-08-25 Thread ryanahamilton
This is an automated email from the ASF dual-hosted git repository. ryanahamilton pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 06e53f2 Chart: configurable number of retention days for log groomers (#17764) add 96f7e3f Increase

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17817: Increase width for "Run" column

2021-08-25 Thread GitBox
boring-cyborg[bot] commented on pull request #17817: URL: https://github.com/apache/airflow/pull/17817#issuecomment-905471630 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] ryanahamilton closed issue #17810: "Runs" column being cut off by "Schedule" column in web UI

2021-08-25 Thread GitBox
ryanahamilton closed issue #17810: URL: https://github.com/apache/airflow/issues/17810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ryanahamilton merged pull request #17817: Increase width for "Run" column

2021-08-25 Thread GitBox
ryanahamilton merged pull request #17817: URL: https://github.com/apache/airflow/pull/17817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] eejbyfeldt commented on pull request #17821: Improve graph view load time for dags with open groups

2021-08-25 Thread GitBox
eejbyfeldt commented on pull request #17821: URL: https://github.com/apache/airflow/pull/17821#issuecomment-905421759 > Nice work! Could you provide steps on how to test the performance locally? Yes, here is what i did: In order to run the webserver locally I did the

  1   2   >