[GitHub] [airflow] potiuk commented on pull request #28256: Include full path to Python files under zip path while clearing import errors.

2023-01-20 Thread via GitHub
potiuk commented on PR #28256: URL: https://github.com/apache/airflow/pull/28256#issuecomment-1399202367 It can be. You can just recursively find if the files exist splitting by directory separator. The advantage will be that you will do it only once during migration so it might take even

[airflow-client-python] tag 2.5.0 created (now 1a6f6ee)

2023-01-20 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to tag 2.5.0 in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git at 1a6f6ee (commit) No new revisions were added by this update.

[airflow-client-python] branch master updated: Update Changelog for 2.5.0 release (#58)

2023-01-20 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git The following commit(s) were added to refs/heads/master by this push: new 1a6f6ee Update

[GitHub] [airflow-client-python] ephraimbuddy merged pull request #58: Update Changelog for 2.5.0 release

2023-01-20 Thread via GitHub
ephraimbuddy merged PR #58: URL: https://github.com/apache/airflow-client-python/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow-client-python] ephraimbuddy commented on pull request #58: Update Changelog for 2.5.0 release

2023-01-20 Thread via GitHub
ephraimbuddy commented on PR #58: URL: https://github.com/apache/airflow-client-python/pull/58#issuecomment-1399192717 Ok. Looks like a review is not necessary. It's a small change too -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] rkarish opened a new pull request, #29079: Use sqlalchemy engine with pandas in DbApiHook (apache#28969)

2023-01-20 Thread via GitHub
rkarish opened a new pull request, #29079: URL: https://github.com/apache/airflow/pull/29079 Closes: apache#28969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[airflow-client-python] branch update-changelog-for-2.5.0 created (now 2870404)

2023-01-20 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch update-changelog-for-2.5.0 in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git at 2870404 Update Changelog for 2.5.0 release This branch includes the

[airflow-client-python] 01/01: Update Changelog for 2.5.0 release

2023-01-20 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch update-changelog-for-2.5.0 in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git commit 2870404823fe3060b5f4cd6011a8829f577dcade Author: Ephraim Anierobi

[GitHub] [airflow] sudeepgupta90 opened a new pull request, #29078: enhance production guide [#20999][#28637]

2023-01-20 Thread via GitHub
sudeepgupta90 opened a new pull request, #29078: URL: https://github.com/apache/airflow/pull/29078 closes: #20999 #28637 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] rkarish commented on issue #28969: "UserWarning: pandas only supports SQLAlchemy connectable" when calling MsSqlHook pandas methods

2023-01-20 Thread via GitHub
rkarish commented on issue #28969: URL: https://github.com/apache/airflow/issues/28969#issuecomment-1399188456 I'll take this one  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] tirkarthi commented on pull request #28256: Include full path to Python files under zip path while clearing import errors.

2023-01-20 Thread via GitHub
tirkarthi commented on PR #28256: URL: https://github.com/apache/airflow/pull/28256#issuecomment-1399175298 I am not sure if there is a reliable way to extract "/home/karthikeyan/airflow/dags/error_dag.zip" from "/home/karthikeyan/airflow/dags/error_dag.zip/error_dag.py" through zipfile

[GitHub] [airflow] Taragolis commented on a diff in pull request #27616: Flush the session in `handle_failure()` prior to invoking callbacks

2023-01-20 Thread via GitHub
Taragolis commented on code in PR #27616: URL: https://github.com/apache/airflow/pull/27616#discussion_r1083237739 ## airflow/models/taskinstance.py: ## @@ -1808,13 +1808,13 @@ def handle_failure( except Exception: self.log.exception("Failed to

[airflow] branch main updated (ca9a59b3e8 -> 09b3a29972)

2023-01-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from ca9a59b3e8 emit dagrun failed duration when timeout (#29076) add 09b3a29972 Migrate

[GitHub] [airflow] potiuk closed issue #28785: AIP-44 Migrate DagFileProcessorManager.clear_nonexistent_import_errors to Internal API

2023-01-20 Thread via GitHub
potiuk closed issue #28785: AIP-44 Migrate DagFileProcessorManager.clear_nonexistent_import_errors to Internal API URL: https://github.com/apache/airflow/issues/28785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] potiuk merged pull request #28976: Migrate DagFileProcessorManager.clear_nonexistent_import_errors to internal API

2023-01-20 Thread via GitHub
potiuk merged PR #28976: URL: https://github.com/apache/airflow/pull/28976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (9dedf81fa1 -> ca9a59b3e8)

2023-01-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 9dedf81fa1 Check for run_id url param when linking to graph/gantt views (#29066) add ca9a59b3e8 emit dagrun

[GitHub] [airflow] potiuk closed issue #29013: Metrics dagrun.duration.failed. not updated when the dag run failed due to timeout

2023-01-20 Thread via GitHub
potiuk closed issue #29013: Metrics dagrun.duration.failed. not updated when the dag run failed due to timeout URL: https://github.com/apache/airflow/issues/29013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk merged pull request #29076: Emit dagrun duration when it fails because of a timeout

2023-01-20 Thread via GitHub
potiuk merged PR #29076: URL: https://github.com/apache/airflow/pull/29076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on a diff in pull request #28846: Updated app to support configuring the caching hash method for FIPS

2023-01-20 Thread via GitHub
potiuk commented on code in PR #28846: URL: https://github.com/apache/airflow/pull/28846#discussion_r1083233955 ## airflow/compat/hashlib_wrapper.py: ## @@ -0,0 +1,41 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [airflow] potiuk commented on pull request #29034: Add functionality for operators to template all eligible fields (apac…

2023-01-20 Thread via GitHub
potiuk commented on PR #29034: URL: https://github.com/apache/airflow/pull/29034#issuecomment-1399164723 LGTM. @uranusjr - I think you were earlier involved in discussions about that one - WDYT? -- This is an automated message from the Apache Git Service. To respond to the message,

[airflow] branch main updated (48cab7cfeb -> 9dedf81fa1)

2023-01-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 48cab7cfeb bump (#28602) add 9dedf81fa1 Check for run_id url param when linking to graph/gantt views (#29066)

[GitHub] [airflow] potiuk merged pull request #29066: Check for run_id url param when linking to graph/gantt views

2023-01-20 Thread via GitHub
potiuk merged PR #29066: URL: https://github.com/apache/airflow/pull/29066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #28155: Links to dag graph some times display incorrect dagrun

2023-01-20 Thread via GitHub
potiuk closed issue #28155: Links to dag graph some times display incorrect dagrun URL: https://github.com/apache/airflow/issues/28155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk commented on issue #28880: Can't configure Kubernetes and Celery workers in Helm Chart

2023-01-20 Thread via GitHub
potiuk commented on issue #28880: URL: https://github.com/apache/airflow/issues/28880#issuecomment-1399161324 Just make a PR - we (or others) can easier discuss it there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] potiuk commented on pull request #29056: Handling error on cluster policy itself

2023-01-20 Thread via GitHub
potiuk commented on PR #29056: URL: https://github.com/apache/airflow/pull/29056#issuecomment-1399158895 > @potiuk (thanks for your kind review..!) I agree with you that exception catch logic on dagbag will be simplified, if using just `except Exception`. so, I reflected in the code. >

[GitHub] [airflow] potiuk commented on issue #20308: Multi Schedulers don't synchronize task instance state when using Triggerer

2023-01-20 Thread via GitHub
potiuk commented on issue #20308: URL: https://github.com/apache/airflow/issues/20308#issuecomment-1399158502 No idea @jskalasariya . There is nothing like prioritization in Airflow. Things get fixed when someone fix them because that someone decides it is important. If it is not fixed,

[GitHub] [airflow] okayhooni commented on pull request #29056: Handling error on cluster policy itself

2023-01-20 Thread via GitHub
okayhooni commented on PR #29056: URL: https://github.com/apache/airflow/pull/29056#issuecomment-1399158194 @potiuk (thanks for your kind review..!) I agree with you that exception catch logic on dagbag will be simplified, if using just `except Exception`. so, I reflected in the

[GitHub] [airflow] potiuk commented on pull request #29056: Handling error on cluster policy itself

2023-01-20 Thread via GitHub
potiuk commented on PR #29056: URL: https://github.com/apache/airflow/pull/29056#issuecomment-1399157535 LGTM now. WDYT Others (@ashb @uranusjr @jedcunningham) - maybe there was a good reason why we decided to only handle specific errors that I have not thought about. I have a feeling that

[GitHub] [airflow] potiuk commented on pull request #28256: Include full path to Python files under zip path while clearing import errors.

2023-01-20 Thread via GitHub
potiuk commented on PR #28256: URL: https://github.com/apache/airflow/pull/28256#issuecomment-1399157056 > @potiuk @uranusjr Sorry, I am little confused. Currently `ImportError` model has filename column that stores full path to Python along with zipfile like

[GitHub] [airflow] jskalasariya commented on issue #20308: Multi Schedulers don't synchronize task instance state when using Triggerer

2023-01-20 Thread via GitHub
jskalasariya commented on issue #20308: URL: https://github.com/apache/airflow/issues/20308#issuecomment-1399156944 @ashb @potiuk are we prioritising this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] syedahsn commented on a diff in pull request #29077: add retries to stop_pipeline on conflict

2023-01-20 Thread via GitHub
syedahsn commented on code in PR #29077: URL: https://github.com/apache/airflow/pull/29077#discussion_r1083228639 ## airflow/providers/amazon/aws/hooks/sagemaker.py: ## @@ -1154,19 +1154,35 @@ def stop_pipeline( :return: Status of the pipeline execution after the

[GitHub] [airflow] potiuk commented on pull request #29048: Allow downloading of dbt Cloud artifacts to non-existent paths

2023-01-20 Thread via GitHub
potiuk commented on PR #29048: URL: https://github.com/apache/airflow/pull/29048#issuecomment-1399156631 Random failures. Nice addition and nice improvements in tests. Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] potiuk commented on pull request #29052: Fix KubernetesPodOperator xcom push when `get_logs=False`

2023-01-20 Thread via GitHub
potiuk commented on PR #29052: URL: https://github.com/apache/airflow/pull/29052#issuecomment-1399155916 LGTM but I think I need also second opinion (@jedcunningham :) again )? I also think having unit tests covering the cases that would have failed previously are needed here. I am

[GitHub] [airflow] potiuk commented on pull request #29000: Skip KubernetesPodOperator task when it returns a provided exit code

2023-01-20 Thread via GitHub
potiuk commented on PR #29000: URL: https://github.com/apache/airflow/pull/29000#issuecomment-1399155414 @jedcunningham - maybe you can take a look as well especially at the exit-code retrieval part. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] syedahsn commented on a diff in pull request #29077: add retries to stop_pipeline on conflict

2023-01-20 Thread via GitHub
syedahsn commented on code in PR #29077: URL: https://github.com/apache/airflow/pull/29077#discussion_r1083228639 ## airflow/providers/amazon/aws/hooks/sagemaker.py: ## @@ -1154,19 +1154,35 @@ def stop_pipeline( :return: Status of the pipeline execution after the

[GitHub] [airflow] potiuk commented on pull request #28795: Migrate Models Variable to Internal API

2023-01-20 Thread via GitHub
potiuk commented on PR #28795: URL: https://github.com/apache/airflow/pull/28795#issuecomment-1399154745 Needs conflict resolution after other merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] potiuk commented on pull request #29065: When clearing task instances try to get associated DAGs from database

2023-01-20 Thread via GitHub
potiuk commented on PR #29065: URL: https://github.com/apache/airflow/pull/29065#issuecomment-1399152967 looks like an important one to merge if the diagnosis is correct. I have not yet looked at the details and do not get that deep knowledge about this part but might be worth seriously

[GitHub] [airflow] potiuk commented on pull request #28602: Bump OPENAPI_GENERATOR_CLI_VER to latest v5 image(5.4.0)

2023-01-20 Thread via GitHub
potiuk commented on PR #28602: URL: https://github.com/apache/airflow/pull/28602#issuecomment-1399150521 Client announced . Merging :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch main updated (886d87dc8a -> 48cab7cfeb)

2023-01-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 886d87dc8a Chart: add doc note about podtemplate images (#29032) add 48cab7cfeb bump (#28602) No new revisions

[GitHub] [airflow] potiuk merged pull request #28602: Bump OPENAPI_GENERATOR_CLI_VER to latest v5 image(5.4.0)

2023-01-20 Thread via GitHub
potiuk merged PR #28602: URL: https://github.com/apache/airflow/pull/28602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk merged pull request #29032: Chart: add doc note about podtemplate images

2023-01-20 Thread via GitHub
potiuk merged PR #29032: URL: https://github.com/apache/airflow/pull/29032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (5da085bcb2 -> 886d87dc8a)

2023-01-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 5da085bcb2 Upgrade bitnami/postgresql helm depenency from 10.5.3 to 12.1.9 (#29071) add 886d87dc8a Chart: add

[GitHub] [airflow] potiuk commented on pull request #27357: Update bitnami/postgresql dependency chart to latest version

2023-01-20 Thread via GitHub
potiuk commented on PR #27357: URL: https://github.com/apache/airflow/pull/27357#issuecomment-1399144100 Closed as #29071 has been merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk closed pull request #27357: Update bitnami/postgresql dependency chart to latest version

2023-01-20 Thread via GitHub
potiuk closed pull request #27357: Update bitnami/postgresql dependency chart to latest version URL: https://github.com/apache/airflow/pull/27357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

svn commit: r59508 - /release/airflow/clients/python/2.5.0/

2023-01-20 Thread ephraimanierobi
Author: ephraimanierobi Date: Sat Jan 21 01:43:30 2023 New Revision: 59508 Log: Release Apache Airflow Python Client 2.5.0 from 2.5.0rc1 Added: release/airflow/clients/python/2.5.0/ release/airflow/clients/python/2.5.0/apache-airflow-client-2.5.0-bin.tar.gz - copied unchanged from

[GitHub] [airflow] csm10495 commented on pull request #28808: Allow setting the name for the base container within K8s Pod Operator

2023-01-20 Thread via GitHub
csm10495 commented on PR #28808: URL: https://github.com/apache/airflow/pull/28808#issuecomment-1399136793 Also does that change it just for the instance or for the class if done that way? .. I'd have to check to know for sure. -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] csm10495 commented on pull request #28808: Allow setting the name for the base container within K8s Pod Operator

2023-01-20 Thread via GitHub
csm10495 commented on PR #28808: URL: https://github.com/apache/airflow/pull/28808#issuecomment-1399135597 It doesn't really match how params are normally passed through. Also it would look kind of weird in a taskflow dag. I think the PR as is makes a bit more sense. -- This

[GitHub] [airflow] vandonr-amz opened a new pull request, #29077: add retries to stop_pipeline on conflict

2023-01-20 Thread via GitHub
vandonr-amz opened a new pull request, #29077: URL: https://github.com/apache/airflow/pull/29077 Explained in comments in the code, but there is a race condition when stopping a pipeline that can make the operation fail if it's in the middle of two steps. It should be very rare in real

[airflow] branch main updated (2b7071c600 -> 5da085bcb2)

2023-01-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 2b7071c600 FTP operator has logic in __init__ (#29073) add 5da085bcb2 Upgrade bitnami/postgresql helm depenency

[GitHub] [airflow] potiuk closed issue #27353: Upgrade to the latest version of bitnami/postgresql

2023-01-20 Thread via GitHub
potiuk closed issue #27353: Upgrade to the latest version of bitnami/postgresql URL: https://github.com/apache/airflow/issues/27353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk merged pull request #29071: Upgrade bitnami/postgresql helm depenency from 10.5.3 to 12.1.9

2023-01-20 Thread via GitHub
potiuk merged PR #29071: URL: https://github.com/apache/airflow/pull/29071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on issue #16618: Access specific values within an `XCom` value using Taskflow API

2023-01-20 Thread via GitHub
jedcunningham commented on issue #16618: URL: https://github.com/apache/airflow/issues/16618#issuecomment-1399101632 @ash, @josh-fell and I had a chat about this. One approach that may work out is having a `output.return_value`, where `[]` get recorded in the `XcomArg` instead of changing

[GitHub] [airflow] potiuk merged pull request #29073: FTP operator has logic in __init__

2023-01-20 Thread via GitHub
potiuk merged PR #29073: URL: https://github.com/apache/airflow/pull/29073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (8eb348911f -> 2b7071c600)

2023-01-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 8eb348911f Mark `test_process_sigterm_works_with_retries` quarantined again (#29075) add 2b7071c600 FTP operator

[GitHub] [airflow] potiuk closed issue #29070: FTP operator has logic in __init__

2023-01-20 Thread via GitHub
potiuk closed issue #29070: FTP operator has logic in __init__ URL: https://github.com/apache/airflow/issues/29070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[airflow-site] branch gh-pages updated: Deploying to gh-pages from @ 966804c0a1779876ddc8301778e7b041a05dd36c 

2023-01-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch gh-pages in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/gh-pages by this push: new 13960ba868 Deploying to gh-pages

[airflow] branch main updated (49ad77c50a -> 8eb348911f)

2023-01-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 49ad77c50a Refactor `TestLocalTaskJob.test_process_sigterm_works_with_retries` (#28990) add 8eb348911f Mark

[GitHub] [airflow] potiuk merged pull request #29075: Mark `test_process_sigterm_works_with_retries` quarantined again

2023-01-20 Thread via GitHub
potiuk merged PR #29075: URL: https://github.com/apache/airflow/pull/29075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow-site] branch main updated: Update Meetups page content (#726)

2023-01-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/main by this push: new 966804c0a1 Update Meetups page content (#726)

[GitHub] [airflow-site] potiuk merged pull request #726: Update Meetups page content

2023-01-20 Thread via GitHub
potiuk merged PR #726: URL: https://github.com/apache/airflow-site/pull/726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] closed pull request #27762: Remove get_db_hook method

2023-01-20 Thread github-actions
github-actions[bot] closed pull request #27762: Remove get_db_hook method URL: https://github.com/apache/airflow/pull/27762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] github-actions[bot] commented on pull request #27947: refactored Amazon Redshift-data functionality into the hook

2023-01-20 Thread github-actions
github-actions[bot] commented on PR #27947: URL: https://github.com/apache/airflow/pull/27947#issuecomment-1399092128 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] github-actions[bot] commented on pull request #28141: Fix GoogleDriveHook writing files to trashed folders on upload

2023-01-20 Thread github-actions
github-actions[bot] commented on PR #28141: URL: https://github.com/apache/airflow/pull/28141#issuecomment-1399092106 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] github-actions[bot] commented on issue #28524: Use only parameters for client_type that are required

2023-01-20 Thread github-actions
github-actions[bot] commented on issue #28524: URL: https://github.com/apache/airflow/issues/28524#issuecomment-1399092083 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] hussein-awala opened a new pull request, #29076: [FIX] emit dagrun duration when it fails because of a timeout

2023-01-20 Thread via GitHub
hussein-awala opened a new pull request, #29076: URL: https://github.com/apache/airflow/pull/29076 closes: #29013 --- **^ Add meaningful description above** Currently the duration of the finished dagruns are emitted in the method `update_state`, which is called only if the

[GitHub] [airflow] Taragolis commented on pull request #29075: Mark `test_process_sigterm_works_with_retries` quarantined again

2023-01-20 Thread via GitHub
Taragolis commented on PR #29075: URL: https://github.com/apache/airflow/pull/29075#issuecomment-1399085492 Oh... this check not make any sense, we initially call all callbacks and only after that we commit to query.

[GitHub] [airflow] Taragolis commented on issue #28658: Fix Quarantine tests

2023-01-20 Thread via GitHub
Taragolis commented on issue #28658: URL: https://github.com/apache/airflow/issues/28658#issuecomment-1399079589 #29075   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] eladkal opened a new issue, #28658: Fix Quarantine tests

2023-01-20 Thread via GitHub
eladkal opened a new issue, #28658: URL: https://github.com/apache/airflow/issues/28658 ### Body We have several tests marked in the code base with `@pytest.mark.quarantined` It means that the tests are flaky and if fail in CI it does not fail the build. The goal is to fix the

[GitHub] [airflow] Taragolis opened a new pull request, #29075: Mark `test_process_sigterm_works_with_retries` quarantined again

2023-01-20 Thread via GitHub
Taragolis opened a new pull request, #29075: URL: https://github.com/apache/airflow/pull/29075 Unfortunately this test still not stable and first run 臘‍♂️ 臘‍♂️ 臘‍♂️ in main failed again. https://github.com/apache/airflow/actions/runs/3971462849/jobs/6808560333: ```console

[GitHub] [airflow] jedcunningham commented on pull request #27848: git-sync 3.6.3

2023-01-20 Thread via GitHub
jedcunningham commented on PR #27848: URL: https://github.com/apache/airflow/pull/27848#issuecomment-1399076067 @danielhoherd, can you add a newsfragement for this ([here is an example](https://github.com/apache/airflow/blob/main/chart/newsfragments/28074.significant.rst))? -- This is an

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29062: Several improvements to the Params doc

2023-01-20 Thread via GitHub
jedcunningham commented on code in PR #29062: URL: https://github.com/apache/airflow/pull/29062#discussion_r1083133413 ## docs/apache-airflow/core-concepts/params.rst: ## @@ -42,15 +42,31 @@ Use a dictionary that maps Param names to a either a :class:`~airflow.models.par

[GitHub] [airflow] hussein-awala commented on pull request #28713: Add a param for get_dags endpoint to list only unpaused dags

2023-01-20 Thread via GitHub
hussein-awala commented on PR #28713: URL: https://github.com/apache/airflow/pull/28713#issuecomment-1399067293 @ashb I just added the tests, can you re-check please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29074: Update Airflow version to 2.5.1

2023-01-20 Thread via GitHub
jedcunningham commented on code in PR #29074: URL: https://github.com/apache/airflow/pull/29074#discussion_r1083087956 ## RELEASE_NOTES.rst: ## @@ -21,6 +21,119 @@ .. towncrier release notes start +Airflow 2.5.1 (2023-01-20) +-- + +Significant

[GitHub] [airflow] pierrejeambrun opened a new pull request, #29074: Update Airflow version to 2.5.1

2023-01-20 Thread via GitHub
pierrejeambrun opened a new pull request, #29074: URL: https://github.com/apache/airflow/pull/29074 Update airflow version for main following the 2.5.1 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] rkarish commented on a diff in pull request #29034: Add functionality for operators to template all eligible fields (apac…

2023-01-20 Thread via GitHub
rkarish commented on code in PR #29034: URL: https://github.com/apache/airflow/pull/29034#discussion_r1083085422 ## airflow/models/baseoperator.py: ## @@ -1184,7 +1197,29 @@ def render_template_fields( """ if not jinja_env: jinja_env =

[GitHub] [airflow] dstandish commented on a diff in pull request #28981: Implemented log_containers option to read from all containers in KubernetesPodOperator

2023-01-20 Thread via GitHub
dstandish commented on code in PR #28981: URL: https://github.com/apache/airflow/pull/28981#discussion_r1083084084 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -264,15 +279,69 @@ def consume_logs(*, since_time: DateTime | None = None, follow: bool = True)

[GitHub] [airflow] rkarish commented on a diff in pull request #29034: Add functionality for operators to template all eligible fields (apac…

2023-01-20 Thread via GitHub
rkarish commented on code in PR #29034: URL: https://github.com/apache/airflow/pull/29034#discussion_r1083083888 ## airflow/models/baseoperator.py: ## @@ -1184,7 +1197,29 @@ def render_template_fields( """ if not jinja_env: jinja_env =

[GitHub] [airflow] rkarish commented on pull request #29034: Add functionality for operators to template all eligible fields (apac…

2023-01-20 Thread via GitHub
rkarish commented on PR #29034: URL: https://github.com/apache/airflow/pull/29034#issuecomment-1398997523 Hi Jarek, quick update on this. The failing static checks was an issue in main, it was resolved with a rebase. All other failures were related to my code changes and I've resolved

[GitHub] [airflow] snjypl opened a new pull request, #29073: FTP operator has logic in __init__

2023-01-20 Thread via GitHub
snjypl opened a new pull request, #29073: URL: https://github.com/apache/airflow/pull/29073 Fixes: https://github.com/apache/airflow/issues/29070 Move the logic from __init__ to execute for FTP operator --- **^ Add meaningful description above** Read the **[Pull

[GitHub] [airflow] potiuk commented on issue #29070: FTP operator has logic in __init__

2023-01-20 Thread via GitHub
potiuk commented on issue #29070: URL: https://github.com/apache/airflow/issues/29070#issuecomment-1398987908 did :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on issue #28271: AIP-44 Migrate Variable to Internal API

2023-01-20 Thread via GitHub
potiuk commented on issue #28271: URL: https://github.com/apache/airflow/issues/28271#issuecomment-1398983633 Changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] snjypl commented on issue #29070: FTP operator has logic in __init__

2023-01-20 Thread via GitHub
snjypl commented on issue #29070: URL: https://github.com/apache/airflow/issues/29070#issuecomment-1398981934 @potiuk can you please assign this to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] potiuk commented on pull request #28990: Refactor `TestLocalTaskJob.test_process_sigterm_works_with_retries`

2023-01-20 Thread via GitHub
potiuk commented on PR #28990: URL: https://github.com/apache/airflow/pull/28990#issuecomment-1398981894 stable enough :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] potiuk merged pull request #28990: Refactor `TestLocalTaskJob.test_process_sigterm_works_with_retries`

2023-01-20 Thread via GitHub
potiuk merged PR #28990: URL: https://github.com/apache/airflow/pull/28990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (100bb8d79a -> 49ad77c50a)

2023-01-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 100bb8d79a listener plugin example added (#27905) add 49ad77c50a Refactor

[GitHub] [airflow] potiuk closed issue #28658: Fix Quarantine tests

2023-01-20 Thread via GitHub
potiuk closed issue #28658: Fix Quarantine tests URL: https://github.com/apache/airflow/issues/28658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] danielhoherd commented on a diff in pull request #27848: git-sync 3.6.3

2023-01-20 Thread via GitHub
danielhoherd commented on code in PR #27848: URL: https://github.com/apache/airflow/pull/27848#discussion_r1083071160 ## chart/values.yaml: ## @@ -93,7 +93,7 @@ images: pullPolicy: IfNotPresent gitSync: repository: k8s.gcr.io/git-sync/git-sync -tag: v3.4.0 +

[GitHub] [airflow] potiuk merged pull request #27905: listener plugin example added

2023-01-20 Thread via GitHub
potiuk merged PR #27905: URL: https://github.com/apache/airflow/pull/27905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (c0d9862d76 -> 100bb8d79a)

2023-01-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from c0d9862d76 Emit DataDog statsd metrics with metadata tags (#28961) add 100bb8d79a listener plugin example added

[GitHub] [airflow] pierrejeambrun closed issue #29026: Status of testing of Apache Airflow 2.5.1rc2

2023-01-20 Thread via GitHub
pierrejeambrun closed issue #29026: Status of testing of Apache Airflow 2.5.1rc2 URL: https://github.com/apache/airflow/issues/29026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow-site] potiuk commented on pull request #726: Update Meetups page content

2023-01-20 Thread via GitHub
potiuk commented on PR #726: URL: https://github.com/apache/airflow-site/pull/726#issuecomment-1398967947 pre-commit/liniting issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[airflow] branch main updated (326b5d9791 -> c0d9862d76)

2023-01-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 326b5d9791 Fix minor typo in breeze example command. (#29072) add c0d9862d76 Emit DataDog statsd metrics with

[GitHub] [airflow] potiuk merged pull request #28961: Emit DataDog statsd metrics with metadata tags

2023-01-20 Thread via GitHub
potiuk merged PR #28961: URL: https://github.com/apache/airflow/pull/28961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] utkarsharma2 commented on a diff in pull request #28934: Remove hard-coded executor-database coupling

2023-01-20 Thread via GitHub
utkarsharma2 commented on code in PR #28934: URL: https://github.com/apache/airflow/pull/28934#discussion_r1083060525 ## airflow/cli/commands/standalone_command.py: ## @@ -159,14 +159,28 @@ def calculate_env(self): # Make sure we're using a local executor flavour

[GitHub] [airflow] potiuk commented on issue #29018: Able to pass arguments to `--conf` not specified in `parameters` argument

2023-01-20 Thread via GitHub
potiuk commented on issue #29018: URL: https://github.com/apache/airflow/issues/29018#issuecomment-1398961154 yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow-site] TohnJhomas opened a new pull request, #726: Update Meetups page content

2023-01-20 Thread via GitHub
TohnJhomas opened a new pull request, #726: URL: https://github.com/apache/airflow-site/pull/726 Adding Chicago and Washington DC meetup groups, update group membership numbers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] mrn-aglic closed issue #29067: TaskGroup dynamic task mapping fails to populate all mapping metadata

2023-01-20 Thread via GitHub
mrn-aglic closed issue #29067: TaskGroup dynamic task mapping fails to populate all mapping metadata URL: https://github.com/apache/airflow/issues/29067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] mrn-aglic commented on issue #29067: TaskGroup dynamic task mapping fails to populate all mapping metadata

2023-01-20 Thread via GitHub
mrn-aglic commented on issue #29067: URL: https://github.com/apache/airflow/issues/29067#issuecomment-1398952175 Seems to be working in 2.5.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch main updated (e926bb9bb0 -> 326b5d9791)

2023-01-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from e926bb9bb0 Add deferrable mode to DataFusionStartPipelineOperator (#28690) add 326b5d9791 Fix minor typo in

[GitHub] [airflow] potiuk merged pull request #29072: Fix minor typo in breeze example command.

2023-01-20 Thread via GitHub
potiuk merged PR #29072: URL: https://github.com/apache/airflow/pull/29072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >