[GitHub] [airflow] VinayGb665 commented on pull request #9549: YAML file supports extra json parameters
VinayGb665 commented on pull request #9549: URL: https://github.com/apache/airflow/pull/9549#issuecomment-655319578 > small nitts in docs Updated This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] VinayGb665 commented on pull request #9549: YAML file supports extra json parameters
VinayGb665 commented on pull request #9549: URL: https://github.com/apache/airflow/pull/9549#issuecomment-651777378 Updated This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] VinayGb665 commented on pull request #9549: YAML file supports extra json parameters
VinayGb665 commented on pull request #9549: URL: https://github.com/apache/airflow/pull/9549#issuecomment-651321092 Would work like a charm :rocket: !! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] VinayGb665 commented on pull request #9549: YAML file supports extra json parameters
VinayGb665 commented on pull request #9549: URL: https://github.com/apache/airflow/pull/9549#issuecomment-650888618 > Is there anything that makes this change exclusive to YAML? It seems to me that this problem also occurs in JSON. What do you think to handle this case in the _create_connection function? I am not really sure if changing _create_connection would help here, because the model in models/connection.py defines the extra field to be of type string and whenever a dict gets passed to it, raises an error This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] VinayGb665 commented on pull request #9549: YAML file supports extra json parameters
VinayGb665 commented on pull request #9549: URL: https://github.com/apache/airflow/pull/9549#issuecomment-650888431 > Is there anything that makes this change exclusive to YAML? It seems to me that this problem also occurs in JSON. What do you think to handle this case in the _create_connection function? I am not really sure if changing _create_connection would help here, because the model in models/connection.py defines the extra field to be of type string and whenever a dict gets passed to it, raises an error This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
