Taragolis commented on PR #29035:
URL: https://github.com/apache/airflow/pull/29035#issuecomment-1400499360
> Ah - isn't that the "airflow.jobs.backfill_job.BackfillJob" generated log ?
Yeah, it is `distributed.client:client.py` logger create this message
```console
ERROR
Taragolis commented on PR #29035:
URL: https://github.com/apache/airflow/pull/29035#issuecomment-1398885650
> No -not skipped - simply a bad timing /flaky test:
>
> ```
> Failed to reconnect to scheduler after 30.00 seconds, closing client
> ```
Technically we should not
Taragolis commented on PR #29035:
URL: https://github.com/apache/airflow/pull/29035#issuecomment-1398808949
Just single non-relevant to this PR failure. Somehow `distributed` could
avoid caplog filter:
https://github.com/apache/airflow/actions/runs/3970014684/jobs/6805354398#step:6:6520
Taragolis commented on PR #29035:
URL: https://github.com/apache/airflow/pull/29035#issuecomment-1398705272
> > @potiuk, is it the right place?
>
> Yep. But you can also add "full tests needed" label on a PR to run a
complete set of tests.
And very easy to forget add this
Taragolis commented on PR #29035:
URL: https://github.com/apache/airflow/pull/29035#issuecomment-1398319160
> Live is like a box of chocolates, you never know which one you get. You
got Helm test this time :)
I postpone migrate this tests to pytest as much as possible, so this looks
Taragolis commented on PR #29035:
URL: https://github.com/apache/airflow/pull/29035#issuecomment-1398119466
Well... I thought that the k8s test failed due to the issues with Github
Actions however it also use `setup` methods and we use `pytest.ini` across all
tests.
Let's migrate
Taragolis commented on PR #29035:
URL: https://github.com/apache/airflow/pull/29035#issuecomment-1396941580
@uranusjr In additional we could add `-p no:nose` in pytest.ini adoptions,
which disable autouse `setup()` and `teardown()` methods. WDYT?
--
This is an automated message
Taragolis commented on PR #29035:
URL: https://github.com/apache/airflow/pull/29035#issuecomment-1396928177
Yep, check in general this actually work (except teardown fixture)
```python
import pytest
class TestNoseSetupTearDown:
def setup(self):
Taragolis commented on PR #29035:
URL: https://github.com/apache/airflow/pull/29035#issuecomment-1396909639
Well even if this work then at least this feature undocumented in `pytest`,
only this methods
[documented](https://docs.pytest.org/en/latest/how-to/xunit_setup.html)
--
This is an
Taragolis commented on PR #29035:
URL: https://github.com/apache/airflow/pull/29035#issuecomment-1396860105
And after found about deprecation functionality in [pytest's
changelog](https://docs.pytest.org/en/latest/changelog.html) I finally realise
why test which use setup/teardown methods
10 matches
Mail list logo
