[GitHub] [airflow] XD-DENG edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details
XD-DENG edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469920279 > @XD-DENG , I don't think it will add 2000 entries to the db for admin role. It only adds the "all_dags" view-menu with the 2 permissions into the table. Hi @feng-tao please refer to https://github.com/apache/airflow/blob/dda309e66224346014ca42a0bcce4f53365f1118/airflow/www/security.py#L440-L453 By checking the code itself, seems it's simply adding all whatever permissions to Admin role. Below is the version before my `set`-related refactoring: https://github.com/apache/airflow/blob/c552996483f5aab5e31793317b26aba62c13332e/airflow/www/security.py#L440-L452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] XD-DENG edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details
XD-DENG edited a comment on issue #4569: [AIRFLOW-3745] Fix viewer not able to view dag details URL: https://github.com/apache/airflow/pull/4569#issuecomment-469920279 > @XD-DENG , I don't think it will add 2000 entries to the db for admin role. It only adds the "all_dags" view-menu with the 2 permissions into the table. Hi @feng-tao please refer to https://github.com/apache/airflow/blob/dda309e66224346014ca42a0bcce4f53365f1118/airflow/www/security.py#L440-L453 By checking the code itself, seems it's simply adding all whatever permissions to Admin role. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
