[GitHub] [airflow] ashb commented on a change in pull request #5668: [AIRFLOW-4316] support setting kubernetes_environment_variables config section from env var
ashb commented on a change in pull request #5668: [AIRFLOW-4316] support
setting kubernetes_environment_variables config section from env var
URL: https://github.com/apache/airflow/pull/5668#discussion_r316690777
##
File path: tests/operators/test_email_operator.py
##
@@ -57,6 +57,6 @@ def _run_as_operator(self, **kwargs):
task.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE)
def test_execute(self):
-with conf_vars({('email', 'EMAIL_BACKEND'):
'tests.operators.test_email_operator.send_email_test'}):
+with conf_vars({('email', 'email_backend'):
'tests.operators.test_email_operator.send_email_test'}):
Review comment:
Probably not, no as that would break a _lot_ of code, and reading is almost
universally safe to be case-insensitive.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #5668: [AIRFLOW-4316] support setting kubernetes_environment_variables config section from env var
ashb commented on a change in pull request #5668: [AIRFLOW-4316] support
setting kubernetes_environment_variables config section from env var
URL: https://github.com/apache/airflow/pull/5668#discussion_r313769536
##
File path: tests/operators/test_email_operator.py
##
@@ -57,6 +57,6 @@ def _run_as_operator(self, **kwargs):
task.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE)
def test_execute(self):
-with conf_vars({('email', 'EMAIL_BACKEND'):
'tests.operators.test_email_operator.send_email_test'}):
+with conf_vars({('email', 'email_backend'):
'tests.operators.test_email_operator.send_email_test'}):
Review comment:
Just to confirm: we are setting these as lowercase because that is how it is
defined in the config, but reading this as `conf.get('email', 'EMAIL_BACKEND')`
still works, right?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
