[GitHub] [airflow] ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op`

ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op` URL: https://github.com/apache/airflow/pull/5598#issuecomment-534040664 @mik-laj I think we stalled working out whether to try and fix the PR, or just deprecate the

[GitHub] [airflow] ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op`

ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op` URL: https://github.com/apache/airflow/pull/5598#issuecomment-521613826 Yeah, this probably can be changed and tieded up now. We'll probably have to fix a lot of our own

[GitHub] [airflow] ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op`

ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op` URL: https://github.com/apache/airflow/pull/5598#issuecomment-521609959 Maybe with the context manager (`with DAG:`) that is doable now, but I suspect this feature

[GitHub] [airflow] ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op`

ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op` URL: https://github.com/apache/airflow/pull/5598#issuecomment-516807208 Argh. This works, except for when the DAG is pickled. Grr. (Maybe we just delete dag pickling

[GitHub] [airflow] ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op`

ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op` URL: https://github.com/apache/airflow/pull/5598#issuecomment-512348463 @milton0825 I've thought of an edge-case with this approach: ```python op1 =

[GitHub] [airflow] ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op`

ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op` URL: https://github.com/apache/airflow/pull/5598#issuecomment-512328509 I've got the scoping of the closure wrong. Given this case ``` op1 =

[GitHub] [airflow] ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op`

ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op` URL: https://github.com/apache/airflow/pull/5598#issuecomment-511789349 Though it looks like this changes _quite a lot_ of behaviour that the tests were relying on.

[GitHub] [airflow] ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op`

ashb commented on issue #5598: [AIRFLOW-733][AIRFLOW-883] Apply default_args when setting `op.dag = dag` or `dag >> op` URL: https://github.com/apache/airflow/pull/5598#issuecomment-511765582 @milton0825 As discussed. This