[GitHub] [airflow] benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

2019-12-10 Thread GitBox
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next… URL: https://github.com/apache/airflow/pull/5565#issuecomment-564205845 Done : https://github.com/apache/airflow/pull/6780

[GitHub] [airflow] benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

2019-12-10 Thread GitBox
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next… URL: https://github.com/apache/airflow/pull/5565#issuecomment-564193491 Yes it was a mistake I will rebases it soon. Le mar. 10 déc. 2019 à 08:32, OmerJog a écrit :

[GitHub] [airflow] benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

2019-09-22 Thread GitBox
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next… URL: https://github.com/apache/airflow/pull/5565#issuecomment-533874400 > Will approve after rebase. Rebase done, but I don't understand why there are errors ?

[GitHub] [airflow] benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

2019-09-07 Thread GitBox
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next… URL: https://github.com/apache/airflow/pull/5565#issuecomment-529126183 I done the rebase on airflow/master such as you expect no? Le sam. 7 sept. 2019 à 17:31, Jarek

[GitHub] [airflow] benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

2019-09-06 Thread GitBox
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next… URL: https://github.com/apache/airflow/pull/5565#issuecomment-528792474 > Yes. Please do rebase on latest apache/master. Thanks, but how do you proceed to make that

[GitHub] [airflow] benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

2019-09-05 Thread GitBox
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next… URL: https://github.com/apache/airflow/pull/5565#issuecomment-528456640 > > Hi. > > I made a change in the base class - GoogleCloudBaseHook. Your PR may need to be changed.

[GitHub] [airflow] benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

2019-09-05 Thread GitBox
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next… URL: https://github.com/apache/airflow/pull/5565#issuecomment-528445423 > Hi. > > I made a change in the base class - GoogleCloudBaseHook. Your PR may need to be

[GitHub] [airflow] benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

2019-09-02 Thread GitBox
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next… URL: https://github.com/apache/airflow/pull/5565#issuecomment-527208652 > Hi. I have prepared a commit for you. > This deletes excessive logs, but it also add missing tests.

[GitHub] [airflow] benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

2019-08-12 Thread GitBox
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next… URL: https://github.com/apache/airflow/pull/5565#issuecomment-520626905 > > Travis is sad > > ``` > >

[GitHub] [airflow] benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

2019-08-12 Thread GitBox
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next… URL: https://github.com/apache/airflow/pull/5565#issuecomment-520623740 > Travis is sad > > ``` >

[GitHub] [airflow] benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

2019-08-12 Thread GitBox
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next… URL: https://github.com/apache/airflow/pull/5565#issuecomment-520566509 Yes I will work on this change soon, but I have some mistakes with my docker to run unit tests locally.

[GitHub] [airflow] benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

2019-07-11 Thread GitBox
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next… URL: https://github.com/apache/airflow/pull/5565#issuecomment-51067 Thanks for your comment. I added the parameter all, it can be helpful.