benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list
from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#issuecomment-564205845
Done : https://github.com/apache/airflow/pull/6780
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list
from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#issuecomment-564193491
Yes it was a mistake I will rebases it soon.
Le mar. 10 déc. 2019 à 08:32, OmerJog a écrit :
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list
from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#issuecomment-533874400
> Will approve after rebase.
Rebase done, but I don't understand why there are errors ?
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list
from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#issuecomment-529126183
I done the rebase on airflow/master such as you expect no?
Le sam. 7 sept. 2019 à 17:31, Jarek
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list
from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#issuecomment-528792474
> Yes. Please do rebase on latest apache/master.
Thanks, but how do you proceed to make that
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list
from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#issuecomment-528456640
> > Hi.
> > I made a change in the base class - GoogleCloudBaseHook. Your PR may
need to be changed.
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list
from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#issuecomment-528445423
> Hi.
>
> I made a change in the base class - GoogleCloudBaseHook. Your PR may need
to be
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list
from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#issuecomment-527208652
> Hi. I have prepared a commit for you.
> This deletes excessive logs, but it also add missing tests.
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list
from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#issuecomment-520626905
> > Travis is sad
> > ```
> >
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list
from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#issuecomment-520623740
> Travis is sad
>
> ```
>
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list
from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#issuecomment-520566509
Yes I will work on this change soon, but I have some mistakes with my docker
to run unit tests locally.
benjamingrenier commented on issue #5565: [AIRFLOW-4899] Fix get_dataset_list
from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#issuecomment-51067
Thanks for your comment. I added the parameter all, it can be helpful.
12 matches
Mail list logo