eladkal commented on code in PR #28970:
URL: https://github.com/apache/airflow/pull/28970#discussion_r1073259126
##########
tests/providers/google/cloud/hooks/test_dataproc.py:
##########
@@ -1006,17 +1006,9 @@ def test_set_python_main(self):
self.builder.set_python_main(main)
assert main ==
self.builder.job["job"][self.job_type]["main_python_file_uri"]
- @pytest.mark.parametrize(
- "job_name",
- [
- pytest.param("name", id="simple"),
- pytest.param("name_with_dash", id="name with underscores"),
- pytest.param("group.name", id="name with dot"),
- pytest.param("group.name_with_dash", id="name with dot and
underscores"),
- ],
- )
Review Comment:
These were added to avoid regression of
https://github.com/apache/airflow/issues/23439
How can you be sure `job_name` works with these values if there is no
coverage for these cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
