[GitHub] [airflow] feng-tao commented on issue #4627: [AIRFLOW-3258] K8S executor environment variables section.

2019-03-06 Thread GitBox 
feng-tao commented on issue #4627: [AIRFLOW-3258] K8S executor environment 
variables section.
URL: https://github.com/apache/airflow/pull/4627#issuecomment-470203801
 
 
   thanks @davlum , lgtm


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feng-tao commented on issue #4627: [AIRFLOW-3258] K8S executor environment variables section.

2019-03-05 Thread GitBox 
feng-tao commented on issue #4627: [AIRFLOW-3258] K8S executor environment 
variables section.
URL: https://github.com/apache/airflow/pull/4627#issuecomment-469891035
 
 
   @davlum ,  a n00b question:
   do you know if it is desirable to have both env variable defined and 
annotation defined(https://github.com/apache/airflow/pull/4589/files)? Or which 
one is a preferred approach?
   
   lgtm based on 101 k8s knowledge
   
   cc @dimberman  in case he has cycle.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services