[GitHub] [airflow] haoliang7 commented on issue #5495: [AIRFLOW-4858] Deprecate "Historical convenience functions" in conf

2019-08-25 Thread GitBox
haoliang7 commented on issue #5495: [AIRFLOW-4858] Deprecate "Historical convenience functions" in conf URL: https://github.com/apache/airflow/pull/5495#issuecomment-524637187 > The change was a little bit bigger than needed (`configuration.conf.getboolean` was fine) but making it all

[GitHub] [airflow] haoliang7 commented on issue #5495: [AIRFLOW-4858] Deprecate "Historical convenience functions" in conf

2019-08-14 Thread GitBox
haoliang7 commented on issue #5495: [AIRFLOW-4858] Deprecate "Historical convenience functions" in conf URL: https://github.com/apache/airflow/pull/5495#issuecomment-521128165 @ashb The old config methods are removed. Please review my last commit.

[GitHub] [airflow] haoliang7 commented on issue #5495: [AIRFLOW-4858] Deprecate "Historical convenience functions" in conf

2019-07-02 Thread GitBox
haoliang7 commented on issue #5495: [AIRFLOW-4858] Deprecate "Historical convenience functions" in conf URL: https://github.com/apache/airflow/pull/5495#issuecomment-507543693 > Can you please also fix up the existing uses in side airflow that this now correctly warns about? > >

[GitHub] [airflow] haoliang7 commented on issue #5495: [AIRFLOW-4858] Deprecate "Historical convenience functions" in conf

2019-06-27 Thread GitBox
haoliang7 commented on issue #5495: [AIRFLOW-4858] Deprecate "Historical convenience functions" in conf URL: https://github.com/apache/airflow/pull/5495#issuecomment-506273935 In conf we want to deprecate "historical convenience functions" get, getint, getboolean, etc. However the current