[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-08-06 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-670141704 Hi @ephraimbuddy it seems like you suggestion worked, thanks a lot  This is an automated message from the

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-08-03 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-668197876 Hi @ephraimbuddy I did rebase, any hint on how to continue? This is an automated message from the Apache Git

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-07-31 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-667352145 @ephraimbuddy rebase master in my branch? This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-07-30 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-665859818 @ephraimbuddy or @potiuk what do you think about my last commet? This is an automated message from the Apache

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-07-22 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-662653175 Hi @mik-laj not sure if this is causing any problems, this is also not really the target for this pull request, its solely to add the very simple (mssql to oracle transfer)

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-07-15 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-658972831 Hi @mik-laj it seems like 9 failing checks are all due to: ` ModuleNotFoundError: No module named 'pymssql' ` In the

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-07-06 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-654397085 Hi @mik-laj this actually helped a lot clarified a lot of things for me! Thank you very much! So what I understood is that transfer operators should go into the

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-07-02 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-653231283 Hi @ephraimbuddy would you mind helping me with the naming convention of the operators? I got an error for my operator to not match: .*Operator$ so I renamed it to

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-06-26 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-650392351 Hi @ephraimbuddy maybe you can help me here again, I have a strange error, that the module is not found `no-name-in-module`: - No name 'MSSQLToOracleTransferOperator' in

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-06-18 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-646298216 @ephraimbuddy would you mind helping me again? The checks are failing because of: - Build cross-dependencies for providers packages - Failed ``` -microsoft.mssql

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-06-17 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-645586989 @ephraimbuddy could you help me again please, I am getting following errors in the checks, which I dont really understand on how to act on: - FAILED

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-06-15 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-644391378 Hi @ephraimbuddy , maybe you can help me, what should I add for default value to my source_sql_params, I cant neither passed None, nor an empty list [] in both cases the checks

[GitHub] [airflow] jkbngl commented on pull request #9295: added mssql to oracle transfer operator

2020-06-14 Thread GitBox
jkbngl commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-643826150 @ephraimbuddy thank you very much for your feedback, I have now added type annotations! This is an automated