[GitHub] [airflow] kaxil edited a comment on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
kaxil edited a comment on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603547473
 
 
   `SystemsManagerParametersBackend` stripping AWS as we don't use GCP or 
Hashicorp in their respective backends too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil edited a comment on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
kaxil edited a comment on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603545674
 
 
   `AwsSystemsManagerParameterStoreBackend` wow that name would be huge
   
   `SystemsManagerParameterStoreBackend` ? We can remove `aws` as it is in 
module_path and `providers` path too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil edited a comment on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
kaxil edited a comment on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603544562
 
 
   > Aws SSM
   
   How about `AwsSecretsManager`? (Based on 
https://docs.aws.amazon.com/secretsmanager/latest/userguide/intro.html)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services