[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-28 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1278072688 ## airflow/cli/cli_parser.py: ## @@ -41,10 +42,23 @@ core_commands, ) from airflow.exceptions import AirflowException +from

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-28 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1278063529 ## airflow/cli/cli_parser.py: ## @@ -41,10 +42,23 @@ core_commands, ) from airflow.exceptions import AirflowException +from

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-28 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1278037043 ## tests/providers/celery/executors/test_celery_kubernetes_executor.py: ## @@ -49,6 +49,9 @@ def test_serve_logs_default_value(self): def

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-28 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1278030846 ## airflow/cli/cli_parser.py: ## @@ -41,10 +42,23 @@ core_commands, ) from airflow.exceptions import AirflowException +from

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-28 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1277926394 ## tests/cli/test_cli_parser.py: ## @@ -203,31 +204,22 @@ def test_positive_int(self): cli_config.positive_int(allow_zero=True)("-1")

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-28 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1277925673 ## tests/cli/conftest.py: ## @@ -34,6 +34,18 @@ custom_executor_module.CustomCeleryKubernetesExecutor = type( # type: ignore

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-28 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1277925303 ## airflow/stats.py: ## @@ -22,7 +22,6 @@ from typing import TYPE_CHECKING, Callable from airflow.configuration import conf -from airflow.metrics import

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-28 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1277924324 ## airflow/cli/cli_parser.py: ## @@ -41,10 +42,23 @@ core_commands, ) from airflow.exceptions import AirflowException +from

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-28 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1277923794 ## airflow/cli/cli_config.py: ## @@ -61,46 +58,6 @@ class DefaultHelpParser(argparse.ArgumentParser): def _check_value(self, action, value):

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-20 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1269833340 ## airflow/executors/celery_kubernetes_executor.py: ## @@ -231,3 +231,7 @@ def send_callback(self, request: CallbackRequest) -> None: if not

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-20 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1269832478 ## airflow/executors/executor_loader.py: ## @@ -184,6 +192,31 @@ def validate_database_executor_compatibility(cls, executor: type[BaseExecutor]) if

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-20 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1269832478 ## airflow/executors/executor_loader.py: ## @@ -184,6 +192,31 @@ def validate_database_executor_compatibility(cls, executor: type[BaseExecutor]) if

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-20 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1269825704 ## airflow/executors/executor_loader.py: ## @@ -184,6 +192,31 @@ def validate_database_executor_compatibility(cls, executor: type[BaseExecutor]) if

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-07-20 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1269819841 ## airflow/executors/celery_kubernetes_executor.py: ## @@ -231,3 +231,7 @@ def send_callback(self, request: CallbackRequest) -> None: if not

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-03-06 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1127136352 ## airflow/cli/cli_parser.py: ## @@ -17,2165 +17,35 @@ # specific language governing permissions and limitations # under the License. """Command-line

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-01-24 Thread via GitHub
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1085901682 ## airflow/cli/cli_parser.py: ## @@ -17,2165 +17,35 @@ # specific language governing permissions and limitations # under the License. """Command-line

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29055: [AIP-51] Executors vending CLI commands

2023-01-19 Thread GitBox
o-nikolas commented on code in PR #29055: URL: https://github.com/apache/airflow/pull/29055#discussion_r1082091328 ## airflow/cli/cli_parser.py: ## @@ -17,2165 +17,35 @@ # specific language governing permissions and limitations # under the License. """Command-line