o-nikolas opened a new pull request, #29055: URL: https://github.com/apache/airflow/pull/29055
This PR addresses executor coupling **5a** and **5b** in Airflow CLI. See [this issue](https://github.com/apache/airflow/issues/27932) (#27932) for more context. ## Please read before reviewing: The changes can be organized into three main groups, which are described below. In fact, it may be very helpful to actually review the three commits of this PR in isolation. 1. In order to resolve circular imports as well as to cleanup the ~2k line `cli_parser.py` module, all cli config (declaration of Args, Commands, etc) moved to a new `cli_config.py` module. This config module is much larger than the remaining `cli_parser.py` module and contains more of the original code, so it is perhaps more helpful to think of it as the `cli_parser.py` module has been _renamed_ to `cli_config.py` where most of the code still lives, and then just the methods related to constructing the parser itself have moved to a new `cli_parser.py` module :) **NOTE: you will need to unhide the diffs for these files since they are quite large** 1. Updates to the executor interface (i.e. add stub methods to the base executor and the two hybrid executors which don't inherit directly from base) to vend cli commands and make small changes in the cli_parser.py module to read in commands from this new method. Add tests for the interface. 1. Move executor related cli commands (for Celery and Kubernetes) to their respective executor modules utilizing the new interface from step 2. All original tests for these CLI commands still apply. <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
