[GitHub] [airflow] potiuk commented on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2023-01-19 Thread GitBox
potiuk commented on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-1397756161 Should be part of discussion here: https://lists.apache.org/thread/96tco8dfs4mh12kqm1pwjhm5mqr54qbm . I think we should limit ID to ASCII and add extra description. -- This is

[GitHub] [airflow] potiuk commented on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-10-26 Thread GitBox
potiuk commented on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-952120850 Good points @Melodie97 :) I think a) and using python-slugify is the way to go. Anything that we do in `main` is by default now 2.3 (we cut-off the 2.2 branch when we

[GitHub] [airflow] potiuk commented on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-10-26 Thread GitBox
potiuk commented on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-952093114 Just added it to label the issues related to telemetry :). U think nothing special changed - I think no-one was working on that issue yet. It's free to work on :) -- This is an

[GitHub] [airflow] potiuk commented on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-09-03 Thread GitBox
potiuk commented on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-912820115 For now - yeah. The problem is that DAG_ID and TASK_ID are also used as descriptions in the UI. And I perfectly understand why someone would like to use the national characters for

[GitHub] [airflow] potiuk commented on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-09-03 Thread GitBox
potiuk commented on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-912702349 Agree it's likely something we should address. I am just wondering why it did not fail at trying to insert DAG to the DB - the DAG_ID there should only allow ASCII. -- This is