[GitHub] [airflow] potiuk commented on pull request #29035: Renaming nose compatible methods in flavour of regular pytest naming

2023-01-20 Thread via GitHub
potiuk commented on PR #29035: URL: https://github.com/apache/airflow/pull/29035#issuecomment-1398891137 Ah - isn't that the "airflow.jobs.backfill_job.BackfillJob" generated log ? I thought simply backfill job sends the log entry when reconnecting? Because if not then maybe for some

[GitHub] [airflow] potiuk commented on pull request #29035: Renaming nose compatible methods in flavour of regular pytest naming

2023-01-20 Thread via GitHub
potiuk commented on PR #29035: URL: https://github.com/apache/airflow/pull/29035#issuecomment-1398821920 > Just single non-relevant to this PR failure. Somehow `distributed` could avoid caplog filter: https://github.com/apache/airflow/actions/runs/3970014684/jobs/6805354398#step:6:6520

[GitHub] [airflow] potiuk commented on pull request #29035: Renaming nose compatible methods in flavour of regular pytest naming

2023-01-20 Thread GitBox
potiuk commented on PR #29035: URL: https://github.com/apache/airflow/pull/29035#issuecomment-1398552691 > @potiuk, is it the right place? Yep. But you can also add "full tests needed" label on a PR to run a complete set of tests. -- This is an automated message from the Apache

[GitHub] [airflow] potiuk commented on pull request #29035: Renaming nose compatible methods in flavour of regular pytest naming

2023-01-20 Thread GitBox
potiuk commented on PR #29035: URL: https://github.com/apache/airflow/pull/29035#issuecomment-1398280798 > Well... I thought that the k8s test failed due to the issues with Github Actions however it also use `setup` methods and we use `pytest.ini` across all tests. > > Let's migrate

[GitHub] [airflow] potiuk commented on pull request #29035: Renaming nose compatible methods in flavour of regular pytest naming

2023-01-19 Thread GitBox
potiuk commented on PR #29035: URL: https://github.com/apache/airflow/pull/29035#issuecomment-1397486576 Yeah. I like to unify the tests and make our tests `pytest-only`. Great that we can disable the built-in plugin to verify it (and to prevent it from accidentally happen in the future).

[GitHub] [airflow] potiuk commented on pull request #29035: Renaming nose compatible methods in flavour of regular pytest naming

2023-01-19 Thread GitBox
potiuk commented on PR #29035: URL: https://github.com/apache/airflow/pull/29035#issuecomment-1397487058 (@uranusjr ?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To