tirkarthi commented on PR #28256:
URL: https://github.com/apache/airflow/pull/28256#issuecomment-1402095422
The original issue was due to traversing over dag folder every time and also
recursively inside zip files to construct paths like test_dag.zip/test_file.py
which is IO expensive. The
tirkarthi commented on PR #28256:
URL: https://github.com/apache/airflow/pull/28256#issuecomment-1401489859
@potiuk The initial issue was that file_paths would give "file.zip" but
import error table had "file.zip/file_inside_zip.py". I initially suggested
modifying file_paths function to
tirkarthi commented on PR #28256:
URL: https://github.com/apache/airflow/pull/28256#issuecomment-1399416351
Updated code and tests since the `clear_nonexistent_import_errors` is now an
internal API.
--
This is an automated message from the Apache Git Service.
To respond to the message,
tirkarthi commented on PR #28256:
URL: https://github.com/apache/airflow/pull/28256#issuecomment-1399415469
Thanks @potiuk , I guess the following does the similar without a migration.
Lets say there are 3 errors with c.py deleted. Then `self._file_paths` will be
`["a.py", "b.zip"]` and it
tirkarthi commented on PR #28256:
URL: https://github.com/apache/airflow/pull/28256#issuecomment-1399175298
I am not sure if there is a reliable way to extract
"/home/karthikeyan/airflow/dags/error_dag.zip" from
"/home/karthikeyan/airflow/dags/error_dag.zip/error_dag.py" through zipfile
tirkarthi commented on PR #28256:
URL: https://github.com/apache/airflow/pull/28256#issuecomment-1397945755
@potiuk @uranusjr Sorry, I am little confused. Currently `ImportError` model
has filename column that stores full path to Python along with zipfile like
tirkarthi commented on PR #28256:
URL: https://github.com/apache/airflow/pull/28256#issuecomment-1344459058
Thanks @potiuk, I updated my branch with main before creating the PR but it
seems some other PRs were merged after my PR. I will rebase in future in case
of test failures. Thanks
tirkarthi commented on PR #28256:
URL: https://github.com/apache/airflow/pull/28256#issuecomment-1344327963
The test failure seems to be unrelated to the pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
tirkarthi commented on PR #28256:
URL: https://github.com/apache/airflow/pull/28256#issuecomment-1344236864
Related commit that added full path to Python file inside zip file to show
all import errors : 97f00654ca9c43ec87e1f3ec207b0f935dd89e15
--
This is an automated message from the
