[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-613831990 And BTW, I alway check DAG view at first, because in big dag with many tasks, I think it's more straightforward about the

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-613830825 Ok, I will try to * Remove "DAG" button in Task Instance dialog in Graph view * Add task instances in dag run dialog in

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-613534495 BTW, I just checkout and find out we already have this function in tree view dagrun

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-613532992 @feluelle You'r right, I that another way to mark dag run state. But this PR is try to fix the exists bug(maybe) in tool view in

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-613443087 ping @kaxil @mik-laj @feluelle again, I need one more approval/review here

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-610174787 > This does not look right to me - to put this button on task-level actions window. Wouldn’t it be better to put it on the

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-609890826 I almost forget about this PR  This is an automated message

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-601492156 PTAL @ashb @kaxil @potiuk @mik-laj @turbaszek @feluelle This is

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-599186252 Fix conflict This is an automated message from the Apache Git

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-598619366 @kaxil @potiuk @mik-laj @nuclearpinguin PTAL. Just ignore the conflict, will fix it after review.

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-597473748 > I'm not really sure could we remove this code, it seem unnecessary Oh, now I realize the code is not unnecessary

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-597399419 Also and make_success/make_failed to dag.html/tree.html