Re: [PR] Add `sqlalchemy_url` property to `DbApiHook` class [airflow]

2024-04-14 Thread via GitHub
Taragolis merged PR #38871: URL: https://github.com/apache/airflow/pull/38871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add `sqlalchemy_url` property to `DbApiHook` class [airflow]

2024-04-14 Thread via GitHub
rawwar commented on PR #38871: URL: https://github.com/apache/airflow/pull/38871#issuecomment-2053943525 @Taragolis , can this be merged? I can continue working on PR's to update other providers -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Add `sqlalchemy_url` property to `DbApiHook` class [airflow]

2024-04-12 Thread via GitHub
Taragolis commented on code in PR #38871: URL: https://github.com/apache/airflow/pull/38871#discussion_r1562385632 ## airflow/providers/common/sql/hooks/sql.py: ## @@ -207,6 +208,17 @@ def get_uri(self) -> str: conn.schema = self.__schema or conn.schema return

Re: [PR] Add `sqlalchemy_url` property in `DbApiHook` class [airflow]

2024-04-10 Thread via GitHub
rawwar commented on code in PR #38871: URL: https://github.com/apache/airflow/pull/38871#discussion_r1559055405 ## airflow/providers/common/sql/hooks/sql.py: ## @@ -207,6 +219,24 @@ def get_uri(self) -> str: conn.schema = self.__schema or conn.schema return

Re: [PR] Add `sqlalchemy_url` property in `DbApiHook` class [airflow]

2024-04-10 Thread via GitHub
rawwar commented on code in PR #38871: URL: https://github.com/apache/airflow/pull/38871#discussion_r1559057020 ## airflow/providers/common/sql/hooks/sql.py: ## @@ -207,6 +219,24 @@ def get_uri(self) -> str: conn.schema = self.__schema or conn.schema return